aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch
Commit message (Collapse)AuthorAgeFilesLines
* remove meaningless AS::FrozenObjectErrorAkira Matsuda2013-01-021-1/+0
|
* Fix indent in UnknownAction templateGuillermo Iguaran2013-01-011-1/+1
|
* Summary and Details HTML elements aren't supported in all modern browsersGuillermo Iguaran2012-12-312-12/+12
|
* Add style to AV::Template::Error exception pageGuillermo Iguaran2012-12-312-14/+42
|
* Improve line-height to have better line spacing in exception messageGuillermo Iguaran2012-12-311-0/+1
|
* Add new style to Routing Error pageGuillermo Iguaran2012-12-311-19/+22
|
* Styling for exception pageGuillermo Iguaran2012-12-316-29/+150
|
* Add source extract to detailed exception pageGuillermo Iguaran2012-12-314-2/+34
|
* Merge pull request #8666 from mekishizufu/fix_lambdasSantiago Pastorino2012-12-311-2/+2
|\ | | | | Fix usage of lambda as a Rack endpoint
| * Fix usage of lambda as a Rack endpointJiri Pospisil2012-12-311-2/+2
| | | | | | | | The response body needs to respond_to? :each.
* | Alias refute methods to assert_not and perfer assert_not on testsRafael Mendonça França2012-12-311-1/+1
| |
* | Inherit from MiniTest::Unit::TestCase instead of MiniTest::SpecRafael Mendonça França2012-12-311-3/+0
|/
* Merge pull request #8662 from ↵Santiago Pastorino2012-12-311-2/+6
|\ | | | | | | | | senny/8661_should_not_append_charset_if_already_present Charset should not be appended to image/* type
| * charset should not be appended for `head` responsesYves Senn2012-12-311-2/+6
| | | | | | | | | | | | | | 1) Failure: test_head_created_with_image_png_content_type(RenderTest) [test/controller/render_test.rb:1238]: Expected: "image/png" Actual: "image/png; charset=utf-8"
* | Define [], []=, permanent, signed and encrypted as the only allowed methods ↵Santiago Pastorino2012-12-301-9/+57
|/ | | | for the non Raw Cookie classes
* Merge pull request #8627 from schneems/schneems/routes-1-9Rafael Mendonça França2012-12-261-1/+1
|\ | | | | Ruby 1.9 style hash in Route Inspector
| * Ruby 1.9 style hash in Route Inspectorschneems2012-12-271-1/+1
| |
* | We need to check explictly that env['action_dispatch.show_exceptions']Rafael Mendonça França2012-12-261-1/+1
| | | | | | | | | | | | is false. If it is nil we can't raise the exception
* | more descriptive return parametersHrvoje Šimić2012-12-261-4/+3
| |
* | return Mime::NullType if format is unknownAngelo Capilleri2012-12-221-1/+12
| | | | | | | | | | | | | | | | | | | | If a request has an unknown format, the methods html?, xml?, json? ...etc not raise an Exception. This patch add a class Mime::NullType, that is returned when request.format is unknown and it responds false to the methods that ends with '?' and true to 'nil?'. It refers to #7837, this issue is considered a improvement not a bug.
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-12-211-0/+5
|\ \
| * | Add script_name option description and example for #url_for optionsIvan Vanyak2012-12-171-0/+5
| | |
* | | Fix indentation issuing warningCarlos Antonio da Silva2012-12-201-1/+1
| | |
* | | update AD::Journey to follow Rails coding conventionsFrancesco Rodriguez2012-12-2016-437/+439
| | |
* | | :nodoc: Journey because is not part of the public API [ci skip]Francesco Rodriguez2012-12-1920-78/+75
| | |
* | | remove code for Ruby 1.8.x supportFrancesco Rodriguez2012-12-191-7/+2
| | |
* | | Remove the actual extension file as well [ci skip]Andrew White2012-12-191-11/+0
| | |
* | | Remove obsolete Hash extension needed for Ruby 1.8.x supportAndrew White2012-12-191-1/+0
| | | | | | | | | | | | [ci skip]
* | | Integrate Journey into Action DispatchAndrew White2012-12-1927-1/+2339
| | | | | | | | | | | | | | | | | | | | | | | | Move the Journey code underneath the ActionDispatch namespace so that we don't pollute the global namespace with names that may be used for models. Fixes rails/journey#49.
* | | Minor js review [ci skip]Carlos Antonio da Silva2012-12-181-7/+7
| | | | | | | | | | | | Remove/add ; where necessary, fix indentation.
* | | Format routes as html on debug pageschneems2012-12-174-2/+76
| |/ |/| | | | | | | | | | | | | | | When someone gets a routing exception, the routes are rendered (starting in Rails 4.0). This PR brings parity between the html routes in the `rails/info/routes` path and when rendered from an exception. This is the continuation of #8521 which brought html formatted routes. In addition to bringing parity to the two views, we're keeping our views DRY by rendering off of the same partials. In this case Railties depends on partials provided by ActionDispatch. I'm open to alternative implementations. Ideally both views will use the same code so any improvements or updates to it will be reproduced on both. <hr /> ![](http://f.cl.ly/items/3O1D0K1v0j0i343O3T3T/Screen%20Shot%202012-12-17%20at%203.07.20%20PM.png)
* | Merge pull request #8529 from schneems/schneems/debug-exceptions-extend-pathSteve Klabnik2012-12-161-1/+1
|\ \ | |/ |/| DebugExceptions `File.join` => `File.expand_path`
| * DebugExceptions `File.join` => `File.expand_path`schneems2012-12-161-1/+1
| |
* | Revert "Merge pull request #8499 from schneems/schneems/html-route-inspector"Steve Klabnik2012-12-141-24/+7
| | | | | | | | | | | | | | This reverts commit ae68fc3864e99ab43c18fd12577744e1583f6b64, reversing changes made to 0262a18c7b0ab6f60fee842b3007388f9ffeb0fa. See here: https://github.com/rails/rails/pull/8499#issuecomment-11356417
* | remove a cache we do not needAaron Patterson2012-12-141-5/+1
| |
* | Merge pull request #8510 from thedarkone/thread_safety_improvementsAaron Patterson2012-12-142-15/+7
|\ \ | | | | | | Thread safety improvements
| * | Replace some global Hash usages with the new thread safe cache.thedarkone2012-12-142-15/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Summary of the changes: * Add thread_safe gem. * Use thread safe cache for digestor caching. * Replace manual synchronization with ThreadSafe::Cache in Relation::Delegation. * Replace @attribute_method_matchers_cache Hash with ThreadSafe::Cache. * Use TS::Cache to avoid the synchronisation overhead on listener retrieval. * Replace synchronisation with TS::Cache usage. * Use a preallocated array for performance/memory reasons. * Update the controllers cache to the new AS::Dependencies::ClassCache API. The original @controllers cache no longer makes much sense after @tenderlove's changes in 7b6bfe84f3 and f345e2380c. * Use TS::Cache in the connection pool to avoid locking overhead. * Use TS::Cache in ConnectionHandler.
* | | Clear url helper methods when routes are reloadedAndrew White2012-12-141-0/+6
| | | | | | | | | | | | | | | Remove all the old url helper methods when clear! is called on the route set because it's possible that some routes have been removed.
* | | Revert "Clear url helpers when reloading routes"Andrew White2012-12-141-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This doesn't actually remove old url helper methods as they are defined in a different module. This reverts commit 96bcef947bf713b7d9fc88f26dff69f568111262. Conflicts: actionpack/CHANGELOG.md
* | | Output routes in :html formatschneems2012-12-121-7/+24
| | | | | | | | | | | | | | | | | | By formatting routes for different media (txt/html) we can apply optimizations based on the format. We can include meta-data in the HTML to allow a rich experience while rendering and viewing the routes. This PR shows route helpers as they are used with the `_path` extension, it also has a javascript toggle on the top to switch to `_url`. This way the developer can see the exact named route helper they can use instead of having to modify a base. This is one example of an optimization that could be applied. Eventually we can link out to guides for the different columns to better explain what helper, HTTP Verb, Path, and Controller#action indicate. We could even add a route search box that could allow developers to input a given route and see all of the routes that match it. These are stand alone features and should be delivered separately.
* | | Fix rewinding in ActionDispatch::Request#raw_postMatt Venables2012-12-111-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | If env['RAW_POST_DATA'] is nil, #raw_post will attempt to set it to the result of #body (which will return env['rack.input'] if env['RAW_POST_DATA'] is nil). #raw_post will then attempt to rewind the result of another call to #body. Since env['RAW_POST_DATA'] has already been set, the result of #body is not env['rack.input'] anymore. This causes env['rack.input'] to never be rewound.
* | | Match the controller and path names defensively.Hiro Asari2012-12-101-1/+1
| | | | | | | | | | | | Use '\A' instead of '^', and make the alteration shorter.
* | | Merge pull request #8468 from schneems/schneems/rack-index-pageSantiago Pastorino2012-12-101-1/+1
|\ \ \ | |/ / |/| | Use Rails to Render Default Index Page
| * | Use Rails to Render Default Index Pageschneems2012-12-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an alternative implementation to #7771 thanks to the advice of @spastorino Rails is a dynamic framework that serves a static index.html by default. One of my first questions ever on IRC was solved by simply deleting my public/index.html file. This file is a source of confusion when starting as it over-rides any set "root" in the routes yet it itself is not listed in the routes. By making the page dynamic by default we can eliminate this confusion. This PR moves the static index page to an internal controller/route/view similar to `rails/info`. When someone starts a rails server, if no root is defined, this route will take over and the "dynamic" index page from rails/welcome_controller will be rendered. These routes are only added in development. If a developer defines a root in their routes, it automatically takes precedence over this route and will be rendered, with no deleting of files required. In addition to removing this source of confusion for new devs, we can now use Rails view helpers to build and render this page. While not the primary intent, the added value of "dogfooding" should not be under-estimated. The prior PR #7771 had push-back since it introduced developer facing files. This PR solves all of the same problems, but does not have any new developer facing files (it actually removes one). cc/ @wsouto, @dickeyxxx, @tyre, @ryanb, @josevalim, @maxim, @subdigital, @steveklabnik ATP Railties and Actionpack.
* | | Merge pull request #8476 from sheerun/fix/multipart-getRafael Mendonça França2012-12-101-1/+5
|\ \ \ | |/ / |/| | Prevent raising EOFError on multipart GET request.
| * | Prevent raising EOFError on multipart GET request.Adam Stankiewicz2012-12-101-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Such request can happen on Internet Explorer. When we redirect after multipart form submission, the request type is changed to GET, but Content-Type is preserved as multipart. GET request cannot have multipart body and that caused Rails to fail. It's similar fix to Rack's one: https://github.com/chneukirchen/rack/blob/8025a4ae9477d1e6231344c2b7d795aa9b3717b6/lib/rack/request.rb#L224
* | | use `_action` instead of `_filter` callbacksFrancesco Rodriguez2012-12-071-2/+2
|/ /
* | Revert "Invert precedence of content in ActionDispatch::Static"Andrew White2012-12-071-11/+7
| | | | | | | | This reverts commit c59734f756b79c39486c45273d2cc5d42cd0c864.
* | Invert precedence of content in ActionDispatch::StaticAndrew White2012-12-061-7/+11
|/ | | | | | | | | | This commit inverts the precedence in ActionDispatch::Static so that dynamic content will be served before static content. This is so that precompiled assets do not inadvertently get included when running in development mode - it should have no effect in production where static files are usually handled by the web server. Closes #6421
* Merge pull request #8412 from ↵Rafael Mendonça França2012-12-051-18/+14
|\ | | | | | | | | JoeyButler/action_dispatch_routing_mapper_refactoring Extract method refactoring.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-06 03:09:17 +0000