aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #3617 from indirect/remote_ipJosé Valim2011-11-132-53/+55
|\ | | | | refactor RemoteIp middleware
| * defer calculating the remote IP until requestedAndre Arko2011-11-121-24/+36
| |
| * refactor RemoteIp middlewareAndre Arko2011-11-112-55/+45
| | | | | | | | | | | | | | | | | | | | | | - return the last forwarded IP before REMOTE_ADDR to handle proxies - remove completely superfluous RemoteIpGetter class - remove duplication of trusted proxies regexp - remove unused constant from Request - move comments from Request to where they are actually relevant - edit comments for clarity of purpose The original code (confusingly) tried to return REMOTE_ADDR both at the beginning and the end of the chain of options. Since REMOTE_ADDR is _always_ set, this is kind of silly. This change leaves REMOTE_ADDR as the last option, so that proxied requests will be assigned the correct remote IP address.
* | Unneeded require memoizableAkira Matsuda2011-11-121-2/+0
|/
* Fix trouble using :subdomain in development environment when using ↵Bradford Folkens2011-11-081-1/+1
| | | | | | | | | | | | | | | | numeric addresses. See-also pull request #3561 from 3-1-stable Otherwise the following occurs: TypeError: can't convert nil into String /Users/bfolkens/dev/bfolkens-rails-core/actionpack/lib/action_dispatch/http/url.rb:75:in host_or_subdomain_and_domain' /Users/bfolkens/dev/bfolkens-rails-core/actionpack/lib/action_dispatch/http/url.rb:37:in url_for' /Users/bfolkens/dev/bfolkens-rails-core/actionpack/lib/action_dispatch/routing/url_for.rb:147:in test_subdomain_may_be_accepted_with_numeric_host' /Users/bfolkens/dev/bfolkens-rails-core/activesupport/lib/active_support/testing/setup_and_teardown.rb:67:in run' /Users/bfolkens/dev/bfolkens-rails-core/activesupport/lib/active_support/callbacks.rb:426:in send' /Users/bfolkens/dev/bfolkens-rails-core/activesupport/lib/active_support/callbacks.rb:81:in run'
* Fix small typos in routing docsAlexey Vakhov2011-11-031-1/+3
|
* Fix typo in Dispatcher#controller documentationAviv Ben-Yosef2011-11-011-1/+1
|
* Fix typo in constraints method documentationAlexey Vakhov2011-11-011-1/+1
|
* Adds missing closing regex slashes.mjy2011-10-251-2/+2
|
* Add ActionDispatch::Session::CacheStore as a generic way of storing sessions ↵Brian Durand2011-10-211-0/+50
| | | | in a cache.
* Remove the unneeded `\d` when sanitizing `X-Request-Id`.Marc Bowes2011-10-201-1/+1
|
* Load object/blank and make use of presence.José Valim2011-10-191-2/+3
|
* Make tests run on 1.8.x, add integration setup.José Valim2011-10-191-3/+2
|
* Blah, SecureRandom#uuid is not supported in 1.8.7 -- cant wait for Rails 4.0 ↵David Heinemeier Hansson2011-10-191-1/+1
| | | | to drop compatibility with 1.8.x
* Require missing string access dependency.José Valim2011-10-191-0/+1
|
* Require securerandom as it is the proper dependency.José Valim2011-10-191-1/+1
|
* Added X-Request-Id tracking and TaggedLogging to easily log that and other ↵David Heinemeier Hansson2011-10-192-0/+48
| | | | production concerns
* Remove superfluous assignment in cookiesAlexey Vakhov2011-10-181-1/+1
|
* / is allowed in URI fragmentsJeremy Kemper2011-10-131-1/+1
|
* Leave escaping up to JourneyJeremy Kemper2011-10-131-4/+3
|
* Add some implementation docs. closes #3298. closes #2509.José Valim2011-10-121-0/+4
|
* allow shorthand routes with nested optional parametersDiego Carrion2011-10-101-3/+3
|
* fix requireAaron Patterson2011-10-061-1/+1
|
* Clean up subdomain code a bit.José Valim2011-10-041-2/+2
|
* :subdomain can now be specified with a value of false in url_for, allowing ↵Kamil Sobieraj2011-10-042-5/+8
| | | | for subdomain(s) removal from the host during link generation. Closes #2025
* TestCase should respect the view_assigns API instead of pulling variables on ↵José Valim2011-10-021-6/+1
| | | | its own.
* Implement Mime::Type#respond_to? (consistently with #method_missing)Evgeniy Dolzhenko2011-09-251-0/+4
|
* Revert "Make process reuse the env var passed as argument"Santiago Pastorino2011-09-241-4/+4
| | | | This reverts commit 0e4748cd415660eb91e63d50aa15cdd027c612dd.
* Deprecate passing the template handler in the template name.José Valim2011-09-221-2/+2
| | | | | | For example, calling hello.erb is now deprecated. Since Rails 3.0 passing the handler had no effect whatsover. This commit simply deprecates such cases so we can clean up the code in later releases.
* Fix named routes modifying argumentsPawel Pierzchala2011-09-221-3/+4
|
* removing backwards compatibility moduleAaron Patterson2011-09-123-9/+8
|
* partially expand the parameters to `match`Aaron Patterson2011-09-121-3/+3
|
* unfactor the Route class to private factory methodsAaron Patterson2011-09-122-45/+42
|
* reduce dependencies of external objects in the Route classAaron Patterson2011-09-122-16/+18
|
* delete unused code, pass path explicitly to journeyAaron Patterson2011-09-122-28/+7
|
* all routes can be stored in the Journey Routes objectAaron Patterson2011-09-121-5/+4
|
* clear! does not need to be called from initializeAaron Patterson2011-09-121-4/+3
|
* reuse the route collection and formatter by clearing themAaron Patterson2011-09-121-6/+10
|
* Instantiate each part of our routing system:Aaron Patterson2011-09-121-7/+8
| | | | | | * A collection of Routes * The Router, which consults the collection of routes * A formatter that consults the collection of routes
* stop freezing the routesAaron Patterson2011-09-121-1/+0
|
* stop using a hash for parameterizingAaron Patterson2011-09-121-11/+9
|
* Switching rack-mount to journey.Aaron Patterson2011-09-121-1/+2
|
* Merge pull request #2499 from akaspick/assert_select_email_fixJon Leighton2011-09-071-2/+2
|\ | | | | Fix assert_select_email to work on non-multipart emails as well as converting the Mail::Body to a string to prevent errors.
| * fix assert_select_email to work on non-multipart emails as well as ↵Andrew Kaspick2011-08-111-2/+2
| | | | | | | | converting the Mail::Body to a string to prevent errors.
* | Merge pull request #2577 from rails-noob/masterSantiago Pastorino2011-09-061-1/+3
|\ \ | | | | | | Fix double slash at start of paths when mounting an engine at the root.
| * | Fix bug #2579.rails-noob2011-09-061-1/+3
| | | | | | | | | | | | Avoids double slash at start of paths when mounting an engine at the root.
* | | if ... nil? is more expensive than unlessMilan Dobrota2011-09-041-1/+1
| | |
* | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2011-09-021-6/+6
|\ \ \
| * | | Fix name of parent resource params when declaring nested resources at routesCarlos Paramio2011-09-011-6/+6
| | | |
* | | | CookieJar is enumerable. fixes #2795Aaron Patterson2011-09-011-0/+5
| | | |