Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | Make caller attribute in deprecation methods optional | Alexey Gaziev | 2012-10-30 | 1 | -2/+1 | |
| | | ||||||
* | | Add missing require for minitest assertions. Breaks calling 'app' in console ↵ | Jeremy Kemper | 2012-10-25 | 1 | -0/+1 | |
|/ | | | | otherwise. See 94248ffe1e6f815b8ffab4eb752b60c1e4459d25. | |||||
* | Register AD::IntegrationTest for minitest's spec DSL | Mike Moore | 2012-09-24 | 1 | -0/+3 | |
| | ||||||
* | Merge pull request #7530 from robin850/master | Xavier Noria | 2012-09-05 | 1 | -1/+1 | |
|\ | | | | | Fix a typo in AD | |||||
| * | Fix a typo | Robin Dupret | 2012-09-05 | 1 | -1/+1 | |
| | | ||||||
* | | Move action_controller/vendor/html-scanner to action_view | Piotr Sarnacki | 2012-08-28 | 3 | -3/+4 | |
| | | | | | | | | | | | | This is another step in moving Action View's dependencies in Action Pack to Action View itself. Also, HtmlScanner seems to be better suited for views rather than controllers. | |||||
* | | removes usage of Object#in? from the code base (the method remains defined ↵ | Xavier Noria | 2012-08-06 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | by Active Support) Selecting which key extensions to include in active_support/rails made apparent the systematic usage of Object#in? in the code base. After some discussion in https://github.com/rails/rails/commit/5ea6b0df9a36d033f21b52049426257a4637028d we decided to remove it and use plain Ruby, which seems enough for this particular idiom. In this commit the refactor has been made case by case. Sometimes include? is the natural alternative, others a simple || is the way you actually spell the condition in your head, others a case statement seems more appropriate. I have chosen the one I liked the most in each case. | |||||
* | | load active_support/core_ext/object/inclusion in active_support/rails | Xavier Noria | 2012-08-02 | 3 | -3/+0 | |
| | | ||||||
* | | load active_support/core_ext/object/blank in active_support/rails | Xavier Noria | 2012-08-02 | 1 | -1/+0 | |
| | | ||||||
* | | Updated with_routing example to 3.x syntax [ci skip] | Wojciech Wnętrzak | 2012-07-13 | 1 | -7/+4 | |
|/ | ||||||
* | make the default environment have actual defaults | Aaron Patterson | 2012-07-03 | 1 | -1/+7 | |
| | | | | | | instead of deleting keys on every instantiation, create defaults we actually use. eventually we can pass an environment in to the request, and create a new req / res object on each call. | |||||
* | Include routes.mounted_helpers into integration tests | Piotr Sarnacki | 2012-06-01 | 1 | -2/+5 | |
| | | | | | | | | | | | | | | | In integration tests, you might want to use helpers from engines that you mounted in your application. It's not hard to add it by yourself, but it's unneeded boilerplate. mounted_helpers are now included by default. That means that given engine mounted like: mount Foo::Engine => "/foo", :as => "foo" you will be able to use paths from this engine in tests this way: foo.root_path #=> "/foo" (closes #6573) | |||||
* | references to the old behavior removed | Mikhail Vaysman | 2012-05-25 | 1 | -4/+3 | |
| | ||||||
* | Fix bug when Rails.application is defined but is nil. See #881 | Marc-Andre Lafortune | 2012-05-21 | 1 | -1/+1 | |
| | ||||||
* | Correct order of expected and actual arguments | Andrew White | 2012-05-20 | 1 | -1/+1 | |
| | ||||||
* | Raise Assertion instead of RoutingError for routing assertion failures. | David Chelimsky | 2012-05-20 | 1 | -7/+13 | |
| | | | | | | | | | | | | | Before this change, assert_recognizes, assert_generates, and assert_routing raised ActionController::RoutingError when they failed to recognize the route. This commit changes them to raise Assertion instead. This aligns with convention for logical failures, and supports reporting tools that care about the difference between logical failures and errors e.g. the summary at the end of a test run. - Fixes #5899 | |||||
* | Removing ==Examples and last blank lines of docs from actionpack | Francesco Rodriguez | 2012-05-15 | 5 | -24/+0 | |
| | ||||||
* | Refactor the handling of default_url_options in integration tests | Andrew White | 2012-05-10 | 1 | -7/+24 | |
| | | | | | | | | | | | | This commit improves the handling of default_url_options in integration tests by making behave closer to how a real application operates. Specifically the following issues have been addressed: * Options specified in routes.rb are used (fixes #546) * Options specified in controllers are used * Request parameters are recalled correctly * Tests can override default_url_options directly | |||||
* | Allows assert_redirected_to to accept a regular expression | Andy Lindeman | 2012-05-03 | 1 | -13/+20 | |
| | ||||||
* | Merge pull request #5716 from jurriaan/tr-gsub-cleanup | Santiago Pastorino | 2012-04-04 | 1 | -1/+1 | |
|\ | | | | | Updated/changed unneeded tr/gsubs | |||||
| * | Updated/changed useless tr/gsubs | Jurriaan Pruis | 2012-04-03 | 1 | -1/+1 | |
| | | ||||||
* | | No need to extend ActiveSupport::Extend here | Oscar Del Ben | 2012-04-04 | 1 | -2/+0 | |
|/ | ||||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-04-01 | 1 | -1/+1 | |
|\ | ||||||
| * | :success includes the whole 200 range, not just 200. | Erich Menge | 2012-04-01 | 1 | -1/+1 | |
| | | | | | | | | | | # File lib/rack/response.rb, line 114 114: def successful?; @status >= 200 && @status < 300; end | |||||
* | | Remove not needed requires | Santiago Pastorino | 2012-03-31 | 1 | -1/+0 | |
| | | ||||||
* | | Remove the leading \n added by textarea on assert_select | Santiago Pastorino | 2012-03-30 | 1 | -0/+1 | |
|/ | ||||||
* | strip null bytes from Location header as well | Brian Lopez | 2012-03-15 | 1 | -1/+1 | |
| | | | | add tests for stripping \r\n chars since that's already happening | |||||
* | Merge pull request #5219 from ↵ | Aaron Patterson | 2012-02-29 | 1 | -4/+3 | |
|\ | | | | | | | | | mattfawcett/2781-fix-querystring-route-constraint-for-testing Fix for #2781 | |||||
| * | Fix the assert_recognizes test method so that it works when there are | Matt Fawcett | 2012-02-24 | 1 | -4/+3 | |
| | | | | | | | | constraints on the querystring. Issue #2781 | |||||
* | | consistently mention first patch, then put | Xavier Noria | 2012-02-24 | 1 | -1/+1 | |
|/ | | | | | | There was a mix, sometimes patch first, sometimes put first. Use always patch first, since this is going to be the primary verb for updates. | |||||
* | Add config.default_method_for_update to support PATCH | David Lee | 2012-02-22 | 1 | -7/+19 | |
| | | | | | | | | | | | | | | | | PATCH is the correct HTML verb to map to the #update action. The semantics for PATCH allows for partial updates, whereas PUT requires a complete replacement. Changes: * adds config.default_method_for_update you can set to :patch * optionally use PATCH instead of PUT in resource routes and forms * adds the #patch verb to routes to detect PATCH requests * adds #patch? to Request * changes documentation and comments to indicate support for PATCH This change maintains complete backwards compatibility by keeping :put as the default for config.default_method_for_update. | |||||
* | Merge pull request #5082 from ↵ | Aaron Patterson | 2012-02-20 | 1 | -1/+2 | |
|\ | | | | | | | | | willbryant/assigns_should_not_stringify_values_master assigns(:foo) should not convert @foo's keys to strings if it happens to be a hash | |||||
| * | assigns(:foo) should not convert @foo's keys to strings if it happens to be ↵ | Will Bryant | 2012-02-18 | 1 | -1/+2 | |
| | | | | | | | | a hash | |||||
* | | Integration tests support the OPTIONS http method | Jeremy Kemper | 2012-02-19 | 1 | -1/+7 | |
|/ | ||||||
* | Stop referring to Atom as "ATOM" | Tom Stuart | 2012-02-05 | 1 | -1/+1 | |
| | | | | | | $ curl -s http://www.ietf.org/rfc/rfc4287 | grep -io ATOM | sort | uniq -c 582 atom 175 Atom | |||||
* | Remove assert_select_feed from assert_select_encoded documentation | Tom Stuart | 2012-02-05 | 1 | -2/+2 | |
| | | | | | | This documentation came from the assert_select plugin, but the assert_select_feed method was omitted when the plugin was merged into Rails in 3142502964f94d6144312ae2c368b4c4589fa25a. | |||||
* | Replaced all 'for' loops with Enumerable#each | Nathan Broadbent | 2012-01-30 | 1 | -2/+2 | |
| | ||||||
* | Use MiniTest::Assertions instead of Test::Unit::Assertions | Rafael Mendonça França | 2012-01-06 | 1 | -2/+1 | |
| | ||||||
* | use assert_equal and assert_operator | Aaron Patterson | 2012-01-06 | 1 | -5/+8 | |
| | ||||||
* | use sprintf rather than build_message | Aaron Patterson | 2012-01-06 | 1 | -4/+6 | |
| | ||||||
* | Just use assert_equal | Aaron Patterson | 2012-01-06 | 1 | -3/+2 | |
| | ||||||
* | refactor assert_response | Aaron Patterson | 2012-01-06 | 1 | -7/+10 | |
| | ||||||
* | test response assertions | Aaron Patterson | 2012-01-06 | 1 | -8/+0 | |
| | ||||||
* | no need for assert_block | Aaron Patterson | 2012-01-06 | 1 | -3/+3 | |
| | ||||||
* | stop using build_message for creating a string | Aaron Patterson | 2012-01-06 | 1 | -1/+1 | |
| | ||||||
* | just use assert and refute rather than building messages | Aaron Patterson | 2012-01-06 | 1 | -6/+2 | |
| | ||||||
* | remove Rails application fallback from AD::IntegrationTest | Sergey Nartimov | 2011-12-23 | 1 | -3/+6 | |
| | | | | set AD::IntegrationTest.app in railtie initializer | |||||
* | TestCase should respect the view_assigns API instead of pulling variables on ↵ | José Valim | 2011-10-02 | 1 | -6/+1 | |
| | | | | its own. | |||||
* | Revert "Make process reuse the env var passed as argument" | Santiago Pastorino | 2011-09-24 | 1 | -4/+4 | |
| | | | | This reverts commit 0e4748cd415660eb91e63d50aa15cdd027c612dd. | |||||
* | fix assert_select_email to work on non-multipart emails as well as ↵ | Andrew Kaspick | 2011-08-11 | 1 | -2/+2 | |
| | | | | converting the Mail::Body to a string to prevent errors. |