aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch/testing
Commit message (Collapse)AuthorAgeFilesLines
* Remove outdated comments [ci skip]Godfrey Chan2014-11-221-6/+0
| | | They were introduced in 23b6def; the serial stuff has been removed since a5d80f8
* Make sure assert_select can assert body tagRafael Mendonça França2014-11-182-2/+2
| | | | | | | | | This reverts commit f93df52845766216f0fe36a4586f8abad505cac4, reversing changes made to a455e3f4e9dbfb9630d47878e1239bc424fb7d13. Conflicts: actionpack/lib/action_controller/test_case.rb actionview/lib/action_view/test_case.rb
* Fix for assigns(:..) resetting template assertionsCalvin Correli2014-11-171-3/+7
| | | | When calling assigns(:...) or cookies(:...), template assertions would be reset, which they obviously shouldn't be.
* Remove session to allow `with_routing` to be called twice.Guo Xiang Tan2014-11-051-0/+4
| | | | Fixes: https://github.com/rails/rails/issues/16814
* edit pass over all warningsXavier Noria2014-10-281-1/+1
| | | | | | | | | | | | | | | This patch uniformizes warning messages. I used the most common style already present in the code base: * Capitalize the first word. * End the message with a full stop. * "Rails 5" instead of "Rails 5.0". * Backticks for method names and inline code. Also, converted a few long strings into the new heredoc convention.
* Parse HTML as document fragment.Kasper Timm Hansen2014-09-292-2/+2
| | | | This is to match the changes in Rails Dom Testing rails/rails-dom-testing#20.
* Remove extra 'has been' from deprecation warning about asserting selectorsPrathamesh Sonpatki2014-09-091-1/+1
| | | | [ci skip]
* Remove extra 'has been' from the deprecation messagePrathamesh Sonpatki2014-09-091-1/+1
| | | | - [ci skip]
* :scissors:Rafael Mendonça França2014-09-051-1/+1
|
* Message doesn't need to be optionalRafael Mendonça França2014-09-051-2/+2
|
* Merge pull request #14911 from estsauver/14908Rafael Mendonça França2014-09-051-7/+7
|\ | | | | | | Propagate test messages through assert_routing helper, Fixes #14908
| * Propagate test messages through assert_routing helper, Fixes #14908Earl St Sauver2014-04-291-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | assert_routing was not raising the message passed into the assertion violation that it raised. This change propagates messages through the on_fail error. This fixes this error: https://github.com/rails/rails/issues/14908 A test case for this issue is located here. https://github.com/estsauver/test14908 To see that test case fail in the example app, just run ruby -Itest test/controllers/guests_controller_test.rb
* | Add missing requireGodfrey Chan2014-08-181-0/+2
| |
* | Deprecate TagAssertion instead of removingRafael Mendonça França2014-08-181-0/+1
| |
* | Merge branch 'master' into loofahRafael Mendonça França2014-08-123-9/+6
|\ \ | | | | | | | | | | | | | | | | | | Conflicts: actionpack/CHANGELOG.md actionpack/test/controller/integration_test.rb actionview/CHANGELOG.md
| * | refactor Redirecting so we do not need a controller instanceAaron Patterson2014-08-061-7/+2
| | |
| * | Revert "Merge pull request #15305 from tgxworld/remove_unnecessary_require"Santiago Pastorino2014-07-301-0/+1
| | | | | | | | | | | | | | | | | | | | | This reverts commit f632f79b8dcd144408c66a544984b2ba9cf52f87, reversing changes made to 98c7fe87690ca4de6c46e8f69806e82e3f8af42d. Closes #16343
| * | ask the named routes collection if the route is definedAaron Patterson2014-07-291-1/+1
| | | | | | | | | | | | | | | we should not be accessing internals to figure out if a method is defined.
| * | Fix AC::TemplateAssertions instance variables not resetting.Guo Xiang Tan2014-07-211-0/+1
| | | | | | | | | | | | Fixes https://github.com/rails/rails/issues/16119.
| * | routed applications will respond to these methodsAaron Patterson2014-07-151-1/+1
| | |
* | | We don't need loofah for the assertionsRafael Mendonça França2014-07-151-3/+2
| | | | | | | | | | | | We can just use nokogiri
* | | Merge pull request #11218 from kaspth/loofah-integrationRafael Mendonça França2014-07-105-597/+20
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | Loofah-integration Conflicts: actionpack/CHANGELOG.md actionview/CHANGELOG.md
| * | Add document_root_element to ActionDispatch::IntegrationTest so ↵Timm2014-06-161-0/+4
| | | | | | | | | | | | assert_select can be called without specifying a root.
| * | Moved html_document to ActionDispatch::Assertions. Included the ↵Timm2014-06-161-1/+12
| | | | | | | | | | | | Rails::Dom::Testing::Assertions there as well.
| * | Changed deprecation message in dom and selector assertions in Action Dispatch.Timm2014-06-162-2/+2
| | |
| * | Removed tag.rb, since it is actually removed, not just deprecated. [ci skip]Timm2014-06-161-3/+0
| | |
| * | Moved ActionView::Assertions dependency from Action Pack's lib to ↵Timm2014-06-161-2/+1
| | | | | | | | | | | | abstract_unit.rb.
| * | Added deprecation warning to ActionDispatch::Assertions::TagAssertions.Timm2014-06-161-0/+3
| | |
| * | Trimmed deprecation message for ActionDispatch::Assertions::SelectorAssertions.Timm2014-06-161-1/+1
| | |
| * | Moved Dom and Selector assertions from ActionDispatch to ActionView.Timm2014-06-164-544/+6
| | |
| * | Fixed: assert_select_encoded finds the right content. No longer uses a ↵Timm2014-06-161-5/+9
| | | | | | | | | | | | <encoded> wrapper. Updated tests to reflect this.
| * | Removed mention of css_select supporting substitution values. It is not ↵Timm2014-06-161-7/+1
| | | | | | | | | | | | tested anywhere.
| * | Updated documentation to state more things about css selectors with ↵Timm2014-06-161-3/+11
| | | | | | | | | | | | substitution values.
| * | Reworked the wrapping root in NodeSet implementation in css_select.Timm2014-06-161-3/+5
| | |
| * | Wrapped element to search in NodeSet. Changed selectors to selector.Timm2014-06-161-3/+5
| | |
| * | Moved around alias line.Timm2014-06-161-2/+2
| | |
| * | Returning from filter if matches are empty.Timm2014-06-161-1/+1
| | |
| * | Fixed: no longer wrapped @selected in fragment, since .css works fine ↵Timm2014-06-161-2/+1
| | | | | | | | | | | | without it.
| * | Reverted to using documents instead of document fragments, since searching ↵Timm2014-06-161-3/+6
| | | | | | | | | | | | via default xml namespaces didn't work.
| * | add_regex returns inspected value for non Regexp objects. Workaround, so ↵Timm2014-06-161-1/+2
| | | | | | | | | | | | users don't have to care about enclosing values in double quotes.
| * | Fixed: inadvertently called message method in MiniTest instead of ↵Timm2014-06-161-1/+1
| | | | | | | | | | | | selector.message.
| * | Cleaned up SubstitutionContext class.Timm2014-06-161-10/+8
| | |
| * | Simplified assert_select further by moving match filtering into HTMLSelector ↵Timm2014-06-161-32/+29
| | | | | | | | | | | | select.
| * | Fixed: now only compares html of children in filter_matches.Timm2014-06-161-1/+1
| | |
| * | Added NodeSet comparison to possible root element in determine_root_from.Timm2014-06-161-1/+1
| | |
| * | Changed html_document to use fragments. Changed response_from_page to be an ↵Timm2014-06-161-6/+3
| | | | | | | | | | | | alias of html_document.
| * | Fixed bug by switching to Loofah fragment instead of document.Timm2014-06-161-2/+2
| | |
| * | Changed css_select to not count on multiple selectors. Fixed bug in ↵Timm2014-06-161-8/+10
| | | | | | | | | | | | determine_root_from where @selected was an Array. Changed assert_select_encoded to use a fragment instead of a document.
| * | Added a proper substitution context class. Changed ArgumentFilter to be a ↵Timm2014-06-161-34/+47
| | | | | | | | | | | | selector. It is now called HTMLSelector.
| * | Fixed nested assert_select bug. Trying to create a full document for a ↵Timm2014-06-161-1/+1
| | | | | | | | | | | | nested call that already had a document.