Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Remove outdated comments [ci skip] | Godfrey Chan | 2014-11-22 | 1 | -6/+0 |
| | | | They were introduced in 23b6def; the serial stuff has been removed since a5d80f8 | ||||
* | Make sure assert_select can assert body tag | Rafael Mendonça França | 2014-11-18 | 2 | -2/+2 |
| | | | | | | | | | This reverts commit f93df52845766216f0fe36a4586f8abad505cac4, reversing changes made to a455e3f4e9dbfb9630d47878e1239bc424fb7d13. Conflicts: actionpack/lib/action_controller/test_case.rb actionview/lib/action_view/test_case.rb | ||||
* | Fix for assigns(:..) resetting template assertions | Calvin Correli | 2014-11-17 | 1 | -3/+7 |
| | | | | When calling assigns(:...) or cookies(:...), template assertions would be reset, which they obviously shouldn't be. | ||||
* | Remove session to allow `with_routing` to be called twice. | Guo Xiang Tan | 2014-11-05 | 1 | -0/+4 |
| | | | | Fixes: https://github.com/rails/rails/issues/16814 | ||||
* | edit pass over all warnings | Xavier Noria | 2014-10-28 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | This patch uniformizes warning messages. I used the most common style already present in the code base: * Capitalize the first word. * End the message with a full stop. * "Rails 5" instead of "Rails 5.0". * Backticks for method names and inline code. Also, converted a few long strings into the new heredoc convention. | ||||
* | Parse HTML as document fragment. | Kasper Timm Hansen | 2014-09-29 | 2 | -2/+2 |
| | | | | This is to match the changes in Rails Dom Testing rails/rails-dom-testing#20. | ||||
* | Remove extra 'has been' from deprecation warning about asserting selectors | Prathamesh Sonpatki | 2014-09-09 | 1 | -1/+1 |
| | | | | [ci skip] | ||||
* | Remove extra 'has been' from the deprecation message | Prathamesh Sonpatki | 2014-09-09 | 1 | -1/+1 |
| | | | | - [ci skip] | ||||
* | :scissors: | Rafael Mendonça França | 2014-09-05 | 1 | -1/+1 |
| | |||||
* | Message doesn't need to be optional | Rafael Mendonça França | 2014-09-05 | 1 | -2/+2 |
| | |||||
* | Merge pull request #14911 from estsauver/14908 | Rafael Mendonça França | 2014-09-05 | 1 | -7/+7 |
|\ | | | | | | | Propagate test messages through assert_routing helper, Fixes #14908 | ||||
| * | Propagate test messages through assert_routing helper, Fixes #14908 | Earl St Sauver | 2014-04-29 | 1 | -7/+7 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | assert_routing was not raising the message passed into the assertion violation that it raised. This change propagates messages through the on_fail error. This fixes this error: https://github.com/rails/rails/issues/14908 A test case for this issue is located here. https://github.com/estsauver/test14908 To see that test case fail in the example app, just run ruby -Itest test/controllers/guests_controller_test.rb | ||||
* | | Add missing require | Godfrey Chan | 2014-08-18 | 1 | -0/+2 |
| | | |||||
* | | Deprecate TagAssertion instead of removing | Rafael Mendonça França | 2014-08-18 | 1 | -0/+1 |
| | | |||||
* | | Merge branch 'master' into loofah | Rafael Mendonça França | 2014-08-12 | 3 | -9/+6 |
|\ \ | | | | | | | | | | | | | | | | | | | Conflicts: actionpack/CHANGELOG.md actionpack/test/controller/integration_test.rb actionview/CHANGELOG.md | ||||
| * | | refactor Redirecting so we do not need a controller instance | Aaron Patterson | 2014-08-06 | 1 | -7/+2 |
| | | | |||||
| * | | Revert "Merge pull request #15305 from tgxworld/remove_unnecessary_require" | Santiago Pastorino | 2014-07-30 | 1 | -0/+1 |
| | | | | | | | | | | | | | | | | | | | | | This reverts commit f632f79b8dcd144408c66a544984b2ba9cf52f87, reversing changes made to 98c7fe87690ca4de6c46e8f69806e82e3f8af42d. Closes #16343 | ||||
| * | | ask the named routes collection if the route is defined | Aaron Patterson | 2014-07-29 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | we should not be accessing internals to figure out if a method is defined. | ||||
| * | | Fix AC::TemplateAssertions instance variables not resetting. | Guo Xiang Tan | 2014-07-21 | 1 | -0/+1 |
| | | | | | | | | | | | | Fixes https://github.com/rails/rails/issues/16119. | ||||
| * | | routed applications will respond to these methods | Aaron Patterson | 2014-07-15 | 1 | -1/+1 |
| | | | |||||
* | | | We don't need loofah for the assertions | Rafael Mendonça França | 2014-07-15 | 1 | -3/+2 |
| | | | | | | | | | | | | We can just use nokogiri | ||||
* | | | Merge pull request #11218 from kaspth/loofah-integration | Rafael Mendonça França | 2014-07-10 | 5 | -597/+20 |
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | Loofah-integration Conflicts: actionpack/CHANGELOG.md actionview/CHANGELOG.md | ||||
| * | | Add document_root_element to ActionDispatch::IntegrationTest so ↵ | Timm | 2014-06-16 | 1 | -0/+4 |
| | | | | | | | | | | | | assert_select can be called without specifying a root. | ||||
| * | | Moved html_document to ActionDispatch::Assertions. Included the ↵ | Timm | 2014-06-16 | 1 | -1/+12 |
| | | | | | | | | | | | | Rails::Dom::Testing::Assertions there as well. | ||||
| * | | Changed deprecation message in dom and selector assertions in Action Dispatch. | Timm | 2014-06-16 | 2 | -2/+2 |
| | | | |||||
| * | | Removed tag.rb, since it is actually removed, not just deprecated. [ci skip] | Timm | 2014-06-16 | 1 | -3/+0 |
| | | | |||||
| * | | Moved ActionView::Assertions dependency from Action Pack's lib to ↵ | Timm | 2014-06-16 | 1 | -2/+1 |
| | | | | | | | | | | | | abstract_unit.rb. | ||||
| * | | Added deprecation warning to ActionDispatch::Assertions::TagAssertions. | Timm | 2014-06-16 | 1 | -0/+3 |
| | | | |||||
| * | | Trimmed deprecation message for ActionDispatch::Assertions::SelectorAssertions. | Timm | 2014-06-16 | 1 | -1/+1 |
| | | | |||||
| * | | Moved Dom and Selector assertions from ActionDispatch to ActionView. | Timm | 2014-06-16 | 4 | -544/+6 |
| | | | |||||
| * | | Fixed: assert_select_encoded finds the right content. No longer uses a ↵ | Timm | 2014-06-16 | 1 | -5/+9 |
| | | | | | | | | | | | | <encoded> wrapper. Updated tests to reflect this. | ||||
| * | | Removed mention of css_select supporting substitution values. It is not ↵ | Timm | 2014-06-16 | 1 | -7/+1 |
| | | | | | | | | | | | | tested anywhere. | ||||
| * | | Updated documentation to state more things about css selectors with ↵ | Timm | 2014-06-16 | 1 | -3/+11 |
| | | | | | | | | | | | | substitution values. | ||||
| * | | Reworked the wrapping root in NodeSet implementation in css_select. | Timm | 2014-06-16 | 1 | -3/+5 |
| | | | |||||
| * | | Wrapped element to search in NodeSet. Changed selectors to selector. | Timm | 2014-06-16 | 1 | -3/+5 |
| | | | |||||
| * | | Moved around alias line. | Timm | 2014-06-16 | 1 | -2/+2 |
| | | | |||||
| * | | Returning from filter if matches are empty. | Timm | 2014-06-16 | 1 | -1/+1 |
| | | | |||||
| * | | Fixed: no longer wrapped @selected in fragment, since .css works fine ↵ | Timm | 2014-06-16 | 1 | -2/+1 |
| | | | | | | | | | | | | without it. | ||||
| * | | Reverted to using documents instead of document fragments, since searching ↵ | Timm | 2014-06-16 | 1 | -3/+6 |
| | | | | | | | | | | | | via default xml namespaces didn't work. | ||||
| * | | add_regex returns inspected value for non Regexp objects. Workaround, so ↵ | Timm | 2014-06-16 | 1 | -1/+2 |
| | | | | | | | | | | | | users don't have to care about enclosing values in double quotes. | ||||
| * | | Fixed: inadvertently called message method in MiniTest instead of ↵ | Timm | 2014-06-16 | 1 | -1/+1 |
| | | | | | | | | | | | | selector.message. | ||||
| * | | Cleaned up SubstitutionContext class. | Timm | 2014-06-16 | 1 | -10/+8 |
| | | | |||||
| * | | Simplified assert_select further by moving match filtering into HTMLSelector ↵ | Timm | 2014-06-16 | 1 | -32/+29 |
| | | | | | | | | | | | | select. | ||||
| * | | Fixed: now only compares html of children in filter_matches. | Timm | 2014-06-16 | 1 | -1/+1 |
| | | | |||||
| * | | Added NodeSet comparison to possible root element in determine_root_from. | Timm | 2014-06-16 | 1 | -1/+1 |
| | | | |||||
| * | | Changed html_document to use fragments. Changed response_from_page to be an ↵ | Timm | 2014-06-16 | 1 | -6/+3 |
| | | | | | | | | | | | | alias of html_document. | ||||
| * | | Fixed bug by switching to Loofah fragment instead of document. | Timm | 2014-06-16 | 1 | -2/+2 |
| | | | |||||
| * | | Changed css_select to not count on multiple selectors. Fixed bug in ↵ | Timm | 2014-06-16 | 1 | -8/+10 |
| | | | | | | | | | | | | determine_root_from where @selected was an Array. Changed assert_select_encoded to use a fragment instead of a document. | ||||
| * | | Added a proper substitution context class. Changed ArgumentFilter to be a ↵ | Timm | 2014-06-16 | 1 | -34/+47 |
| | | | | | | | | | | | | selector. It is now called HTMLSelector. | ||||
| * | | Fixed nested assert_select bug. Trying to create a full document for a ↵ | Timm | 2014-06-16 | 1 | -1/+1 |
| | | | | | | | | | | | | nested call that already had a document. |