aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch/testing/assertions
Commit message (Collapse)AuthorAgeFilesLines
* Change all `MiniTest` to `Minitest` since, `MiniTest` namespace has been ↵Vipul A M2013-12-181-1/+1
| | | | | | renamed to `Minitest` Ref: https://github.com/seattlerb/minitest/blob/master/History.txt
* Better error message for typos in assert_response argument.Victor Costan2013-11-251-0/+3
| | | | | This commit makes it really easy to debug errors due to typos like "assert_response :succezz".
* Fix incorrect assert_redirected_to failure messageDerek Prior2013-09-191-15/+5
| | | | | | | | | | | | | | | In some instances, `assert_redirected_to` assertion was returning an incorrect and misleading failure message when the assertion failed. This was due to a disconnect in how the assertion computes the redirect string for the failure message and how `redirect_to` computes the string that is actually used for redirection. I made the `_compute_redirect_to_loaction` method used by `redirect_to` public and call that from the method `assert_redirect_to` uses to calculate the URL. The reveals a new test failure due to the regex used by `_compute_redirect_to_location` allow `_` in the URL scheme.
* Pass assert_dom_equal message arg to underlying assertionRyan McGeary2013-08-041-4/+4
| | | | | #assert_dom_equal and #assert_dom_not_equal both take a "failure" message argument, but this argument was not utilized.
* Mark unused variables and make some style fixesAgis Anastasopoulos2013-04-082-4/+4
| | | | It'd be a nice convention to mark the unused variables like this, now that Ruby 2 will issue no warnings for such vars being unused.
* Missing requiresAkira Matsuda2013-01-061-0/+1
|
* Remove unnecessary begin..rescue..end, use only rescueAkira Matsuda2013-01-061-5/+3
|
* Alias refute methods to assert_not and perfer assert_not on testsRafael Mendonça França2012-12-311-1/+1
|
* Cleans and removes 'Examples' tag [ci skip]Alvaro Pereyra2012-12-011-2/+0
|
* Removed extra call to #diff in #assert_recognizes. assert_equal calls it for ↵Ryan Davis2012-11-171-4/+7
| | | | you and shows the diff. Also delayed message calculation so the cost of the diff on success is now gone.
* Deprecate Hash#diff.Steve Klabnik2012-11-091-3/+1
| | | | | | It's no longer used in Rails any more. See https://github.com/rails/rails/pull/8142\#issuecomment-10227297 for more
* 1.9 hash syntax changes to docsAvnerCohen2012-10-314-38/+38
|
* Move action_controller/vendor/html-scanner to action_viewPiotr Sarnacki2012-08-283-3/+4
| | | | | | This is another step in moving Action View's dependencies in Action Pack to Action View itself. Also, HtmlScanner seems to be better suited for views rather than controllers.
* load active_support/core_ext/object/inclusion in active_support/railsXavier Noria2012-08-022-2/+0
|
* Updated with_routing example to 3.x syntax [ci skip]Wojciech Wnętrzak2012-07-131-7/+4
|
* Correct order of expected and actual argumentsAndrew White2012-05-201-1/+1
|
* Raise Assertion instead of RoutingError for routing assertion failures.David Chelimsky2012-05-201-7/+13
| | | | | | | | | | | | | Before this change, assert_recognizes, assert_generates, and assert_routing raised ActionController::RoutingError when they failed to recognize the route. This commit changes them to raise Assertion instead. This aligns with convention for logical failures, and supports reporting tools that care about the difference between logical failures and errors e.g. the summary at the end of a test run. - Fixes #5899
* Removing ==Examples and last blank lines of docs from actionpackFrancesco Rodriguez2012-05-155-24/+0
|
* Allows assert_redirected_to to accept a regular expressionAndy Lindeman2012-05-031-13/+20
|
* Merge pull request #5716 from jurriaan/tr-gsub-cleanupSantiago Pastorino2012-04-041-1/+1
|\ | | | | Updated/changed unneeded tr/gsubs
| * Updated/changed useless tr/gsubsJurriaan Pruis2012-04-031-1/+1
| |
* | No need to extend ActiveSupport::Extend hereOscar Del Ben2012-04-041-2/+0
|/
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-04-011-1/+1
|\
| * :success includes the whole 200 range, not just 200.Erich Menge2012-04-011-1/+1
| | | | | | | | | | # File lib/rack/response.rb, line 114 114: def successful?; @status >= 200 && @status < 300; end
* | Remove the leading \n added by textarea on assert_selectSantiago Pastorino2012-03-301-0/+1
|/
* strip null bytes from Location header as wellBrian Lopez2012-03-151-1/+1
| | | | add tests for stripping \r\n chars since that's already happening
* Fix the assert_recognizes test method so that it works when there areMatt Fawcett2012-02-241-4/+3
| | | | constraints on the querystring. Issue #2781
* Stop referring to Atom as "ATOM"Tom Stuart2012-02-051-1/+1
| | | | | | $ curl -s http://www.ietf.org/rfc/rfc4287 | grep -io ATOM | sort | uniq -c 582 atom 175 Atom
* Remove assert_select_feed from assert_select_encoded documentationTom Stuart2012-02-051-2/+2
| | | | | | This documentation came from the assert_select plugin, but the assert_select_feed method was omitted when the plugin was merged into Rails in 3142502964f94d6144312ae2c368b4c4589fa25a.
* Replaced all 'for' loops with Enumerable#eachNathan Broadbent2012-01-301-2/+2
|
* use assert_equal and assert_operatorAaron Patterson2012-01-061-5/+8
|
* use sprintf rather than build_messageAaron Patterson2012-01-061-4/+6
|
* Just use assert_equalAaron Patterson2012-01-061-3/+2
|
* refactor assert_responseAaron Patterson2012-01-061-7/+10
|
* test response assertionsAaron Patterson2012-01-061-8/+0
|
* no need for assert_blockAaron Patterson2012-01-061-3/+3
|
* stop using build_message for creating a stringAaron Patterson2012-01-061-1/+1
|
* just use assert and refute rather than building messagesAaron Patterson2012-01-061-6/+2
|
* fix assert_select_email to work on non-multipart emails as well as ↵Andrew Kaspick2011-08-111-2/+2
| | | | converting the Mail::Body to a string to prevent errors.
* Remove blank lineSantiago Pastorino2011-07-261-1/+0
|
* refactored 'assert_redirected_to': local call to validate_request! will be ↵thoefer2011-07-261-5/+4
| | | | called in assert_response already. changed names of local variables in order to recognize the semantics a bit easier.
* TODO fix explicitly loading exceptations, autoload removedVishnu Atrai2011-07-111-0/+1
|
* Corrected some typos and American vs. Queen's English issuesLee Reilly2011-05-291-4/+4
|
* Merge branch 'master' of git://github.com/lifo/docrailsXavier Noria2011-05-251-9/+9
|\ | | | | | | | | | | Conflicts: actionmailer/lib/action_mailer/base.rb activesupport/lib/active_support/core_ext/kernel/requires.rb
| * Remove extra white spaces on ActionPack docs.Sebastian Martinez2011-05-231-9/+9
| |
* | Restructure TemplateAssertions-related code to eliminate circular requires.wycats2011-05-221-7/+0
|/ | | Also, no need to include dependencies in AS::Concerns inside included blocks.
* Follow code conventions on docsSebastian Martinez2011-05-101-1/+1
|
* Flunk makes a lot more sense, doesnt it (hat tip @tenderlove)David Heinemeier Hansson2011-05-021-1/+1
|
* We cant use assert_block because its buggy in MiniTest and wont actually ↵David Heinemeier Hansson2011-04-221-1/+1
| | | | show you the failure message you provide -- instead you just always get a "Expected block to return true"
* Remove `#among?` from Active SupportPrem Sichanugrist2011-04-131-1/+1
| | | | | | After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`.