Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Remove extra 'has been' from deprecation warning about asserting selectors | Prathamesh Sonpatki | 2014-09-09 | 1 | -1/+1 |
| | | | | [ci skip] | ||||
* | Remove extra 'has been' from the deprecation message | Prathamesh Sonpatki | 2014-09-09 | 1 | -1/+1 |
| | | | | - [ci skip] | ||||
* | :scissors: | Rafael Mendonça França | 2014-09-05 | 1 | -1/+1 |
| | |||||
* | Message doesn't need to be optional | Rafael Mendonça França | 2014-09-05 | 1 | -2/+2 |
| | |||||
* | Merge pull request #14911 from estsauver/14908 | Rafael Mendonça França | 2014-09-05 | 1 | -7/+7 |
|\ | | | | | | | Propagate test messages through assert_routing helper, Fixes #14908 | ||||
| * | Propagate test messages through assert_routing helper, Fixes #14908 | Earl St Sauver | 2014-04-29 | 1 | -7/+7 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | assert_routing was not raising the message passed into the assertion violation that it raised. This change propagates messages through the on_fail error. This fixes this error: https://github.com/rails/rails/issues/14908 A test case for this issue is located here. https://github.com/estsauver/test14908 To see that test case fail in the example app, just run ruby -Itest test/controllers/guests_controller_test.rb | ||||
* | | Add missing require | Godfrey Chan | 2014-08-18 | 1 | -0/+2 |
| | | |||||
* | | Deprecate TagAssertion instead of removing | Rafael Mendonça França | 2014-08-18 | 1 | -0/+1 |
| | | |||||
* | | Merge branch 'master' into loofah | Rafael Mendonça França | 2014-08-12 | 2 | -8/+3 |
|\ \ | | | | | | | | | | | | | | | | | | | Conflicts: actionpack/CHANGELOG.md actionpack/test/controller/integration_test.rb actionview/CHANGELOG.md | ||||
| * | | refactor Redirecting so we do not need a controller instance | Aaron Patterson | 2014-08-06 | 1 | -7/+2 |
| | | | |||||
| * | | ask the named routes collection if the route is defined | Aaron Patterson | 2014-07-29 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | we should not be accessing internals to figure out if a method is defined. | ||||
* | | | Changed deprecation message in dom and selector assertions in Action Dispatch. | Timm | 2014-06-16 | 2 | -2/+2 |
| | | | |||||
* | | | Removed tag.rb, since it is actually removed, not just deprecated. [ci skip] | Timm | 2014-06-16 | 1 | -3/+0 |
| | | | |||||
* | | | Added deprecation warning to ActionDispatch::Assertions::TagAssertions. | Timm | 2014-06-16 | 1 | -0/+3 |
| | | | |||||
* | | | Trimmed deprecation message for ActionDispatch::Assertions::SelectorAssertions. | Timm | 2014-06-16 | 1 | -1/+1 |
| | | | |||||
* | | | Moved Dom and Selector assertions from ActionDispatch to ActionView. | Timm | 2014-06-16 | 2 | -539/+4 |
| | | | |||||
* | | | Fixed: assert_select_encoded finds the right content. No longer uses a ↵ | Timm | 2014-06-16 | 1 | -5/+9 |
| | | | | | | | | | | | | <encoded> wrapper. Updated tests to reflect this. | ||||
* | | | Removed mention of css_select supporting substitution values. It is not ↵ | Timm | 2014-06-16 | 1 | -7/+1 |
| | | | | | | | | | | | | tested anywhere. | ||||
* | | | Updated documentation to state more things about css selectors with ↵ | Timm | 2014-06-16 | 1 | -3/+11 |
| | | | | | | | | | | | | substitution values. | ||||
* | | | Reworked the wrapping root in NodeSet implementation in css_select. | Timm | 2014-06-16 | 1 | -3/+5 |
| | | | |||||
* | | | Wrapped element to search in NodeSet. Changed selectors to selector. | Timm | 2014-06-16 | 1 | -3/+5 |
| | | | |||||
* | | | Moved around alias line. | Timm | 2014-06-16 | 1 | -2/+2 |
| | | | |||||
* | | | Returning from filter if matches are empty. | Timm | 2014-06-16 | 1 | -1/+1 |
| | | | |||||
* | | | Fixed: no longer wrapped @selected in fragment, since .css works fine ↵ | Timm | 2014-06-16 | 1 | -2/+1 |
| | | | | | | | | | | | | without it. | ||||
* | | | Reverted to using documents instead of document fragments, since searching ↵ | Timm | 2014-06-16 | 1 | -3/+6 |
| | | | | | | | | | | | | via default xml namespaces didn't work. | ||||
* | | | add_regex returns inspected value for non Regexp objects. Workaround, so ↵ | Timm | 2014-06-16 | 1 | -1/+2 |
| | | | | | | | | | | | | users don't have to care about enclosing values in double quotes. | ||||
* | | | Fixed: inadvertently called message method in MiniTest instead of ↵ | Timm | 2014-06-16 | 1 | -1/+1 |
| | | | | | | | | | | | | selector.message. | ||||
* | | | Cleaned up SubstitutionContext class. | Timm | 2014-06-16 | 1 | -10/+8 |
| | | | |||||
* | | | Simplified assert_select further by moving match filtering into HTMLSelector ↵ | Timm | 2014-06-16 | 1 | -32/+29 |
| | | | | | | | | | | | | select. | ||||
* | | | Fixed: now only compares html of children in filter_matches. | Timm | 2014-06-16 | 1 | -1/+1 |
| | | | |||||
* | | | Added NodeSet comparison to possible root element in determine_root_from. | Timm | 2014-06-16 | 1 | -1/+1 |
| | | | |||||
* | | | Changed html_document to use fragments. Changed response_from_page to be an ↵ | Timm | 2014-06-16 | 1 | -6/+3 |
| | | | | | | | | | | | | alias of html_document. | ||||
* | | | Fixed bug by switching to Loofah fragment instead of document. | Timm | 2014-06-16 | 1 | -2/+2 |
| | | | |||||
* | | | Changed css_select to not count on multiple selectors. Fixed bug in ↵ | Timm | 2014-06-16 | 1 | -8/+10 |
| | | | | | | | | | | | | determine_root_from where @selected was an Array. Changed assert_select_encoded to use a fragment instead of a document. | ||||
* | | | Added a proper substitution context class. Changed ArgumentFilter to be a ↵ | Timm | 2014-06-16 | 1 | -34/+47 |
| | | | | | | | | | | | | selector. It is now called HTMLSelector. | ||||
* | | | Fixed nested assert_select bug. Trying to create a full document for a ↵ | Timm | 2014-06-16 | 1 | -1/+1 |
| | | | | | | | | | | | | nested call that already had a document. | ||||
* | | | Added implementation for substitution values via Nokogiri's custom pseudo ↵ | Timm | 2014-06-16 | 1 | -5/+35 |
| | | | | | | | | | | | | classes. | ||||
* | | | Readded some documentation about substitution values. | Timm | 2014-06-16 | 1 | -2/+12 |
| | | | |||||
* | | | Updated documentation to remove mention of HTML::Selector and clarify what ↵ | Timm | 2014-06-15 | 1 | -21/+9 |
| | | | | | | | | | | | | is expected of a selector now. | ||||
* | | | Readded html_document method since it is used integration tests. | Timm | 2014-06-15 | 1 | -1/+5 |
| | | | |||||
* | | | Changed filter_matches to return a new NodeSet instead of Array. | Timm | 2014-06-15 | 1 | -1/+2 |
| | | | |||||
* | | | Initialized @css_selector_is_second_argument in determine_root_from. | Timm | 2014-06-15 | 1 | -0/+1 |
| | | | |||||
* | | | Changed early return for filter_matches as well as reassigning matches. ↵ | Timm | 2014-06-15 | 1 | -6/+6 |
| | | | | | | | | | | | | Meddled with initialize in ArgumentFilter. | ||||
* | | | Removed redundant comments from assert_select. | Timm | 2014-06-15 | 1 | -3/+1 |
| | | | | | | | | | | | | Cleaned up a comment. | ||||
* | | | Added assert_size_match! with the assertions for assert_select. | Timm | 2014-06-15 | 1 | -14/+18 |
| | | | |||||
* | | | Changed some documentation for css_select. | Timm | 2014-06-15 | 1 | -1/+1 |
| | | | |||||
* | | | Replaced fragment calls with document, since we assume the responses are ↵ | Timm | 2014-06-15 | 1 | -9/+8 |
| | | | | | | | | | | | | complete documents. | ||||
* | | | Added filter_matches to reduce line count in assert_select. | Timm | 2014-06-15 | 1 | -24/+19 |
| | | | |||||
* | | | Renamed Selector to ArgumentFilter. Put code from HTMLSelector to ↵ | Timm | 2014-06-15 | 1 | -59/+39 |
| | | | | | | | | | | | | ArgumentFilter. | ||||
* | | | Removed the custom selected proc. It's no longer needed. | Timm | 2014-06-15 | 1 | -10/+8 |
| | | |