Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Initialized @css_selector_is_second_argument in determine_root_from. | Timm | 2014-06-15 | 1 | -0/+1 |
| | |||||
* | Changed early return for filter_matches as well as reassigning matches. ↵ | Timm | 2014-06-15 | 1 | -6/+6 |
| | | | | Meddled with initialize in ArgumentFilter. | ||||
* | Removed redundant comments from assert_select. | Timm | 2014-06-15 | 1 | -3/+1 |
| | | | | Cleaned up a comment. | ||||
* | Added assert_size_match! with the assertions for assert_select. | Timm | 2014-06-15 | 1 | -14/+18 |
| | |||||
* | Changed some documentation for css_select. | Timm | 2014-06-15 | 1 | -1/+1 |
| | |||||
* | Replaced fragment calls with document, since we assume the responses are ↵ | Timm | 2014-06-15 | 1 | -9/+8 |
| | | | | complete documents. | ||||
* | Added filter_matches to reduce line count in assert_select. | Timm | 2014-06-15 | 1 | -24/+19 |
| | |||||
* | Renamed Selector to ArgumentFilter. Put code from HTMLSelector to ↵ | Timm | 2014-06-15 | 1 | -59/+39 |
| | | | | ArgumentFilter. | ||||
* | Removed the custom selected proc. It's no longer needed. | Timm | 2014-06-15 | 1 | -10/+8 |
| | |||||
* | Updated selector to not have reponse_from_page. | Timm | 2014-06-15 | 1 | -5/+6 |
| | |||||
* | Changed css_select and pulled out response_from_page from Selector. | Timm | 2014-06-15 | 1 | -23/+17 |
| | |||||
* | Changed comparison from HTML::Node to Nokogiri::XML::Node in ↵ | Timm | 2014-06-15 | 1 | -1/+1 |
| | | | | assert_select_encoded. | ||||
* | Removed more redundant lines. Removed fix_content block that circumvented a ↵ | Timm | 2014-06-15 | 1 | -7/+1 |
| | | | | bug in html-scanner. | ||||
* | Removed more lines of code in assert_select. | Timm | 2014-06-15 | 1 | -7/+6 |
| | |||||
* | Simplified the first delete_if loop in assert_select to use Loofah's text ↵ | Timm | 2014-06-15 | 1 | -14/+13 |
| | | | | method. | ||||
* | Removed argument and root variable in assert_select proc. | Timm | 2014-06-15 | 1 | -4/+2 |
| | |||||
* | Changed name to selector. And a bunch of other things. | Timm | 2014-06-15 | 1 | -60/+51 |
| | |||||
* | The first attempt at abstracting argument parsing from selection methods. | Timm | 2014-06-15 | 1 | -81/+114 |
| | |||||
* | Removed tag.rb since it has been deprecated. | Timm | 2014-06-15 | 1 | -135/+0 |
| | |||||
* | Corrected documentation bug. | Timm | 2014-06-15 | 1 | -10/+57 |
| | |||||
* | Added Loofah as a dependency in actionview.gemspec. | Timm | 2014-06-11 | 1 | -9/+9 |
| | | | | | | Implemented ActionView: FullSanitizer, LinkSanitizer and WhiteListSanitizer in sanitizers.rb. Deprecated protocol_separator and bad_tags. Added new tests in sanitizers_test.rb and reimplemented assert_dom_equal with Loofah. | ||||
* | Fix regression on `assert_redirected_to`. | Arthur Neves | 2014-05-13 | 1 | -1/+7 |
| | | | | | | | | | | `assert_redirected_to` would fail if there is no controller set on a `ActionDispatch::IntegrationTest`, as _compute_redirect_to_location would be called on the controller to build the url. This regression was introduced after 1dacfbabf3bb1e0a9057dd2a016b1804e7fa38c0. [fixes #14691] | ||||
* | Remove surplus period from assertion messages | Marcus Stollsteimer | 2014-04-13 | 1 | -3/+3 |
| | |||||
* | Swapped parameters of assert_equal in assert_select | Vishal Lal | 2014-03-22 | 1 | -1/+1 |
| | |||||
* | Change all `MiniTest` to `Minitest` since, `MiniTest` namespace has been ↵ | Vipul A M | 2013-12-18 | 1 | -1/+1 |
| | | | | | | renamed to `Minitest` Ref: https://github.com/seattlerb/minitest/blob/master/History.txt | ||||
* | Better error message for typos in assert_response argument. | Victor Costan | 2013-11-25 | 1 | -0/+3 |
| | | | | | This commit makes it really easy to debug errors due to typos like "assert_response :succezz". | ||||
* | Fix incorrect assert_redirected_to failure message | Derek Prior | 2013-09-19 | 1 | -15/+5 |
| | | | | | | | | | | | | | | | In some instances, `assert_redirected_to` assertion was returning an incorrect and misleading failure message when the assertion failed. This was due to a disconnect in how the assertion computes the redirect string for the failure message and how `redirect_to` computes the string that is actually used for redirection. I made the `_compute_redirect_to_loaction` method used by `redirect_to` public and call that from the method `assert_redirect_to` uses to calculate the URL. The reveals a new test failure due to the regex used by `_compute_redirect_to_location` allow `_` in the URL scheme. | ||||
* | Pass assert_dom_equal message arg to underlying assertion | Ryan McGeary | 2013-08-04 | 1 | -4/+4 |
| | | | | | #assert_dom_equal and #assert_dom_not_equal both take a "failure" message argument, but this argument was not utilized. | ||||
* | Mark unused variables and make some style fixes | Agis Anastasopoulos | 2013-04-08 | 2 | -4/+4 |
| | | | | It'd be a nice convention to mark the unused variables like this, now that Ruby 2 will issue no warnings for such vars being unused. | ||||
* | Missing requires | Akira Matsuda | 2013-01-06 | 1 | -0/+1 |
| | |||||
* | Remove unnecessary begin..rescue..end, use only rescue | Akira Matsuda | 2013-01-06 | 1 | -5/+3 |
| | |||||
* | Alias refute methods to assert_not and perfer assert_not on tests | Rafael Mendonça França | 2012-12-31 | 1 | -1/+1 |
| | |||||
* | Cleans and removes 'Examples' tag [ci skip] | Alvaro Pereyra | 2012-12-01 | 1 | -2/+0 |
| | |||||
* | Removed extra call to #diff in #assert_recognizes. assert_equal calls it for ↵ | Ryan Davis | 2012-11-17 | 1 | -4/+7 |
| | | | | you and shows the diff. Also delayed message calculation so the cost of the diff on success is now gone. | ||||
* | Deprecate Hash#diff. | Steve Klabnik | 2012-11-09 | 1 | -3/+1 |
| | | | | | | It's no longer used in Rails any more. See https://github.com/rails/rails/pull/8142\#issuecomment-10227297 for more | ||||
* | 1.9 hash syntax changes to docs | AvnerCohen | 2012-10-31 | 4 | -38/+38 |
| | |||||
* | Move action_controller/vendor/html-scanner to action_view | Piotr Sarnacki | 2012-08-28 | 3 | -3/+4 |
| | | | | | | This is another step in moving Action View's dependencies in Action Pack to Action View itself. Also, HtmlScanner seems to be better suited for views rather than controllers. | ||||
* | load active_support/core_ext/object/inclusion in active_support/rails | Xavier Noria | 2012-08-02 | 2 | -2/+0 |
| | |||||
* | Updated with_routing example to 3.x syntax [ci skip] | Wojciech Wnętrzak | 2012-07-13 | 1 | -7/+4 |
| | |||||
* | Correct order of expected and actual arguments | Andrew White | 2012-05-20 | 1 | -1/+1 |
| | |||||
* | Raise Assertion instead of RoutingError for routing assertion failures. | David Chelimsky | 2012-05-20 | 1 | -7/+13 |
| | | | | | | | | | | | | | Before this change, assert_recognizes, assert_generates, and assert_routing raised ActionController::RoutingError when they failed to recognize the route. This commit changes them to raise Assertion instead. This aligns with convention for logical failures, and supports reporting tools that care about the difference between logical failures and errors e.g. the summary at the end of a test run. - Fixes #5899 | ||||
* | Removing ==Examples and last blank lines of docs from actionpack | Francesco Rodriguez | 2012-05-15 | 5 | -24/+0 |
| | |||||
* | Allows assert_redirected_to to accept a regular expression | Andy Lindeman | 2012-05-03 | 1 | -13/+20 |
| | |||||
* | Merge pull request #5716 from jurriaan/tr-gsub-cleanup | Santiago Pastorino | 2012-04-04 | 1 | -1/+1 |
|\ | | | | | Updated/changed unneeded tr/gsubs | ||||
| * | Updated/changed useless tr/gsubs | Jurriaan Pruis | 2012-04-03 | 1 | -1/+1 |
| | | |||||
* | | No need to extend ActiveSupport::Extend here | Oscar Del Ben | 2012-04-04 | 1 | -2/+0 |
|/ | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-04-01 | 1 | -1/+1 |
|\ | |||||
| * | :success includes the whole 200 range, not just 200. | Erich Menge | 2012-04-01 | 1 | -1/+1 |
| | | | | | | | | | | # File lib/rack/response.rb, line 114 114: def successful?; @status >= 200 && @status < 300; end | ||||
* | | Remove the leading \n added by textarea on assert_select | Santiago Pastorino | 2012-03-30 | 1 | -0/+1 |
|/ | |||||
* | strip null bytes from Location header as well | Brian Lopez | 2012-03-15 | 1 | -1/+1 |
| | | | | add tests for stripping \r\n chars since that's already happening |