aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch/testing/assertions
Commit message (Collapse)AuthorAgeFilesLines
* Initialized @css_selector_is_second_argument in determine_root_from.Timm2014-06-151-0/+1
|
* Changed early return for filter_matches as well as reassigning matches. ↵Timm2014-06-151-6/+6
| | | | Meddled with initialize in ArgumentFilter.
* Removed redundant comments from assert_select.Timm2014-06-151-3/+1
| | | | Cleaned up a comment.
* Added assert_size_match! with the assertions for assert_select.Timm2014-06-151-14/+18
|
* Changed some documentation for css_select.Timm2014-06-151-1/+1
|
* Replaced fragment calls with document, since we assume the responses are ↵Timm2014-06-151-9/+8
| | | | complete documents.
* Added filter_matches to reduce line count in assert_select.Timm2014-06-151-24/+19
|
* Renamed Selector to ArgumentFilter. Put code from HTMLSelector to ↵Timm2014-06-151-59/+39
| | | | ArgumentFilter.
* Removed the custom selected proc. It's no longer needed.Timm2014-06-151-10/+8
|
* Updated selector to not have reponse_from_page.Timm2014-06-151-5/+6
|
* Changed css_select and pulled out response_from_page from Selector.Timm2014-06-151-23/+17
|
* Changed comparison from HTML::Node to Nokogiri::XML::Node in ↵Timm2014-06-151-1/+1
| | | | assert_select_encoded.
* Removed more redundant lines. Removed fix_content block that circumvented a ↵Timm2014-06-151-7/+1
| | | | bug in html-scanner.
* Removed more lines of code in assert_select.Timm2014-06-151-7/+6
|
* Simplified the first delete_if loop in assert_select to use Loofah's text ↵Timm2014-06-151-14/+13
| | | | method.
* Removed argument and root variable in assert_select proc.Timm2014-06-151-4/+2
|
* Changed name to selector. And a bunch of other things.Timm2014-06-151-60/+51
|
* The first attempt at abstracting argument parsing from selection methods.Timm2014-06-151-81/+114
|
* Removed tag.rb since it has been deprecated.Timm2014-06-151-135/+0
|
* Corrected documentation bug.Timm2014-06-151-10/+57
|
* Added Loofah as a dependency in actionview.gemspec.Timm2014-06-111-9/+9
| | | | | | Implemented ActionView: FullSanitizer, LinkSanitizer and WhiteListSanitizer in sanitizers.rb. Deprecated protocol_separator and bad_tags. Added new tests in sanitizers_test.rb and reimplemented assert_dom_equal with Loofah.
* Fix regression on `assert_redirected_to`.Arthur Neves2014-05-131-1/+7
| | | | | | | | | | `assert_redirected_to` would fail if there is no controller set on a `ActionDispatch::IntegrationTest`, as _compute_redirect_to_location would be called on the controller to build the url. This regression was introduced after 1dacfbabf3bb1e0a9057dd2a016b1804e7fa38c0. [fixes #14691]
* Remove surplus period from assertion messagesMarcus Stollsteimer2014-04-131-3/+3
|
* Swapped parameters of assert_equal in assert_selectVishal Lal2014-03-221-1/+1
|
* Change all `MiniTest` to `Minitest` since, `MiniTest` namespace has been ↵Vipul A M2013-12-181-1/+1
| | | | | | renamed to `Minitest` Ref: https://github.com/seattlerb/minitest/blob/master/History.txt
* Better error message for typos in assert_response argument.Victor Costan2013-11-251-0/+3
| | | | | This commit makes it really easy to debug errors due to typos like "assert_response :succezz".
* Fix incorrect assert_redirected_to failure messageDerek Prior2013-09-191-15/+5
| | | | | | | | | | | | | | | In some instances, `assert_redirected_to` assertion was returning an incorrect and misleading failure message when the assertion failed. This was due to a disconnect in how the assertion computes the redirect string for the failure message and how `redirect_to` computes the string that is actually used for redirection. I made the `_compute_redirect_to_loaction` method used by `redirect_to` public and call that from the method `assert_redirect_to` uses to calculate the URL. The reveals a new test failure due to the regex used by `_compute_redirect_to_location` allow `_` in the URL scheme.
* Pass assert_dom_equal message arg to underlying assertionRyan McGeary2013-08-041-4/+4
| | | | | #assert_dom_equal and #assert_dom_not_equal both take a "failure" message argument, but this argument was not utilized.
* Mark unused variables and make some style fixesAgis Anastasopoulos2013-04-082-4/+4
| | | | It'd be a nice convention to mark the unused variables like this, now that Ruby 2 will issue no warnings for such vars being unused.
* Missing requiresAkira Matsuda2013-01-061-0/+1
|
* Remove unnecessary begin..rescue..end, use only rescueAkira Matsuda2013-01-061-5/+3
|
* Alias refute methods to assert_not and perfer assert_not on testsRafael Mendonça França2012-12-311-1/+1
|
* Cleans and removes 'Examples' tag [ci skip]Alvaro Pereyra2012-12-011-2/+0
|
* Removed extra call to #diff in #assert_recognizes. assert_equal calls it for ↵Ryan Davis2012-11-171-4/+7
| | | | you and shows the diff. Also delayed message calculation so the cost of the diff on success is now gone.
* Deprecate Hash#diff.Steve Klabnik2012-11-091-3/+1
| | | | | | It's no longer used in Rails any more. See https://github.com/rails/rails/pull/8142\#issuecomment-10227297 for more
* 1.9 hash syntax changes to docsAvnerCohen2012-10-314-38/+38
|
* Move action_controller/vendor/html-scanner to action_viewPiotr Sarnacki2012-08-283-3/+4
| | | | | | This is another step in moving Action View's dependencies in Action Pack to Action View itself. Also, HtmlScanner seems to be better suited for views rather than controllers.
* load active_support/core_ext/object/inclusion in active_support/railsXavier Noria2012-08-022-2/+0
|
* Updated with_routing example to 3.x syntax [ci skip]Wojciech Wnętrzak2012-07-131-7/+4
|
* Correct order of expected and actual argumentsAndrew White2012-05-201-1/+1
|
* Raise Assertion instead of RoutingError for routing assertion failures.David Chelimsky2012-05-201-7/+13
| | | | | | | | | | | | | Before this change, assert_recognizes, assert_generates, and assert_routing raised ActionController::RoutingError when they failed to recognize the route. This commit changes them to raise Assertion instead. This aligns with convention for logical failures, and supports reporting tools that care about the difference between logical failures and errors e.g. the summary at the end of a test run. - Fixes #5899
* Removing ==Examples and last blank lines of docs from actionpackFrancesco Rodriguez2012-05-155-24/+0
|
* Allows assert_redirected_to to accept a regular expressionAndy Lindeman2012-05-031-13/+20
|
* Merge pull request #5716 from jurriaan/tr-gsub-cleanupSantiago Pastorino2012-04-041-1/+1
|\ | | | | Updated/changed unneeded tr/gsubs
| * Updated/changed useless tr/gsubsJurriaan Pruis2012-04-031-1/+1
| |
* | No need to extend ActiveSupport::Extend hereOscar Del Ben2012-04-041-2/+0
|/
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-04-011-1/+1
|\
| * :success includes the whole 200 range, not just 200.Erich Menge2012-04-011-1/+1
| | | | | | | | | | # File lib/rack/response.rb, line 114 114: def successful?; @status >= 200 && @status < 300; end
* | Remove the leading \n added by textarea on assert_selectSantiago Pastorino2012-03-301-0/+1
|/
* strip null bytes from Location header as wellBrian Lopez2012-03-151-1/+1
| | | | add tests for stripping \r\n chars since that's already happening