| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | fix with_routing when testing api only controllers | Julia López | 2016-12-29 | 1 | -2/+5 |
| | | |||||
| * | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 1 | -3/+3 |
| | | |||||
| * | Add three new rubocop rules | Rafael Mendonça França | 2016-08-16 | 1 | -1/+1 |
| | | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository. | ||||
| * | Allow specifying encoding of parameters by action | Kerri Miller | 2016-08-09 | 1 | -1/+1 |
| | | | | | | At GitHub we need to handle parameter encodings that are not UTF-8. This patch allows us to specify encodings per parameter per action. | ||||
| * | remove redundant curlies from hash arguments | Xavier Noria | 2016-08-06 | 1 | -1/+1 |
| | | |||||
| * | modernizes hash syntax in actionpack | Xavier Noria | 2016-08-06 | 1 | -1/+1 |
| | | |||||
| * | applies new string literal convention in actionpack/lib | Xavier Noria | 2016-08-06 | 1 | -5/+5 |
| | | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
| * | Change 'a HTTP' to 'an HTTP' [ci skip] | Santosh Wadghule | 2016-03-03 | 1 | -1/+1 |
| | | |||||
| * | Duplicate assert_generates options before modifying it | Pierre Schambacher | 2016-02-01 | 1 | -0/+1 |
| | | |||||
| * | Fix double word 'string' [ci skip] | Jake Worth | 2015-11-01 | 1 | -1/+1 |
| | | |||||
| * | Improved readability of Assertion docs, replaced ‘Assert’ -> ↵ | amitkumarsuroliya | 2015-10-09 | 1 | -4/+4 |
| | | | | | | ‘Asserts’ at all places [ci skip] Following commit https://github.com/rails/docrails/commit/495722a95687e25114ae75608dd3107ac5d6611b | ||||
| * | Rename `extra_keys` variables to `query_string_keys` | eileencodes | 2015-08-08 | 1 | -2/+2 |
| | | | | | | | `extra_keys` is a confusing variable name because it's not clear what is "extra". This renames it to `query_string_keys` so it's clear that the "extra" is just the query string. | ||||
| * | Oops! :bomb: | Akira Matsuda | 2015-07-17 | 1 | -1/+1 |
| | | |||||
| * | "warning: instance variable @routes not initialized" | Akira Matsuda | 2015-07-17 | 1 | -1/+1 |
| | | |||||
| * | add a new constructor for allocating test requests | Aaron Patterson | 2015-07-08 | 1 | -1/+1 |
| | | |||||
| * | pass the starting env and session to build_request | Aaron Patterson | 2015-07-08 | 1 | -1/+1 |
| | | |||||
| * | let the superclass build the request and response | Aaron Patterson | 2015-07-08 | 1 | -1/+1 |
| | | | | | | We should leverage the request / response objects that the superclass has already allocated for us. | ||||
| * | Merge pull request #18665 from sgrif/sg-test-route-all | Sean Griffin | 2015-02-20 | 1 | -8/+14 |
| |\ | | | | | Allow `method: "all"` as a valid routing test option | ||||
| | * | Allow `method: "all"` as a valid routing test option | Sean Griffin | 2015-01-23 | 1 | -8/+14 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows the test to mirror the production code, since `via: :all` is a valid option. The behavior in 4.1 did not actually test that it matched all verbs, but instead defaulted to testing for "GET". This implementation aims to better handle the intention of passing "all". What will actually be asserted doesn't quite match up with the generated route, since it appears to just not create a constraint on the method. However, I don't think that we can easily test the lack of that constraint. Testing each of the main 4 HTTP verbs seems to be a reasonably close approximation, which should be sufficient for our needs. Fixes #18511. | ||||
| * | | Use public Module#include, in favor of https://bugs.ruby-lang.org/issues/8846 | robertomiranda | 2015-01-31 | 1 | -1/+1 |
| |/ | | | | ref: https://github.com/rails/rails/pull/18763#issuecomment-72349769 | ||||
| * | Remove outdated comments [ci skip] | Godfrey Chan | 2014-11-22 | 1 | -6/+0 |
| | | | | They were introduced in 23b6def; the serial stuff has been removed since a5d80f8 | ||||
| * | :scissors: | Rafael Mendonça França | 2014-09-05 | 1 | -1/+1 |
| | | |||||
| * | Message doesn't need to be optional | Rafael Mendonça França | 2014-09-05 | 1 | -2/+2 |
| | | |||||
| * | Merge pull request #14911 from estsauver/14908 | Rafael Mendonça França | 2014-09-05 | 1 | -7/+7 |
| |\ | | | | | | | Propagate test messages through assert_routing helper, Fixes #14908 | ||||
| | * | Propagate test messages through assert_routing helper, Fixes #14908 | Earl St Sauver | 2014-04-29 | 1 | -7/+7 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | assert_routing was not raising the message passed into the assertion violation that it raised. This change propagates messages through the on_fail error. This fixes this error: https://github.com/rails/rails/issues/14908 A test case for this issue is located here. https://github.com/estsauver/test14908 To see that test case fail in the example app, just run ruby -Itest test/controllers/guests_controller_test.rb | ||||
| * | | ask the named routes collection if the route is defined | Aaron Patterson | 2014-07-29 | 1 | -1/+1 |
| |/ | | | | | we should not be accessing internals to figure out if a method is defined. | ||||
| * | Change all `MiniTest` to `Minitest` since, `MiniTest` namespace has been ↵ | Vipul A M | 2013-12-18 | 1 | -1/+1 |
| | | | | | | | renamed to `Minitest` Ref: https://github.com/seattlerb/minitest/blob/master/History.txt | ||||
| * | Mark unused variables and make some style fixes | Agis Anastasopoulos | 2013-04-08 | 1 | -2/+2 |
| | | | | | It'd be a nice convention to mark the unused variables like this, now that Ruby 2 will issue no warnings for such vars being unused. | ||||
| * | Missing requires | Akira Matsuda | 2013-01-06 | 1 | -0/+1 |
| | | |||||
| * | Remove unnecessary begin..rescue..end, use only rescue | Akira Matsuda | 2013-01-06 | 1 | -5/+3 |
| | | |||||
| * | Removed extra call to #diff in #assert_recognizes. assert_equal calls it for ↵ | Ryan Davis | 2012-11-17 | 1 | -4/+7 |
| | | | | | you and shows the diff. Also delayed message calculation so the cost of the diff on success is now gone. | ||||
| * | Deprecate Hash#diff. | Steve Klabnik | 2012-11-09 | 1 | -3/+1 |
| | | | | | | | It's no longer used in Rails any more. See https://github.com/rails/rails/pull/8142\#issuecomment-10227297 for more | ||||
| * | 1.9 hash syntax changes to docs | AvnerCohen | 2012-10-31 | 1 | -15/+15 |
| | | |||||
| * | Updated with_routing example to 3.x syntax [ci skip] | Wojciech Wnętrzak | 2012-07-13 | 1 | -7/+4 |
| | | |||||
| * | Raise Assertion instead of RoutingError for routing assertion failures. | David Chelimsky | 2012-05-20 | 1 | -7/+13 |
| | | | | | | | | | | | | | | Before this change, assert_recognizes, assert_generates, and assert_routing raised ActionController::RoutingError when they failed to recognize the route. This commit changes them to raise Assertion instead. This aligns with convention for logical failures, and supports reporting tools that care about the difference between logical failures and errors e.g. the summary at the end of a test run. - Fixes #5899 | ||||
| * | Removing ==Examples and last blank lines of docs from actionpack | Francesco Rodriguez | 2012-05-15 | 1 | -3/+0 |
| | | |||||
| * | Fix the assert_recognizes test method so that it works when there are | Matt Fawcett | 2012-02-24 | 1 | -4/+3 |
| | | | | | constraints on the querystring. Issue #2781 | ||||
| * | use sprintf rather than build_message | Aaron Patterson | 2012-01-06 | 1 | -4/+6 |
| | | |||||
| * | TODO fix explicitly loading exceptations, autoload removed | Vishnu Atrai | 2011-07-11 | 1 | -0/+1 |
| | | |||||
| * | Remove extra white spaces on ActionPack docs. | Sebastian Martinez | 2011-05-23 | 1 | -9/+9 |
| | | |||||
| * | use assert_equal so we get normal error messages along with our custom ↵ | Aaron Patterson | 2011-03-30 | 1 | -3/+3 |
| | | | | | failure message | ||||
| * | Remove incorrect assert_recognizes example | Andrew White | 2011-02-13 | 1 | -3/+0 |
| | | |||||
| * | Fix assert_recognizes with block constraints [#5805 state:resolved] | Andrew White | 2011-02-13 | 1 | -1/+2 |
| | | |||||
| * | _routes must be inside @controller conditional. | Emilio Tagua | 2010-09-27 | 1 | -1/+1 |
| | | |||||
| * | Refactor method to avoid warnings and not run unnecessary code. | Emilio Tagua | 2010-09-27 | 1 | -11/+11 |
| | | |||||
| * | Ask is @controller is defined to avoid warning. | Emilio Tagua | 2010-09-27 | 1 | -1/+1 |
| | | |||||
| * | escape constants that should not be linked to | Joost Baaij | 2010-08-27 | 1 | -2/+2 |
| | | |||||
| * | Support routing constraints in functional tests | Andrew White | 2010-08-20 | 1 | -14/+37 |
| | | | | | | | | | | | Extend assert_recognizes and assert_generates to support passing full urls as the path argument. This allows testing of routing constraints such as subdomain and host within functional tests. [#5005 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Remove unused variable on assert_recognizes [#4912 state:resolved] | Paco Guzman | 2010-06-22 | 1 | -1/+0 |
| | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Some require indifferent_access added | Santiago Pastorino | 2010-04-21 | 1 | -0/+1 |
| | | | | | Signed-off-by: Xavier Noria <fxn@ubuntu.(none)> | ||||
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |