aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch/testing/assertions/response.rb
Commit message (Collapse)AuthorAgeFilesLines
* Use frozen string literal in actionpack/Kir Shatrov2017-07-291-0/+2
|
* Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-021-1/+0
| | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* Merge pull request #29540 from kirs/rubocop-frozen-stringMatthew Draper2017-07-021-0/+1
|\ | | | | | | Enforce frozen string in Rubocop
| * Enforce frozen string in RubocopKir Shatrov2017-07-011-0/+1
| |
* | Make ActionView frozen string literal friendly.Pat Allan2017-06-201-1/+1
|/ | | | Plus a couple of related ActionPack patches.
* [docs] fix ActionDispatch documentationHrvoje Šimić2017-03-131-1/+1
|
* Add more rubocop rules about whitespacesRafael Mendonça França2016-10-291-1/+1
|
* Improve assert_response helperKir Shatrov2016-09-141-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | When the check is failed, print the actual response body if it's not too large. This could improve productivity when writing new tests. Before: ``` ThemeEditorIntegrationTest#test_whatever Expected response to be a <200: ok>, but was a <422: Unprocessable Entity>. Expected: 200 Actual: 422 ``` After: ``` ThemeEditorIntegrationTest#test_whatever Expected response to be a <200: ok>, but was a <422: Unprocessable Entity>. Expected: 200 Actual: 422 Response body: {"errors":["Invalid settings object for section '1'"]} ```
* applies new string literal convention in actionpack/libXavier Noria2016-08-061-1/+1
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* Add both HTTP Response Code and Type to assertion messagesSean Collins2016-01-121-14/+14
| | | | | Also, refactor logic to convert between symbol and response code, via the AssertionResponse class
* Show redirect response code in assert_response messagesJon Atack2015-12-111-10/+8
| | | | | | | | | | | | Follow-up to PR #19977, which helpfully added the redirection path to the error message of assert_response if response is a redirection, but which removed the response code, obscuring the type of redirect. This PR: - brings back the response code in the error message, - updates the tests so the new messages can be tested, - and adds test cases for the change.
* Use assert over assert_predicate in assert_responsePrathamesh Sonpatki2015-12-061-1/+1
| | | | | | | | | | | | | | | | | | | - `assert_predicate` appends its own error message at the end of message generated by `assert_response` and because of that the error message displays the whole `response` object. - For eg. Expected response to be a <success>, but was a redirect to <http://test.host/posts>. Expected #<ActionDispatch::TestResponse:0x007fb1cc1cf6f8....(lambda)>}>> to be successful?. - Complete message can be found here - https://gist.github.com/prathamesh-sonpatki/055afb74b66108e71ded#file-gistfile1-txt-L19. - After this change the message from `assert_predicate` won't be displayed and only message generated by `assert_response` will be shown as follows: Expected response to be a <success>, but was a redirect to <http://test.host/posts>
* Add redirection path in the error message of assert_response if response is ↵Prathamesh Sonpatki2015-12-041-0/+15
| | | | | | | | | | | | | | | | :redirect - If the assert_response is checking for any non-redirect response like :success and actual response is :redirect then, the error message displayed was - Expected response to be a <success>, but was <302> - This commit adds the redirect path to the error message of assert_response if the response is :redirect. So above message is changed to - Expected response to be a <success>, but was a redirect to <http://test.host/posts/lol>
* Improved readability of Assertion docs, replaced ‘Assert’ -> ↵amitkumarsuroliya2015-10-091-6/+6
| | | | | ‘Asserts’ at all places [ci skip] Following commit https://github.com/rails/docrails/commit/495722a95687e25114ae75608dd3107ac5d6611b
* Fixed wording in Assertion docs, changed ‘Assert’ -> ‘Asserts’Ronak Jangir2015-10-071-1/+1
|
* use a lookup table for `assert_response`Aaron Patterson2015-07-131-3/+8
| | | | | | | | We shouldn't depend on specific methods imlemented in the TestResponse subclass because the response could actually be a real response object. In the future, we should either push the aliased predicate methods in TestResponse up to the real response object, or remove them
* refactor Redirecting so we do not need a controller instanceAaron Patterson2014-08-061-7/+2
|
* Fix regression on `assert_redirected_to`.Arthur Neves2014-05-131-1/+7
| | | | | | | | | | `assert_redirected_to` would fail if there is no controller set on a `ActionDispatch::IntegrationTest`, as _compute_redirect_to_location would be called on the controller to build the url. This regression was introduced after 1dacfbabf3bb1e0a9057dd2a016b1804e7fa38c0. [fixes #14691]
* Better error message for typos in assert_response argument.Victor Costan2013-11-251-0/+3
| | | | | This commit makes it really easy to debug errors due to typos like "assert_response :succezz".
* Fix incorrect assert_redirected_to failure messageDerek Prior2013-09-191-15/+5
| | | | | | | | | | | | | | | In some instances, `assert_redirected_to` assertion was returning an incorrect and misleading failure message when the assertion failed. This was due to a disconnect in how the assertion computes the redirect string for the failure message and how `redirect_to` computes the string that is actually used for redirection. I made the `_compute_redirect_to_loaction` method used by `redirect_to` public and call that from the method `assert_redirect_to` uses to calculate the URL. The reveals a new test failure due to the regex used by `_compute_redirect_to_location` allow `_` in the URL scheme.
* 1.9 hash syntax changes to docsAvnerCohen2012-10-311-3/+3
|
* load active_support/core_ext/object/inclusion in active_support/railsXavier Noria2012-08-021-1/+0
|
* Correct order of expected and actual argumentsAndrew White2012-05-201-1/+1
|
* Removing ==Examples and last blank lines of docs from actionpackFrancesco Rodriguez2012-05-151-6/+0
|
* Allows assert_redirected_to to accept a regular expressionAndy Lindeman2012-05-031-13/+20
|
* Merge pull request #5716 from jurriaan/tr-gsub-cleanupSantiago Pastorino2012-04-041-1/+1
|\ | | | | Updated/changed unneeded tr/gsubs
| * Updated/changed useless tr/gsubsJurriaan Pruis2012-04-031-1/+1
| |
* | No need to extend ActiveSupport::Extend hereOscar Del Ben2012-04-041-2/+0
|/
* :success includes the whole 200 range, not just 200.Erich Menge2012-04-011-1/+1
| | | | | # File lib/rack/response.rb, line 114 114: def successful?; @status >= 200 && @status < 300; end
* strip null bytes from Location header as wellBrian Lopez2012-03-151-1/+1
| | | | add tests for stripping \r\n chars since that's already happening
* Just use assert_equalAaron Patterson2012-01-061-3/+2
|
* refactor assert_responseAaron Patterson2012-01-061-7/+10
|
* test response assertionsAaron Patterson2012-01-061-8/+0
|
* no need for assert_blockAaron Patterson2012-01-061-3/+3
|
* stop using build_message for creating a stringAaron Patterson2012-01-061-1/+1
|
* Remove blank lineSantiago Pastorino2011-07-261-1/+0
|
* refactored 'assert_redirected_to': local call to validate_request! will be ↵thoefer2011-07-261-5/+4
| | | | called in assert_response already. changed names of local variables in order to recognize the semantics a bit easier.
* Corrected some typos and American vs. Queen's English issuesLee Reilly2011-05-291-4/+4
|
* Restructure TemplateAssertions-related code to eliminate circular requires.wycats2011-05-221-7/+0
| | | Also, no need to include dependencies in AS::Concerns inside included blocks.
* Flunk makes a lot more sense, doesnt it (hat tip @tenderlove)David Heinemeier Hansson2011-05-021-1/+1
|
* We cant use assert_block because its buggy in MiniTest and wont actually ↵David Heinemeier Hansson2011-04-221-1/+1
| | | | show you the failure message you provide -- instead you just always get a "Expected block to return true"
* Remove `#among?` from Active SupportPrem Sichanugrist2011-04-131-1/+1
| | | | | | After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`.
* Change Object#either? to Object#among? -- thanks to @jamesarosen for the ↵David Heinemeier Hansson2011-04-121-1/+1
| | | | suggestion!
* Using Object#in? and Object#either? in various placesPrem Sichanugrist2011-04-111-1/+3
| | | | There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?.
* corrected the location of status code symbolsmisfo2011-01-291-1/+1
|
* _ is not a valid scheme name character, \w includes it and also is redundant ↵Emilio Tagua2010-09-291-1/+1
| | | | | | with \d. 'The scheme name consists of a letter followed by any combination of letters, digits, and the plus ("+"), period ("."), or hyphen ("-") characters; and is terminated by a colon (":").'
* Remove redundant conditional.Emilio Tagua2010-09-291-5/+1
|
* escape constants that should not be linked toJoost Baaij2010-08-271-5/+5
|
* Modify assert_template to use instrumentationCarlhuda2010-03-171-52/+0
|
* No longer add missing leading / on path args to assert_redirected_to. ↵Jeremy Kemper2010-03-021-9/+14
| | | | Deprecated in 2.3.6.
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-29 09:34:14 +0000