Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Better error message for typos in assert_response argument. | Victor Costan | 2013-11-25 | 1 | -0/+3 |
| | | | | | This commit makes it really easy to debug errors due to typos like "assert_response :succezz". | ||||
* | Fix incorrect assert_redirected_to failure message | Derek Prior | 2013-09-19 | 1 | -15/+5 |
| | | | | | | | | | | | | | | | In some instances, `assert_redirected_to` assertion was returning an incorrect and misleading failure message when the assertion failed. This was due to a disconnect in how the assertion computes the redirect string for the failure message and how `redirect_to` computes the string that is actually used for redirection. I made the `_compute_redirect_to_loaction` method used by `redirect_to` public and call that from the method `assert_redirect_to` uses to calculate the URL. The reveals a new test failure due to the regex used by `_compute_redirect_to_location` allow `_` in the URL scheme. | ||||
* | 1.9 hash syntax changes to docs | AvnerCohen | 2012-10-31 | 1 | -3/+3 |
| | |||||
* | load active_support/core_ext/object/inclusion in active_support/rails | Xavier Noria | 2012-08-02 | 1 | -1/+0 |
| | |||||
* | Correct order of expected and actual arguments | Andrew White | 2012-05-20 | 1 | -1/+1 |
| | |||||
* | Removing ==Examples and last blank lines of docs from actionpack | Francesco Rodriguez | 2012-05-15 | 1 | -6/+0 |
| | |||||
* | Allows assert_redirected_to to accept a regular expression | Andy Lindeman | 2012-05-03 | 1 | -13/+20 |
| | |||||
* | Merge pull request #5716 from jurriaan/tr-gsub-cleanup | Santiago Pastorino | 2012-04-04 | 1 | -1/+1 |
|\ | | | | | Updated/changed unneeded tr/gsubs | ||||
| * | Updated/changed useless tr/gsubs | Jurriaan Pruis | 2012-04-03 | 1 | -1/+1 |
| | | |||||
* | | No need to extend ActiveSupport::Extend here | Oscar Del Ben | 2012-04-04 | 1 | -2/+0 |
|/ | |||||
* | :success includes the whole 200 range, not just 200. | Erich Menge | 2012-04-01 | 1 | -1/+1 |
| | | | | | # File lib/rack/response.rb, line 114 114: def successful?; @status >= 200 && @status < 300; end | ||||
* | strip null bytes from Location header as well | Brian Lopez | 2012-03-15 | 1 | -1/+1 |
| | | | | add tests for stripping \r\n chars since that's already happening | ||||
* | Just use assert_equal | Aaron Patterson | 2012-01-06 | 1 | -3/+2 |
| | |||||
* | refactor assert_response | Aaron Patterson | 2012-01-06 | 1 | -7/+10 |
| | |||||
* | test response assertions | Aaron Patterson | 2012-01-06 | 1 | -8/+0 |
| | |||||
* | no need for assert_block | Aaron Patterson | 2012-01-06 | 1 | -3/+3 |
| | |||||
* | stop using build_message for creating a string | Aaron Patterson | 2012-01-06 | 1 | -1/+1 |
| | |||||
* | Remove blank line | Santiago Pastorino | 2011-07-26 | 1 | -1/+0 |
| | |||||
* | refactored 'assert_redirected_to': local call to validate_request! will be ↵ | thoefer | 2011-07-26 | 1 | -5/+4 |
| | | | | called in assert_response already. changed names of local variables in order to recognize the semantics a bit easier. | ||||
* | Corrected some typos and American vs. Queen's English issues | Lee Reilly | 2011-05-29 | 1 | -4/+4 |
| | |||||
* | Restructure TemplateAssertions-related code to eliminate circular requires. | wycats | 2011-05-22 | 1 | -7/+0 |
| | | | Also, no need to include dependencies in AS::Concerns inside included blocks. | ||||
* | Flunk makes a lot more sense, doesnt it (hat tip @tenderlove) | David Heinemeier Hansson | 2011-05-02 | 1 | -1/+1 |
| | |||||
* | We cant use assert_block because its buggy in MiniTest and wont actually ↵ | David Heinemeier Hansson | 2011-04-22 | 1 | -1/+1 |
| | | | | show you the failure message you provide -- instead you just always get a "Expected block to return true" | ||||
* | Remove `#among?` from Active Support | Prem Sichanugrist | 2011-04-13 | 1 | -1/+1 |
| | | | | | | After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`. | ||||
* | Change Object#either? to Object#among? -- thanks to @jamesarosen for the ↵ | David Heinemeier Hansson | 2011-04-12 | 1 | -1/+1 |
| | | | | suggestion! | ||||
* | Using Object#in? and Object#either? in various places | Prem Sichanugrist | 2011-04-11 | 1 | -1/+3 |
| | | | | There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?. | ||||
* | corrected the location of status code symbols | misfo | 2011-01-29 | 1 | -1/+1 |
| | |||||
* | _ is not a valid scheme name character, \w includes it and also is redundant ↵ | Emilio Tagua | 2010-09-29 | 1 | -1/+1 |
| | | | | | | with \d. 'The scheme name consists of a letter followed by any combination of letters, digits, and the plus ("+"), period ("."), or hyphen ("-") characters; and is terminated by a colon (":").' | ||||
* | Remove redundant conditional. | Emilio Tagua | 2010-09-29 | 1 | -5/+1 |
| | |||||
* | escape constants that should not be linked to | Joost Baaij | 2010-08-27 | 1 | -5/+5 |
| | |||||
* | Modify assert_template to use instrumentation | Carlhuda | 2010-03-17 | 1 | -52/+0 |
| | |||||
* | No longer add missing leading / on path args to assert_redirected_to. ↵ | Jeremy Kemper | 2010-03-02 | 1 | -9/+14 |
| | | | | Deprecated in 2.3.6. | ||||
* | assert_template depends on AV::Template monkey patches in action_view/test_case | Joshua Peek | 2010-01-05 | 1 | -0/+9 |
| | |||||
* | AD::StatusCodes support is now part of rack | Joshua Peek | 2009-12-22 | 1 | -1/+1 |
| | |||||
* | Extract ActionController rescue templates into Rescue and ShowExceptions ↵ | Joshua Peek | 2009-05-02 | 1 | -7/+1 |
| | | | | | middleware. This commit breaks all exception catching plugins like ExceptionNotifier. These plugins should be rewritten as middleware instead overriding Controller#rescue_action_in_public. | ||||
* | Deprecate assert_redirect_to's partial hash matching | Joshua Peek | 2009-05-02 | 1 | -7/+2 |
| | |||||
* | Move generic assertions into ActionDispatch | Joshua Peek | 2009-04-30 | 1 | -0/+156 |