Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | pass the module to define_named_route_methods | Aaron Patterson | 2014-07-29 | 1 | -7/+7 | |
| | | | | | | | | after this, we can disconnect @module from the instance | |||||
* | | only ask for the routes module once | Aaron Patterson | 2014-07-29 | 1 | -2/+4 | |
| | | | | | | | | we can cache the module on the stack, then reuse it | |||||
* | | eval_block should be private | Aaron Patterson | 2014-07-29 | 1 | -0/+1 | |
| | | ||||||
* | | remove the mounted? method | Aaron Patterson | 2014-07-28 | 2 | -6/+2 | |
| | | | | | | | | | | we know the routes should not be "optimized" when mounting an application | |||||
* | | remove some caching | Aaron Patterson | 2014-07-28 | 1 | -2/+1 | |
| | | | | | | | | | | this caching doesn't increase performance, but does increase complexity. remove it for now and find better ways to speed up this code. | |||||
* | | pass the route name to define_url_helper | Aaron Patterson | 2014-07-17 | 2 | -22/+24 | |
| | | | | | | | | | | this allows us to avoid 2 hash allocations per named helper definition, also we can avoid a `merge` and `delete`. | |||||
* | | use a strategy object for generating urls in named helpers | Aaron Patterson | 2014-07-17 | 1 | -13/+24 | |
| | | | | | | | | | | | | since we know that the route should be a path or fully qualified, we can pass a strategy object that handles generation. This allows us to eliminate an "if only_path" branch when generating urls. | |||||
* | | we do not need to dup the options hash, it is private and a new object each call | Aaron Patterson | 2014-07-16 | 1 | -2/+2 | |
| | | ||||||
* | | push rails app testing up | Aaron Patterson | 2014-07-16 | 1 | -9/+13 | |
| | | | | | | | | this way we only have to test for whether it is a rails app once. | |||||
* | | Rails-ish apps should descend from Rails::Railtie | Aaron Patterson | 2014-07-16 | 1 | -8/+3 | |
| | | | | | | | | | | Use an is_a check to ensure it's a Railsish app so we can avoid respond_to calls everywhere. | |||||
* | | app should always be a class (I suppose) | Aaron Patterson | 2014-07-16 | 1 | -1/+1 | |
| | | ||||||
* | | we should be checking if the app is a class | Aaron Patterson | 2014-07-16 | 1 | -1/+1 | |
| | | | | | | | | | | Hopefully `object.class` always returns something that is_a?(Class), so the previous logic didn't really make sense. | |||||
* | | extract inner options before delegating to the helper | Aaron Patterson | 2014-07-16 | 1 | -7/+13 | |
| | | | | | | | | | | If we extract the options from the user facing method call ASAP, then we can simplify internal logic. | |||||
* | | routed applications will respond to these methods | Aaron Patterson | 2014-07-15 | 1 | -1/+1 | |
| | | ||||||
* | | RouteSet should be in charge of constructing the dispather | Aaron Patterson | 2014-07-15 | 2 | -8/+13 | |
| | | | | | | | | Now we can override how requests are dispatched in the routeset object | |||||
* | | Generate shallow paths for all children of shallow resources. | Seb Jacobs | 2014-07-06 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prior to this commit shallow resources would only generate paths for non-direct children (with a nested depth greater than 1). Take the following routes file. resources :blogs do resources :posts, shallow: true do resources :comments do resources :tags end end end This would generate shallow paths for `tags` nested under `posts`, e.g `/posts/:id/tags/`, however it would not generate shallow paths for `comments` nested under `posts`, e.g `/posts/:id/comments/new`. This commit changes the behaviour of the route mapper so that it generate paths for direct children of shallow resources, for example if you take the previous routes file, this will now generate shallow paths for `comments` nested under `posts`, .e.g `posts/:id/comments/new`. This was the behaviour in Rails `4.0.4` however this was broken in @jcoglan's fix for another routes related issue[1]. This also fixes an issue[2] reported by @smdern. [1] https://github.com/rails/rails/commit/d0e5963 [2] https://github.com/rails/rails/issues/15783 | |||||
* | | Fix doc unwanted dl Admin:: [ci skip] | Ciro Santilli | 2014-07-01 | 1 | -1/+1 | |
|/ | ||||||
* | Remove unused param 'separators' from RouteSet#build_path | Mindaugas Mozūras | 2014-06-15 | 1 | -2/+2 | |
| | ||||||
* | remove another wasteful AS::SafeBuffer allocation | Aaron Patterson | 2014-06-06 | 1 | -1/+1 | |
| | ||||||
* | push splitting "to" up the callstack | Aaron Patterson | 2014-06-03 | 1 | -15/+20 | |
| | ||||||
* | Routes specifying 'to:' must be a string that contains a "#" or a rack | Aaron Patterson | 2014-06-03 | 1 | -3/+21 | |
| | | | | | application. Use of a symbol should be replaced with `action: symbol`. Use of a string without a "#" should be replaced with `controller: string`. | |||||
* | push some options munging to an alternate constructor | Aaron Patterson | 2014-06-03 | 1 | -13/+19 | |
| | ||||||
* | move options_constraints tests next to each other | Aaron Patterson | 2014-06-03 | 1 | -2/+2 | |
| | ||||||
* | only do is_a checks on `formatted` once | Aaron Patterson | 2014-06-03 | 1 | -9/+5 | |
| | ||||||
* | push options_constraints processing up | Aaron Patterson | 2014-06-03 | 1 | -22/+24 | |
| | | | | | this lets us reduce is_a checks on the options_constraints and push "callable constraints" verification to the right place. | |||||
* | remove options as an ivar | Aaron Patterson | 2014-06-03 | 1 | -6/+8 | |
| | ||||||
* | only do Regexp === option once | Aaron Patterson | 2014-06-03 | 1 | -3/+4 | |
| | ||||||
* | return early from add_request_method | Aaron Patterson | 2014-06-03 | 1 | -11/+11 | |
| | ||||||
* | only loop over `options` once (hopefully) | Aaron Patterson | 2014-06-03 | 1 | -13/+11 | |
| | ||||||
* | only loop through constraints once | Aaron Patterson | 2014-06-03 | 1 | -19/+15 | |
| | ||||||
* | change defaults allocation to a one-liner | Aaron Patterson | 2014-06-03 | 1 | -3/+2 | |
| | ||||||
* | no longer need the scope ivar | Aaron Patterson | 2014-06-03 | 1 | -2/+1 | |
| | ||||||
* | only look up scope[:module] once | Aaron Patterson | 2014-06-03 | 1 | -6/+6 | |
| | ||||||
* | remove IGNORE_OPTIONS | Aaron Patterson | 2014-06-03 | 1 | -4/+8 | |
| | ||||||
* | :only is never used in Mapping, so rm the key | Aaron Patterson | 2014-06-03 | 1 | -1/+2 | |
| | ||||||
* | remove :defaults from the IGNORE_OPTIONS list | Aaron Patterson | 2014-06-03 | 1 | -4/+4 | |
| | ||||||
* | remove :constraints from IGNORE_OPTIONS | Aaron Patterson | 2014-06-03 | 1 | -4/+5 | |
| | ||||||
* | disconnect normalize_defaults! from options[:constraints] | Aaron Patterson | 2014-06-03 | 1 | -6/+6 | |
| | ||||||
* | disconnect options and scope from the `blocks` method | Aaron Patterson | 2014-06-03 | 1 | -7/+8 | |
| | ||||||
* | disconnect the constraints method from the options and scope hashes | Aaron Patterson | 2014-06-03 | 1 | -12/+15 | |
| | ||||||
* | :on is removed from options before the Mapping is instantiated, so remove it ↵ | Aaron Patterson | 2014-06-03 | 1 | -1/+1 | |
| | | | | from IGNORE_OPTIONS | |||||
* | pull up via extraction and remove it from options / IGNORE_OPTIONS | Aaron Patterson | 2014-06-03 | 1 | -8/+6 | |
| | ||||||
* | always make :via a list | Aaron Patterson | 2014-06-03 | 1 | -3/+2 | |
| | ||||||
* | always pull out a via variable and simplify logic | Aaron Patterson | 2014-06-03 | 1 | -12/+15 | |
| | ||||||
* | add a test for missing "via" parameter | Aaron Patterson | 2014-06-03 | 1 | -1/+1 | |
| | ||||||
* | remove :as and :anchor from IGNORE_OPTIONS | Aaron Patterson | 2014-06-03 | 1 | -3/+5 | |
| | ||||||
* | remove another value from IGNORE_OPTIONS | Aaron Patterson | 2014-06-03 | 1 | -2/+2 | |
| | ||||||
* | shorten up IGNORE_OPTIONS | Aaron Patterson | 2014-06-03 | 1 | -2/+2 | |
| | | | | | | since we are now passing the format value around, we can remove it from the options hash, which means we don't need to consult as many values from IGNORE_OPTIONS | |||||
* | only look up the format option from the hash once | Aaron Patterson | 2014-06-03 | 1 | -16/+18 | |
| | ||||||
* | Mapping never actually uses @set, so rm | Aaron Patterson | 2014-05-29 | 1 | -3/+3 | |
| |