Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Don't ignore nil positional arguments for url helpers - fixes #6196. | Andrew White | 2012-05-10 | 1 | -1/+1 |
| | |||||
* | Reset the request parameters after a constraints check | Andrew White | 2012-05-03 | 1 | -0/+2 |
| | | | | | | | | | | | | | | A callable object passed as a constraint for a route may access the request parameters as part of its check. This causes the combined parameters hash to be cached in the environment hash. If the constraint fails then any subsequent access of the request parameters will be against that stale hash. To fix this we delete the cache after every call to `matches?`. This may have a negative performance impact if the contraint wraps a large number of routes as the parameters hash is built by merging GET, POST and path parameters. Fixes #2510. (cherry picked from commit 56030506563352944fed12a6bb4793bb2462094b) | ||||
* | Restore interpolation of path option in redirect routes | Andrew White | 2012-04-29 | 1 | -0/+10 |
| | |||||
* | Add missing require from b608cdd64c95d0d16eb98d86562e22f3b01be9e3 | Andrew White | 2012-04-29 | 1 | -0/+1 |
| | |||||
* | Escape interpolated params when redirecting - fixes #5688 | Andrew White | 2012-04-29 | 1 | -1/+6 |
| | |||||
* | Fix the redirect when it receive blocks with arity of 1. | Rafael Mendonça França | 2012-03-31 | 1 | -1/+2 |
| | | | | Closes #5677 | ||||
* | Fix typo in match :to docs | Justin Woodbridge | 2012-02-25 | 1 | -1/+1 |
| | |||||
* | Avoid inspecting the whole route set, closes #1525 | José Valim | 2012-02-23 | 1 | -0/+6 |
| | |||||
* | Merge pull request #5084 from johndouthat/patch-1 | Aaron Patterson | 2012-02-22 | 1 | -2/+1 |
| | | | | Remove reference to rails_legacy_mapper, which isn't compatible with 3.2... | ||||
* | Merge pull request #4988 from kennyj/fix_4720-3 | Aaron Patterson | 2012-02-10 | 1 | -0/+5 |
| | | | | Fix GH #4720. Routing problem with nested namespace and already camelized controller option. | ||||
* | Fixed force_ssl redirects to include original query params | Ryan McGeary | 2012-02-06 | 1 | -0/+1 |
| | | | | | | `ActionController.force_ssl` redirects http URLs to their https equivalent; however, when a URL contains a query string, the resulting redirect lacked the original query string. | ||||
* | Merge pull request #4908 from kennyj/fix_3864 | José Valim | 2012-02-06 | 1 | -1/+1 |
| | | | | Fix url_for method's behavior. GH #3684. | ||||
* | Added custom regexps to ASTs that have literal nodes on either side of | Aaron Patterson | 2012-01-23 | 1 | -1/+20 |
| | | | | symbol nodes. Fixes #4585 | ||||
* | Revert "Named Routes shouldn't override existing ones (currently route ↵ | Aaron Patterson | 2012-01-03 | 1 | -1/+1 |
| | | | | | | recognition goes with the earliest match, named routes use the latest match)" This reverts commit 71d769e3b58cb56b4b1d5143936c65be8b27c490. | ||||
* | Override respond_to? since we are also overriding method_missing. | José Valim | 2012-01-03 | 1 | -0/+4 |
| | |||||
* | Documented about using :path option for resources | Kevin Moore | 2011-12-29 | 1 | -0/+7 |
| | |||||
* | Correctly display rack apps with dynamic constraints in RoutesInspector | Piotr Sarnacki | 2011-12-26 | 1 | -1/+1 |
| | | | | | | | | | | | | | If you used dynamic constraint like that: scope :constraint => MyConstraint.new do mount RackApp => "/foo" end routes were not displayed correctly when using `rake routes`. This commit fixes it. If you want nice display of dynamic constraints in `rake routes` output, please just override to_s method in your constraint's class. | ||||
* | Do not raise an exception if an invalid route was generated automatically. | José Valim | 2011-12-16 | 1 | -3/+11 |
| | |||||
* | Move symbolize keys to the inner options as we can assume url_options will ↵ | José Valim | 2011-12-08 | 2 | -2/+2 |
| | | | | be properly symbolized. | ||||
* | Improve cache on route_key lookup. | José Valim | 2011-12-08 | 1 | -4/+6 |
| | |||||
* | Named Routes shouldn't override existing ones (currently route recognition ↵ | Andy Jeffries | 2011-12-05 | 1 | -1/+1 |
| | | | | goes with the earliest match, named routes use the latest match) | ||||
* | Fixing incorrect documentation | Aviv Ben-Yosef | 2011-11-30 | 1 | -2/+2 |
| | | | `path_names` can only be used for affecting `new` and `edit` | ||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2011-11-26 | 1 | -2/+2 |
|\ | |||||
| * | what's -> that's | Uģis Ozols | 2011-11-25 | 1 | -1/+1 |
| | | |||||
| * | Remove unnecessary comment. | Uģis Ozols | 2011-11-25 | 1 | -1/+1 |
| | | |||||
* | | Revert "copy options keys to the right place so that undo will work correctly" | Aaron Patterson | 2011-11-19 | 1 | -4/+10 |
| | | | | | | | | This reverts commit 3178cc9a80262d3bf7754f3507ef60243b46634f. | ||||
* | | Warning removed for shadowing variable | Arun Agrawal | 2011-11-19 | 1 | -1/+1 |
| | | |||||
* | | Revert "make sure to require the right deprecation warning file" | Aaron Patterson | 2011-11-18 | 1 | -1/+0 |
| | | | | | | | | This reverts commit 9d725e3df502a07222f35576108eb2df2bd88259. | ||||
* | | Refactoring the redirect method for the router api. | Aaron Patterson | 2011-11-18 | 1 | -25/+19 |
| | | |||||
* | | moving redirection to objects | Aaron Patterson | 2011-11-18 | 1 | -45/+58 |
| | | |||||
* | | remove the :path feature to redirects, since it cannot work | Aaron Patterson | 2011-11-18 | 1 | -15/+7 |
| | | |||||
* | | make sure to require the right deprecation warning file | Aaron Patterson | 2011-11-18 | 1 | -0/+1 |
| | | |||||
* | | arity check has been pushed up, so no need for proc wrapping | Aaron Patterson | 2011-11-18 | 1 | -1/+1 |
| | | |||||
* | | require that all blocks have arity of 2 | Aaron Patterson | 2011-11-18 | 1 | -5/+10 |
| | | |||||
* | | copy options keys to the right place so that undo will work correctly | Aaron Patterson | 2011-11-18 | 1 | -10/+4 |
| | | |||||
* | | no need for type checking | Aaron Patterson | 2011-11-18 | 1 | -1/+1 |
| | | |||||
* | | cleaning up variable names to match method parameter names | Aaron Patterson | 2011-11-18 | 1 | -6/+8 |
| | | |||||
* | | stop doing is_a? checks on the resource type | Aaron Patterson | 2011-11-18 | 1 | -4/+4 |
| | | |||||
* | | move constants to methods since nothing else is using them | Aaron Patterson | 2011-11-18 | 1 | -6/+5 |
| | | |||||
* | | pushing hash validation up | Aaron Patterson | 2011-11-18 | 1 | -13/+14 |
| | | |||||
* | | breaking match down to smaller methods | Aaron Patterson | 2011-11-18 | 1 | -19/+22 |
| | | |||||
* | | some refactoring of the match method | Aaron Patterson | 2011-11-18 | 1 | -25/+17 |
|/ | |||||
* | Fix small typos in routing docs | Alexey Vakhov | 2011-11-03 | 1 | -1/+3 |
| | |||||
* | Fix typo in Dispatcher#controller documentation | Aviv Ben-Yosef | 2011-11-01 | 1 | -1/+1 |
| | |||||
* | Fix typo in constraints method documentation | Alexey Vakhov | 2011-11-01 | 1 | -1/+1 |
| | |||||
* | Adds missing closing regex slashes. | mjy | 2011-10-25 | 1 | -2/+2 |
| | |||||
* | Leave escaping up to Journey | Jeremy Kemper | 2011-10-13 | 1 | -4/+3 |
| | |||||
* | allow shorthand routes with nested optional parameters | Diego Carrion | 2011-10-10 | 1 | -3/+3 |
| | |||||
* | fix require | Aaron Patterson | 2011-10-06 | 1 | -1/+1 |
| | |||||
* | :subdomain can now be specified with a value of false in url_for, allowing ↵ | Kamil Sobieraj | 2011-10-04 | 1 | -2/+3 |
| | | | | for subdomain(s) removal from the host during link generation. Closes #2025 |