Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | remove unused path_without_format variable | Kornelius Kalnbach | 2013-03-03 | 1 | -2/+0 |
| | | | Was forgotten in a72dab0. | ||||
* | determine the match shorthand target early. | Yves Senn | 2013-02-22 | 1 | -9/+12 |
| | | | | | | | | | Backport #9361. Closes #7554. This patch determines the `controller#action` directly in the `match` method when the shorthand syntax is used. this prevents problems with namespaces and scopes. | ||||
* | Duplicate possible frozen string from route | Andrew White | 2013-01-21 | 1 | -2/+3 |
| | | | | | | | | | | | | | Ruby 1.9 freezes Hash string keys by default so where a route is defined like this: get 'search' => 'search' then the Mapper will derive the action from the key. This blows up later when the action is added to the parameters hash and the encoding is forced. Closes #3429 | ||||
* | Clear url helper methods when routes are reloaded | Andrew White | 2012-12-14 | 1 | -6/+12 |
| | | | | | | | | Clear url helper methods when routes are reloaded by removing the methods explicitly rather than just clearing the module because it didn't work properly and could be the source of a memory leak. Closes #8488. | ||||
* | Refactor Generator class to not rely on in-place editing the controller | Andrew White | 2012-11-16 | 1 | -5/+10 |
| | |||||
* | Fix bug when url_for changes controller. | Nikita Beloglazov | 2012-11-16 | 1 | -2/+2 |
| | |||||
* | Fix redirect example block | Carlos Antonio da Silva | 2012-11-09 | 1 | -3/+3 |
| | | | | See #8160. [ci skip] | ||||
* | backport, handle trailing slash with engines | Yves Senn | 2012-11-08 | 1 | -1/+1 |
| | | | | this is a backport of #8115 to fix #7842 | ||||
* | Clear url helpers when reloading routes | Santiago Pastorino | 2012-11-02 | 1 | -0/+1 |
| | |||||
* | Revert "Merge pull request #7668 from Draiken/fix_issue_6497" | Rafael Mendonça França | 2012-11-02 | 1 | -1/+1 |
| | | | | | | | | | This reverts commit 61d5d2d8a97fd289b81991cd79dca3112e7ca135. Conflicts: actionpack/CHANGELOG.md REASON: This added a backward incompatible change. | ||||
* | Merge pull request #7789 from senny/7777_resource_functions_modify_options | Rafael Mendonça França | 2012-10-01 | 1 | -2/+2 |
| | | | | resource and resources do no longer modify passed options | ||||
* | Merge pull request #7668 from Draiken/fix_issue_6497 | Rafael Mendonça França | 2012-09-19 | 1 | -1/+1 |
| | | | | | | Removing to_shorthand to fix #6497 Conflicts: actionpack/CHANGELOG.md | ||||
* | Add support for optional root segments containing slashes | Andrew White | 2012-07-17 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Optional segments with a root scope need to have the leading slash outside of the parentheses, otherwise the generated url will be empty. However if the route has non-optional elements then the leading slash needs to remain inside the parentheses otherwise the generated url will have two leading slashes, e.g: Blog::Application.routes.draw do get '/(:category)', :to => 'posts#index', :as => :root get '/(:category)/author/:name', :to => 'posts#author', :as => :author end $ rake routes root GET /(:category)(.:format) posts#index author GET (/:category)/author/:name(.:format) posts#author This change adds support for optional segments that contain a slash, allowing support for urls like /page/2 for the root path, e.g: Blog::Application.routes.draw do get '/(page/:page)', :to => 'posts#index', :as => :root end $ rake routes root GET /(page/:page)(.:format) posts#index Fixes #7073 (cherry picked from commit d8745decaf59aad32aa2f09abdba99b8d0e48b31) | ||||
* | Use to_model delegates for polymorphic route generation | Nathaniel Bibler | 2012-06-01 | 1 | -1/+7 |
| | |||||
* | Don't ignore nil positional arguments for url helpers - fixes #6196. | Andrew White | 2012-05-10 | 1 | -1/+1 |
| | |||||
* | Reset the request parameters after a constraints check | Andrew White | 2012-05-03 | 1 | -0/+2 |
| | | | | | | | | | | | | | | A callable object passed as a constraint for a route may access the request parameters as part of its check. This causes the combined parameters hash to be cached in the environment hash. If the constraint fails then any subsequent access of the request parameters will be against that stale hash. To fix this we delete the cache after every call to `matches?`. This may have a negative performance impact if the contraint wraps a large number of routes as the parameters hash is built by merging GET, POST and path parameters. Fixes #2510. (cherry picked from commit 56030506563352944fed12a6bb4793bb2462094b) | ||||
* | Restore interpolation of path option in redirect routes | Andrew White | 2012-04-29 | 1 | -0/+10 |
| | |||||
* | Add missing require from b608cdd64c95d0d16eb98d86562e22f3b01be9e3 | Andrew White | 2012-04-29 | 1 | -0/+1 |
| | |||||
* | Escape interpolated params when redirecting - fixes #5688 | Andrew White | 2012-04-29 | 1 | -1/+6 |
| | |||||
* | Fix the redirect when it receive blocks with arity of 1. | Rafael Mendonça França | 2012-03-31 | 1 | -1/+2 |
| | | | | Closes #5677 | ||||
* | Fix typo in match :to docs | Justin Woodbridge | 2012-02-25 | 1 | -1/+1 |
| | |||||
* | Avoid inspecting the whole route set, closes #1525 | José Valim | 2012-02-23 | 1 | -0/+6 |
| | |||||
* | Merge pull request #5084 from johndouthat/patch-1 | Aaron Patterson | 2012-02-22 | 1 | -2/+1 |
| | | | | Remove reference to rails_legacy_mapper, which isn't compatible with 3.2... | ||||
* | Merge pull request #4988 from kennyj/fix_4720-3 | Aaron Patterson | 2012-02-10 | 1 | -0/+5 |
| | | | | Fix GH #4720. Routing problem with nested namespace and already camelized controller option. | ||||
* | Fixed force_ssl redirects to include original query params | Ryan McGeary | 2012-02-06 | 1 | -0/+1 |
| | | | | | | `ActionController.force_ssl` redirects http URLs to their https equivalent; however, when a URL contains a query string, the resulting redirect lacked the original query string. | ||||
* | Merge pull request #4908 from kennyj/fix_3864 | José Valim | 2012-02-06 | 1 | -1/+1 |
| | | | | Fix url_for method's behavior. GH #3684. | ||||
* | Added custom regexps to ASTs that have literal nodes on either side of | Aaron Patterson | 2012-01-23 | 1 | -1/+20 |
| | | | | symbol nodes. Fixes #4585 | ||||
* | Revert "Named Routes shouldn't override existing ones (currently route ↵ | Aaron Patterson | 2012-01-03 | 1 | -1/+1 |
| | | | | | | recognition goes with the earliest match, named routes use the latest match)" This reverts commit 71d769e3b58cb56b4b1d5143936c65be8b27c490. | ||||
* | Override respond_to? since we are also overriding method_missing. | José Valim | 2012-01-03 | 1 | -0/+4 |
| | |||||
* | Documented about using :path option for resources | Kevin Moore | 2011-12-29 | 1 | -0/+7 |
| | |||||
* | Correctly display rack apps with dynamic constraints in RoutesInspector | Piotr Sarnacki | 2011-12-26 | 1 | -1/+1 |
| | | | | | | | | | | | | | If you used dynamic constraint like that: scope :constraint => MyConstraint.new do mount RackApp => "/foo" end routes were not displayed correctly when using `rake routes`. This commit fixes it. If you want nice display of dynamic constraints in `rake routes` output, please just override to_s method in your constraint's class. | ||||
* | Do not raise an exception if an invalid route was generated automatically. | José Valim | 2011-12-16 | 1 | -3/+11 |
| | |||||
* | Move symbolize keys to the inner options as we can assume url_options will ↵ | José Valim | 2011-12-08 | 2 | -2/+2 |
| | | | | be properly symbolized. | ||||
* | Improve cache on route_key lookup. | José Valim | 2011-12-08 | 1 | -4/+6 |
| | |||||
* | Named Routes shouldn't override existing ones (currently route recognition ↵ | Andy Jeffries | 2011-12-05 | 1 | -1/+1 |
| | | | | goes with the earliest match, named routes use the latest match) | ||||
* | Fixing incorrect documentation | Aviv Ben-Yosef | 2011-11-30 | 1 | -2/+2 |
| | | | `path_names` can only be used for affecting `new` and `edit` | ||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2011-11-26 | 1 | -2/+2 |
|\ | |||||
| * | what's -> that's | Uģis Ozols | 2011-11-25 | 1 | -1/+1 |
| | | |||||
| * | Remove unnecessary comment. | Uģis Ozols | 2011-11-25 | 1 | -1/+1 |
| | | |||||
* | | Revert "copy options keys to the right place so that undo will work correctly" | Aaron Patterson | 2011-11-19 | 1 | -4/+10 |
| | | | | | | | | This reverts commit 3178cc9a80262d3bf7754f3507ef60243b46634f. | ||||
* | | Warning removed for shadowing variable | Arun Agrawal | 2011-11-19 | 1 | -1/+1 |
| | | |||||
* | | Revert "make sure to require the right deprecation warning file" | Aaron Patterson | 2011-11-18 | 1 | -1/+0 |
| | | | | | | | | This reverts commit 9d725e3df502a07222f35576108eb2df2bd88259. | ||||
* | | Refactoring the redirect method for the router api. | Aaron Patterson | 2011-11-18 | 1 | -25/+19 |
| | | |||||
* | | moving redirection to objects | Aaron Patterson | 2011-11-18 | 1 | -45/+58 |
| | | |||||
* | | remove the :path feature to redirects, since it cannot work | Aaron Patterson | 2011-11-18 | 1 | -15/+7 |
| | | |||||
* | | make sure to require the right deprecation warning file | Aaron Patterson | 2011-11-18 | 1 | -0/+1 |
| | | |||||
* | | arity check has been pushed up, so no need for proc wrapping | Aaron Patterson | 2011-11-18 | 1 | -1/+1 |
| | | |||||
* | | require that all blocks have arity of 2 | Aaron Patterson | 2011-11-18 | 1 | -5/+10 |
| | | |||||
* | | copy options keys to the right place so that undo will work correctly | Aaron Patterson | 2011-11-18 | 1 | -10/+4 |
| | | |||||
* | | no need for type checking | Aaron Patterson | 2011-11-18 | 1 | -1/+1 |
| | |