Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Merge pull request #6588 from nbibler/polymorphic_to_model | José Valim | 2012-06-01 | 1 | -1/+7 | |
| | | | | Correct the use of to_model in polymorphic routing | |||||
* | Include routes.mounted_helpers into integration tests | Piotr Sarnacki | 2012-06-01 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | In integration tests, you might want to use helpers from engines that you mounted in your application. It's not hard to add it by yourself, but it's unneeded boilerplate. mounted_helpers are now included by default. That means that given engine mounted like: mount Foo::Engine => "/foo", :as => "foo" you will be able to use paths from this engine in tests this way: foo.root_path #=> "/foo" (closes #6573) | |||||
* | Simplify logic to initialize valid conditions in RouteSet | Carlos Antonio da Silva | 2012-05-31 | 1 | -7/+3 | |
| | | | | | | Remove :to_sym call from public_instance_methods iteration, as such methods in Ruby 1.9 already return symbols. Initialize valid conditions with controller/action instead of setting them afterwards. | |||||
* | Remove implicit dependency on pathname | José Valim | 2012-05-25 | 1 | -3/+3 | |
| | ||||||
* | Merge pull request #2549 from trek/RoutingErrorForMissingControllers | Aaron Patterson | 2012-05-21 | 1 | -3/+7 | |
|\ | | | | | When a route references a missing controller, raise ActionController::RoutingError with clearer message | |||||
| * | When a route references a missing controller, raise ↵ | Trek Glowacki | 2011-08-16 | 1 | -3/+7 | |
| | | | | | | | | ActionController::RoutingError with a clearer message | |||||
* | | Return 400 Bad Request for URL paths with invalid encoding. | Andrew White | 2012-05-20 | 2 | -0/+18 | |
| | | | | | | | | | | | | | | | | | | Passing path parameters with invalid encoding is likely to trigger errors further on like `ArgumentError (invalid byte sequence in UTF-8)`. This will result in a 500 error whereas the better error to return is a 400 error which allows exception notification libraries to filter it out if they wish. Closes #4450 | |||||
* | | Improve `rake routes` output for redirects - closes #6369. | Andrew White | 2012-05-19 | 1 | -12/+22 | |
| | | ||||||
* | | Fix inspecting route redirections, closes #6369 | Łukasz Strzałkowski | 2012-05-18 | 1 | -0/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | This commit fixes route inspection in `rake routes` Before: foo /foo(.:format) :controller#:action" After: foo /foo(.:format) Redirect (301) | |||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-05-15 | 2 | -13/+0 | |
|\ \ | | | | | | | | | | | | | Conflicts: actionpack/lib/action_view/helpers/asset_tag_helper.rb | |||||
| * | | Removing ==Examples and last blank lines of docs from actionpack | Francesco Rodriguez | 2012-05-15 | 2 | -13/+0 | |
| | | | ||||||
* | | | add tests and external file backtrace for Routing::Mapper#draw | Kornelius Kalnbach | 2012-05-15 | 1 | -3/+4 | |
|/ / | ||||||
* | | Copy literal route constraints to defaults - fixes #3571 and #6224. | Andrew White | 2012-05-11 | 1 | -0/+19 | |
| | | ||||||
* | | Don't ignore nil positional arguments for url helpers - fixes #6196. | Andrew White | 2012-05-10 | 1 | -1/+1 | |
| | | ||||||
* | | Refactor Generator class to not rely on in-place editing the controller | Andrew White | 2012-05-09 | 1 | -5/+10 | |
| | | ||||||
* | | Fix bug when url_for changes controller. | Nikita Beloglazov | 2012-05-09 | 1 | -2/+2 | |
| | | ||||||
* | | Fix that optimized named routes should also work as singleton methods on the ↵ | Jeremy Kemper | 2012-05-06 | 1 | -1/+2 | |
| | | | | | | | | url_helpers module | |||||
* | | Force given path to http methods in mapper to skip canonical action checking | Carlos Antonio da Silva | 2012-05-04 | 1 | -2/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes the following scenario: resources :contacts do post 'new', action: 'new', on: :collection, as: :new end Where the /new path is not generated because it's considered a canonical action, part of the normal resource actions: new_contacts POST /contacts(.:format) contacts#new Fixes #2999 | |||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-05-04 | 1 | -1/+1 | |
|\ \ | ||||||
| * | | Corrected the name of the module that should be included to get the url helpers. | Anuj Dutta | 2012-05-03 | 1 | -1/+1 | |
| | | | ||||||
* | | | RouteSet: optimize routes generation when globbing is used | Bogdan Gusiev | 2012-05-03 | 1 | -2/+5 | |
| | | | ||||||
* | | | use extract_options! | Paul McMahon | 2012-05-03 | 1 | -1/+2 | |
| | | | ||||||
* | | | Merge pull request #6138 from bogdan/routes | José Valim | 2012-05-03 | 1 | -19/+10 | |
|\ \ \ | | | | | | | | | RouteSet: remove some code dups | |||||
| * | | | RouteSet: remove some code dups | Bogdan Gusiev | 2012-05-02 | 1 | -19/+10 | |
| | | | | ||||||
* | | | | Reset the request parameters after a constraints check | Andrew White | 2012-05-02 | 1 | -0/+2 | |
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A callable object passed as a constraint for a route may access the request parameters as part of its check. This causes the combined parameters hash to be cached in the environment hash. If the constraint fails then any subsequent access of the request parameters will be against that stale hash. To fix this we delete the cache after every call to `matches?`. This may have a negative performance impact if the contraint wraps a large number of routes as the parameters hash is built by merging GET, POST and path parameters. Fixes #2510. | |||||
* / / | ActionPack routes: remove some useless code. | Bogdan Gusiev | 2012-05-02 | 1 | -26/+4 | |
|/ / | ||||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-05-01 | 1 | -8/+6 | |
|\ \ | ||||||
| * | | Reword polymorphic routes + mounted engine rdoc | Mark Rushakoff | 2012-04-29 | 1 | -8/+6 | |
| | | | | | | | | | | | | Also correctly indent its example code. | |||||
* | | | Restore interpolation of path option in redirect routes | Andrew White | 2012-04-29 | 1 | -0/+10 | |
| | | | ||||||
* | | | Escape interpolated params when redirecting - fixes #5688 | Andrew White | 2012-04-29 | 1 | -1/+7 | |
|/ / | ||||||
* | | Shadowing variable warning removed | Arun Agrawal | 2012-04-26 | 1 | -3/+3 | |
| | | ||||||
* | | Allow loading external route files from the router | Jose and Yehuda | 2012-04-25 | 2 | -0/+18 | |
| | | | | | | | | | | | | | | | | | | This feature enables the ability to load an external routes file from the router via: draw :filename External routes files go in +config/routes+. This feature works in both engines and applications. | |||||
* | | Remove default match without specified method | Jose and Yehuda | 2012-04-24 | 1 | -2/+12 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the current router DSL, using the +match+ DSL method will match all verbs for the path to the specified endpoint. In the vast majority of cases, people are currently using +match+ when they actually mean +get+. This introduces security implications. This commit disallows calling +match+ without an HTTP verb constraint by default. To explicitly match all verbs, this commit also adds a :via => :all option to +match+. Closes #5964 | |||||
* | | Refactor hash creation in routeset | Carlos Antonio da Silva | 2012-04-24 | 1 | -3/+4 | |
| | | ||||||
* | | RouteSet: decomplecting a way to handle positional args | Bogdan Gusiev | 2012-04-24 | 1 | -26/+20 | |
| | | ||||||
* | | RouteSet: simplify routes helpers generation code | Bogdan Gusiev | 2012-04-24 | 1 | -13/+21 | |
| | | ||||||
* | | Add missing requires in routes | Bogdan Gusiev | 2012-04-23 | 1 | -0/+1 | |
| | | ||||||
* | | Fix formatting | Oscar Del Ben | 2012-04-18 | 1 | -2/+2 | |
| | | ||||||
* | | let's keep the slash in the return value instead of the path variable [ci skip] | Vijay Dev | 2012-04-18 | 1 | -2/+2 | |
| | | ||||||
* | | Warn about do end syntax in redirect option | Oscar Del Ben | 2012-04-17 | 1 | -0/+3 | |
| | | ||||||
* | | Fix redirect with block example | Alexey Vakhov | 2012-04-17 | 1 | -3/+3 | |
| | | ||||||
* | | Revert "Merge pull request #5750 from ahoward/master" | Santiago Pastorino | 2012-04-08 | 1 | -10/+1 | |
| | | | | | | | | | | | | | | This reverts commit 174cf8b22064c3999dfa685014d5b31ac993bb54, reversing changes made to 7ecd6a731bd60665bc6de94095137f0b2c4ada2a. The reverted commit improved the performance in the wrong place, now we have added this 6ddbd1844a6fd6aca2992f5f75c9f605cf89808f improvement. | |||||
* | | documents the contract for the argument of AD::Routing::RouteSet#url_for | Xavier Noria | 2012-04-05 | 1 | -0/+1 | |
| | | ||||||
* | | Make url_for work when option is nil and default_url_options has | Rafael Mendonça França | 2012-04-05 | 1 | -1/+1 | |
| | | | | | | | | stringified keys | |||||
* | | Fix url_for when options is nil | Rafael Mendonça França | 2012-04-05 | 1 | -1/+1 | |
| | | | | | | | | | | RouteSet#url_for was modifying the options hash that belong to the caller | |||||
* | | url_for: avoid a nil check. unroll a loop. handle most common case 1st. | ara.t.howard | 2012-04-05 | 1 | -18/+13 | |
| | | ||||||
* | | carefully and quickly merge url_for options | ara.t.howard | 2012-04-04 | 1 | -1/+17 | |
| | | ||||||
* | | Updated/changed useless tr/gsubs | Jurriaan Pruis | 2012-04-03 | 1 | -2/+2 | |
| | | ||||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-03-27 | 1 | -0/+19 | |
|\ \ | ||||||
| * | | add missing do [ci skip] | Vijay Dev | 2012-03-27 | 1 | -1/+1 | |
| | | |