Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #6138 from bogdan/routes | José Valim | 2012-05-03 | 1 | -19/+10 |
|\ | | | | | RouteSet: remove some code dups | ||||
| * | RouteSet: remove some code dups | Bogdan Gusiev | 2012-05-02 | 1 | -19/+10 |
| | | |||||
* | | Reset the request parameters after a constraints check | Andrew White | 2012-05-02 | 1 | -0/+2 |
|/ | | | | | | | | | | | | | A callable object passed as a constraint for a route may access the request parameters as part of its check. This causes the combined parameters hash to be cached in the environment hash. If the constraint fails then any subsequent access of the request parameters will be against that stale hash. To fix this we delete the cache after every call to `matches?`. This may have a negative performance impact if the contraint wraps a large number of routes as the parameters hash is built by merging GET, POST and path parameters. Fixes #2510. | ||||
* | ActionPack routes: remove some useless code. | Bogdan Gusiev | 2012-05-02 | 1 | -26/+4 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-05-01 | 1 | -8/+6 |
|\ | |||||
| * | Reword polymorphic routes + mounted engine rdoc | Mark Rushakoff | 2012-04-29 | 1 | -8/+6 |
| | | | | | | | | Also correctly indent its example code. | ||||
* | | Restore interpolation of path option in redirect routes | Andrew White | 2012-04-29 | 1 | -0/+10 |
| | | |||||
* | | Escape interpolated params when redirecting - fixes #5688 | Andrew White | 2012-04-29 | 1 | -1/+7 |
|/ | |||||
* | Shadowing variable warning removed | Arun Agrawal | 2012-04-26 | 1 | -3/+3 |
| | |||||
* | Allow loading external route files from the router | Jose and Yehuda | 2012-04-25 | 2 | -0/+18 |
| | | | | | | | | | This feature enables the ability to load an external routes file from the router via: draw :filename External routes files go in +config/routes+. This feature works in both engines and applications. | ||||
* | Remove default match without specified method | Jose and Yehuda | 2012-04-24 | 1 | -2/+12 |
| | | | | | | | | | | | | | | | | In the current router DSL, using the +match+ DSL method will match all verbs for the path to the specified endpoint. In the vast majority of cases, people are currently using +match+ when they actually mean +get+. This introduces security implications. This commit disallows calling +match+ without an HTTP verb constraint by default. To explicitly match all verbs, this commit also adds a :via => :all option to +match+. Closes #5964 | ||||
* | Refactor hash creation in routeset | Carlos Antonio da Silva | 2012-04-24 | 1 | -3/+4 |
| | |||||
* | RouteSet: decomplecting a way to handle positional args | Bogdan Gusiev | 2012-04-24 | 1 | -26/+20 |
| | |||||
* | RouteSet: simplify routes helpers generation code | Bogdan Gusiev | 2012-04-24 | 1 | -13/+21 |
| | |||||
* | Add missing requires in routes | Bogdan Gusiev | 2012-04-23 | 1 | -0/+1 |
| | |||||
* | Fix formatting | Oscar Del Ben | 2012-04-18 | 1 | -2/+2 |
| | |||||
* | let's keep the slash in the return value instead of the path variable [ci skip] | Vijay Dev | 2012-04-18 | 1 | -2/+2 |
| | |||||
* | Warn about do end syntax in redirect option | Oscar Del Ben | 2012-04-17 | 1 | -0/+3 |
| | |||||
* | Fix redirect with block example | Alexey Vakhov | 2012-04-17 | 1 | -3/+3 |
| | |||||
* | Revert "Merge pull request #5750 from ahoward/master" | Santiago Pastorino | 2012-04-08 | 1 | -10/+1 |
| | | | | | | | This reverts commit 174cf8b22064c3999dfa685014d5b31ac993bb54, reversing changes made to 7ecd6a731bd60665bc6de94095137f0b2c4ada2a. The reverted commit improved the performance in the wrong place, now we have added this 6ddbd1844a6fd6aca2992f5f75c9f605cf89808f improvement. | ||||
* | documents the contract for the argument of AD::Routing::RouteSet#url_for | Xavier Noria | 2012-04-05 | 1 | -0/+1 |
| | |||||
* | Make url_for work when option is nil and default_url_options has | Rafael Mendonça França | 2012-04-05 | 1 | -1/+1 |
| | | | | stringified keys | ||||
* | Fix url_for when options is nil | Rafael Mendonça França | 2012-04-05 | 1 | -1/+1 |
| | | | | | RouteSet#url_for was modifying the options hash that belong to the caller | ||||
* | url_for: avoid a nil check. unroll a loop. handle most common case 1st. | ara.t.howard | 2012-04-05 | 1 | -18/+13 |
| | |||||
* | carefully and quickly merge url_for options | ara.t.howard | 2012-04-04 | 1 | -1/+17 |
| | |||||
* | Updated/changed useless tr/gsubs | Jurriaan Pruis | 2012-04-03 | 1 | -2/+2 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-03-27 | 1 | -0/+19 |
|\ | |||||
| * | add missing do [ci skip] | Vijay Dev | 2012-03-27 | 1 | -1/+1 |
| | | |||||
| * | added shallow_prefix option description in documantation | Lukasz Sarnacki | 2012-03-27 | 1 | -0/+19 |
| | | | | | | | | It is in response for confusion in issue #5301 | ||||
* | | Allow a defining custom member field on resources | Jamie Macey | 2012-03-25 | 1 | -4/+5 |
|/ | | | | | | | | | | By default, resources routes are created with :resource/:id. A model defining to_param can make prettier urls by using something more readable than an integer ID, but since the route picks it up as :id you wind up with awkward User.find_by_username(params[:id]) calls. By overriding the key to be used in @request.params you can be more obvious in your intent. | ||||
* | Add missing require | Santiago Pastorino | 2012-03-17 | 1 | -0/+1 |
| | |||||
* | Remove unused require | Santiago Pastorino | 2012-03-17 | 1 | -1/+0 |
| | |||||
* | Route root helper shortcut | Brian Cardarella | 2012-03-03 | 1 | -0/+5 |
| | | | | Allow the root route helper to accept just a string | ||||
* | don't pass unnecessary argument | Sergey Nartimov | 2012-03-02 | 1 | -2/+2 |
| | |||||
* | Optimize url helpers. | Sergey Nartimov + José Valim | 2012-03-02 | 2 | -11/+13 |
| | |||||
* | Optimize path helpers. | José Valim | 2012-03-02 | 3 | -12/+64 |
| | |||||
* | Merge pull request #5219 from ↵ | Aaron Patterson | 2012-02-29 | 1 | -0/+2 |
|\ | | | | | | | | | mattfawcett/2781-fix-querystring-route-constraint-for-testing Fix for #2781 | ||||
| * | Fix the assert_recognizes test method so that it works when there are | Matt Fawcett | 2012-02-24 | 1 | -0/+2 |
| | | | | | | | | constraints on the querystring. Issue #2781 | ||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-02-25 | 1 | -1/+1 |
|\ \ | | | | | | | | | | | | | Conflicts: actionmailer/CHANGELOG.md | ||||
| * | | Fix typo in match :to docs | Justin Woodbridge | 2012-02-23 | 1 | -1/+1 |
| | | | |||||
* | | | consistently mention first patch, then put | Xavier Noria | 2012-02-24 | 1 | -7/+7 |
| | | | | | | | | | | | | | | | | | | There was a mix, sometimes patch first, sometimes put first. Use always patch first, since this is going to be the primary verb for updates. | ||||
* | | | uses PATCH for the forms of persisted records, and routes PATCH and PUT to ↵ | Xavier Noria | 2012-02-24 | 1 | -9/+8 |
| |/ |/| | | | | | the update action of resources | ||||
* | | Avoid inspecting the whole route set, closes #1525 | José Valim | 2012-02-23 | 1 | -0/+6 |
| | | |||||
* | | Merge pull request #5084 from johndouthat/patch-1 | Aaron Patterson | 2012-02-22 | 1 | -2/+1 |
|\ \ | | | | | | | Remove reference to rails_legacy_mapper, which isn't compatible with 3.2... | ||||
| * | | Remove reference to rails_legacy_mapper, which isn't compatible with 3.2 #5022 | johndouthat | 2012-02-18 | 1 | -2/+1 |
| |/ | |||||
* | | Fix routes inspection order | Rafael Mendonça França | 2012-02-22 | 1 | -2/+2 |
| | | |||||
* | | Add config.default_method_for_update to support PATCH | David Lee | 2012-02-22 | 1 | -54/+71 |
|/ | | | | | | | | | | | | | | | | PATCH is the correct HTML verb to map to the #update action. The semantics for PATCH allows for partial updates, whereas PUT requires a complete replacement. Changes: * adds config.default_method_for_update you can set to :patch * optionally use PATCH instead of PUT in resource routes and forms * adds the #patch verb to routes to detect PATCH requests * adds #patch? to Request * changes documentation and comments to indicate support for PATCH This change maintains complete backwards compatibility by keeping :put as the default for config.default_method_for_update. | ||||
* | Fix GH #4720. Routing problem with nested namespace and already camelized ↵ | kennyj | 2012-02-10 | 1 | -0/+5 |
| | | | | controller option. | ||||
* | Fix match docs | Rafael Mendonça França | 2012-02-07 | 1 | -1/+1 |
| | |||||
* | Fixed force_ssl redirects to include original query params | Ryan McGeary | 2012-02-07 | 1 | -0/+1 |
| | | | | | | | | | | `ActionController.force_ssl` redirects http URLs to their https equivalent; however, when a URL contains a query string, the resulting redirect lacked the original query string. Conflicts: actionpack/lib/action_controller/metal/force_ssl.rb |