Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | fix variable names, only pass hashes to the positional args method | Aaron Patterson | 2014-05-20 | 1 | -8/+10 | |
| | ||||||
* | Only path requirements are relevant to optimized urls | Andrew White | 2014-05-15 | 1 | -1/+1 | |
| | | | | | The bit of URL generation that is optimized is the generation of the path so things like :host, :port, etc. are irrelevant. | |||||
* | Add missing requires for require 'action_dispatch/routing' | Andrew White | 2014-05-15 | 1 | -0/+2 | |
| | ||||||
* | _recall should be set to a hash or not set | Aaron Patterson | 2014-05-13 | 1 | -2/+2 | |
| | | | | Then we can avoid nil checks | |||||
* | we never call url_for with a block, so rm | Aaron Patterson | 2014-05-13 | 1 | -1/+0 | |
| | ||||||
* | drop || test for cases that do not need it | Aaron Patterson | 2014-05-13 | 2 | -4/+6 | |
| | ||||||
* | no need to check for presence, script names can be blank | Aaron Patterson | 2014-05-13 | 1 | -2/+2 | |
| | ||||||
* | extend with a module then use define_method | Aaron Patterson | 2014-05-13 | 1 | -7/+4 | |
| | | | | no need for redefine_method | |||||
* | this method should always have a parameter passed to it, so remove the default | Aaron Patterson | 2014-05-13 | 1 | -1/+1 | |
| | ||||||
* | options should always be passed to url_for | Aaron Patterson | 2014-05-13 | 1 | -2/+2 | |
| | ||||||
* | calls with :host should still use the optimized path | Aaron Patterson | 2014-05-13 | 1 | -2/+2 | |
| | ||||||
* | use fewer method calls to determine the url_for options | Aaron Patterson | 2014-05-13 | 1 | -5/+4 | |
| | ||||||
* | just merge instead of dup and merge | Aaron Patterson | 2014-05-13 | 1 | -2/+1 | |
| | ||||||
* | the :only_path option is applied by the time the helper is called | Aaron Patterson | 2014-05-13 | 1 | -4/+1 | |
| | ||||||
* | options already have symbolized keys, so we can avoid this call | Aaron Patterson | 2014-05-13 | 1 | -1/+1 | |
| | ||||||
* | Get rid of unused method | Carlos Antonio da Silva | 2014-05-13 | 1 | -11/+0 | |
| | | | | It's usage has been removed in 325c9d5e5235db4b5210d9db6c863835d1ac7eed. | |||||
* | Simplify merge call on polymorphic helpers | Carlos Antonio da Silva | 2014-05-13 | 1 | -2/+2 | |
| | ||||||
* | avoid array allocation when extracting usernames and passwords | Aaron Patterson | 2014-05-12 | 1 | -1/+7 | |
| | ||||||
* | Revert "reduce conditionals in url_for" | Aaron Patterson | 2014-05-12 | 1 | -6/+3 | |
| | | | | This reverts commit 9df60693d77813b362fb528fc62381ac8f1eec12. | |||||
* | use the helper method builder to construct helper methods | Aaron Patterson | 2014-05-12 | 2 | -57/+112 | |
| | ||||||
* | undo optimized calls until the builder object is finished | Aaron Patterson | 2014-05-12 | 2 | -37/+20 | |
| | ||||||
* | remove suffix from the handler methods | Aaron Patterson | 2014-05-12 | 1 | -20/+19 | |
| | ||||||
* | push list handling to the builder object | Aaron Patterson | 2014-05-12 | 1 | -30/+30 | |
| | ||||||
* | push string handling to the builder object | Aaron Patterson | 2014-05-12 | 1 | -10/+8 | |
| | ||||||
* | push model and class handling to a helper builder object | Aaron Patterson | 2014-05-12 | 1 | -36/+48 | |
| | ||||||
* | adding a method to handle strings using the same api | Aaron Patterson | 2014-05-12 | 1 | -22/+32 | |
| | ||||||
* | break each polymorphic type to it's own method | Aaron Patterson | 2014-05-12 | 1 | -24/+81 | |
| | ||||||
* | remove dead code | Aaron Patterson | 2014-05-12 | 1 | -12/+0 | |
| | ||||||
* | only test `persisted?` on the record once | Aaron Patterson | 2014-05-12 | 1 | -3/+7 | |
| | | | | | also avoid the case of calling `persisted?` on something that doesn't respond to it | |||||
* | only send options if there are any options | Aaron Patterson | 2014-05-12 | 1 | -5/+7 | |
| | ||||||
* | remove should_pop variable | Aaron Patterson | 2014-05-12 | 1 | -4/+1 | |
| | ||||||
* | only pop records when we get an array | Aaron Patterson | 2014-05-12 | 1 | -6/+7 | |
| | ||||||
* | remove unnecessary array allocations | Coraline Ada Ehmke + Aaron Patterson | 2014-05-12 | 1 | -5/+1 | |
| | ||||||
* | simplified route method name generation | Coraline Ada Ehmke + Aaron Patterson | 2014-05-12 | 1 | -27/+17 | |
| | ||||||
* | small refactoring | Coraline Ada Ehmke + Aaron Patterson | 2014-05-12 | 1 | -6/+2 | |
| | ||||||
* | pulling helpermethods up before refactoring | Coraline Ada Ehmke + Aaron Patterson | 2014-05-12 | 1 | -20/+46 | |
| | ||||||
* | push all is_a tests up, always pass options to the named route | Aaron Patterson | 2014-05-12 | 1 | -28/+27 | |
| | ||||||
* | pull nil checks up | Aaron Patterson | 2014-05-12 | 1 | -3/+5 | |
| | ||||||
* | skip another Array is_a check | Aaron Patterson | 2014-05-12 | 1 | -4/+6 | |
| | ||||||
* | only do the Array is_a check once | Aaron Patterson | 2014-05-12 | 1 | -4/+3 | |
| | ||||||
* | we always convert this variable to a list, so we can remove the unconversion | Aaron Patterson | 2014-05-12 | 1 | -1/+0 | |
| | ||||||
* | record as a hash is not possible, so rm branch | Aaron Patterson | 2014-05-12 | 1 | -2/+0 | |
| | ||||||
* | stop popping in build_named_route_call | Aaron Patterson | 2014-05-12 | 1 | -4/+3 | |
| | ||||||
* | remove extract_record since we have extracted the list | Aaron Patterson | 2014-05-12 | 1 | -12/+1 | |
| | ||||||
* | always pass a list to build_named_route_call | Aaron Patterson | 2014-05-12 | 1 | -10/+19 | |
| | ||||||
* | add a test for passing two models to the polymorphic_url method | Aaron Patterson | 2014-05-12 | 1 | -1/+1 | |
| | ||||||
* | reduce conditionals in url_for | Aaron Patterson | 2014-05-12 | 1 | -3/+6 | |
| | ||||||
* | extract route key translation to a method and reuse it | Aaron Patterson | 2014-05-12 | 1 | -17/+14 | |
| | ||||||
* | make the module version quack the same as the instance | Aaron Patterson | 2014-05-12 | 1 | -3/+10 | |
| | | | | this way we can stop checking respond_to on every call. | |||||
* | Hash#except is expensive and this is a hotspot, so use a dup + delete | Aaron Patterson | 2014-05-12 | 1 | -1/+2 | |
| |