| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
we already know what helpers are path helpers, so just iterate through
that list and define the helpers with warnings
|
| |
|
|
|
|
|
| |
this lets us avoid hard coding a regexp for separating path and url
helpers in the clear! method.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Email does not support relative links since there is no implicit host. Therefore all links inside of emails must be fully qualified URLs. All path helpers are now deprecated. When removed, the error will give early indication to developers to use `*_url` methods instead.
Currently if a developer uses a `*_path` helper, their tests and `mail_view` will not catch the mistake. The only way to see the error is by sending emails in production. Preventing sending out emails with non-working path's is the desired end goal of this PR.
Currently path helpers are mixed-in to controllers (the ActionMailer::Base acts as a controller). All `*_url` and `*_path` helpers are made available through the same module. This PR separates this behavior into two modules so we can extend the `*_path` methods to add a Deprecation to them. Once deprecated we can use this same area to raise a NoMethodError and add an informative message directing the developer to use `*_url` instead.
The module with warnings is only mixed in when a controller returns false from the newly added `supports_relative_path?`.
Paired @sgrif & @schneems
|
|
|
|
| |
use helpers.include? so we don't get any false positives
|
|
|
|
|
| |
we should not be accessing internals to figure out if a method is
defined.
|
|
|
|
|
| |
since helpers is a set, we can be confident about when to remove methods
from the module.
|
|
|
|
| |
after this, we can disconnect @module from the instance
|
|
|
|
| |
we can cache the module on the stack, then reuse it
|
| |
|
|
|
|
|
| |
we know the routes should not be "optimized" when mounting an
application
|
|
|
|
|
| |
this caching doesn't increase performance, but does increase complexity.
remove it for now and find better ways to speed up this code.
|
|
|
|
|
| |
this allows us to avoid 2 hash allocations per named helper definition,
also we can avoid a `merge` and `delete`.
|
|
|
|
|
|
| |
since we know that the route should be a path or fully qualified, we can
pass a strategy object that handles generation. This allows us to
eliminate an "if only_path" branch when generating urls.
|
| |
|
|
|
|
| |
this way we only have to test for whether it is a rails app once.
|
|
|
|
|
| |
Use an is_a check to ensure it's a Railsish app so we can avoid
respond_to calls everywhere.
|
| |
|
|
|
|
|
| |
Hopefully `object.class` always returns something that is_a?(Class), so
the previous logic didn't really make sense.
|
|
|
|
|
| |
If we extract the options from the user facing method call ASAP, then we
can simplify internal logic.
|
| |
|
|
|
|
| |
Now we can override how requests are dispatched in the routeset object
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Prior to this commit shallow resources would only generate paths for
non-direct children (with a nested depth greater than 1).
Take the following routes file.
resources :blogs do
resources :posts, shallow: true do
resources :comments do
resources :tags
end
end
end
This would generate shallow paths for `tags` nested under `posts`,
e.g `/posts/:id/tags/`, however it would not generate shallow paths
for `comments` nested under `posts`, e.g `/posts/:id/comments/new`.
This commit changes the behaviour of the route mapper so that it
generate paths for direct children of shallow resources, for example
if you take the previous routes file, this will now generate
shallow paths for `comments` nested under `posts`, .e.g
`posts/:id/comments/new`.
This was the behaviour in Rails `4.0.4` however this was broken in
@jcoglan's fix for another routes related issue[1].
This also fixes an issue[2] reported by @smdern.
[1] https://github.com/rails/rails/commit/d0e5963
[2] https://github.com/rails/rails/issues/15783
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
application. Use of a symbol should be replaced with `action: symbol`.
Use of a string without a "#" should be replaced with `controller: string`.
|
| |
|
| |
|
| |
|
|
|
|
|
| |
this lets us reduce is_a checks on the options_constraints and push
"callable constraints" verification to the right place.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
from IGNORE_OPTIONS
|
| |
|