aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch/routing
Commit message (Collapse)AuthorAgeFilesLines
* pass the extra params to the rack test environment so that routes with block ↵Brian Hahn2013-09-061-1/+2
| | | | constraints have access
* Add missing requireSantiago Pastorino2013-07-021-0/+1
|
* Fix shorthand routes where controller and action are in the scopeAndrew White2013-06-251-0/+8
| | | | | | | | | | | Merge `:action` from routing scope and assign endpoint if both `:controller` and `:action` are present. The endpoint assignment only occurs if there is no `:to` present in the options hash so should only affect routes using the shorthand syntax (i.e. endpoint is inferred from the the path). Fixes #9856 Backport of 37b4276
* just clear the caches on clear! rather than replacing. fixes #10251Aaron Patterson2013-04-171-8/+4
|
* remove unused path_without_format variableKornelius Kalnbach2013-03-031-2/+0
| | | Was forgotten in a72dab0.
* determine the match shorthand target early.Yves Senn2013-02-221-9/+12
| | | | | | | | | Backport #9361. Closes #7554. This patch determines the `controller#action` directly in the `match` method when the shorthand syntax is used. this prevents problems with namespaces and scopes.
* Duplicate possible frozen string from routeAndrew White2013-01-211-2/+3
| | | | | | | | | | | | | Ruby 1.9 freezes Hash string keys by default so where a route is defined like this: get 'search' => 'search' then the Mapper will derive the action from the key. This blows up later when the action is added to the parameters hash and the encoding is forced. Closes #3429
* Clear url helper methods when routes are reloadedAndrew White2012-12-141-6/+12
| | | | | | | | Clear url helper methods when routes are reloaded by removing the methods explicitly rather than just clearing the module because it didn't work properly and could be the source of a memory leak. Closes #8488.
* Refactor Generator class to not rely on in-place editing the controllerAndrew White2012-11-161-5/+10
|
* Fix bug when url_for changes controller.Nikita Beloglazov2012-11-161-2/+2
|
* Fix redirect example blockCarlos Antonio da Silva2012-11-091-3/+3
| | | | See #8160. [ci skip]
* backport, handle trailing slash with enginesYves Senn2012-11-081-1/+1
| | | | this is a backport of #8115 to fix #7842
* Clear url helpers when reloading routesSantiago Pastorino2012-11-021-0/+1
|
* Revert "Merge pull request #7668 from Draiken/fix_issue_6497"Rafael Mendonça França2012-11-021-1/+1
| | | | | | | | | This reverts commit 61d5d2d8a97fd289b81991cd79dca3112e7ca135. Conflicts: actionpack/CHANGELOG.md REASON: This added a backward incompatible change.
* Merge pull request #7789 from senny/7777_resource_functions_modify_optionsRafael Mendonça França2012-10-011-2/+2
| | | | resource and resources do no longer modify passed options
* Merge pull request #7668 from Draiken/fix_issue_6497Rafael Mendonça França2012-09-191-1/+1
| | | | | | Removing to_shorthand to fix #6497 Conflicts: actionpack/CHANGELOG.md
* Add support for optional root segments containing slashesAndrew White2012-07-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Optional segments with a root scope need to have the leading slash outside of the parentheses, otherwise the generated url will be empty. However if the route has non-optional elements then the leading slash needs to remain inside the parentheses otherwise the generated url will have two leading slashes, e.g: Blog::Application.routes.draw do get '/(:category)', :to => 'posts#index', :as => :root get '/(:category)/author/:name', :to => 'posts#author', :as => :author end $ rake routes root GET /(:category)(.:format) posts#index author GET (/:category)/author/:name(.:format) posts#author This change adds support for optional segments that contain a slash, allowing support for urls like /page/2 for the root path, e.g: Blog::Application.routes.draw do get '/(page/:page)', :to => 'posts#index', :as => :root end $ rake routes root GET /(page/:page)(.:format) posts#index Fixes #7073 (cherry picked from commit d8745decaf59aad32aa2f09abdba99b8d0e48b31)
* Use to_model delegates for polymorphic route generationNathaniel Bibler2012-06-011-1/+7
|
* Don't ignore nil positional arguments for url helpers - fixes #6196.Andrew White2012-05-101-1/+1
|
* Reset the request parameters after a constraints checkAndrew White2012-05-031-0/+2
| | | | | | | | | | | | | | A callable object passed as a constraint for a route may access the request parameters as part of its check. This causes the combined parameters hash to be cached in the environment hash. If the constraint fails then any subsequent access of the request parameters will be against that stale hash. To fix this we delete the cache after every call to `matches?`. This may have a negative performance impact if the contraint wraps a large number of routes as the parameters hash is built by merging GET, POST and path parameters. Fixes #2510. (cherry picked from commit 56030506563352944fed12a6bb4793bb2462094b)
* Restore interpolation of path option in redirect routesAndrew White2012-04-291-0/+10
|
* Add missing require from b608cdd64c95d0d16eb98d86562e22f3b01be9e3Andrew White2012-04-291-0/+1
|
* Escape interpolated params when redirecting - fixes #5688Andrew White2012-04-291-1/+6
|
* Fix the redirect when it receive blocks with arity of 1.Rafael Mendonça França2012-03-311-1/+2
| | | | Closes #5677
* Fix typo in match :to docsJustin Woodbridge2012-02-251-1/+1
|
* Avoid inspecting the whole route set, closes #1525José Valim2012-02-231-0/+6
|
* Merge pull request #5084 from johndouthat/patch-1Aaron Patterson2012-02-221-2/+1
| | | | Remove reference to rails_legacy_mapper, which isn't compatible with 3.2...
* Merge pull request #4988 from kennyj/fix_4720-3Aaron Patterson2012-02-101-0/+5
| | | | Fix GH #4720. Routing problem with nested namespace and already camelized controller option.
* Fixed force_ssl redirects to include original query paramsRyan McGeary2012-02-061-0/+1
| | | | | | `ActionController.force_ssl` redirects http URLs to their https equivalent; however, when a URL contains a query string, the resulting redirect lacked the original query string.
* Merge pull request #4908 from kennyj/fix_3864José Valim2012-02-061-1/+1
| | | | Fix url_for method's behavior. GH #3684.
* Added custom regexps to ASTs that have literal nodes on either side ofAaron Patterson2012-01-231-1/+20
| | | | symbol nodes. Fixes #4585
* Revert "Named Routes shouldn't override existing ones (currently route ↵Aaron Patterson2012-01-031-1/+1
| | | | | | recognition goes with the earliest match, named routes use the latest match)" This reverts commit 71d769e3b58cb56b4b1d5143936c65be8b27c490.
* Override respond_to? since we are also overriding method_missing.José Valim2012-01-031-0/+4
|
* Documented about using :path option for resourcesKevin Moore2011-12-291-0/+7
|
* Correctly display rack apps with dynamic constraints in RoutesInspectorPiotr Sarnacki2011-12-261-1/+1
| | | | | | | | | | | | | If you used dynamic constraint like that: scope :constraint => MyConstraint.new do mount RackApp => "/foo" end routes were not displayed correctly when using `rake routes`. This commit fixes it. If you want nice display of dynamic constraints in `rake routes` output, please just override to_s method in your constraint's class.
* Do not raise an exception if an invalid route was generated automatically.José Valim2011-12-161-3/+11
|
* Move symbolize keys to the inner options as we can assume url_options will ↵José Valim2011-12-082-2/+2
| | | | be properly symbolized.
* Improve cache on route_key lookup.José Valim2011-12-081-4/+6
|
* Named Routes shouldn't override existing ones (currently route recognition ↵Andy Jeffries2011-12-051-1/+1
| | | | goes with the earliest match, named routes use the latest match)
* Fixing incorrect documentation Aviv Ben-Yosef2011-11-301-2/+2
| | | `path_names` can only be used for affecting `new` and `edit`
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2011-11-261-2/+2
|\
| * what's -> that'sUģis Ozols2011-11-251-1/+1
| |
| * Remove unnecessary comment.Uģis Ozols2011-11-251-1/+1
| |
* | Revert "copy options keys to the right place so that undo will work correctly"Aaron Patterson2011-11-191-4/+10
| | | | | | | | This reverts commit 3178cc9a80262d3bf7754f3507ef60243b46634f.
* | Warning removed for shadowing variableArun Agrawal2011-11-191-1/+1
| |
* | Revert "make sure to require the right deprecation warning file"Aaron Patterson2011-11-181-1/+0
| | | | | | | | This reverts commit 9d725e3df502a07222f35576108eb2df2bd88259.
* | Refactoring the redirect method for the router api.Aaron Patterson2011-11-181-25/+19
| |
* | moving redirection to objectsAaron Patterson2011-11-181-45/+58
| |
* | remove the :path feature to redirects, since it cannot workAaron Patterson2011-11-181-15/+7
| |
* | make sure to require the right deprecation warning fileAaron Patterson2011-11-181-0/+1
| |