Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Avoid (@_var ||= nil) pattern by using initialize methods and ensuring ↵ | José Valim | 2010-09-29 | 1 | -1/+5 |
| | | | | everyone calls super as expected. | ||||
* | Merge remote branch 'miloops/warnings' | José Valim | 2010-09-29 | 2 | -1/+2 |
|\ | |||||
| * | Use redefine_method instead define_method, it may be already defined. | Emilio Tagua | 2010-09-28 | 1 | -1/+1 |
| | | |||||
| * | Remove more warnings on variables. | Emilio Tagua | 2010-09-28 | 1 | -0/+1 |
| | | |||||
| * | Move uri parser to AS as URI.parser method to reuse it in AP and ARes. | Emilio Tagua | 2010-09-27 | 1 | -8/+2 |
| | | |||||
* | | Move uri parser to AS as URI.parser method to reuse it in AP and ARes. | Emilio Tagua | 2010-09-28 | 1 | -8/+2 |
| | | |||||
* | | Fix tests on 1.9.2. | José Valim | 2010-09-28 | 1 | -5/+0 |
| | | |||||
* | | Properly initialize variables inside the initialize method. | José Valim | 2010-09-27 | 1 | -3/+8 |
|/ | |||||
* | Define @_routes inside method, makes more sense and will be initialized when ↵ | Emilio Tagua | 2010-09-27 | 2 | -2/+1 |
| | | | | | | called anywhere. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Remove warning "URI.unescape is obsolete" from actionpack. | Emilio Tagua | 2010-09-27 | 1 | -4/+2 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Merge remote branch 'miloops/warnings' | José Valim | 2010-09-27 | 3 | -12/+24 |
|\ | | | | | | | | | Conflicts: actionpack/lib/action_controller/metal/url_for.rb | ||||
| * | Initialize @_routes if it doesn't exists. | Emilio Tagua | 2010-09-27 | 1 | -0/+1 |
| | | |||||
| * | Remove warning "too many arguments for format string" when interpolating ↵ | Emilio Tagua | 2010-09-27 | 1 | -1/+1 |
| | | | | | | | | with empty hash. | ||||
| * | Initialize @as before plural method is called. | Emilio Tagua | 2010-09-27 | 1 | -0/+1 |
| | | |||||
| * | Remove old method before redefining it. | Emilio Tagua | 2010-09-27 | 1 | -0/+2 |
| | | |||||
| * | Remove warning "URI.unescape is obsolete" from actionpack. | Emilio Tagua | 2010-09-27 | 2 | -11/+19 |
| | | |||||
* | | Convert unless/else into if/else. | thedarkone | 2010-09-27 | 1 | -4/+4 |
| | | |||||
* | | Hash#empty? is faster than Enumerable#any? when used on a Hash. | thedarkone | 2010-09-27 | 1 | -1/+1 |
| | | |||||
* | | options[:action] is very likely to be nil. | thedarkone | 2010-09-27 | 1 | -1/+1 |
| | | |||||
* | | No need to create a separate lambda for each call. | thedarkone | 2010-09-27 | 1 | -15/+14 |
|/ | |||||
* | Refactor routing methods. | Emilio Tagua | 2010-09-22 | 2 | -11/+2 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Raise ArgumentError instead of normalizing controller name when there is a ↵ | Andrew White | 2010-09-18 | 1 | -1/+5 |
| | | | | leading slash [#5651 state:resolved] | ||||
* | Remove leading slash from controller [#5651 state:resolved] | Andrew White | 2010-09-18 | 1 | -1/+1 |
| | |||||
* | Add RouteSet#append | Carl Lerche | 2010-09-17 | 1 | -4/+12 |
| | | | Allows specifying blocks to the routeset that will get appended after the RouteSet is drawn. | ||||
* | Change app to main_app in mounted_helpers | Piotr Sarnacki | 2010-09-08 | 1 | -1/+1 |
| | |||||
* | Do not require passing :app to mounted helpers, it's actually useless and ↵ | Piotr Sarnacki | 2010-09-08 | 1 | -1/+1 |
| | | | | not DRY | ||||
* | Remove a few tests from old router that do not make sense with the new one. | José Valim | 2010-09-05 | 1 | -21/+3 |
| | |||||
* | Removed deprecated_mapper - we don't need it anymore | Łukasz Strzałkowski | 2010-09-05 | 1 | -525/+0 |
| | |||||
* | Ported missing functionality from Rails 2.3.x, raise error on wrong regexps ↵ | Piotr Sarnacki | 2010-09-05 | 1 | -0/+9 |
| | | | | in :constraints in routes | ||||
* | raise error on invalid HTTP methods or :head passed with :via in routes | Piotr Sarnacki | 2010-09-05 | 1 | -0/+9 |
| | |||||
* | Implemented resources :foos, :except => :all option | Piotr Sarnacki | 2010-09-05 | 1 | -2/+11 |
| | |||||
* | Removed deprecated RouteSet API, still many tests fail | Piotr Sarnacki | 2010-09-05 | 2 | -15/+4 |
| | |||||
* | Implemented RouteSet#default_scope, which allows to set the scope for the ↵ | Piotr Sarnacki | 2010-09-03 | 2 | -2/+12 |
| | | | | entire routes object | ||||
* | Use new ActiveModel::Naming.route_key in polymorphic_routes | Piotr Sarnacki | 2010-09-03 | 1 | -11/+2 |
| | |||||
* | Add short note on using url_for instead of directly calling named route in ↵ | Piotr Sarnacki | 2010-09-03 | 1 | -0/+3 |
| | | | | polymorphic_url | ||||
* | Add possibility to explicitly call engine's routes through ↵ | Piotr Sarnacki | 2010-09-03 | 1 | -1/+20 |
| | | | | polymorphic_routes, for example: polymorphic_url([blog, @post]) | ||||
* | Move RoutesProxy to separate file | Piotr Sarnacki | 2010-09-03 | 2 | -32/+35 |
| | |||||
* | Added more tests for polymorphic_url with namespaced models and implemented ↵ | Piotr Sarnacki | 2010-09-03 | 1 | -5/+10 |
| | | | | missing use cases | ||||
* | This was used only to clear warning in ActionMailer tests, it shouldn't be ↵ | Piotr Sarnacki | 2010-09-03 | 1 | -5/+0 |
| | | | | done like that | ||||
* | Modified polymorphic_url to check for model's namespace | Piotr Sarnacki | 2010-09-03 | 1 | -0/+4 |
| | | | | | | | | | | | This change allows using namespaced models with polymorphic_url, in the way that you would use them without namespace. Let's say that you have Blog::Post model in namespaced Engine. When you use polymorphic_path with Blog::Post instances, like in form_for(@post), it will look for blog_posts_path named url helper. As we are inside Blog::Engine, it's annoying to always use the prefix. With this commit, blog_ prefix will be removed and posts_path will be called. | ||||
* | Refactor RoutesProxy to avoid using _with_routes in helpers | Piotr Sarnacki | 2010-09-03 | 2 | -1/+5 |
| | |||||
* | Refactor ActionMailer to not use hide_actions | Piotr Sarnacki | 2010-09-03 | 1 | -1/+6 |
| | |||||
* | Fix generating urls with mounted helpers in view context | Piotr Sarnacki | 2010-09-03 | 1 | -1/+1 |
| | | | | | | | | | | There were actually 2 problems with this one: * script_name was added to options as a string and then it was used in RouteSet#url_for with usage of <<, which was changing the original script_name * the second issue was with _with_routes method. It was called in RoutesProxy to modify _routes in view_context, but url_helpers in views is just delegating it to controller, so another _with_routes call is needed there | ||||
* | For view_context we need to initialize RoutesProxy in context of controller, ↵ | Piotr Sarnacki | 2010-09-03 | 1 | -2/+4 |
| | | | | not view, quick fix, I need to dig into it later | ||||
* | Add Rails::Railtie.railtie_name method to allow setting custom name for railtie | Piotr Sarnacki | 2010-09-03 | 1 | -2/+7 |
| | |||||
* | We don't need delegating polymorphic_url and polymorphic_path anymore | Piotr Sarnacki | 2010-09-03 | 1 | -10/+6 |
| | |||||
* | Add mounted_helpers to routes | Piotr Sarnacki | 2010-09-03 | 3 | -23/+69 |
| | | | | | | | | | | | | | | | | mounted_helpers are a bit similar to url_helpers. They're automatically included in controllers for Rails.application and each of mounted Engines. Mounted helper allows to call url_for and named helpers for given application. Given Blog::Engine mounted as blog_engine, there are 2 helpers defined: app and blog_engine. You can call routes for app and engine using those helpers: app.root_url app.url_for(:controller => "foo") blog_engine.posts_path blog_engine.url_for(@post) | ||||
* | Routes refactoring: | Piotr Sarnacki | 2010-09-03 | 3 | -9/+6 |
| | | | | | | | * added more tests for prefix generation * fixed bug with generating host for both prefix and url * refactored url_for method * organized tests for prefix generation | ||||
* | Extended url_for to handle specifying which router should be used. | Piotr Sarnacki | 2010-09-03 | 3 | -29/+42 |
| | | | | | | | A few examples: url_for Blog::Engine, :posts_path url_for Blog::Engine, @post url_for Blog::Engine, :action => "main", :controller => "index" | ||||
* | Get rid of :skip_prefix options in routes | Piotr Sarnacki | 2010-09-03 | 1 | -6/+3 |
| |