aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch/routing/url_for.rb
Commit message (Collapse)AuthorAgeFilesLines
* Revert "Don't handle params option in a special way in url_for helper"Rafael Mendonça França2019-01-161-0/+1
| | | | | | | | | | | This reverts commit e385e4678fc64be6e176c3bdac6641db9fe48d85. While this option was undocumented it exists to make possible to pass parameters to the route helpers that are reserved like `:domain`. While `url_for(domain: 'foo.com')` would generate a URL in the `foo.com` domain `url_for(params: { domain: 'foo.com' })` would generate a URL with `?domain=foo.com`.
* Small doc fixesT.J. Schuck2018-04-021-1/+1
| | | | [ci skip]
* Quote string return values in doc examples [ci skip]Andrew White2018-03-081-2/+2
|
* Add example of maintaining context with `route_for`Andrew White2018-03-081-0/+6
| | | | [ci skip]
* Express `ActionDispatch::Routing::UrlFor#route_for` as public apibogdanvlviv2018-03-071-1/+13
| | | | | | | | | This method was added by #28462 but marked as private api. Since `route_for` looks good in pair with `ActionDispatch::Routing::Mapper::CustomUrls#direct` let's make it as public api. We use it in https://github.com/rails/rails/blob/e83575ff533690db86c92447a539d76b648e9fed/activestorage/config/routes.rb Closes #31417
* Update incorrect backtick usage in RDoc to teletypeT.J. Schuck2017-11-221-1/+1
| | | [ci skip]
* Use tt in doc for ActionPack [ci skip]Yoshiyuki Hirano2017-08-261-1/+1
|
* Use frozen string literal in actionpack/Kir Shatrov2017-07-291-0/+2
|
* Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-021-1/+0
| | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* Enforce frozen string in RubocopKir Shatrov2017-07-011-0/+1
|
* Reuse the Parameters#to_h check in the routing helpersRafael Mendonça França2017-04-181-10/+3
| | | | | Since this protection is now in Parameters we can use it instead of reimplementing again.
* Merge pull request #28394 from shime/docs-action-dispatchXavier Noria2017-03-221-2/+2
|\ | | | | [docs] fix ActionDispatch documentation
| * [docs] fix ActionDispatch documentationHrvoje Šimić2017-03-131-2/+2
| |
* | Always use original url_for when generating direct routesAndrew White2017-03-171-0/+4
| | | | | | | | | | | | | | Action View overrides `url_for` in the view context to render paths by default when using `url_for` and this means that direct route helpers don't get the full url when called with the url suffix. To fix this always call the original `url_for`.
* | Add support for calling nested direct routes (#28462)Andrew White2017-03-171-0/+4
|/ | | | | | | | | | | | | | | | | | | | Not all requirements can be expressed in terms of polymorphic url options so add a `route_for` method that allows calling another direct route (or regular named route) which a set of arguments, e.g: resources :buckets direct :recordable do |recording| route_for(:bucket, recording.bucket) end direct :threadable do |threadable| route_for(:recordable, threadable.parent) end This maintains the context of the original caller, e.g. threadable_path(threadable) # => /buckets/1 threadable_url(threadable) # => http://example.com/buckets/1
* Privatize unneededly protected methods in Action PackAkira Matsuda2016-12-241-2/+4
|
* normalizes indentation and whitespace across the projectXavier Noria2016-08-061-12/+12
|
* Add more info to insecure URL generation errorDerek Prior2016-04-261-1/+1
| | | | | | | | I always appreciate having a bit more information as to why something is now an error. We can use this error to tell people why what they were previously doing is insecure and give them hints on how to fix it. Signed-off-by: Kasper Timm Hansen <kaspth@gmail.com>
* Use a URL instead of an URL everywhereAbhishek Jain2016-02-151-1/+1
|
* Prevent ActionController::Parameters from being passed to url_for directlyJean Boussier2015-12-151-1/+4
|
* [ci skip] Change 'an URL' to 'a URL' as URL doesn't have a vowel soundtanmay30112015-10-061-1/+1
|
* `url_for` does not modify polymorphic optionsBernerd Schaefer2015-09-041-1/+2
| | | | | | | | | | | | | | | | | The `url_for` methods in `actionpack` and `actionview` now make a copy of the provided options before generating polymorphic paths or URLs. The bug in the previous behavior is most noticeable in a case like: url_options = [:new, :post, param: 'value'] if current_page?(url_options) css_class = "active" end link_to "New Post", url_options, class: css_class
* Make AC::Parameters not inherited from HashPrem Sichanugrist2015-07-151-0/+4
| | | | | | | | This is another take at #14384 as we decided to wait until `master` is targeting Rails 5.0. This commit is implementation-complete, as it guarantees that all the public methods on the hash-inherited Parameters are still working (based on test case). We can decide to follow-up later if we want to remove some methods out from Parameters.
* [ci skip] Improve the url_for documentationRoque Pinel2015-07-011-3/+19
| | | | | | | | | Clarify the `url_for` usage in mailers. Re-add the documentation about `url_for` and Route's path parameters, first introduced by 5c4f1859970d06228a0b67cad6d4486c1526ef2a. This was reported on #15097 and until it is decided to deprecate it or not, I believe the documentation should exist.
* move _generate_paths_by_default to where it is usedAaron Patterson2015-03-011-6/+0
| | | | | _generate_paths_by_default wasn't used in AD::Routing::UrlFor, so we should be able to move it where it is used in AV::Routing
* let mailer templates generate URLs by default [Xavier Noria, Richard Schneeman]Xavier Noria2014-11-241-0/+6
|
* remove some cachingAaron Patterson2014-07-281-2/+1
| | | | | this caching doesn't increase performance, but does increase complexity. remove it for now and find better ways to speed up this code.
* pass the route name to define_url_helperAaron Patterson2014-07-171-1/+3
| | | | | this allows us to avoid 2 hash allocations per named helper definition, also we can avoid a `merge` and `delete`.
* use the helper method builder to construct helper methodsAaron Patterson2014-05-121-1/+5
|
* undo optimized calls until the builder object is finishedAaron Patterson2014-05-121-1/+1
|
* Take Hash with options inside Array in #url_forAndrey Ognevsky2013-11-151-0/+2
|
* Fix link_to return valueEarl J St Sauver2013-09-221-1/+1
| | | | | | The documentation is showing the link_to method as just returning the contents of the url_for method. It should be returning an "<a>" tag with the correct href set.
* Add script_name option description and example for #url_for optionsIvan Vanyak2012-12-171-0/+5
|
* 1.9 hash syntax changes to docsAvnerCohen2012-10-311-15/+15
|
* removed : warning: `*' interpreted as argument prefixArun Agrawal2012-08-281-1/+1
|
* Don't require action_dispatch in ActionView::UrlHelpersPiotr Sarnacki2012-08-281-0/+2
| | | | | | | | | | ActionDispatch::Routing::UrlFor was always required in UrlHelpers. This was changed by splitting previous implementation of UrlHelper into 2 modules: ActionView::Helpers::UrlHelper and ActionView::Routing::UrlHelper. The former one keeps only basic implementation of url_for. The latter adds features that allow to use routes and is only required when url_helpers or mounted_helpers are required.
* fix typo in documentationAnatoly Makarevich2012-07-261-1/+1
|
* Removing ==Examples and last blank lines of docs from actionpackFrancesco Rodriguez2012-05-151-2/+0
|
* Corrected the name of the module that should be included to get the url helpers.Anuj Dutta2012-05-031-1/+1
|
* Revert "Merge pull request #5750 from ahoward/master"Santiago Pastorino2012-04-081-10/+1
| | | | | | | This reverts commit 174cf8b22064c3999dfa685014d5b31ac993bb54, reversing changes made to 7ecd6a731bd60665bc6de94095137f0b2c4ada2a. The reverted commit improved the performance in the wrong place, now we have added this 6ddbd1844a6fd6aca2992f5f75c9f605cf89808f improvement.
* Make url_for work when option is nil and default_url_options hasRafael Mendonça França2012-04-051-1/+1
| | | | stringified keys
* url_for: avoid a nil check. unroll a loop. handle most common case 1st.ara.t.howard2012-04-051-18/+13
|
* carefully and quickly merge url_for optionsara.t.howard2012-04-041-1/+17
|
* Optimize url helpers.Sergey Nartimov + José Valim2012-03-021-2/+5
|
* Optimize path helpers.José Valim2012-03-021-0/+5
|
* Clean up routes inclusion and add some comments for the next soul that ↵José Valim2012-01-031-11/+12
| | | | decides to adventure on this code.
* just add the writer rather than adding both and removing oneAaron Patterson2011-12-291-2/+1
|
* Move symbolize keys to the inner options as we can assume url_options will ↵José Valim2011-12-081-1/+1
| | | | be properly symbolized.
* what's -> that'sUģis Ozols2011-11-251-1/+1
|
* Remove unnecessary comment.Uģis Ozols2011-11-251-1/+1
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-01 13:28:23 +0000