Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Revert "Merge pull request #5750 from ahoward/master" | Santiago Pastorino | 2012-04-08 | 1 | -10/+1 |
| | | | | | | | This reverts commit 174cf8b22064c3999dfa685014d5b31ac993bb54, reversing changes made to 7ecd6a731bd60665bc6de94095137f0b2c4ada2a. The reverted commit improved the performance in the wrong place, now we have added this 6ddbd1844a6fd6aca2992f5f75c9f605cf89808f improvement. | ||||
* | Make url_for work when option is nil and default_url_options has | Rafael Mendonça França | 2012-04-05 | 1 | -1/+1 |
| | | | | stringified keys | ||||
* | url_for: avoid a nil check. unroll a loop. handle most common case 1st. | ara.t.howard | 2012-04-05 | 1 | -18/+13 |
| | |||||
* | carefully and quickly merge url_for options | ara.t.howard | 2012-04-04 | 1 | -1/+17 |
| | |||||
* | Optimize url helpers. | Sergey Nartimov + José Valim | 2012-03-02 | 1 | -2/+5 |
| | |||||
* | Optimize path helpers. | José Valim | 2012-03-02 | 1 | -0/+5 |
| | |||||
* | Clean up routes inclusion and add some comments for the next soul that ↵ | José Valim | 2012-01-03 | 1 | -11/+12 |
| | | | | decides to adventure on this code. | ||||
* | just add the writer rather than adding both and removing one | Aaron Patterson | 2011-12-29 | 1 | -2/+1 |
| | |||||
* | Move symbolize keys to the inner options as we can assume url_options will ↵ | José Valim | 2011-12-08 | 1 | -1/+1 |
| | | | | be properly symbolized. | ||||
* | what's -> that's | Uģis Ozols | 2011-11-25 | 1 | -1/+1 |
| | |||||
* | Remove unnecessary comment. | Uģis Ozols | 2011-11-25 | 1 | -1/+1 |
| | |||||
* | :subdomain can now be specified with a value of false in url_for, allowing ↵ | Kamil Sobieraj | 2011-10-04 | 1 | -2/+3 |
| | | | | for subdomain(s) removal from the host during link generation. Closes #2025 | ||||
* | doc fixes | Vijay Dev | 2011-08-28 | 1 | -4/+8 |
| | |||||
* | We actually don't need a reverse_merge! here. dup removed was giving error ↵ | Arun Agrawal | 2011-08-12 | 1 | -1/+1 |
| | | | | with nil class. | ||||
* | when calling url_for with a hash, additional (likely unwanted) values (such ↵ | Andrew Kaspick | 2011-08-11 | 1 | -1/+1 |
| | | | | as :host) would be returned in the hash... calling #dup on the hash prevents this | ||||
* | Remove extra white spaces on ActionPack docs. | Sebastian Martinez | 2011-05-23 | 1 | -1/+1 |
| | |||||
* | Follow code conventions on docs | Sebastian Martinez | 2011-05-10 | 1 | -4/+4 |
| | |||||
* | copy-edits RDoc of 2fe43b6 | Xavier Noria | 2010-11-23 | 1 | -2/+3 |
| | |||||
* | :subdomain, :domain and :tld_length options can now be used in url_for, ↵ | Josh Kalderimis | 2010-11-23 | 1 | -0/+6 |
| | | | | | | allowing for easy manipulation of the host during link generation. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Avoid (@_var ||= nil) pattern by using initialize methods and ensuring ↵ | José Valim | 2010-09-29 | 1 | -1/+5 |
| | | | | everyone calls super as expected. | ||||
* | Remove more warnings on variables. | Emilio Tagua | 2010-09-28 | 1 | -0/+1 |
| | |||||
* | Define @_routes inside method, makes more sense and will be initialized when ↵ | Emilio Tagua | 2010-09-27 | 1 | -1/+0 |
| | | | | | | called anywhere. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Initialize @_routes if it doesn't exists. | Emilio Tagua | 2010-09-27 | 1 | -0/+1 |
| | |||||
* | Refactor RoutesProxy to avoid using _with_routes in helpers | Piotr Sarnacki | 2010-09-03 | 1 | -0/+4 |
| | |||||
* | Add mounted_helpers to routes | Piotr Sarnacki | 2010-09-03 | 1 | -21/+7 |
| | | | | | | | | | | | | | | | | mounted_helpers are a bit similar to url_helpers. They're automatically included in controllers for Rails.application and each of mounted Engines. Mounted helper allows to call url_for and named helpers for given application. Given Blog::Engine mounted as blog_engine, there are 2 helpers defined: app and blog_engine. You can call routes for app and engine using those helpers: app.root_url app.url_for(:controller => "foo") blog_engine.posts_path blog_engine.url_for(@post) | ||||
* | Routes refactoring: | Piotr Sarnacki | 2010-09-03 | 1 | -6/+4 |
| | | | | | | | * added more tests for prefix generation * fixed bug with generating host for both prefix and url * refactored url_for method * organized tests for prefix generation | ||||
* | Extended url_for to handle specifying which router should be used. | Piotr Sarnacki | 2010-09-03 | 1 | -16/+29 |
| | | | | | | | A few examples: url_for Blog::Engine, :posts_path url_for Blog::Engine, @post url_for Blog::Engine, :action => "main", :controller => "index" | ||||
* | New way of generating urls for Application from Engine. | Piotr Sarnacki | 2010-09-03 | 1 | -5/+10 |
| | | | | | | | | | It's based specifying application's script_name with: Rails.application.default_url_options = {:script_name => "/foo"} default_url_options method is delegated to routes. If router used to generate url differs from the router passed via env it always overwrites :script_name with this value. | ||||
* | Allow to generate Application routes inside Engine | Piotr Sarnacki | 2010-09-03 | 1 | -3/+3 |
| | | | | | | This requires knowledge about original SCRIPT_NAME and the parent router. It should be pass through the env as ORIGIAL_SCRIPT_NAME and action_dispatch.parent_routes | ||||
* | Use env['action_dispatch.routes'] to determine if we should generate prefix ↵ | Piotr Sarnacki | 2010-09-03 | 1 | -1/+7 |
| | | | | | | | | | | or not. This technique is here to allow using routes from Engine in Application and vice versa. When using Engine routes inside Application it should generate prefix based on mount point. When using Engine routes inside Engine it should use env['SCRIPT_NAME']. In any other case it should generate prefix as env should not be even available. | ||||
* | Expanded routing documentation with current best practices | Joost Baaij | 2010-08-29 | 1 | -5/+4 |
| | |||||
* | edit pass to apply API guideline wrt the use of "# =>" in example code | Xavier Noria | 2010-07-30 | 1 | -1/+1 |
| | |||||
* | options could be of any kind of Hash (Hash, HashWithIndifferentAccess or ↵ | Santiago Pastorino | 2010-07-21 | 1 | -1/+1 |
| | | | | OrderedHash) this way we keep the properties of the options passed as an argument | ||||
* | Moved PolymorphicRoutes to ActionDispatch::Routing | Piotr Sarnacki | 2010-07-20 | 1 | -0/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Unify routes naming by renaming router to routes | Piotr Sarnacki | 2010-07-02 | 1 | -1/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Make ActionDispatch url_for use HWIA symbolize_keys | Santiago Pastorino | 2010-04-22 | 1 | -1/+1 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Ensure that url_for uses symbolized keys in the controller. [#4391] | J Smith | 2010-04-22 | 1 | -1/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Update various documentation examples to use new routing DSL | Andrew White | 2010-04-04 | 1 | -1/+1 |
| | |||||
* | ActionController::Resources has gone away | Andrew White | 2010-03-31 | 1 | -2/+1 |
| | |||||
* | Fix a mistake in the documentation (ht: Evgeniy Dolzhenko) [#4217 ↵ | wycats | 2010-03-27 | 1 | -1/+1 |
| | | | | state:resolved] | ||||
* | skip_relative_url_root url_for option is dead | Joshua Peek | 2010-03-09 | 1 | -2/+0 |
| | |||||
* | RouteSet#rewrite => url_for | Joshua Peek | 2010-03-09 | 1 | -1/+1 |
| | |||||
* | Move AC::UrlRewriter onto route set | Joshua Peek | 2010-03-09 | 1 | -1/+1 |
| | |||||
* | Reinstate default_url_options and remove url_options= writer | Jeremy Kemper | 2010-03-08 | 1 | -47/+19 |
| | |||||
* | Now that class_attribute creates an instance method, remove it to avoid ↵ | wycats | 2010-03-08 | 1 | -1/+2 |
| | | | | deprecation warnings ;) | ||||
* | Tweak default_url_options deprecation warning | Jeremy Kemper | 2010-03-05 | 1 | -2/+2 |
| | |||||
* | Tweak out url_for uses :script_name and add some tests | Carl Lerche | 2010-03-04 | 1 | -4/+5 |
| | |||||
* | Get rid of relative_url_path in favor of respecting SCRIPT_NAME. Also added ↵ | Carlhuda | 2010-03-04 | 1 | -1/+5 |
| | | | | a way to specify a default SCRIPT_NAME when generating URLs out of the context of a request. | ||||
* | The instance_reader of default_url_options needs to not exist. | Yehuda Katz | 2010-02-27 | 1 | -0/+1 |
| | |||||
* | Change the API for setting global options for #url_for to self.url_options = ↵ | Carlhuda | 2010-02-26 | 1 | -11/+23 |
| | | | | | | { ... } This attr_accessor can be set in a before filter or in the action itself. Overwriting default_url_options still works but will output a deprecation notice. |