Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Use a URL instead of an URL everywhere | Abhishek Jain | 2016-02-15 | 1 | -1/+1 |
| | |||||
* | Prevent ActionController::Parameters from being passed to url_for directly | Jean Boussier | 2015-12-15 | 1 | -1/+4 |
| | |||||
* | [ci skip] Change 'an URL' to 'a URL' as URL doesn't have a vowel sound | tanmay3011 | 2015-10-06 | 1 | -1/+1 |
| | |||||
* | `url_for` does not modify polymorphic options | Bernerd Schaefer | 2015-09-04 | 1 | -1/+2 |
| | | | | | | | | | | | | | | | | | The `url_for` methods in `actionpack` and `actionview` now make a copy of the provided options before generating polymorphic paths or URLs. The bug in the previous behavior is most noticeable in a case like: url_options = [:new, :post, param: 'value'] if current_page?(url_options) css_class = "active" end link_to "New Post", url_options, class: css_class | ||||
* | Make AC::Parameters not inherited from Hash | Prem Sichanugrist | 2015-07-15 | 1 | -0/+4 |
| | | | | | | | | This is another take at #14384 as we decided to wait until `master` is targeting Rails 5.0. This commit is implementation-complete, as it guarantees that all the public methods on the hash-inherited Parameters are still working (based on test case). We can decide to follow-up later if we want to remove some methods out from Parameters. | ||||
* | [ci skip] Improve the url_for documentation | Roque Pinel | 2015-07-01 | 1 | -3/+19 |
| | | | | | | | | | Clarify the `url_for` usage in mailers. Re-add the documentation about `url_for` and Route's path parameters, first introduced by 5c4f1859970d06228a0b67cad6d4486c1526ef2a. This was reported on #15097 and until it is decided to deprecate it or not, I believe the documentation should exist. | ||||
* | move _generate_paths_by_default to where it is used | Aaron Patterson | 2015-03-01 | 1 | -6/+0 |
| | | | | | _generate_paths_by_default wasn't used in AD::Routing::UrlFor, so we should be able to move it where it is used in AV::Routing | ||||
* | let mailer templates generate URLs by default [Xavier Noria, Richard Schneeman] | Xavier Noria | 2014-11-24 | 1 | -0/+6 |
| | |||||
* | remove some caching | Aaron Patterson | 2014-07-28 | 1 | -2/+1 |
| | | | | | this caching doesn't increase performance, but does increase complexity. remove it for now and find better ways to speed up this code. | ||||
* | pass the route name to define_url_helper | Aaron Patterson | 2014-07-17 | 1 | -1/+3 |
| | | | | | this allows us to avoid 2 hash allocations per named helper definition, also we can avoid a `merge` and `delete`. | ||||
* | use the helper method builder to construct helper methods | Aaron Patterson | 2014-05-12 | 1 | -1/+5 |
| | |||||
* | undo optimized calls until the builder object is finished | Aaron Patterson | 2014-05-12 | 1 | -1/+1 |
| | |||||
* | Take Hash with options inside Array in #url_for | Andrey Ognevsky | 2013-11-15 | 1 | -0/+2 |
| | |||||
* | Fix link_to return value | Earl J St Sauver | 2013-09-22 | 1 | -1/+1 |
| | | | | | | The documentation is showing the link_to method as just returning the contents of the url_for method. It should be returning an "<a>" tag with the correct href set. | ||||
* | Add script_name option description and example for #url_for options | Ivan Vanyak | 2012-12-17 | 1 | -0/+5 |
| | |||||
* | 1.9 hash syntax changes to docs | AvnerCohen | 2012-10-31 | 1 | -15/+15 |
| | |||||
* | removed : warning: `*' interpreted as argument prefix | Arun Agrawal | 2012-08-28 | 1 | -1/+1 |
| | |||||
* | Don't require action_dispatch in ActionView::UrlHelpers | Piotr Sarnacki | 2012-08-28 | 1 | -0/+2 |
| | | | | | | | | | | ActionDispatch::Routing::UrlFor was always required in UrlHelpers. This was changed by splitting previous implementation of UrlHelper into 2 modules: ActionView::Helpers::UrlHelper and ActionView::Routing::UrlHelper. The former one keeps only basic implementation of url_for. The latter adds features that allow to use routes and is only required when url_helpers or mounted_helpers are required. | ||||
* | fix typo in documentation | Anatoly Makarevich | 2012-07-26 | 1 | -1/+1 |
| | |||||
* | Removing ==Examples and last blank lines of docs from actionpack | Francesco Rodriguez | 2012-05-15 | 1 | -2/+0 |
| | |||||
* | Corrected the name of the module that should be included to get the url helpers. | Anuj Dutta | 2012-05-03 | 1 | -1/+1 |
| | |||||
* | Revert "Merge pull request #5750 from ahoward/master" | Santiago Pastorino | 2012-04-08 | 1 | -10/+1 |
| | | | | | | | This reverts commit 174cf8b22064c3999dfa685014d5b31ac993bb54, reversing changes made to 7ecd6a731bd60665bc6de94095137f0b2c4ada2a. The reverted commit improved the performance in the wrong place, now we have added this 6ddbd1844a6fd6aca2992f5f75c9f605cf89808f improvement. | ||||
* | Make url_for work when option is nil and default_url_options has | Rafael Mendonça França | 2012-04-05 | 1 | -1/+1 |
| | | | | stringified keys | ||||
* | url_for: avoid a nil check. unroll a loop. handle most common case 1st. | ara.t.howard | 2012-04-05 | 1 | -18/+13 |
| | |||||
* | carefully and quickly merge url_for options | ara.t.howard | 2012-04-04 | 1 | -1/+17 |
| | |||||
* | Optimize url helpers. | Sergey Nartimov + José Valim | 2012-03-02 | 1 | -2/+5 |
| | |||||
* | Optimize path helpers. | José Valim | 2012-03-02 | 1 | -0/+5 |
| | |||||
* | Clean up routes inclusion and add some comments for the next soul that ↵ | José Valim | 2012-01-03 | 1 | -11/+12 |
| | | | | decides to adventure on this code. | ||||
* | just add the writer rather than adding both and removing one | Aaron Patterson | 2011-12-29 | 1 | -2/+1 |
| | |||||
* | Move symbolize keys to the inner options as we can assume url_options will ↵ | José Valim | 2011-12-08 | 1 | -1/+1 |
| | | | | be properly symbolized. | ||||
* | what's -> that's | Uģis Ozols | 2011-11-25 | 1 | -1/+1 |
| | |||||
* | Remove unnecessary comment. | Uģis Ozols | 2011-11-25 | 1 | -1/+1 |
| | |||||
* | :subdomain can now be specified with a value of false in url_for, allowing ↵ | Kamil Sobieraj | 2011-10-04 | 1 | -2/+3 |
| | | | | for subdomain(s) removal from the host during link generation. Closes #2025 | ||||
* | doc fixes | Vijay Dev | 2011-08-28 | 1 | -4/+8 |
| | |||||
* | We actually don't need a reverse_merge! here. dup removed was giving error ↵ | Arun Agrawal | 2011-08-12 | 1 | -1/+1 |
| | | | | with nil class. | ||||
* | when calling url_for with a hash, additional (likely unwanted) values (such ↵ | Andrew Kaspick | 2011-08-11 | 1 | -1/+1 |
| | | | | as :host) would be returned in the hash... calling #dup on the hash prevents this | ||||
* | Remove extra white spaces on ActionPack docs. | Sebastian Martinez | 2011-05-23 | 1 | -1/+1 |
| | |||||
* | Follow code conventions on docs | Sebastian Martinez | 2011-05-10 | 1 | -4/+4 |
| | |||||
* | copy-edits RDoc of 2fe43b6 | Xavier Noria | 2010-11-23 | 1 | -2/+3 |
| | |||||
* | :subdomain, :domain and :tld_length options can now be used in url_for, ↵ | Josh Kalderimis | 2010-11-23 | 1 | -0/+6 |
| | | | | | | allowing for easy manipulation of the host during link generation. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Avoid (@_var ||= nil) pattern by using initialize methods and ensuring ↵ | José Valim | 2010-09-29 | 1 | -1/+5 |
| | | | | everyone calls super as expected. | ||||
* | Remove more warnings on variables. | Emilio Tagua | 2010-09-28 | 1 | -0/+1 |
| | |||||
* | Define @_routes inside method, makes more sense and will be initialized when ↵ | Emilio Tagua | 2010-09-27 | 1 | -1/+0 |
| | | | | | | called anywhere. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Initialize @_routes if it doesn't exists. | Emilio Tagua | 2010-09-27 | 1 | -0/+1 |
| | |||||
* | Refactor RoutesProxy to avoid using _with_routes in helpers | Piotr Sarnacki | 2010-09-03 | 1 | -0/+4 |
| | |||||
* | Add mounted_helpers to routes | Piotr Sarnacki | 2010-09-03 | 1 | -21/+7 |
| | | | | | | | | | | | | | | | | mounted_helpers are a bit similar to url_helpers. They're automatically included in controllers for Rails.application and each of mounted Engines. Mounted helper allows to call url_for and named helpers for given application. Given Blog::Engine mounted as blog_engine, there are 2 helpers defined: app and blog_engine. You can call routes for app and engine using those helpers: app.root_url app.url_for(:controller => "foo") blog_engine.posts_path blog_engine.url_for(@post) | ||||
* | Routes refactoring: | Piotr Sarnacki | 2010-09-03 | 1 | -6/+4 |
| | | | | | | | * added more tests for prefix generation * fixed bug with generating host for both prefix and url * refactored url_for method * organized tests for prefix generation | ||||
* | Extended url_for to handle specifying which router should be used. | Piotr Sarnacki | 2010-09-03 | 1 | -16/+29 |
| | | | | | | | A few examples: url_for Blog::Engine, :posts_path url_for Blog::Engine, @post url_for Blog::Engine, :action => "main", :controller => "index" | ||||
* | New way of generating urls for Application from Engine. | Piotr Sarnacki | 2010-09-03 | 1 | -5/+10 |
| | | | | | | | | | It's based specifying application's script_name with: Rails.application.default_url_options = {:script_name => "/foo"} default_url_options method is delegated to routes. If router used to generate url differs from the router passed via env it always overwrites :script_name with this value. | ||||
* | Allow to generate Application routes inside Engine | Piotr Sarnacki | 2010-09-03 | 1 | -3/+3 |
| | | | | | | This requires knowledge about original SCRIPT_NAME and the parent router. It should be pass through the env as ORIGIAL_SCRIPT_NAME and action_dispatch.parent_routes |