aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch/routing/route_set.rb
Commit message (Collapse)AuthorAgeFilesLines
* Remove unused param 'separators' from RouteSet#build_pathMindaugas Mozūras2014-06-151-2/+2
|
* pass the parsed path from mapper to the StrexpAaron Patterson2014-05-291-3/+6
|
* add an alternate constructor to Strexp that takes a stringAaron Patterson2014-05-291-1/+1
|
* PARAMETERS_KEY is only used in the request, so move the constant thereAaron Patterson2014-05-271-2/+0
|
* move path_parameter encoding check to the request objectAaron Patterson2014-05-271-10/+1
|
* dispatcher doesn't need `call` anymoreAaron Patterson2014-05-271-4/+0
|
* give all endpoints a superclassAaron Patterson2014-05-271-3/+10
|
* pass a request to `matches?` so we can avoid creating excess requestsAaron Patterson2014-05-251-1/+1
|
* push is_a?(Dispatcher) check in to one placeAaron Patterson2014-05-241-5/+3
|
* Always construct route objects with Constraint objectsAaron Patterson2014-05-241-1/+1
|
* unwrap the constraints object on initialization, eliminate loopsAaron Patterson2014-05-241-1/+1
| | | | | | | Unwrap Constraints objects. I don't actually think it's possible to pass a Constraints object to this constructor, but there were multiple places that kept testing children of this object. I *think* they were just being defensive, but I have no idea.
* glob_param is never used, so rmAaron Patterson2014-05-231-8/+2
| | | | | | this also changes the constructor. We don't need to pass more options than "defaults" (whatever defaults are, ugh. probably another hash of stupid stuff).
* decouple the router object from the request classAaron Patterson2014-05-231-2/+1
|
* pass the correct custom request to the recognize methodAaron Patterson2014-05-231-1/+1
|
* pull request allocation up one frameAaron Patterson2014-05-231-1/+3
|
* stop using PARAMETERS_KEY, and use the accessor on the request objectAaron Patterson2014-05-221-1/+0
| | | | this decouples our code from the env hash a bit.
* use symbol keys for path_parametersAaron Patterson2014-05-221-2/+2
|
* middle variable is never used, so rmAaron Patterson2014-05-211-1/+1
|
* remove dead code. @klass isn't used anymoreAaron Patterson2014-05-211-1/+0
|
* reuse path formatter from the non-optimized path.Aaron Patterson2014-05-211-6/+1
| | | | | The optimized and non-optimized path share more code now without significant performance degretation
* reduce object allocationsAaron Patterson2014-05-211-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Example: x = [1,2,3,4] y = [3,2,1] def test x, y hash = {} x.zip(y) { |k,v| hash[k] = v } hash end def test2 x, y Hash[x.zip(y)] end def test3 x, y x.zip(y).each_with_object({}) { |(k,v),hash| hash[k] = v } end def stat num start = GC.stat(:total_allocated_object) num.times { yield } total_obj_count = GC.stat(:total_allocated_object) - start puts "#{total_obj_count / num} allocations per call" end stat(100) { test(x,y) } stat(100) { test2(x,y) } stat(100) { test3(x,y) } __END__ 2 allocations per call 7 allocations per call 8 allocations per call
* we don't use this parameter for anything, so rmAaron Patterson2014-05-201-1/+1
|
* fewer hash allocations when calling url_forAaron Patterson2014-05-201-9/+12
|
* fix variable names, only pass hashes to the positional args methodAaron Patterson2014-05-201-8/+10
|
* Only path requirements are relevant to optimized urlsAndrew White2014-05-151-1/+1
| | | | | The bit of URL generation that is optimized is the generation of the path so things like :host, :port, etc. are irrelevant.
* Add missing requires for require 'action_dispatch/routing'Andrew White2014-05-151-0/+2
|
* _recall should be set to a hash or not setAaron Patterson2014-05-131-2/+2
| | | | Then we can avoid nil checks
* we never call url_for with a block, so rmAaron Patterson2014-05-131-1/+0
|
* drop || test for cases that do not need itAaron Patterson2014-05-131-3/+3
|
* no need to check for presence, script names can be blankAaron Patterson2014-05-131-2/+2
|
* this method should always have a parameter passed to it, so remove the defaultAaron Patterson2014-05-131-1/+1
|
* options should always be passed to url_forAaron Patterson2014-05-131-2/+2
|
* calls with :host should still use the optimized pathAaron Patterson2014-05-131-2/+2
|
* use fewer method calls to determine the url_for optionsAaron Patterson2014-05-131-5/+4
|
* just merge instead of dup and mergeAaron Patterson2014-05-131-2/+1
|
* the :only_path option is applied by the time the helper is calledAaron Patterson2014-05-131-4/+1
|
* options already have symbolized keys, so we can avoid this callAaron Patterson2014-05-131-1/+1
|
* Get rid of unused methodCarlos Antonio da Silva2014-05-131-11/+0
| | | | It's usage has been removed in 325c9d5e5235db4b5210d9db6c863835d1ac7eed.
* avoid array allocation when extracting usernames and passwordsAaron Patterson2014-05-121-1/+7
|
* Revert "reduce conditionals in url_for"Aaron Patterson2014-05-121-6/+3
| | | | This reverts commit 9df60693d77813b362fb528fc62381ac8f1eec12.
* reduce conditionals in url_forAaron Patterson2014-05-121-3/+6
|
* make the module version quack the same as the instanceAaron Patterson2014-05-121-3/+10
| | | | this way we can stop checking respond_to on every call.
* Hash#except is expensive and this is a hotspot, so use a dup + deleteAaron Patterson2014-05-121-1/+2
|
* Make URL escaping more consistentAndrew White2014-04-201-2/+2
| | | | | | | | | | | | | | | | | | | | | | 1. Escape '%' characters in URLs - only unescaped data should be passed to URL helpers 2. Add an `escape_segment` helper to `Router::Utils` that escapes '/' characters 3. Use `escape_segment` rather than `escape_fragment` in optimized URL generation 4. Use `escape_segment` rather than `escape_path` in URL generation For point 4 there are two exceptions. Firstly, when a route uses wildcard segments (e.g. *foo) then we use `escape_path` as the value may contain '/' characters. This means that wildcard routes can't be optimized. Secondly, if a `:controller` segment is used in the path then this uses `escape_path` as the controller may be namespaced. Fixes #14629, #14636 and #14070.
* Unique the segment keys array for non-optimized url helpersAndrew White2014-01-051-1/+1
| | | | | | | | | | In Rails 3.2 you only needed pass an argument for dynamic segment once so unique the segment keys array to match the number of args. Since the number of args is less than required parts the non-optimized code path is selected. This means to benefit from optimized url generation the arg needs to be specified as many times as it appears in the path. Fixes #12808
* Show full route constraints in error messageAndrew White2014-01-051-2/+3
| | | | | | | | When an optimized helper fails to generate, show the full route constraints in the error message. Previously it would only show the contraints that were required as part of the path. Fixes #13592
* Simplify arg parameterizationAndrew White2014-01-051-6/+1
|
* Use a custom route vistor for optimized route generationAndrew White2014-01-051-27/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using a Regexp to replace dynamic segments in a path string is fraught with difficulty and can lead to odd edge cases like #13349. Since we already have a parsed representation of the path it makes sense to use that to generate an array of segments that can be used to build an optimized route's path quickly. Tests on a simple route (e.g. /posts/:id) show a speedup of 35%: https://gist.github.com/pixeltrix/8261932 Calculating ------------------------------------- Current Helper: 5274 i/100ms New Helper: 8050 i/100ms ------------------------------------------------- Current Helper: 79263.6 (±3.7%) i/s - 395550 in 4.997252s New Helper: 153464.5 (±4.9%) i/s - 772800 in 5.047834s Tests on a more complex route show even an greater performance boost: https://gist.github.com/pixeltrix/8261957 Calculating ------------------------------------- Current Helper: 2367 i/100ms New Helper: 5382 i/100ms ------------------------------------------------- Current Helper: 29506.0 (±3.2%) i/s - 149121 in 5.059294s New Helper: 78815.5 (±4.1%) i/s - 398268 in 5.062161s It also has the added benefit of fixing the edge cases described above. Fixes #13349
* Spelling and Grammar checksAkshay Vishnoi2013-12-121-1/+1
|
* Merge pull request #12216 from suginoy/a-anRafael Mendonça França2013-09-131-1/+1
|\ | | | | Fix typos: the indefinite articles(a -> an).
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-07 10:21:52 +0000