Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Recognize should also work with route is wrapped in a constraint. | José Valim | 2010-07-06 | 1 | -0/+2 |
| | |||||
* | Fixes for "router" and "routes" terminology | Wincent Colaiuta | 2010-07-03 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit f7ba614c2db improved the internal consistency of the different means of accessing routes, but it introduced some problems at the level of code comments and user-visible strings. This commit applies fixes on three levels: Firstly, we remove or replace grammatically invalid constructs such as "a routes" or "a particular routes". Secondly, we make sure that we always use "the router DSL" or "the router syntax", because this has always been the official terminology. Finally, we make sure that we only use "routes" when referring to the application-specific set of routes that are defined in the "config/routes.rb" file, we use "router" when referring on a more abstract level to "the code in Rails used to handle routing", and we use "routing" when we need an adjective to apply to nouns such as "url_helpers. Again this is consistent with historical practice and other places in the documentation. Note that this is not a sweep over the entire codebase to ensure consistent usage of language; it is just a revision of the changes introduced in commit f7ba614c2db. Signed-off-by: Wincent Colaiuta <win@wincent.com> Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Refactor recall parameter normalization [#5021 state:resolved] | Andrew White | 2010-07-03 | 1 | -16/+6 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Fix routes with :controller segment when namespaced [#5034 state:resolved] | José Valim | 2010-07-02 | 1 | -17/+33 |
| | |||||
* | Unify routes naming by renaming router to routes | Piotr Sarnacki | 2010-07-02 | 1 | -3/+3 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Tidy up valid conditions in router a bit. | José Valim | 2010-06-28 | 1 | -2/+4 |
| | |||||
* | Add :controller and :action to the list of valid conditions | Andrew White | 2010-06-28 | 1 | -0/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Remove invalid conditions from route [#4989 state:resolved] | Andrew White | 2010-06-28 | 1 | -2/+3 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Vendor unreleased rack-mount 0.6.6.pre dependency | Jeremy Kemper | 2010-06-27 | 1 | -1/+3 |
| | |||||
* | Normalize recall params when the route is not a standard route otherwise ↵ | Andrew White | 2010-06-27 | 1 | -3/+26 |
| | | | | | | :controller and :action may appear in the generated url [#4326 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | URL fragments should not have safe characters escaped. Ref: Appendix A, ↵ | Andrew White | 2010-06-25 | 1 | -1/+1 |
| | | | | | | | | http://tools.ietf.org/rfc/rfc3986.txt [#4762 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Make named helpers unprotected without becoming actions [#4696 state:resolved] | wycats | 2010-06-07 | 1 | -1/+4 |
| | |||||
* | Optimize LookupContext | wycats | 2010-06-04 | 1 | -3/+10 |
| | |||||
* | No need to unescape params twice if we came from Rack::Mount | wycats | 2010-06-04 | 1 | -7/+7 |
| | |||||
* | RouteSet does not raise ActionController::RoutingError when no routes match ↵ | Carl Lerche | 2010-04-30 | 1 | -5/+0 |
| | | | | anymore. Instead, it follows the X-Cascade convention. ShowExceptions checks for X-Cascade so that the routing error page can still be displayed. | ||||
* | add missing requires to Rescuable and RouteSet [#4415 state:committed] | Mislav Marohnić | 2010-04-16 | 1 | -0/+1 |
| | | | | Signed-off-by: Xavier Noria <fxn@hashref.com> | ||||
* | * Change the object used in routing constraints to be an instance of | wycats | 2010-04-03 | 1 | -3/+7 |
| | | | | | | | | | | | ActionDispatch::Request rather than Rack::Request. * Changed ActionDispatch::Request#method to return a String, to be compatible with the Rack::Request superclass. * Changed ActionDispatch::Request#method to return the original method in the case of methodoverride and #request_method not to, to be compatible with Rack::Request | ||||
* | Remove routing implementation details from RDoc | Andrew White | 2010-03-31 | 1 | -2/+2 |
| | |||||
* | Protect routes again so they don't end up as actions. We need a better ↵ | wycats | 2010-03-23 | 1 | -0/+1 |
| | | | | solution than this. | ||||
* | We seem to have removed the URL helpers from ActionView subclasses... | wycats | 2010-03-18 | 1 | -0/+1 |
| | |||||
* | Install url helpers on module instance so they can be accessed | Joshua Peek | 2010-03-17 | 1 | -5/+13 |
| | | | | globally | ||||
* | Do not always include the named URL helpers into AC::Base and AV::Base. | Carl Lerche | 2010-03-16 | 1 | -1/+0 |
| | |||||
* | Make RouteSet#finalize! a NOOP if it's been called already. Call finalize! ↵ | Carl Lerche | 2010-03-16 | 1 | -0/+5 |
| | | | | the first time call() and url_for() are called if the RouteSet has not been finalized yet. | ||||
* | skip_relative_url_root url_for option is dead | Joshua Peek | 2010-03-09 | 1 | -1/+1 |
| | |||||
* | Allow default_url_options to be set on route set | Joshua Peek | 2010-03-09 | 1 | -0/+4 |
| | |||||
* | RouteSet#rewrite => url_for | Joshua Peek | 2010-03-09 | 1 | -2/+1 |
| | |||||
* | Unused RouteSet#url_for is hogging a good method name | Joshua Peek | 2010-03-09 | 1 | -13/+4 |
| | |||||
* | Move AC::UrlRewriter onto route set | Joshua Peek | 2010-03-09 | 1 | -0/+56 |
| | |||||
* | Refactor the RouteSet so it uses a Generator object instead of one huge method. | wycats | 2010-03-09 | 1 | -87/+109 |
| | |||||
* | Remove outdated, distracting commented code | Jeremy Kemper | 2010-03-08 | 1 | -25/+0 |
| | |||||
* | Add support for mount RackApp, :at => "/sprockets" with a shorthand of mount ↵ | Carlhuda | 2010-03-08 | 1 | -2/+2 |
| | | | | | | | | | | Sprockets => "/sprockets". This is different from the match syntax in that it cannot be used for controller/action and it does not assume an anchor at the end of the match. For instance, in the above example, if the client asked for "/sprockets/foo.js", the Sprockets app would have a SCRIPT_NAME of "/sprockets" and PATH_INFO of "/foo.js". | ||||
* | Remove the ability to set the mountpoint when initializing a route set. | Carl Lerche | 2010-03-04 | 1 | -4/+3 |
| | |||||
* | Tweak out url_for uses :script_name and add some tests | Carl Lerche | 2010-03-04 | 1 | -6/+6 |
| | |||||
* | Have ActionDispatch::Routing::RouteSet.new ready to receive routes as is. | Carl Lerche | 2010-03-04 | 1 | -0/+1 |
| | |||||
* | Get rid of relative_url_path in favor of respecting SCRIPT_NAME. Also added ↵ | Carlhuda | 2010-03-04 | 1 | -1/+4 |
| | | | | a way to specify a default SCRIPT_NAME when generating URLs out of the context of a request. | ||||
* | Remove implicit controller namespacing from new dsl | Joshua Peek | 2010-02-28 | 1 | -22/+2 |
| | |||||
* | If IntegrationSession is initialized with an objects that responds to ↵ | Carlhuda | 2010-02-26 | 1 | -1/+0 |
| | | | | #routes, automatically extend the URL helpers from the RouteSet onto it | ||||
* | Rename named_url_helpers to url_helpers and url_helpers to url_for | Carlhuda | 2010-02-26 | 1 | -6/+5 |
| | |||||
* | Continued effort to deglobalize the router | Carlhuda | 2010-02-25 | 1 | -18/+5 |
| | |||||
* | WIP: Remove the global router | Carlhuda | 2010-02-25 | 1 | -0/+30 |
| | |||||
* | Merge master. | José Valim | 2010-02-17 | 1 | -1/+1 |
|\ | |||||
| * | rack-mount 0.5 support | Joshua Peek | 2010-02-15 | 1 | -1/+1 |
| | | |||||
* | | Make Railties tests green again. | José Valim | 2010-02-17 | 1 | -7/+12 |
| | | |||||
* | | Do not swallow controller loading errors unless required. | José Valim | 2010-02-16 | 1 | -10/+4 |
|/ | |||||
* | Routes should not swallow all NameErrors [#3862 status:resolved]. | José Valim | 2010-02-06 | 1 | -1/+2 |
| | |||||
* | Ensure namespaced controllers in engines work. | José Valim | 2010-01-24 | 1 | -21/+7 |
| | |||||
* | Respect resources_path_names and :path_names options in new dsl | Joshua Peek | 2010-01-13 | 1 | -2/+9 |
| | |||||
* | Ensure that segments in default_url_options also work with format specified. | José Valim | 2010-01-07 | 1 | -2/+2 |
| | |||||
* | From now on, parameters defined in default_url_options can be absent from ↵ | José Valim | 2010-01-07 | 1 | -21/+51 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | named routes. This allows the following setup to work: # app/controllers/application_controller.rb class ApplicationController def default_url_options(options=nil) { :locale => I18n.locale } end end # From your views and controllers: I18n.locale #=> :en users_url #=> "/en/users" users_url(:pl) #=> "/pl/users" user_url(1) #=> "/en/users/1" user_url(:pl, 1) #=> "/pl/users/1" user_url(1, :locale => :pl) #=> "/pl/users/1" If you provide all expected parameters, it still works as previously. But if any parameter is missing, it tries to assign all possible ones with the hash returned in default_url_options or the one passed straight to the named route method. Beware that default_url_options in ApplicationController is not shared with ActionMailer, so you are required to always give the locale in your email views. | ||||
* | Allow named routes to be debugged. | José Valim | 2010-01-06 | 1 | -23/+20 |
| |