Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Reset the request parameters after a constraints check | Andrew White | 2012-05-02 | 1 | -0/+2 |
| | | | | | | | | | | | | | A callable object passed as a constraint for a route may access the request parameters as part of its check. This causes the combined parameters hash to be cached in the environment hash. If the constraint fails then any subsequent access of the request parameters will be against that stale hash. To fix this we delete the cache after every call to `matches?`. This may have a negative performance impact if the contraint wraps a large number of routes as the parameters hash is built by merging GET, POST and path parameters. Fixes #2510. | ||||
* | Shadowing variable warning removed | Arun Agrawal | 2012-04-26 | 1 | -3/+3 |
| | |||||
* | Allow loading external route files from the router | Jose and Yehuda | 2012-04-25 | 1 | -0/+16 |
| | | | | | | | | | This feature enables the ability to load an external routes file from the router via: draw :filename External routes files go in +config/routes+. This feature works in both engines and applications. | ||||
* | Remove default match without specified method | Jose and Yehuda | 2012-04-24 | 1 | -2/+12 |
| | | | | | | | | | | | | | | | | In the current router DSL, using the +match+ DSL method will match all verbs for the path to the specified endpoint. In the vast majority of cases, people are currently using +match+ when they actually mean +get+. This introduces security implications. This commit disallows calling +match+ without an HTTP verb constraint by default. To explicitly match all verbs, this commit also adds a :via => :all option to +match+. Closes #5964 | ||||
* | Add missing requires in routes | Bogdan Gusiev | 2012-04-23 | 1 | -0/+1 |
| | |||||
* | Updated/changed useless tr/gsubs | Jurriaan Pruis | 2012-04-03 | 1 | -2/+2 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-03-27 | 1 | -0/+19 |
|\ | |||||
| * | add missing do [ci skip] | Vijay Dev | 2012-03-27 | 1 | -1/+1 |
| | | |||||
| * | added shallow_prefix option description in documantation | Lukasz Sarnacki | 2012-03-27 | 1 | -0/+19 |
| | | | | | | | | It is in response for confusion in issue #5301 | ||||
* | | Allow a defining custom member field on resources | Jamie Macey | 2012-03-25 | 1 | -4/+5 |
|/ | | | | | | | | | | By default, resources routes are created with :resource/:id. A model defining to_param can make prettier urls by using something more readable than an integer ID, but since the route picks it up as :id you wind up with awkward User.find_by_username(params[:id]) calls. By overriding the key to be used in @request.params you can be more obvious in your intent. | ||||
* | Add missing require | Santiago Pastorino | 2012-03-17 | 1 | -0/+1 |
| | |||||
* | Remove unused require | Santiago Pastorino | 2012-03-17 | 1 | -1/+0 |
| | |||||
* | Route root helper shortcut | Brian Cardarella | 2012-03-03 | 1 | -0/+5 |
| | | | | Allow the root route helper to accept just a string | ||||
* | Optimize path helpers. | José Valim | 2012-03-02 | 1 | -1/+5 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-02-25 | 1 | -1/+1 |
|\ | | | | | | | | | Conflicts: actionmailer/CHANGELOG.md | ||||
| * | Fix typo in match :to docs | Justin Woodbridge | 2012-02-23 | 1 | -1/+1 |
| | | |||||
* | | consistently mention first patch, then put | Xavier Noria | 2012-02-24 | 1 | -7/+7 |
| | | | | | | | | | | | | There was a mix, sometimes patch first, sometimes put first. Use always patch first, since this is going to be the primary verb for updates. | ||||
* | | uses PATCH for the forms of persisted records, and routes PATCH and PUT to ↵ | Xavier Noria | 2012-02-24 | 1 | -9/+8 |
| | | | | | | | | the update action of resources | ||||
* | | Fix routes inspection order | Rafael Mendonça França | 2012-02-22 | 1 | -2/+2 |
| | | |||||
* | | Add config.default_method_for_update to support PATCH | David Lee | 2012-02-22 | 1 | -54/+71 |
|/ | | | | | | | | | | | | | | | | PATCH is the correct HTML verb to map to the #update action. The semantics for PATCH allows for partial updates, whereas PUT requires a complete replacement. Changes: * adds config.default_method_for_update you can set to :patch * optionally use PATCH instead of PUT in resource routes and forms * adds the #patch verb to routes to detect PATCH requests * adds #patch? to Request * changes documentation and comments to indicate support for PATCH This change maintains complete backwards compatibility by keeping :put as the default for config.default_method_for_update. | ||||
* | Fix match docs | Rafael Mendonça França | 2012-02-07 | 1 | -1/+1 |
| | |||||
* | Note the ways #match may be called | Jeremy Kemper | 2012-02-05 | 1 | -0/+3 |
| | |||||
* | Revert "Deprecated multi args to http route methods" | Jeremy Kemper | 2012-02-05 | 1 | -11/+0 |
| | | | | | | | | | | Too painful to lose the compact shorthand form! This reverts commit e848c52535fa0f9488cdbdb3f1cedc7c7c02d643. Conflicts: actionpack/lib/action_dispatch/routing/mapper.rb | ||||
* | Fix typo in routing documentation | Wen-Tien Chang | 2012-02-01 | 1 | -1/+1 |
| | |||||
* | initialized the @segment_keys instance variable | Aaron Patterson | 2012-01-23 | 1 | -1/+4 |
| | |||||
* | updated the warning signature | Aaron Patterson | 2012-01-23 | 1 | -1/+1 |
| | |||||
* | Deprecated multi args to http route methods | Aaron Patterson | 2012-01-23 | 1 | -0/+11 |
| | |||||
* | stop splatting so much. We don't need :star:args everywhere | Aaron Patterson | 2012-01-20 | 1 | -7/+6 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2011-12-29 | 1 | -0/+7 |
|\ | |||||
| * | Documented about using :path option for resources | Kevin Moore | 2011-12-28 | 1 | -0/+7 |
| | | |||||
* | | Correctly display rack apps with dynamic constraints in RoutesInspector | Piotr Sarnacki | 2011-12-26 | 1 | -1/+1 |
|/ | | | | | | | | | | | | | If you used dynamic constraint like that: scope :constraint => MyConstraint.new do mount RackApp => "/foo" end routes were not displayed correctly when using `rake routes`. This commit fixes it. If you want nice display of dynamic constraints in `rake routes` output, please just override to_s method in your constraint's class. | ||||
* | remove checking for non-empty string before calling to_sym | Vasiliy Ermolovich | 2011-12-24 | 1 | -2/+1 |
| | |||||
* | Do not raise an exception if an invalid route was generated automatically. | José Valim | 2011-12-16 | 1 | -3/+11 |
| | |||||
* | Fixing incorrect documentation | Aviv Ben-Yosef | 2011-11-30 | 1 | -2/+2 |
| | | | `path_names` can only be used for affecting `new` and `edit` | ||||
* | Revert "copy options keys to the right place so that undo will work correctly" | Aaron Patterson | 2011-11-19 | 1 | -4/+10 |
| | | | | This reverts commit 3178cc9a80262d3bf7754f3507ef60243b46634f. | ||||
* | Warning removed for shadowing variable | Arun Agrawal | 2011-11-19 | 1 | -1/+1 |
| | |||||
* | copy options keys to the right place so that undo will work correctly | Aaron Patterson | 2011-11-18 | 1 | -10/+4 |
| | |||||
* | no need for type checking | Aaron Patterson | 2011-11-18 | 1 | -1/+1 |
| | |||||
* | cleaning up variable names to match method parameter names | Aaron Patterson | 2011-11-18 | 1 | -6/+8 |
| | |||||
* | stop doing is_a? checks on the resource type | Aaron Patterson | 2011-11-18 | 1 | -4/+4 |
| | |||||
* | move constants to methods since nothing else is using them | Aaron Patterson | 2011-11-18 | 1 | -6/+5 |
| | |||||
* | pushing hash validation up | Aaron Patterson | 2011-11-18 | 1 | -13/+14 |
| | |||||
* | breaking match down to smaller methods | Aaron Patterson | 2011-11-18 | 1 | -19/+22 |
| | |||||
* | some refactoring of the match method | Aaron Patterson | 2011-11-18 | 1 | -25/+17 |
| | |||||
* | Fix small typos in routing docs | Alexey Vakhov | 2011-11-03 | 1 | -1/+3 |
| | |||||
* | Fix typo in constraints method documentation | Alexey Vakhov | 2011-11-01 | 1 | -1/+1 |
| | |||||
* | Adds missing closing regex slashes. | mjy | 2011-10-25 | 1 | -2/+2 |
| | |||||
* | allow shorthand routes with nested optional parameters | Diego Carrion | 2011-10-10 | 1 | -3/+3 |
| | |||||
* | removing backwards compatibility module | Aaron Patterson | 2011-09-12 | 1 | -3/+3 |
| | |||||
* | partially expand the parameters to `match` | Aaron Patterson | 2011-09-12 | 1 | -3/+3 |
| |