Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Reset the request parameters after a constraints check | Andrew White | 2012-05-03 | 1 | -0/+2 |
| | | | | | | | | | | | | | | A callable object passed as a constraint for a route may access the request parameters as part of its check. This causes the combined parameters hash to be cached in the environment hash. If the constraint fails then any subsequent access of the request parameters will be against that stale hash. To fix this we delete the cache after every call to `matches?`. This may have a negative performance impact if the contraint wraps a large number of routes as the parameters hash is built by merging GET, POST and path parameters. Fixes #2510. (cherry picked from commit 56030506563352944fed12a6bb4793bb2462094b) | ||||
* | Fix typo in match :to docs | Justin Woodbridge | 2012-02-25 | 1 | -1/+1 |
| | |||||
* | Documented about using :path option for resources | Kevin Moore | 2011-12-29 | 1 | -0/+7 |
| | |||||
* | Correctly display rack apps with dynamic constraints in RoutesInspector | Piotr Sarnacki | 2011-12-26 | 1 | -1/+1 |
| | | | | | | | | | | | | | If you used dynamic constraint like that: scope :constraint => MyConstraint.new do mount RackApp => "/foo" end routes were not displayed correctly when using `rake routes`. This commit fixes it. If you want nice display of dynamic constraints in `rake routes` output, please just override to_s method in your constraint's class. | ||||
* | Do not raise an exception if an invalid route was generated automatically. | José Valim | 2011-12-16 | 1 | -3/+11 |
| | |||||
* | Fixing incorrect documentation | Aviv Ben-Yosef | 2011-11-30 | 1 | -2/+2 |
| | | | `path_names` can only be used for affecting `new` and `edit` | ||||
* | Revert "copy options keys to the right place so that undo will work correctly" | Aaron Patterson | 2011-11-19 | 1 | -4/+10 |
| | | | | This reverts commit 3178cc9a80262d3bf7754f3507ef60243b46634f. | ||||
* | Warning removed for shadowing variable | Arun Agrawal | 2011-11-19 | 1 | -1/+1 |
| | |||||
* | copy options keys to the right place so that undo will work correctly | Aaron Patterson | 2011-11-18 | 1 | -10/+4 |
| | |||||
* | no need for type checking | Aaron Patterson | 2011-11-18 | 1 | -1/+1 |
| | |||||
* | cleaning up variable names to match method parameter names | Aaron Patterson | 2011-11-18 | 1 | -6/+8 |
| | |||||
* | stop doing is_a? checks on the resource type | Aaron Patterson | 2011-11-18 | 1 | -4/+4 |
| | |||||
* | move constants to methods since nothing else is using them | Aaron Patterson | 2011-11-18 | 1 | -6/+5 |
| | |||||
* | pushing hash validation up | Aaron Patterson | 2011-11-18 | 1 | -13/+14 |
| | |||||
* | breaking match down to smaller methods | Aaron Patterson | 2011-11-18 | 1 | -19/+22 |
| | |||||
* | some refactoring of the match method | Aaron Patterson | 2011-11-18 | 1 | -25/+17 |
| | |||||
* | Fix small typos in routing docs | Alexey Vakhov | 2011-11-03 | 1 | -1/+3 |
| | |||||
* | Fix typo in constraints method documentation | Alexey Vakhov | 2011-11-01 | 1 | -1/+1 |
| | |||||
* | Adds missing closing regex slashes. | mjy | 2011-10-25 | 1 | -2/+2 |
| | |||||
* | allow shorthand routes with nested optional parameters | Diego Carrion | 2011-10-10 | 1 | -3/+3 |
| | |||||
* | removing backwards compatibility module | Aaron Patterson | 2011-09-12 | 1 | -3/+3 |
| | |||||
* | partially expand the parameters to `match` | Aaron Patterson | 2011-09-12 | 1 | -3/+3 |
| | |||||
* | Merge pull request #2577 from rails-noob/master | Santiago Pastorino | 2011-09-06 | 1 | -1/+3 |
|\ | | | | | Fix double slash at start of paths when mounting an engine at the root. | ||||
| * | Fix bug #2579. | rails-noob | 2011-09-06 | 1 | -1/+3 |
| | | | | | | | | Avoids double slash at start of paths when mounting an engine at the root. | ||||
* | | if ... nil? is more expensive than unless | Milan Dobrota | 2011-09-04 | 1 | -1/+1 |
| | | |||||
* | | Fix name of parent resource params when declaring nested resources at routes | Carlos Paramio | 2011-09-01 | 1 | -6/+6 |
|/ | |||||
* | Merge pull request #2327 from cesario/patch-1 | José Valim | 2011-07-28 | 1 | -1/+0 |
|\ | | | | | We don't need to require erb here. | ||||
| * | We don't need to require erb here. | Franck Verrot | 2011-07-28 | 1 | -1/+0 |
| | | |||||
* | | Merge pull request #2330 from thedarkone/resources-router-fix | José Valim | 2011-07-28 | 1 | -8/+7 |
|\ \ | |/ |/| | Inline resources router fix | ||||
| * | Make use of the inherited initializer. | thedarkone | 2011-07-28 | 1 | -3/+2 |
| | | |||||
| * | There is no need to be destructive with the passed-in options. | thedarkone | 2011-07-28 | 1 | -6/+6 |
| | | | | | | | | This fixes a bug that is caused by Resource/SingletonResource mangling resource options when using inline "multi"-resource declarations. | ||||
* | | simplify conditionals by assuming hash values will never be `false` | Aaron Patterson | 2011-07-26 | 1 | -10/+2 |
| | | |||||
* | | use regular ruby rather than clever ruby | Aaron Patterson | 2011-07-26 | 1 | -3/+3 |
| | | |||||
* | | fixing wildcard path matching when wildcard is inside parenthesis | Aaron Patterson | 2011-07-26 | 1 | -1/+1 |
| | | |||||
* | | Allow a route to have :format => true | Erik Michaels-Ober | 2011-07-25 | 1 | -0/+2 |
| | | | | | | | | | | | | When format is true, it is mandatory (as opposed to :format => false). This is currently not possible with resource routes, which automatically make format optional by default. | ||||
* | | Ensure the constraints block is only applied to the correct route | Dave Rogers | 2011-07-25 | 1 | -6/+5 |
|/ | | | | | addresses issue #1907 - any routes that follow a route with a constraints block are inheriting the previous route's constraints. | ||||
* | Better formatting of route requirements in rake:routes. | Hendy Tanata | 2011-07-16 | 1 | -7/+7 |
| | | | | | | | | | | Previously it was: {:controller=>"photos", :action=>"show", :id=>/[A-Z]\d{5}/} Now it becomes: photos#show {:id=>/[A-Z]\d{5}/} | ||||
* | Removed warning while running test with ruby 1.9.2 | bagwanpankaj | 2011-06-14 | 1 | -1/+1 |
| | |||||
* | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2011-06-11 | 1 | -3/+3 |
|\ | |||||
| * | shallow_path example updated | ganesh | 2011-06-10 | 1 | -3/+3 |
| | | |||||
* | | removed the unnecessary back slashes from the regular expression | Raghunadh | 2011-06-10 | 1 | -2/+2 |
| | | |||||
* | | rafactored the regex related code in the mapper class | Raghunadh | 2011-06-07 | 1 | -4/+7 |
|/ | |||||
* | fix creating an empty route on 1.8. Closes #1210 | Damien Mathieu | 2011-06-01 | 1 | -1/+3 |
| | |||||
* | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2011-05-25 | 1 | -7/+7 |
|\ | | | | | | | | | | | Conflicts: actionmailer/lib/action_mailer/base.rb activesupport/lib/active_support/core_ext/kernel/requires.rb | ||||
| * | Remove extra white spaces on ActionPack docs. | Sebastian Martinez | 2011-05-23 | 1 | -1/+1 |
| | | |||||
| * | Fixed documentation for scope with path. | Anuj Dutta | 2011-05-22 | 1 | -2/+2 |
| | | |||||
| * | fixes code highlight in shallow_path example | Diego Plentz | 2011-05-19 | 1 | -4/+4 |
| | | |||||
* | | Correct example and expand on description of :shallow option for resources | Andrew White | 2011-05-21 | 1 | -3/+7 |
|/ | |||||
* | minor edits after going through what's new in docrails | Xavier Noria | 2011-05-14 | 1 | -2/+2 |
| | |||||
* | Missing an end in routing docs | James Miller | 2011-05-09 | 1 | -0/+1 |
| |