Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | add help text to routing error | schneems | 2011-12-17 | 1 | -8/+13 |
| | | | | | | When a newcomer hits the routing error page they are often confused about how to trouble shoot the next step. Adding a simple help text can gently remind coders where to get more help. | ||||
* | ShowExceptions should understand X-Cascade responses from exceptions app. | José Valim | 2011-12-16 | 3 | -6/+16 |
| | |||||
* | Improve the specs on exceptions app. | José Valim | 2011-12-16 | 1 | -1/+6 |
| | |||||
* | Extract the rendering of public exceptions pages into a Rack app. | José Valim | 2011-12-16 | 2 | -33/+48 |
| | |||||
* | Get rid of the close checks since we cannot reliably close the session anyway. | José Valim | 2011-12-16 | 4 | -27/+0 |
| | |||||
* | Close the response body on cascade pass, closes #3975. | José Valim | 2011-12-14 | 1 | -0/+2 |
| | |||||
* | log exception backtrace when all backtrace lines silenced | Sergey Nartimov | 2011-12-13 | 1 | -1/+4 |
| | |||||
* | Allow reloader to be configured. | José Valim | 2011-12-12 | 1 | -14/+38 |
| | |||||
* | Fix failing cascade exception. | José Valim | 2011-12-03 | 2 | -2/+3 |
| | |||||
* | Try to play nice with plugins doing monkey patches. | José Valim | 2011-12-02 | 1 | -0/+5 |
| | |||||
* | Split and improve show and debug exceptions middlewares. | José Valim | 2011-12-01 | 1 | -11/+11 |
| | |||||
* | Split ShowExceptions responsibilities in two middlewares. | José Valim | 2011-12-01 | 3 | -82/+106 |
| | |||||
* | Add a deprecation to old show exceptions API (even though it was not public). | José Valim | 2011-12-01 | 1 | -0/+14 |
| | |||||
* | Add an ExceptionWrapper that wraps an exception and provide convenience helpers. | José Valim | 2011-12-01 | 2 | -74/+100 |
| | |||||
* | Allow rescue responses to be configured through a railtie. | José Valim | 2011-12-01 | 1 | -8/+4 |
| | |||||
* | put backtrace_cleaner to env | lest | 2011-11-28 | 1 | -13/+13 |
| | |||||
* | middlewares should use logger from env | lest | 2011-11-25 | 2 | -9/+13 |
| | |||||
* | configuration option to always write cookie | lest | 2011-11-23 | 1 | -1/+4 |
| | |||||
* | Remove unreachable code, and add additional testcases. | kennyj | 2011-11-24 | 1 | -6/+1 |
| | |||||
* | deprecation warning, changelog entry | lest | 2011-11-22 | 1 | -1/+3 |
| | |||||
* | add ActionController::Metal#show_detailed_exceptions? | lest | 2011-11-22 | 1 | -9/+7 |
| | |||||
* | It should be @calculated_ip not @calculate_ip | Arun Agrawal | 2011-11-17 | 1 | -1/+1 |
| | | | | We are using @calculated_ip. @calculate_ip is no where used | ||||
* | Initialize our instance variables. | Aaron Patterson | 2011-11-16 | 1 | -1/+3 |
| | |||||
* | Merge pull request #3649 from indirect/remote_ip | Aaron Patterson | 2011-11-16 | 1 | -3/+6 |
|\ | | | | | Fixes for Request#remote_ip (no middleware, all proxies) | ||||
| * | :facepalm: Request#remote_ip has to work without the middleware | Andre Arko | 2011-11-16 | 1 | -1/+1 |
| | | |||||
| * | Revert "Revert "Merge pull request #3640 from indirect/remote_ip"" | Andre Arko | 2011-11-16 | 1 | -3/+6 |
| | | | | | | | | This reverts commit 8d1a2b3ecde5a8745b3eaab4763a71d80ca3441f, because I have fixed the issues this commit caused in the next commit. | ||||
* | | Merge pull request #3500 from olivierlacan/error-whitespace | Jon Leighton | 2011-11-16 | 1 | -0/+1 |
|\ \ | |/ |/| | CSS fix to prevent error output from being breaking out of body element. | ||||
| * | CSS fix to prevent error output from being breaking out of body element. | Olivier Lacan | 2011-11-03 | 1 | -0/+1 |
| | | | | | | | | | | | | | | | | | | Using the white-space: pre-wrap adds extra line breaks to prevent the text from breaking out of the element's box. In this case single line output can be extremely long, breaking out the <body> element. See for reference: http://www.quirksmode.org/css/whitespace.html Before: http://link.olivierlacan.com/BVU4 After: http://link.olivierlacan.com/BUfM | ||||
* | | Revert "Merge pull request #3640 from indirect/remote_ip" | Jon Leighton | 2011-11-15 | 1 | -6/+3 |
| | | | | | | | | | | | | | | | | This reverts commit 6491aadc525b8703708e0fd0fbf05bd436a47801, reversing changes made to 83bf0b626cf2134260903e57d74f67de57384073. See https://github.com/rails/rails/pull/3640#issuecomment-2752761 for explanation. | ||||
* | | GetIp#to_s should never return nil. That's icky. | Andre Arko | 2011-11-14 | 1 | -3/+6 |
| | | |||||
* | | memoize the relatively expensive remote IP code | Andre Arko | 2011-11-14 | 1 | -1/+7 |
| | | |||||
* | | cleaner names | Andre Arko | 2011-11-14 | 1 | -6/+6 |
| | | |||||
* | | remove ignored flag, fixes warnings | Andre Arko | 2011-11-13 | 1 | -1/+1 |
| | | |||||
* | | turns out the tests expect remote_addrs.first | Andre Arko | 2011-11-13 | 1 | -1/+1 |
| | | |||||
* | | correctly raise IpSpoofAttackError message | Andre Arko | 2011-11-13 | 1 | -2/+2 |
| | | |||||
* | | defer calculating the remote IP until requested | Andre Arko | 2011-11-12 | 1 | -24/+36 |
| | | |||||
* | | refactor RemoteIp middleware | Andre Arko | 2011-11-11 | 1 | -37/+44 |
|/ | | | | | | | | | | | - return the last forwarded IP before REMOTE_ADDR to handle proxies - remove completely superfluous RemoteIpGetter class - remove duplication of trusted proxies regexp - remove unused constant from Request - move comments from Request to where they are actually relevant - edit comments for clarity of purpose The original code (confusingly) tried to return REMOTE_ADDR both at the beginning and the end of the chain of options. Since REMOTE_ADDR is _always_ set, this is kind of silly. This change leaves REMOTE_ADDR as the last option, so that proxied requests will be assigned the correct remote IP address. | ||||
* | Add ActionDispatch::Session::CacheStore as a generic way of storing sessions ↵ | Brian Durand | 2011-10-21 | 1 | -0/+50 |
| | | | | in a cache. | ||||
* | Remove the unneeded `\d` when sanitizing `X-Request-Id`. | Marc Bowes | 2011-10-20 | 1 | -1/+1 |
| | |||||
* | Load object/blank and make use of presence. | José Valim | 2011-10-19 | 1 | -2/+3 |
| | |||||
* | Make tests run on 1.8.x, add integration setup. | José Valim | 2011-10-19 | 1 | -3/+2 |
| | |||||
* | Blah, SecureRandom#uuid is not supported in 1.8.7 -- cant wait for Rails 4.0 ↵ | David Heinemeier Hansson | 2011-10-19 | 1 | -1/+1 |
| | | | | to drop compatibility with 1.8.x | ||||
* | Require missing string access dependency. | José Valim | 2011-10-19 | 1 | -0/+1 |
| | |||||
* | Require securerandom as it is the proper dependency. | José Valim | 2011-10-19 | 1 | -1/+1 |
| | |||||
* | Added X-Request-Id tracking and TaggedLogging to easily log that and other ↵ | David Heinemeier Hansson | 2011-10-19 | 1 | -0/+38 |
| | | | | production concerns | ||||
* | Remove superfluous assignment in cookies | Alexey Vakhov | 2011-10-18 | 1 | -1/+1 |
| | |||||
* | Add some implementation docs. closes #3298. closes #2509. | José Valim | 2011-10-12 | 1 | -0/+4 |
| | |||||
* | Deprecate passing the template handler in the template name. | José Valim | 2011-09-22 | 1 | -2/+2 |
| | | | | | | For example, calling hello.erb is now deprecated. Since Rails 3.0 passing the handler had no effect whatsover. This commit simply deprecates such cases so we can clean up the code in later releases. | ||||
* | CookieJar is enumerable. fixes #2795 | Aaron Patterson | 2011-09-01 | 1 | -0/+5 |
| | |||||
* | Split long string into multiple shorter ones | Daniel Schierbeck | 2011-08-29 | 1 | -1/+4 |
| | | | This makes the code more readable. |