Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | refactor RemoteIp middleware | Andre Arko | 2011-11-11 | 1 | -37/+44 |
| | | | | | | | | | | | - return the last forwarded IP before REMOTE_ADDR to handle proxies - remove completely superfluous RemoteIpGetter class - remove duplication of trusted proxies regexp - remove unused constant from Request - move comments from Request to where they are actually relevant - edit comments for clarity of purpose The original code (confusingly) tried to return REMOTE_ADDR both at the beginning and the end of the chain of options. Since REMOTE_ADDR is _always_ set, this is kind of silly. This change leaves REMOTE_ADDR as the last option, so that proxied requests will be assigned the correct remote IP address. | ||||
* | Add ActionDispatch::Session::CacheStore as a generic way of storing sessions ↵ | Brian Durand | 2011-10-21 | 1 | -0/+50 |
| | | | | in a cache. | ||||
* | Remove the unneeded `\d` when sanitizing `X-Request-Id`. | Marc Bowes | 2011-10-20 | 1 | -1/+1 |
| | |||||
* | Load object/blank and make use of presence. | José Valim | 2011-10-19 | 1 | -2/+3 |
| | |||||
* | Make tests run on 1.8.x, add integration setup. | José Valim | 2011-10-19 | 1 | -3/+2 |
| | |||||
* | Blah, SecureRandom#uuid is not supported in 1.8.7 -- cant wait for Rails 4.0 ↵ | David Heinemeier Hansson | 2011-10-19 | 1 | -1/+1 |
| | | | | to drop compatibility with 1.8.x | ||||
* | Require missing string access dependency. | José Valim | 2011-10-19 | 1 | -0/+1 |
| | |||||
* | Require securerandom as it is the proper dependency. | José Valim | 2011-10-19 | 1 | -1/+1 |
| | |||||
* | Added X-Request-Id tracking and TaggedLogging to easily log that and other ↵ | David Heinemeier Hansson | 2011-10-19 | 1 | -0/+38 |
| | | | | production concerns | ||||
* | Remove superfluous assignment in cookies | Alexey Vakhov | 2011-10-18 | 1 | -1/+1 |
| | |||||
* | Add some implementation docs. closes #3298. closes #2509. | José Valim | 2011-10-12 | 1 | -0/+4 |
| | |||||
* | Deprecate passing the template handler in the template name. | José Valim | 2011-09-22 | 1 | -2/+2 |
| | | | | | | For example, calling hello.erb is now deprecated. Since Rails 3.0 passing the handler had no effect whatsover. This commit simply deprecates such cases so we can clean up the code in later releases. | ||||
* | CookieJar is enumerable. fixes #2795 | Aaron Patterson | 2011-09-01 | 1 | -0/+5 |
| | |||||
* | Split long string into multiple shorter ones | Daniel Schierbeck | 2011-08-29 | 1 | -1/+4 |
| | | | This makes the code more readable. | ||||
* | TODO fix explicitly loading exceptations, autoload removed | Vishnu Atrai | 2011-07-11 | 1 | -0/+1 |
| | |||||
* | Add has_key? and key? methods to CookieJar removed in 0ca69ca65f83b4bb34f8 | José Valim | 2011-06-30 | 1 | -0/+5 |
| | |||||
* | Revert "Delegate to @flashes with 'delegate' instead of manually." | Aaron Patterson | 2011-06-29 | 1 | -2/+24 |
| | | | | This reverts commit 701e8554a8f69b0c81fe794cba985bfda804161b. | ||||
* | Delegate to @flashes with 'delegate' instead of manually. | Ben Orenstein | 2011-06-29 | 1 | -24/+2 |
| | |||||
* | remove warning: assigned but unused variable | Santiago Pastorino | 2011-06-08 | 1 | -1/+1 |
| | |||||
* | Add backward compatibility for testing cookies | Andrew White | 2011-06-05 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | This commit restores the ability to assign cookies for testing via @request.env['HTTP_COOKIE'] and @request.cookies, e.g: @request.env['HTTP_COOKIE'] = 'user_name=david' get :index assert_equal 'david', cookies[:user_name] and @request.cookies[:user_name] = 'david' get :index assert_equal 'david', cookies[:user_name] Assigning via cookies[] is the preferred method and will take precedence over the other two methods. This is so that cookies set in controller actions have precedence and are carried over between calls to get, post, etc. | ||||
* | Ensure cookie keys are strings | Andrew White | 2011-06-05 | 1 | -2/+3 |
| | |||||
* | Refactor ActionController::TestCase cookies | Andrew White | 2011-06-04 | 1 | -0/+10 |
| | | | | | | | | | | | | | | | | | | Assigning cookies for test cases should now use cookies[], e.g: cookies[:email] = 'user@example.com' get :index assert_equal 'user@example.com', cookies[:email] To clear the cookies, use clear, e.g: cookies.clear get :index assert_nil cookies[:email] We now no longer write out HTTP_COOKIE and the cookie jar is persistent between requests so if you need to manipulate the environment for your test you need to do it before the cookie jar is created. | ||||
* | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2011-05-25 | 1 | -1/+1 |
|\ | | | | | | | | | | | Conflicts: actionmailer/lib/action_mailer/base.rb activesupport/lib/active_support/core_ext/kernel/requires.rb | ||||
| * | Remove extra white spaces on ActionPack docs. | Sebastian Martinez | 2011-05-23 | 1 | -1/+1 |
| | | |||||
* | | removed deprecated methods, and related tests, from ActionPack | Josh Kalderimis | 2011-05-24 | 2 | -9/+2 |
| | | |||||
* | | Remove extra white-space on some exception messages. | Sebastian Martinez | 2011-05-23 | 1 | -1/+1 |
| | | |||||
* | | Replace references to ActiveSupport::SecureRandom with just SecureRandom, ↵ | Jon Leighton | 2011-05-23 | 2 | -2/+2 |
| | | | | | | | | and require 'securerandom' from the stdlib when active support is required. | ||||
* | | fixing sym and string cookie name, two cookies to browser bug. | steve | 2011-05-19 | 1 | -3/+3 |
|/ | |||||
* | Don't pluralize, camelize. | José Valim | 2011-05-06 | 1 | -1/+1 |
| | |||||
* | Only show dump of regular env methods on exception screen (not all the rack ↵ | David Heinemeier Hansson | 2011-05-04 | 1 | -1/+1 |
| | | | | crap) [DHH] | ||||
* | Fix renew feature on cookies. | José Valim | 2011-05-04 | 1 | -1/+1 |
| | |||||
* | cache strings in the AST for faster comparison than include? | Aaron Patterson | 2011-05-03 | 1 | -6/+3 |
| | |||||
* | Sets the HTTP charset parameter for rescue response. | Matias Korhonen | 2011-05-03 | 1 | -1/+1 |
| | |||||
* | Rescues template HTML5 doctype and the utf8 charset meta tag, and better ↵ | Matias Korhonen | 2011-05-03 | 1 | -2/+4 |
| | | | | font choices for Mac users. | ||||
* | Static middleware accepts cache control. | José Valim | 2011-05-03 | 1 | -4/+4 |
| | |||||
* | show http method in routing error message | Schneems | 2011-04-23 | 1 | -1/+1 |
| | |||||
* | Use initialize_copy! to proper initialize now on clone. | José Valim | 2011-04-19 | 1 | -15/+18 |
| | |||||
* | Don't reuse a closed flash when using now | Florent Piteau | 2011-04-20 | 1 | -1/+5 |
| | |||||
* | Do not inherit from Rack::Response, remove a shit-ton of unused code. | José Valim | 2011-04-19 | 1 | -0/+1 |
| | |||||
* | Be sure to not store the closed flash in the session. | José Valim | 2011-04-19 | 1 | -16/+25 |
| | |||||
* | Make static faster as we don't have to serve multiple paths anymore. | José Valim | 2011-04-15 | 1 | -28/+15 |
| | |||||
* | generated session ids should be encoded as UTF-8 | Aaron Patterson | 2011-04-14 | 1 | -1/+3 |
| | |||||
* | Merge branch 'master' of github.com:rails/rails | Aaron Patterson | 2011-04-07 | 1 | -1/+1 |
|\ | | | | | | | | | | | | | | | | | | | * 'master' of github.com:rails/rails: Cache flash now Revert "Use freeze instead of close!" Revert "Eagerly load Signed and Permanent cookies" cookies here Eagerly load Signed and Permanent cookies Use freeze instead of close! | ||||
| * | Cache flash now | Santiago Pastorino | 2011-04-07 | 1 | -1/+1 |
| | | |||||
| * | Revert "Use freeze instead of close!" | Santiago Pastorino | 2011-04-07 | 2 | -5/+14 |
| | | | | | | | | This reverts commit 29592a7f09dda2e7e1e0a915d9230fe6a9b5c0af. | ||||
| * | Revert "Eagerly load Signed and Permanent cookies" | Santiago Pastorino | 2011-04-07 | 1 | -17/+10 |
| | | | | | | | | This reverts commit dffeda377021ba8691381195f5a2889f8e040b93. | ||||
| * | Eagerly load Signed and Permanent cookies | Santiago Pastorino | 2011-04-07 | 1 | -10/+17 |
| | | |||||
| * | Use freeze instead of close! | Santiago Pastorino | 2011-04-06 | 2 | -14/+5 |
| | | |||||
* | | getting the flash hash under test | Aaron Patterson | 2011-04-06 | 1 | -0/+4 |
| | | |||||
* | | favor composition over inheritance, have FlashHash delegate to a Hash | Aaron Patterson | 2011-04-06 | 1 | -7/+40 |
|/ |