aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch/middleware/show_exceptions.rb
Commit message (Collapse)AuthorAgeFilesLines
* Enable `Layout/EmptyLinesAroundAccessModifier` copRyuta Kamizono2019-06-131-1/+0
| | | | | | | | | | | We sometimes say "✂️ newline after `private`" in a code review (e.g. https://github.com/rails/rails/pull/18546#discussion_r23188776, https://github.com/rails/rails/pull/34832#discussion_r244847195). Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style `EnforcedStyle: only_before` (https://github.com/rubocop-hq/rubocop/pull/7059). That cop and enforced style will reduce the our code review cost.
* Fixed a bug where the debug view does not show the error page properlyYuki Nishijima2019-01-241-1/+1
| | | | | | | | | | | | | | | | | | | | | There are two cases where the debug view does not show the error details properly: * When the cause is mapped to an HTTP status code the last exception is unexpectedly uwrapped * When the last error is thrown from a view template the debug view is not using the `rescues/template_error.html.erb` to generate the view Both the cases could be fixed by not unwrapping the exception. The only case where the exception should be unwrapped is when the last error is an `ActionView::Template::Error` object. In this case the HTTP status code is determined based on the cause. There are actually more wrapper exceptions that are intentionally thrown. However, there is a consistent pattern of setting the original message and original backtrace to the wrapper exception implemented, so the debug view will not lose the information about what went wrong eariler.
* [Action Pack] require => require_relativeAkira Matsuda2017-10-211-2/+2
| | | | | This basically reverts e9fca7668b9eba82bcc832cb0061459703368397, d08da958b9ae17d4bbe4c9d7db497ece2450db5f, d1fe1dcf8ab1c0210a37c2a78c1ee52cf199a66d, and 68eaf7b4d5f2bb56d939f71c5ece2d61cf6680a3
* Use frozen string literal in actionpack/Kir Shatrov2017-07-291-0/+2
|
* [Action Dispatch] require => require_relativeAkira Matsuda2017-07-011-2/+2
|
* [docs] fix ActionDispatch documentationHrvoje Šimić2017-03-131-1/+1
|
* Add three new rubocop rulesRafael Mendonça França2016-08-161-1/+1
| | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
* normalizes indentation and whitespace across the projectXavier Noria2016-08-061-16/+16
|
* applies new string literal convention in actionpack/libXavier Noria2016-08-061-5/+5
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* use methods on the request object instead of accessing envAaron Patterson2015-08-231-7/+7
|
* ask the request if we should show exceptionsAaron Patterson2015-08-061-3/+4
| | | | | hide the env key in the request object so that other code doesn't need to know.
* ExceptionWrapper doesn't need to know about `env`Aaron Patterson2015-08-061-1/+2
| | | | | | ExceptionWrapper only cares about the backtrace cleaner, so lets just pass the cleaner to the wrapper. It does not need to know that env exists or what key the backtrace cleaner is stored in
* Stash original path in `ShowExceptions` middlewareGrey Baker2014-07-141-0/+1
| | | | | | | | | | `ActionDispatch::ShowExceptions` overwrites `PATH_INFO` with the status code for the exception defined in `ExceptionWrapper`, so the path the user was visiting when an exception occurred was not previously available to any custom exceptions_app. The original `PATH_INFO` is now stashed in `env["action_dispatch.original_path"]`.
* Remove surprise if from show_exception middlewarePrem Sichanugrist2013-10-271-2/+5
| | | This increase the readability within the rescue block.
* refactor ShowExceptions' #call to use def-rescue instead of begin-rescueGosha Arinich2013-01-071-7/+4
|
* Reduce number of Strings a bitAkira Matsuda2013-01-071-3/+3
|
* Add ensure block to make sure the state is properly restoredCarlos Antonio da Silva2012-11-041-1/+1
|
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-10-111-1/+1
|\ | | | | | | | | | | Conflicts: activerecord/lib/active_record/persistence.rb railties/lib/rails/generators/rails/resource_route/resource_route_generator.rb
| * Space between "every" and "time"schneems2012-10-021-1/+1
| |
* | Failsafe exception returns text/plain.Steve Klabnik2012-10-011-3/+3
|/ | | | | | | It's best to just return text/plain when something has gone terribly wrong. Fixes #5660.
* Whitespaces :scissors:Rafael Mendonça França2012-03-171-1/+1
|
* remove status_code from AD::ShowExceptions and useless requiresSergey Nartimov2011-12-211-6/+0
|
* Remove deprecation warnings from Action Pack.José Valim2011-12-201-25/+1
|
* ShowExceptions should understand X-Cascade responses from exceptions app.José Valim2011-12-161-4/+15
|
* Improve the specs on exceptions app.José Valim2011-12-161-1/+6
|
* Extract the rendering of public exceptions pages into a Rack app.José Valim2011-12-161-33/+18
|
* Fix failing cascade exception.José Valim2011-12-031-1/+1
|
* Try to play nice with plugins doing monkey patches.José Valim2011-12-021-0/+5
|
* Split and improve show and debug exceptions middlewares.José Valim2011-12-011-11/+11
|
* Split ShowExceptions responsibilities in two middlewares.José Valim2011-12-011-82/+28
|
* Add a deprecation to old show exceptions API (even though it was not public).José Valim2011-12-011-0/+14
|
* Add an ExceptionWrapper that wraps an exception and provide convenience helpers.José Valim2011-12-011-74/+23
|
* Allow rescue responses to be configured through a railtie.José Valim2011-12-011-8/+4
|
* put backtrace_cleaner to envlest2011-11-281-13/+13
|
* middlewares should use logger from envlest2011-11-251-6/+10
|
* deprecation warning, changelog entrylest2011-11-221-1/+3
|
* add ActionController::Metal#show_detailed_exceptions?lest2011-11-221-9/+7
|
* Deprecate passing the template handler in the template name.José Valim2011-09-221-2/+2
| | | | | | For example, calling hello.erb is now deprecated. Since Rails 3.0 passing the handler had no effect whatsover. This commit simply deprecates such cases so we can clean up the code in later releases.
* TODO fix explicitly loading exceptations, autoload removedVishnu Atrai2011-07-111-0/+1
|
* Sets the HTTP charset parameter for rescue response.Matias Korhonen2011-05-031-1/+1
|
* show http method in routing error messageSchneems2011-04-231-1/+1
|
* use raise to create exceptions and to set the backtraceAaron Patterson2011-01-121-1/+1
|
* reraising should be in the rescue blockAaron Patterson2011-01-121-1/+1
|
* Refactor to handle the X-Cascade without having to raise an exceptionKrekoten' Marjan2011-01-091-12/+12
|
* Show exceptions rescues the original exceptionLes Hill and Sandro Turriate2010-10-121-0/+13
| | | | | | [#5784 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Revert "Setup explicit requires for files with exceptions. Removed them from ↵José Valim2010-09-021-1/+0
| | | | | | | | autoloading." Booting a new Rails application does not work after this commit [#5359 state:open] This reverts commit 38a421b34d0b414564e919f67d339fac067a56e6.
* Setup explicit requires for files with exceptions. Removed them from ↵Łukasz Strzałkowski2010-09-021-0/+1
| | | | | | autoloading. Signed-off-by: José Valim <jose.valim@gmail.com>
* annoted_source_code may return nil if an error happens during template ↵José Valim2010-08-161-1/+1
| | | | compiling.
* Moves local_request? to require.local?Santiago Pastorino2010-08-131-8/+1
| | | | [#5361 state:committed]
* Use Rack::Utils.bytesize when calculating content-length of exception pages. ↵Tarsoly András2010-06-201-1/+1
| | | | | | [#4727 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-06 19:31:38 +0000