aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch/middleware/flash.rb
Commit message (Collapse)AuthorAgeFilesLines
* Use frozen string literal in actionpack/Kir Shatrov2017-07-291-0/+2
|
* Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-021-1/+0
| | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* Enforce frozen string in RubocopKir Shatrov2017-07-011-0/+1
|
* [docs] fix ActionDispatch documentationHrvoje Šimić2017-03-131-1/+1
|
* Privatize unneededly protected methods in Action PackAkira Matsuda2016-12-241-1/+2
|
* Add missing `+` around a some literals.bogdanvlviv2016-10-271-1/+1
| | | | | | Mainly around `nil` [ci skip]
* normalizes indentation and whitespace across the projectXavier Noria2016-08-061-7/+7
|
* applies new string literal convention in actionpack/libXavier Noria2016-08-061-8/+8
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* Make flash messages cookie compatible with Rails 4Rafael Mendonça França2016-05-061-1/+1
| | | | | | | | In #18721 we removed the discard key from the session hash used to flash messages and that broke compatibility with Rails 4 applications because they try to map in the discarded flash messages and it returns nil. Fixes #24726.
* Fix request.reset_session for API controllersJon Moss2016-03-191-0/+5
| | | | | | | | | | | | Due to that `ActionDispatch::Flash` (the flash API's middleware) is not included for API controllers, the `request.reset_session` method, which relies on there being a `flash=` method which is in fact defined by the middleware, was previously breaking. Similarly to how add46482a540b33184f3011c5c307f4b8e90c9cc created a method to be overridden by the flash middleware in order to ensure non-breakage, this is how flashes are now reset. Fixes #24222
* pull the flash methods in to their own moduleAaron Patterson2015-09-251-34/+38
| | | | | | We only want to activate flash when the user has enabled it. Api servers don't use flash, so add an empty implementation to the base Request object.
* commit the flash after the controller finishes being servicedAaron Patterson2015-09-251-10/+16
| | | | | Committing the flash needs to happen in order for the session to be written correctly, so lets guarantee that it actually does happen.
* move flash committing to the request object.Aaron Patterson2015-09-251-12/+1
| | | | | I'm doing this so that we can commit the flash to the session object Out of Band of the flash middleware
* ask the request object for the sessionAaron Patterson2015-09-221-1/+1
| | | | | The flash middleware shouldn't know how to look up the session object. Just ask the request for that information.
* stop inheriting from Rack::RequestAaron Patterson2015-09-041-1/+1
| | | | | | Just include the modules necessary in the Request object to implement the things we need. This should make it easier to build delegate request objects because the API is smaller
* remove usage of `@env`Aaron Patterson2015-08-231-3/+5
| | | | | try to remove dependencies on `@env` so we can have more flexible internals
* use a request object in the session middlewareAaron Patterson2015-08-221-1/+1
| | | | | This commit allows us to use one request object rather than allocating multiple request objects to deal with the session.
* move flash hash access to methods on the request objectAaron Patterson2015-08-071-2/+11
|
* Migrate old flash behaviourSamuel Cochran2015-01-301-0/+6
|
* Discard from flash before persisting in sessionSamuel Cochran2015-01-291-17/+17
|
* adding nodoc to private methodsJonathan Cutrell2014-11-231-2/+2
|
* Adding simple docs for ActionDispatch::Flash::FlashHash#to_session_valueJonathan Cutrell2014-11-231-1/+4
|
* Make FlashHash#key? work with symbol and stringRafael Mendonça França2014-11-111-1/+1
| | | | Closes #17586
* flash doesn't pass objects #15522 [ci skip]Nishant Modak2014-07-011-3/+6
|
* Missed FlashHash#replaceGodfrey Chan2014-02-111-1/+1
|
* Fixed broken flash testsGodfrey Chan2014-02-111-1/+1
|
* Stringify the incoming hash in FlashHashGuillermo Iguaran2014-02-111-1/+3
| | | | | Stringify the incoming as well to handle incoming symbol keys from marshalled sessions
* Convert FlashHash in a Hash with indifferent accessGuillermo Iguaran2014-02-111-4/+15
|
* Fixing build broken by this changeArun Agrawal2013-05-131-2/+2
| | | | c43ca06ca091fc09e2c86bb051ac92b648f12b64
* Code cleanup for ActionDispatch::Flash#callJulian Vargas2013-05-121-9/+3
| | | | | | | The nested `if` was replaced by using `presence` which takes account for the given hash when it is `nil` or when it is empty. The `else` was removed because what it was doing was to assign to `env[KEY]` the value it already had.
* extract alert= and notice= examples to FlashHash#now [ci skip]Francesco Rodriguez2013-01-031-17/+15
|
* Add examples `alert=` and `notice=`, using memeslambda_2013-01-031-0/+10
|
* Remove nodoc from FlashHash #[]= [ci skip]Pablo Torres2012-12-011-1/+1
|
* Revert "Remove trailing whitespaces"Florent Guilleux2012-12-011-1/+1
| | | | This reverts commit 90c887fa7d0c454b7533e208daefc342dea4d5f3.
* Remove trailing whitespacesFlorent Guilleux2012-12-011-1/+1
|
* Store FlashHashes in the session as plain hashes rather than custom objects ↵James Coglan2012-11-091-10/+24
| | | | | | | | | | | | | | | | | | | | with unstable class names and instance variables. Refactor FlashHash to take values for its ivars in the constructor, to pretty up FlashHash.from_session_value. Remove stale comment on FlashHash: it is no longer Marshaled in the session so we can change its implementation. Remove blank lines I introduced in controller/test_case.rb. Unit tests for FlashHash#to_session_value. Put in a compatibility layer to accept FlashHash serializations from Rails 3.0+. Test that Rails 3.2 session flashes are correctly converted to the new format. Remove code path for processing Rails 3.0 FlashHashes since they can no longer deserialize. Fix session['flash'] deletion condition: it will never be empty?, it will either be nil or a hash with 'discard' and 'flashes' keys.
* Removing ==Examples and last blank lines of docs from actionpackFrancesco Rodriguez2012-05-151-1/+1
|
* make sure the superclass matches so load order does not matterAaron Patterson2012-05-041-1/+1
|
* bread AD::Request::Session to it's own file, consolidate HASH OF DOOM lookupsAaron Patterson2012-05-031-1/+1
|
* Merge pull request #6083 from brainopia/remove_unused_closed_ivarsJosé Valim2012-04-301-1/+0
|\ | | | | Remove a couple of unused ivars left from previous refactoring
| * Remove unused ivars left from close checksbrainopia2012-04-301-1/+0
| | | | | | | | These ivars were missed in d142572567 when close checks were removed
* | fix the Flash middleware loading the session on every request (very ↵Will Bryant2012-04-281-6/+3
|/ | | | dangerous especially with Rack::Cache), it should only be loaded when the flash method is called
* Fix example in flash middlewareAlexey Vakhov2012-04-171-1/+1
|
* simplify sweep now that discard and flashes are in syncAaron Patterson2011-12-281-8/+2
|
* mutations on the underlying hash should also mutate the discard setAaron Patterson2011-12-281-3/+5
|
* rename @used to something a bit more meaningfulAaron Patterson2011-12-281-7/+7
|
* mutations can't be done without the consent of our proxy object. ThisAaron Patterson2011-12-281-3/+0
| | | | is one benefit of choosing composition over inheritance.
* again, use Set#subtractAaron Patterson2011-12-281-1/+1
|
* Use Set#subtract and Set#merge for keeping track of used / unused keysAaron Patterson2011-12-281-15/+4
|
* fix method visibilityAaron Patterson2011-12-281-15/+15
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-01 23:29:16 +0000