Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fixing build broken by this change | Arun Agrawal | 2013-05-13 | 1 | -2/+2 |
| | | | | c43ca06ca091fc09e2c86bb051ac92b648f12b64 | ||||
* | Code cleanup for ActionDispatch::Flash#call | Julian Vargas | 2013-05-12 | 1 | -9/+3 |
| | | | | | | | The nested `if` was replaced by using `presence` which takes account for the given hash when it is `nil` or when it is empty. The `else` was removed because what it was doing was to assign to `env[KEY]` the value it already had. | ||||
* | extract alert= and notice= examples to FlashHash#now [ci skip] | Francesco Rodriguez | 2013-01-03 | 1 | -17/+15 |
| | |||||
* | Add examples `alert=` and `notice=`, using memes | lambda_ | 2013-01-03 | 1 | -0/+10 |
| | |||||
* | Remove nodoc from FlashHash #[]= [ci skip] | Pablo Torres | 2012-12-01 | 1 | -1/+1 |
| | |||||
* | Revert "Remove trailing whitespaces" | Florent Guilleux | 2012-12-01 | 1 | -1/+1 |
| | | | | This reverts commit 90c887fa7d0c454b7533e208daefc342dea4d5f3. | ||||
* | Remove trailing whitespaces | Florent Guilleux | 2012-12-01 | 1 | -1/+1 |
| | |||||
* | Store FlashHashes in the session as plain hashes rather than custom objects ↵ | James Coglan | 2012-11-09 | 1 | -10/+24 |
| | | | | | | | | | | | | | | | | | | | | with unstable class names and instance variables. Refactor FlashHash to take values for its ivars in the constructor, to pretty up FlashHash.from_session_value. Remove stale comment on FlashHash: it is no longer Marshaled in the session so we can change its implementation. Remove blank lines I introduced in controller/test_case.rb. Unit tests for FlashHash#to_session_value. Put in a compatibility layer to accept FlashHash serializations from Rails 3.0+. Test that Rails 3.2 session flashes are correctly converted to the new format. Remove code path for processing Rails 3.0 FlashHashes since they can no longer deserialize. Fix session['flash'] deletion condition: it will never be empty?, it will either be nil or a hash with 'discard' and 'flashes' keys. | ||||
* | Removing ==Examples and last blank lines of docs from actionpack | Francesco Rodriguez | 2012-05-15 | 1 | -1/+1 |
| | |||||
* | make sure the superclass matches so load order does not matter | Aaron Patterson | 2012-05-04 | 1 | -1/+1 |
| | |||||
* | bread AD::Request::Session to it's own file, consolidate HASH OF DOOM lookups | Aaron Patterson | 2012-05-03 | 1 | -1/+1 |
| | |||||
* | Merge pull request #6083 from brainopia/remove_unused_closed_ivars | José Valim | 2012-04-30 | 1 | -1/+0 |
|\ | | | | | Remove a couple of unused ivars left from previous refactoring | ||||
| * | Remove unused ivars left from close checks | brainopia | 2012-04-30 | 1 | -1/+0 |
| | | | | | | | | These ivars were missed in d142572567 when close checks were removed | ||||
* | | fix the Flash middleware loading the session on every request (very ↵ | Will Bryant | 2012-04-28 | 1 | -6/+3 |
|/ | | | | dangerous especially with Rack::Cache), it should only be loaded when the flash method is called | ||||
* | Fix example in flash middleware | Alexey Vakhov | 2012-04-17 | 1 | -1/+1 |
| | |||||
* | simplify sweep now that discard and flashes are in sync | Aaron Patterson | 2011-12-28 | 1 | -8/+2 |
| | |||||
* | mutations on the underlying hash should also mutate the discard set | Aaron Patterson | 2011-12-28 | 1 | -3/+5 |
| | |||||
* | rename @used to something a bit more meaningful | Aaron Patterson | 2011-12-28 | 1 | -7/+7 |
| | |||||
* | mutations can't be done without the consent of our proxy object. This | Aaron Patterson | 2011-12-28 | 1 | -3/+0 |
| | | | | is one benefit of choosing composition over inheritance. | ||||
* | again, use Set#subtract | Aaron Patterson | 2011-12-28 | 1 | -1/+1 |
| | |||||
* | Use Set#subtract and Set#merge for keeping track of used / unused keys | Aaron Patterson | 2011-12-28 | 1 | -15/+4 |
| | |||||
* | fix method visibility | Aaron Patterson | 2011-12-28 | 1 | -15/+15 |
| | |||||
* | no need for bang bang :bomb: | Aaron Patterson | 2011-12-28 | 1 | -1/+1 |
| | |||||
* | Get rid of the close checks since we cannot reliably close the session anyway. | José Valim | 2011-12-16 | 1 | -6/+0 |
| | |||||
* | Add some implementation docs. closes #3298. closes #2509. | José Valim | 2011-10-12 | 1 | -0/+4 |
| | |||||
* | Revert "Delegate to @flashes with 'delegate' instead of manually." | Aaron Patterson | 2011-06-29 | 1 | -2/+24 |
| | | | | This reverts commit 701e8554a8f69b0c81fe794cba985bfda804161b. | ||||
* | Delegate to @flashes with 'delegate' instead of manually. | Ben Orenstein | 2011-06-29 | 1 | -24/+2 |
| | |||||
* | Use initialize_copy! to proper initialize now on clone. | José Valim | 2011-04-19 | 1 | -15/+18 |
| | |||||
* | Don't reuse a closed flash when using now | Florent Piteau | 2011-04-20 | 1 | -1/+5 |
| | |||||
* | Do not inherit from Rack::Response, remove a shit-ton of unused code. | José Valim | 2011-04-19 | 1 | -0/+1 |
| | |||||
* | Be sure to not store the closed flash in the session. | José Valim | 2011-04-19 | 1 | -16/+25 |
| | |||||
* | Merge branch 'master' of github.com:rails/rails | Aaron Patterson | 2011-04-07 | 1 | -1/+1 |
|\ | | | | | | | | | | | | | | | | | | | * 'master' of github.com:rails/rails: Cache flash now Revert "Use freeze instead of close!" Revert "Eagerly load Signed and Permanent cookies" cookies here Eagerly load Signed and Permanent cookies Use freeze instead of close! | ||||
| * | Cache flash now | Santiago Pastorino | 2011-04-07 | 1 | -1/+1 |
| | | |||||
| * | Revert "Use freeze instead of close!" | Santiago Pastorino | 2011-04-07 | 1 | -3/+9 |
| | | | | | | | | This reverts commit 29592a7f09dda2e7e1e0a915d9230fe6a9b5c0af. | ||||
| * | Use freeze instead of close! | Santiago Pastorino | 2011-04-06 | 1 | -9/+3 |
| | | |||||
* | | getting the flash hash under test | Aaron Patterson | 2011-04-06 | 1 | -0/+4 |
| | | |||||
* | | favor composition over inheritance, have FlashHash delegate to a Hash | Aaron Patterson | 2011-04-06 | 1 | -7/+40 |
|/ | |||||
* | Add ClosedError message to the initializer | Santiago Pastorino | 2011-04-06 | 1 | -5/+2 |
| | |||||
* | raise if someone tries to modify the flash when it was already streamed back ↵ | Santiago Pastorino | 2011-04-05 | 1 | -1/+19 |
| | | | | to the client or converted to HTTP headers | ||||
* | Use common terminology | Joost Baaij | 2010-08-27 | 1 | -3/+3 |
| | |||||
* | mention the alert and notice accessors on the flash | Joost Baaij | 2010-08-27 | 1 | -0/+5 |
| | |||||
* | Just reading flash messages should not create a session if one does not ↵ | José Valim | 2010-06-25 | 1 | -2/+9 |
| | | | | exist yet. | ||||
* | Restore flash sweep | Jeremy Kemper | 2010-06-05 | 1 | -1/+1 |
| | |||||
* | Stop the flash middleware from forcibly loading sessions even if the user ↵ | wycats | 2010-06-04 | 1 | -2/+2 |
| | | | | doesn't use sessions at all | ||||
* | added convenience methods #notice and #alert to flash.now | Martin | 2010-05-15 | 1 | -0/+10 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Move Flash into middleware | Joshua Peek | 2010-01-15 | 1 | -0/+174 |