aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch/middleware/debug_exceptions.rb
Commit message (Collapse)AuthorAgeFilesLines
* API only apps: Preserve request format for HTML requests tooPrathamesh Sonpatki2016-05-111-8/+12
| | | | | | | | | | | | | - Earlier we were responding with JSON format for HTML requests in a API app. - Now we will respond with HTML format for such requests in API apps. - Also earlier we were not testing the API app's JSON requests properly. We were actually sending HTML requests. Now we send correct JSON requests. Also added more test coverage. - Based on the discussion from this commit - https://github.com/rails/rails/commit/05d89410bf97d0778e78558db3c9fed275f8a614. [Prathamesh Sonpatki, Jorge Bejar]
* Fix code styleRafael Mendonça França2016-02-171-3/+4
| | | | This change was added in #23203 and it was not conforming our code style.
* WIP: Errors in logs should show log tags as well.Vipul A M2016-02-121-7/+11
| | | | | | | - Changed formatted_code_for to return array of logs to be tagged for each line - Changed some render tests to match new behaviour of return Fixes #22979
* Avoid warning because of the mime typeJorge Bejar2015-12-091-1/+1
|
* DebugException initialize with a response_format valueJorge Bejar2015-12-091-6/+7
|
* Better name for method in DebugExceptions middlewareJorge Bejar2015-12-091-2/+2
|
* Minor cleanup in AD::DebugExceptionsJorge Bejar2015-12-091-6/+9
|
* Remove unneeded args in AD::DebugExceptionsJorge Bejar2015-12-091-1/+0
|
* New hash syntax in AD::DebugExceptionsJorge Bejar2015-12-091-4/+4
|
* Fix some edge cases in AD::DebugExceptions in rails api appsJorge Bejar2015-12-091-41/+64
|
* Response when error should be formatted properly in Rails API if local requestJorge Bejar2015-12-091-2/+15
|
* remove env access from debug_exceptionsAaron Patterson2015-08-231-10/+9
| | | | Creates fewer request objects and helps to abstract away from internals
* ask the request if we should show exceptionsAaron Patterson2015-08-061-1/+2
| | | | | hide the env key in the request object so that other code doesn't need to know.
* ExceptionWrapper doesn't need to know about `env`Aaron Patterson2015-08-061-1/+2
| | | | | | ExceptionWrapper only cares about the backtrace cleaner, so lets just pass the cleaner to the wrapper. It does not need to know that env exists or what key the backtrace cleaner is stored in
* Action View is needed for DebugExceptionsRafael Mendonça França2014-12-021-0/+2
| | | | We should remove this dependency later.
* Refactor debug viewKir Shatrov2014-12-021-1/+29
| | | Avoid logic in ERB and use helpers
* Merge pull request #17630 from gsamokovarov/exception-wrapper-source-extractGuillermo Iguaran2014-11-161-1/+1
|\ | | | | Rename #source_extract to #source_extracts in ExceptionWrapper
| * Rename #source_extract to #source_extracts in ExceptionWrapperGenadi Samokovarov2014-11-161-1/+1
| | | | | | | | | | It returns multiple source extracts since 1ed264bc. Also cleaned its result structure, as we no longer need the file in a code extract.
* | Don't show full trace on routing errorsGenadi Samokovarov2014-11-161-1/+1
|/ | | | | | | | | | Since dbcbbcf2bc58e8971672b143d1c52c0244e33f26 the full trace is shown by default on routing errors. While this is a nice feature to have, it does take the attention off the routes table in this view and I think this is what most of the people look for in this page. Added an exception to the default trace switching rule to remove that noise.
* Move DebugExceptions#traces_from_wrapper to ExceptionWrapperGenadi Samokovarov2014-11-031-29/+1
| | | | | ActionDispatch::ExceptionWrapper seems to be the more natural place for this method to live in.
* Show the user’s application in the source window and select the correct ↵Byron Bischoff2014-10-231-23/+33
| | | | trace list, closes #17312
* Retrieve source code for the entire stack traceRyan Dao2014-08-081-3/+32
| | | | | | Provide the ability to extract the source code of the entire exception stack trace, not just the frame raising the error. This improves debugging capability of the error page, especially for framework-related errors.
* Display exceptions in text format for xhr requestKir Shatrov2013-08-221-13/+21
|
* remove begin-rescue in favor of def-rescueGosha Arinich2013-01-071-10/+9
|
* Fix operators precedence issueRafael Mendonça França2013-01-061-1/+1
|
* Merge pull request #8787 from tank-bohr/masterRafael Mendonça França2013-01-061-2/+2
|\ | | | | masgn and response variable
| * return multiple assingment and response variabletank-bohr2013-01-071-2/+2
| |
* | refactor DebugExceptions by combining two conditionals into oneGosha Arinich2013-01-071-2/+1
|/
* fix for rbxtank-bohr2013-01-071-2/+2
| | | | | | | | | Rubinius returns a boolean after such assingment response = (_, headers, body = @app.call(env)) see https://github.com/rubinius/rubinius/issues/2117 get rid of a local variable
* Move table routes formatter class to the inspector and rename itCarlos Antonio da Silva2013-01-061-18/+0
| | | | | | | It feels more consistent to have this class called "HtmlTableFormatter", and to have it here with the routes inspector and console formatter, since it's used for both routing error exceptions and the rails info page.
* display mountable engine routes on RoutingError.Yves Senn2013-01-051-6/+21
|
* Add source extract to detailed exception pageGuillermo Iguaran2012-12-311-1/+4
|
* We need to check explictly that env['action_dispatch.show_exceptions']Rafael Mendonça França2012-12-261-1/+1
| | | | | | is false. If it is nil we can't raise the exception
* more descriptive return parametersHrvoje Šimić2012-12-261-4/+3
|
* Format routes as html on debug pageschneems2012-12-171-1/+1
| | | | | | | | | When someone gets a routing exception, the routes are rendered (starting in Rails 4.0). This PR brings parity between the html routes in the `rails/info/routes` path and when rendered from an exception. This is the continuation of #8521 which brought html formatted routes. In addition to bringing parity to the two views, we're keeping our views DRY by rendering off of the same partials. In this case Railties depends on partials provided by ActionDispatch. I'm open to alternative implementations. Ideally both views will use the same code so any improvements or updates to it will be reproduced on both. <hr /> ![](http://f.cl.ly/items/3O1D0K1v0j0i343O3T3T/Screen%20Shot%202012-12-17%20at%203.07.20%20PM.png)
* DebugExceptions `File.join` => `File.expand_path`schneems2012-12-161-1/+1
|
* Rename RouteInspector to RoutesInspectorCarlos Antonio da Silva2012-07-081-2/+1
| | | | Follow the consistency defined in dbc43bc.
* move route_inspector to actionpack@schneems and @mattt2012-07-071-5/+7
| | | | this is so we can show route output in the development when we get a routing error. Railties can use features of ActionDispatch, but ActionDispatch should not depend on Railties.
* show routes while debugging RoutingErrorschneems2012-07-071-1/+12
| | | | If someone receives a routing error, they likely need to view the routes. Rather than making them visit '/rails/info/routes' or run `rake routes` we can give them that information on the page.
* Action pack logger methodschanged to active supoort Logger methodsKarunakar (Ruby)2011-12-221-1/+1
|
* ShowExceptions should understand X-Cascade responses from exceptions app.José Valim2011-12-161-1/+0
|
* Close the response body on cascade pass, closes #3975.José Valim2011-12-141-0/+2
|
* log exception backtrace when all backtrace lines silencedSergey Nartimov2011-12-131-1/+4
|
* Fix failing cascade exception.José Valim2011-12-031-1/+2
|
* Split ShowExceptions responsibilities in two middlewares.José Valim2011-12-011-0/+77
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-30 15:03:17 +0000