Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Avoid warning because of the mime type | Jorge Bejar | 2015-12-09 | 1 | -1/+1 |
| | |||||
* | DebugException initialize with a response_format value | Jorge Bejar | 2015-12-09 | 1 | -6/+7 |
| | |||||
* | Better name for method in DebugExceptions middleware | Jorge Bejar | 2015-12-09 | 1 | -2/+2 |
| | |||||
* | Minor cleanup in AD::DebugExceptions | Jorge Bejar | 2015-12-09 | 1 | -6/+9 |
| | |||||
* | Remove unneeded args in AD::DebugExceptions | Jorge Bejar | 2015-12-09 | 1 | -1/+0 |
| | |||||
* | New hash syntax in AD::DebugExceptions | Jorge Bejar | 2015-12-09 | 1 | -4/+4 |
| | |||||
* | Fix some edge cases in AD::DebugExceptions in rails api apps | Jorge Bejar | 2015-12-09 | 1 | -41/+64 |
| | |||||
* | Response when error should be formatted properly in Rails API if local request | Jorge Bejar | 2015-12-09 | 1 | -2/+15 |
| | |||||
* | remove env access from debug_exceptions | Aaron Patterson | 2015-08-23 | 1 | -10/+9 |
| | | | | Creates fewer request objects and helps to abstract away from internals | ||||
* | ask the request if we should show exceptions | Aaron Patterson | 2015-08-06 | 1 | -1/+2 |
| | | | | | hide the env key in the request object so that other code doesn't need to know. | ||||
* | ExceptionWrapper doesn't need to know about `env` | Aaron Patterson | 2015-08-06 | 1 | -1/+2 |
| | | | | | | ExceptionWrapper only cares about the backtrace cleaner, so lets just pass the cleaner to the wrapper. It does not need to know that env exists or what key the backtrace cleaner is stored in | ||||
* | Action View is needed for DebugExceptions | Rafael Mendonça França | 2014-12-02 | 1 | -0/+2 |
| | | | | We should remove this dependency later. | ||||
* | Refactor debug view | Kir Shatrov | 2014-12-02 | 1 | -1/+29 |
| | | | Avoid logic in ERB and use helpers | ||||
* | Merge pull request #17630 from gsamokovarov/exception-wrapper-source-extract | Guillermo Iguaran | 2014-11-16 | 1 | -1/+1 |
|\ | | | | | Rename #source_extract to #source_extracts in ExceptionWrapper | ||||
| * | Rename #source_extract to #source_extracts in ExceptionWrapper | Genadi Samokovarov | 2014-11-16 | 1 | -1/+1 |
| | | | | | | | | | | It returns multiple source extracts since 1ed264bc. Also cleaned its result structure, as we no longer need the file in a code extract. | ||||
* | | Don't show full trace on routing errors | Genadi Samokovarov | 2014-11-16 | 1 | -1/+1 |
|/ | | | | | | | | | | Since dbcbbcf2bc58e8971672b143d1c52c0244e33f26 the full trace is shown by default on routing errors. While this is a nice feature to have, it does take the attention off the routes table in this view and I think this is what most of the people look for in this page. Added an exception to the default trace switching rule to remove that noise. | ||||
* | Move DebugExceptions#traces_from_wrapper to ExceptionWrapper | Genadi Samokovarov | 2014-11-03 | 1 | -29/+1 |
| | | | | | ActionDispatch::ExceptionWrapper seems to be the more natural place for this method to live in. | ||||
* | Show the user’s application in the source window and select the correct ↵ | Byron Bischoff | 2014-10-23 | 1 | -23/+33 |
| | | | | trace list, closes #17312 | ||||
* | Retrieve source code for the entire stack trace | Ryan Dao | 2014-08-08 | 1 | -3/+32 |
| | | | | | | Provide the ability to extract the source code of the entire exception stack trace, not just the frame raising the error. This improves debugging capability of the error page, especially for framework-related errors. | ||||
* | Display exceptions in text format for xhr request | Kir Shatrov | 2013-08-22 | 1 | -13/+21 |
| | |||||
* | remove begin-rescue in favor of def-rescue | Gosha Arinich | 2013-01-07 | 1 | -10/+9 |
| | |||||
* | Fix operators precedence issue | Rafael Mendonça França | 2013-01-06 | 1 | -1/+1 |
| | |||||
* | Merge pull request #8787 from tank-bohr/master | Rafael Mendonça França | 2013-01-06 | 1 | -2/+2 |
|\ | | | | | masgn and response variable | ||||
| * | return multiple assingment and response variable | tank-bohr | 2013-01-07 | 1 | -2/+2 |
| | | |||||
* | | refactor DebugExceptions by combining two conditionals into one | Gosha Arinich | 2013-01-07 | 1 | -2/+1 |
|/ | |||||
* | fix for rbx | tank-bohr | 2013-01-07 | 1 | -2/+2 |
| | | | | | | | | | Rubinius returns a boolean after such assingment response = (_, headers, body = @app.call(env)) see https://github.com/rubinius/rubinius/issues/2117 get rid of a local variable | ||||
* | Move table routes formatter class to the inspector and rename it | Carlos Antonio da Silva | 2013-01-06 | 1 | -18/+0 |
| | | | | | | | It feels more consistent to have this class called "HtmlTableFormatter", and to have it here with the routes inspector and console formatter, since it's used for both routing error exceptions and the rails info page. | ||||
* | display mountable engine routes on RoutingError. | Yves Senn | 2013-01-05 | 1 | -6/+21 |
| | |||||
* | Add source extract to detailed exception page | Guillermo Iguaran | 2012-12-31 | 1 | -1/+4 |
| | |||||
* | We need to check explictly that env['action_dispatch.show_exceptions'] | Rafael Mendonça França | 2012-12-26 | 1 | -1/+1 |
| | | | | | | is false. If it is nil we can't raise the exception | ||||
* | more descriptive return parameters | Hrvoje Šimić | 2012-12-26 | 1 | -4/+3 |
| | |||||
* | Format routes as html on debug page | schneems | 2012-12-17 | 1 | -1/+1 |
| | | | | | | | | | When someone gets a routing exception, the routes are rendered (starting in Rails 4.0). This PR brings parity between the html routes in the `rails/info/routes` path and when rendered from an exception. This is the continuation of #8521 which brought html formatted routes. In addition to bringing parity to the two views, we're keeping our views DRY by rendering off of the same partials. In this case Railties depends on partials provided by ActionDispatch. I'm open to alternative implementations. Ideally both views will use the same code so any improvements or updates to it will be reproduced on both. <hr /> ![](http://f.cl.ly/items/3O1D0K1v0j0i343O3T3T/Screen%20Shot%202012-12-17%20at%203.07.20%20PM.png) | ||||
* | DebugExceptions `File.join` => `File.expand_path` | schneems | 2012-12-16 | 1 | -1/+1 |
| | |||||
* | Rename RouteInspector to RoutesInspector | Carlos Antonio da Silva | 2012-07-08 | 1 | -2/+1 |
| | | | | Follow the consistency defined in dbc43bc. | ||||
* | move route_inspector to actionpack | @schneems and @mattt | 2012-07-07 | 1 | -5/+7 |
| | | | | this is so we can show route output in the development when we get a routing error. Railties can use features of ActionDispatch, but ActionDispatch should not depend on Railties. | ||||
* | show routes while debugging RoutingError | schneems | 2012-07-07 | 1 | -1/+12 |
| | | | | If someone receives a routing error, they likely need to view the routes. Rather than making them visit '/rails/info/routes' or run `rake routes` we can give them that information on the page. | ||||
* | Action pack logger methodschanged to active supoort Logger methods | Karunakar (Ruby) | 2011-12-22 | 1 | -1/+1 |
| | |||||
* | ShowExceptions should understand X-Cascade responses from exceptions app. | José Valim | 2011-12-16 | 1 | -1/+0 |
| | |||||
* | Close the response body on cascade pass, closes #3975. | José Valim | 2011-12-14 | 1 | -0/+2 |
| | |||||
* | log exception backtrace when all backtrace lines silenced | Sergey Nartimov | 2011-12-13 | 1 | -1/+4 |
| | |||||
* | Fix failing cascade exception. | José Valim | 2011-12-03 | 1 | -1/+2 |
| | |||||
* | Split ShowExceptions responsibilities in two middlewares. | José Valim | 2011-12-01 | 1 | -0/+77 |