Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | applies remaining conventions across the project | Xavier Noria | 2016-08-06 | 1 | -1/+1 |
| | |||||
* | applies new string literal convention in actionpack/lib | Xavier Noria | 2016-08-06 | 1 | -2/+2 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Replace x.times.map{} with Array.new(x){} | Viktar Basharymau | 2016-01-02 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | The former is slightly more readable, performant and has fewer method calls. ```ruby Benchmark.ips do |x| x.report('times.map') { 5.times.map{} } x.report('Array.new') { Array.new(5){} } x.compare! end __END__ Calculating ------------------------------------- times.map 21.188k i/100ms Array.new 30.449k i/100ms ------------------------------------------------- times.map 311.613k (± 3.5%) i/s - 1.568M Array.new 590.374k (± 1.2%) i/s - 2.954M Comparison: Array.new: 590373.6 i/s times.map: 311612.8 i/s - 1.89x slower ``` | ||||
* | used predicate methods to avoid is_a? checks | Ronak Jangir | 2015-10-10 | 1 | -3/+3 |
| | |||||
* | avoid is_a? checks | Aaron Patterson | 2015-08-17 | 1 | -2/+2 |
| | | | | add another predicate method so we can avoid is_a checks | ||||
* | pull RegexpOffsets in to a method | Aaron Patterson | 2015-08-17 | 1 | -27/+14 |
| | | | | we don't really need this visitor | ||||
* | default pattern to use a joined string | Aaron Patterson | 2015-08-17 | 1 | -2/+2 |
| | | | | | The string we create is almost always the same, so rather than joining all the time, lets join once, then reuse that string everywhere. | ||||
* | remove Strexp | Aaron Patterson | 2015-08-13 | 1 | -7/+11 |
| | | | | | This was a useless object. We can just directly construct a Path::Pattern object without a Strexp object. | ||||
* | pass anchor directly to `Pattern` | Aaron Patterson | 2015-08-13 | 1 | -3/+3 |
| | | | | | the caller already has it, there is no reason to pack it in to an object and just throw that object away. | ||||
* | Merge pull request #17827 from rkh/rkh-fix-or-pattern | Aaron Patterson | 2014-12-01 | 1 | -0/+5 |
|\ | | | | | Fix OR in Journey patterns | ||||
| * | make OR in journey patterns compile to a valid regular expression | Konstantin Haase | 2014-11-29 | 1 | -0/+5 |
| | | |||||
* | | Pass symbol as an argument instead of a block | Erik Michaels-Ober | 2014-11-29 | 1 | -2/+2 |
|/ | |||||
* | no more is_a checks on instantiation | Aaron Patterson | 2014-05-29 | 1 | -9/+4 |
| | |||||
* | Path::Pattern is instantiated internally, so make the contructor require a ↵ | Aaron Patterson | 2014-05-29 | 1 | -7/+6 |
| | | | | strexp object | ||||
* | ask the strexp for the ast | Aaron Patterson | 2014-05-29 | 1 | -3/+2 |
| | |||||
* | push the formatter up to the Route object | Aaron Patterson | 2014-05-21 | 1 | -3/+2 |
| | |||||
* | cache the formatter on the path object | Aaron Patterson | 2014-05-20 | 1 | -0/+5 |
| | |||||
* | Replace map.flatten with flat_map in actionpack | Erik Michaels-Ober | 2014-03-03 | 1 | -2/+2 |
| | |||||
* | Make ActionDispatch::Journey::Path::Pattern#new raise more meaningful ↵ | zires | 2013-02-27 | 1 | -1/+1 |
| | | | | exception message. | ||||
* | update AD::Journey to follow Rails coding conventions | Francesco Rodriguez | 2012-12-20 | 1 | -30/+31 |
| | |||||
* | :nodoc: Journey because is not part of the public API [ci skip] | Francesco Rodriguez | 2012-12-19 | 1 | -4/+4 |
| | |||||
* | Integrate Journey into Action Dispatch | Andrew White | 2012-12-19 | 1 | -0/+195 |
Move the Journey code underneath the ActionDispatch namespace so that we don't pollute the global namespace with names that may be used for models. Fixes rails/journey#49. |