| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Fix broken IPv6 addresses handling
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Code cleanup
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Cleanup for `ActionDispatch::Http::Parameters` - no need for required libraries
and remove not used private method.
Apparently this method was used in `ActionDispatch::Http::Request` - fixed
by calling `Request::Utils` explicitly (as was done in other parts of the codebase)
|
| | |
| | |
| | |
| | |
| | | |
eventually we'll remove this instance variable, but this is the first
step
|
| | |
| | |
| | |
| | |
| | | |
we're storing the value in the headers hash, so lets just store the
value in one place.
|
| | |
| | |
| | |
| | |
| | | |
Modules should be using the API that the abstract modules use so that we
can move these modules between implementations
|
| | |
| | |
| | |
| | |
| | | |
cookies are always stored as a string in the header hash, so it will not
need to be joined.
|
| | | |
|
|/ /
| |
| |
| | |
eventually we will refactor this to not know about header hashes
|
| |
| |
| |
| |
| | |
Rack::Response::Helpers implements this method, so we can safely remove
it
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Controllers should always have a request and response when responding.
Since we make this The Rule(tm), then controllers don't need to be
somewhere in limbo between "asking a response object for a rack
response" or "I, myself contain a rack response". This duality leads to
conditionals spread through the codebase that we can delete:
* https://github.com/rails/rails/blob/85a78d9358aa728298cd020cdc842b55c16f9549/actionpack/lib/action_controller/metal.rb#L221-L223
|
| |
| |
| |
| |
| | |
now the caller can just treat it like a regular controller even though
it will return a 404
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
We don't want to directly access the env hash
|
| |
| |
| |
| |
| | |
I want to implement this with something besides `@env` in the future, so
lets stop directly referencing it.
|
| |
| |
| |
| |
| | |
This commit allows us to use one request object rather than allocating
multiple request objects to deal with the session.
|
| |
| |
| |
| |
| | |
We're going to implement storing env values differently in the future,
so let's disconnect these methods from the instance variables
|
| | |
|
| |
| |
| |
| | |
we're already doing this with a bunch of other header data.
|
| |
| |
| |
| | |
we have a method that knows how to get rack.input, so lets use that.
|
| |
| |
| |
| |
| |
| | |
We need to abstract the internals of the request object away from this
instance variable so that the values for `@env` can be calculated in a
different way.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This refactoring moves the controller class name that was on the route
set to the request. The purpose of this refactoring is for changes we
need to move controller tests to integration tests, mainly being able to
access the controller on the request instead of having to go through
the router.
[Eileen M. Uchitelle & Aaron Patterson]
|
| | |
|
| |
| |
| |
| |
| | |
we want to go through methods to access `env` because in the future that
ivar may not be available, or may be calculated lazily
|
| |
| |
| |
| |
| | |
now the parameter filter doesn't need to know about the env hash in
these two methds.
|
| |
| |
| |
| | |
Now the Headers internals don't depend on the env hash.
|
| |
| |
| |
| |
| | |
This prevents external mutations from impacting the internals of the
request or the Header object.
|
| |
| |
| |
| |
| | |
this reduces the API footprint for the env hash so that we can be more
flexible when changing API in the future
|
| |
| |
| |
| | |
This allows us to avoid calling `env_name` twice.
|
| |
| |
| |
| | |
duping the request will dup it's underlying env hash.
|
| | |
|
| |
| |
| |
| |
| | |
Since we are always responding with an array and using `any?`, we don't
need to check if an array is empty
|
| | |
|
| |
| |
| |
| |
| |
| | |
people should be accessing request information through the request
object, not via the env hash. If they really really want at the env
hash, then they can get it off the request.
|
| |
| |
| |
| |
| |
| |
| | |
Actions are processed through `dispatch`, so they should have the
request set on them before any user land code can be executed. Lets
stop setting _env on the controller, and give access to it through the
`env` method.
|
| |
| |
| |
| |
| | |
this is another place that we should stop directly accessing the env
hash and let the request object take care of that for us
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
again, we want to hide the contents of `env` from the implementation.
Allocate a request object to access the contents of env, but save
allocations due to string literal allocations when accessing the env
hash.
|
| |
| |
| |
| |
| | |
hide the env key in the request object so that other code doesn't need
to know.
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Fix Encoding::UndefinedConversionError with multibyte UTF-8 filename containing "%" character
|
| | | |
|
| | | |
|
|/ /
| |
| |
| |
| | |
This decouples the `call` method from knowing the SCRIPT_NAME key and
offloads decisions about how to access script_name
|