aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch/http
Commit message (Collapse)AuthorAgeFilesLines
* Add documentation to ActionDispatch::Http::UploadedFile#headersRafael Mendonça França2013-01-031-0/+1
| | | | [ci skip]
* Remove a useless TODO commentRobin Dupret2013-01-031-1/+0
|
* do not append a second slash when usingYves Senn2013-01-021-1/+5
|
* charset should not be appended for `head` responsesYves Senn2012-12-311-2/+6
| | | | | | | 1) Failure: test_head_created_with_image_png_content_type(RenderTest) [test/controller/render_test.rb:1238]: Expected: "image/png" Actual: "image/png; charset=utf-8"
* return Mime::NullType if format is unknownAngelo Capilleri2012-12-221-1/+12
| | | | | | | | | | If a request has an unknown format, the methods html?, xml?, json? ...etc not raise an Exception. This patch add a class Mime::NullType, that is returned when request.format is unknown and it responds false to the methods that ends with '?' and true to 'nil?'. It refers to #7837, this issue is considered a improvement not a bug.
* remove a cache we do not needAaron Patterson2012-12-141-5/+1
|
* Merge pull request #8510 from thedarkone/thread_safety_improvementsAaron Patterson2012-12-141-7/+3
|\ | | | | Thread safety improvements
| * Replace some global Hash usages with the new thread safe cache.thedarkone2012-12-141-7/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Summary of the changes: * Add thread_safe gem. * Use thread safe cache for digestor caching. * Replace manual synchronization with ThreadSafe::Cache in Relation::Delegation. * Replace @attribute_method_matchers_cache Hash with ThreadSafe::Cache. * Use TS::Cache to avoid the synchronisation overhead on listener retrieval. * Replace synchronisation with TS::Cache usage. * Use a preallocated array for performance/memory reasons. * Update the controllers cache to the new AS::Dependencies::ClassCache API. The original @controllers cache no longer makes much sense after @tenderlove's changes in 7b6bfe84f3 and f345e2380c. * Use TS::Cache in the connection pool to avoid locking overhead. * Use TS::Cache in ConnectionHandler.
* | Fix rewinding in ActionDispatch::Request#raw_postMatt Venables2012-12-111-2/+3
|/ | | | | | | | | If env['RAW_POST_DATA'] is nil, #raw_post will attempt to set it to the result of #body (which will return env['rack.input'] if env['RAW_POST_DATA'] is nil). #raw_post will then attempt to rewind the result of another call to #body. Since env['RAW_POST_DATA'] has already been set, the result of #body is not env['rack.input'] anymore. This causes env['rack.input'] to never be rewound.
* Merge pull request #8476 from sheerun/fix/multipart-getRafael Mendonça França2012-12-101-1/+5
|\ | | | | Prevent raising EOFError on multipart GET request.
| * Prevent raising EOFError on multipart GET request.Adam Stankiewicz2012-12-101-1/+5
| | | | | | | | | | | | | | | | | | | | Such request can happen on Internet Explorer. When we redirect after multipart form submission, the request type is changed to GET, but Content-Type is preserved as multipart. GET request cannot have multipart body and that caused Rails to fail. It's similar fix to Rack's one: https://github.com/chneukirchen/rack/blob/8025a4ae9477d1e6231344c2b7d795aa9b3717b6/lib/rack/request.rb#L224
* | use `_action` instead of `_filter` callbacksFrancesco Rodriguez2012-12-071-2/+2
|/
* Adding filter capability to ActionController logsFabrizio Regini2012-12-052-0/+38
|
* Correct the use of params options when given to url_forCarlos Antonio da Silva2012-11-191-1/+1
| | | | Merge url for tests and add changelog entry for #8233.
* Fix issue with params in url_fortumayun2012-11-191-1/+1
| | | | | | With a "params" argument, the following error is raised: undefined method `reject!` for "":String
* Refactor url methods a bitCarlos Antonio da Silva2012-11-161-9/+9
| | | | | | Use if..else conditions instead of return guards. Use _ for not used arguments when iterating. Set the path variable directly instead of using an empty string and <<.
* implement to_a and to_ary so that the Array() call in template.rb willAaron Patterson2012-11-091-9/+14
| | | | | | | | | | | | | | | | not raise so many exceptions: https://github.com/rails/rails/blob/master/actionpack/lib/action_view/template.rb#L126 irb(main):001:0> class Foo; def method_missing(*args); super; end end => nil irb(main):002:0> $DEBUG = true => true irb(main):003:0> Array(Foo.new) Exception `NoMethodError' at (irb):1 - undefined method `to_ary' for #<Foo:0x007f854390e488> Exception `NoMethodError' at (irb):1 - undefined method `to_a' for #<Foo:0x007f854390e488> => [#<Foo:0x007f854390e488>] irb(main):004:0>
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-11-031-2/+2
|\ | | | | | | | | | | | | Conflicts: actionpack/lib/action_controller/metal/mime_responds.rb activerecord/lib/active_record/attribute_methods.rb guides/source/working_with_javascript_in_rails.md
| * 1.9 hash syntax changes to docsAvnerCohen2012-10-311-2/+2
| |
* | Revert "if format is unknown NullMimeTypeObject is returned"Guillermo Iguaran2012-10-311-12/+1
| | | | | | | | This reverts commit a8560fa361958b33d76e4468eb5c07d82a20196e.
* | if format is unknown NullMimeTypeObject is returnedAngelo capilleri2012-10-311-1/+12
| | | | | | | | | | | | | | | | | | | | If a unknown format is passed in a request, the methods html?, xml?, json? ...etc Nil Exception. This patch add a class NullMimeTypeObject, that is returned when request.format is unknown and it responds false to the methods that ends with '?'. It refers to #7837, not fixes because it's not considered a improvement not a bug.
* | Make caller attribute in deprecation methods optionalAlexey Gaziev2012-10-301-2/+2
| |
* | Provide a call stack for deprecation warnings where needed.Nikita Afanasenko2012-10-291-2/+2
| | | | | | | | It's sometimes hard to quickly find where deprecated call was performed, especially in case of migrating between Rails versions. So this is an attempt to improve the call stack part of the warning message by providing caller explicitly.
* | give access to the original exception raised in case of a parse errorAaron Patterson2012-10-251-2/+2
| |
* | do not lose backtrace information from the raised exceptionAaron Patterson2012-10-251-10/+6
|/
* synchronize on param filter cache.Aaron Patterson2012-10-181-2/+7
| | | | Do we actually need this cache?
* add another singleton for environment filteringAaron Patterson2012-10-181-3/+8
|
* oops, forgot the default parameterAaron Patterson2012-10-181-1/+1
|
* keep a singleton filter around that we can use when no filter is setAaron Patterson2012-10-181-2/+6
|
* move compiled filters to their own class so that recursive calls don'tAaron Patterson2012-10-181-41/+45
| | | | need to check for the length of @filters
* nil isn't a valid filterAaron Patterson2012-10-181-1/+0
|
* prevent people from accidentally modifying the filter wordAaron Patterson2012-10-181-1/+1
|
* simplify filter enabled checkingAaron Patterson2012-10-181-9/+4
|
* if no filters are supplied, default to an empty listAaron Patterson2012-10-181-1/+1
|
* initialize required instance variables for this mixinAaron Patterson2012-10-181-2/+7
|
* eagerly populate the http method loookup cache so we don't need locksAaron Patterson2012-10-181-1/+7
|
* move cache inside the instance so we do not need lockingAaron Patterson2012-10-181-9/+12
|
* add test for fetch with a blockAaron Patterson2012-10-181-2/+2
|
* prefer composition over inheritenceAaron Patterson2012-10-181-11/+15
|
* depreacte unused Mime::Type#verify_request? and ↵grosser2012-09-241-1/+6
| | | | Mime::Type.browser_generated_types
* documents ActionDispatch::Http::UploadedFileXavier Noria2012-09-221-6/+55
|
* Accept parameters in methods delegated to tempfileSergio Gil Pérez de la Manga2012-09-221-6/+2
|
* Delegate ActionDispatch::Http::UploadedFile#close to tempfileSergio Gil Pérez de la Manga2012-09-201-1/+1
|
* Check if etag exists before to do the gsubRafael Mendonça França2012-09-151-2/+4
| | | | This fix the build http://travis-ci.org/#!/rails/rails/builds/2459981
* fix the buildSteve Klabnik2012-09-151-0/+1
|
* Support for multiple etags in an If-None-Match headerTravis Warlick2012-09-151-1/+7
| | | | | | | | This is a rebased version of #2520. Conflicts: actionpack/test/dispatch/request_test.rb
* Fixed missing requireIlya Vorontsov2012-09-081-0/+1
| | | | | | | Missing require caused fail of guide generation (in action_dispatch/http/mime_type, line 295, undefined method `ends_with` for "to_ary":String) With this fix guides were normally generated
* Refactor `Mime::Type`Aleksey Magusev2012-09-051-84/+93
| | | | | | | | | | | `parse` method performance improvements - ~27-33%: accept = "image/gif, image/x-xbitmap, image/jpeg, image/pjpeg, application/x-shockwave-flash, application/vnd.ms-excel, application/vnd.ms-powerpoint, application/msword, , pronto/1.00.00, sslvpn/1.00.00.00, */*" Benchmark.measure{ 1_000_0.times { Mime::Type.parse(accept) }} old: 1.430000 0.000000 1.430000 ( 1.440977) new: 0.920000 0.000000 0.920000 ( 0.921813)
* Properly reset the session on reset_sessionSteve Klabnik2012-08-311-2/+5
| | | | Fixes #7478
* Add Request#formats=(extensions) that lets you set multiple formats directly ↵David Heinemeier Hansson2012-08-141-0/+21
| | | | in a prioritized order
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-31 14:39:11 +0000