aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch/http
Commit message (Collapse)AuthorAgeFilesLines
* Use each_with_objectSantiago Pastorino2013-08-191-4/+2
|
* Organize normalize_encoding_params' conditionals a bit better and use a case ↵Santiago Pastorino2013-08-191-15/+18
| | | | | | statement for it Refactor of the work done in #11891
* Normalize file parameters in same place as other parameters ↵robertomiranda2013-08-143-14/+2
| | | | (ActionDispatch::Http::Parameters#normalize_encode_params)
* Use helper method to get ENV['CONTENT_LENGTH']Paul Nikitochkin2013-07-081-1/+1
|
* writing the new body can cause the response to be committed and theAaron Patterson2013-06-281-1/+3
| | | | | | | | request thread to return up the stack before the instance variable is assigned. Synchronize so that the ivar is assigned before the other thread can activate. fixes #10984
* Fix undefined method `ref' for nil:NilClass for bad accept headersStephen Becker IV2013-06-191-1/+1
|
* Merge pull request #10839 from gsamokovarov/clean-normalize_encoded_pathsRafael Mendonça França2013-06-041-11/+7
|\ | | | | Refactor ActionDispatch::Http::Parameters#normalize_encode_params
| * Refactor ActionDispatch::Http::Parameters#normalize_encode_paramsGenadi Samokovarov2013-06-041-11/+7
| |
* | Remove Mime::Type#verify_request? and Mime::Type.browser_generated_types ↵kennyj2013-06-021-16/+0
| | | | | | | | were deprecated.
* | Add propery docs to ActionDispatch::Response [ci skip]Steve Klabnik2013-05-301-3/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | After some discussion on Twitter with @skud, the documentation on ActionDispatch::Response is a bit sparse. This class is useful when you're writing tests, as often you want to assert various things about the response that's coming back. Better docs would make this easier for people new to testing in Rails. I only added some descriptions for various properties that were defined, and mostly just a sentence or two. Most of these things are familliar if you're working with HTTP, but some words is better than no words at all. Hopefully further commits will fix up things that aren't just documentation.
* | Extract ActionDispatch::Request#deep_mungeGenadi Samokovarov2013-05-301-17/+2
|/ | | | | | | | | ActionDispatch::Request#deep_munge was introduced as a private method, but was turned into a public one for the use of ActionDispatch::ParamsParser. I have extracted it into ActionDispatch::Request::Utils, so it does not get mixed up with the Request public methods.
* use constant for encodingNihad Abbasov2013-05-021-1/+1
|
* extract no content response codes to a constantVipul A M2013-04-221-1/+2
|
* Refactor ActionDispatch::Http::URL.build_host_urlAndrew White2013-04-181-20/+49
| | | | | Add support for extracting the port from the :host option and for removing the subdomain by using nil, false or ''.
* Duplicate options before mutating themAndrew White2013-04-181-0/+1
|
* Passing subdomain: '' to url_for removes the subdomain (instead of adding a ↵Derek Watson2013-04-181-1/+1
| | | | | | leading .) Adding a boolean route constraint checks for presence/absence of request property
* Return nil for Mime::NullType#refAndrew White2013-04-101-0/+4
|
* Reverts rendering behavior when format is unknownGrzegorz Świrski2013-04-101-1/+5
| | | | | | | | | If a request has unknown format (eg. /foo.bar), the renderer fallbacks to default format. This patch reverts Rails 3.2 behavior after c2267db commit. Fixes issue #9654.
* Mark unused variables and make some style fixesAgis Anastasopoulos2013-04-081-2/+2
| | | | It'd be a nice convention to mark the unused variables like this, now that Ruby 2 will issue no warnings for such vars being unused.
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-03-301-1/+1
|\ | | | | | | | | | | | | | | | | Conflicts: activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb activerecord/test/cases/adapter_test.rb guides/source/testing.md [ci skip]
| * Fixed small typosPrathamesh Sonpatki2013-03-191-1/+1
| |
* | Merge pull request #9794 from schneems/schneems/email-hostAndrew White2013-03-191-1/+12
|\ \ | | | | | | Fix improperly configured host in generated urls
| * | Fix improperly configured host in generated urlsschneems2013-03-191-1/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the host in `default_url_options` is accidentally set with a protocol such as ``` host: "http://example.com" ``` then the generated url will have the protocol twice `http://http://example.com` which is not what the user intended. Likely they wanted to define a host `host: "example.com"` and a `protocol: "http://"` but did not know the convention. This may not the most common problem, but when it happens it can go undetected for a while. I accidentally added `http://` out of habit recently only to find all the links in my emails were broken after deploying a demo site to production. Rather than allow this accident go undetected, we can fix the problem in line by properly setting the protocol and host. I was able to find this related question on stack overflow: http://stackoverflow.com/questions/5878329/rails-3-devise-how-do-i-make-the-email-confirmation-links-use-secure-https-n where the answer was highly upvoted. This is based off of work in #7415 cc/ @pixeltrix ATP Action Mailer and Action Pack
* | | Remove mentions of "app" from http request docs [ci skip]Carlos Antonio da Silva2013-03-191-12/+10
|/ /
* | drop an unused hash; change slang to SPECIALVipul A M2013-03-191-2/+2
| |
* | Merge pull request #5606 from teohm/multipart_unicode_param_nameSteve Klabnik2013-03-153-31/+24
|\ \ | | | | | | multipart POST - utf8 param name not encoded
| * | UTF-8 encode all keys and values in nested params hash.Teo Hui Ming2013-03-153-31/+24
| | |
* | | `Http::Headers` directly modifies the passed environment.Yves Senn2013-03-151-2/+1
|/ / | | | | | | | | | | | | | | | | The env hash passed to `Http::Headers#new` must be in env format. Also be aware that the passed hash is modified directly. docs and test-cases for setting headers/env in functional tests. Follow up to #9700.
* | Add extra clarifying line in docs. [ci skip]Steve Klabnik2013-03-131-0/+1
| |
* | Fix docs: response -> request.Steve Klabnik2013-03-131-2/+2
| | | | | | | | Even though I read it carefully, my brain tricked me. :cry:
* | Merge pull request #9698 from garethrees/request_documentationSteve Klabnik2013-03-131-0/+16
|\ \ | | | | | | Add documentation to ActionDispatch::Request
| * | Add documentation to ActionDispatch::RequestGareth Rees2013-03-131-0/+16
| |/
* | `Http::Headers` respects dotted env vars, symbols, headers with numbers.Yves Senn2013-03-131-11/+6
| |
* | allow headers and env to be passed in `IntegrationTest`.Yves Senn2013-03-131-1/+15
| | | | | | | | Closes #6513.
* | refactor, `Http::Headers` stores headers in env notationYves Senn2013-03-131-17/+21
| | | | | | | | | | Also: cleanup, use consistent syntax for `Http::Header` and test.
* | Http::Headers respects headers that are not prefixed with HTTP_Yves Senn2013-03-131-1/+13
| |
* | Change from each to each_value in http/parameters since we don't use keyVipul A M2013-03-131-1/+1
|/
* Fix formats on xhr requests when HTTP_ACCEPT is empty stringmaximerety2013-03-041-1/+1
| | | | | | Fix ActionDispatch::Request#formats on xhr requests when HTTP_ACCEPT header is empty string. About issue #7774, same fix as in commit bebb02f but for xhr requests.
* Require AS deps in ActionDispatch::Http::URLMiha Filej2013-02-191-0/+3
| | | | Allows us to use url_for and friends in isolation.
* Removed an old require of an MD5 digest which is no longer used.wangjohn2013-02-151-1/+0
|
* Merge pull request #8704 from senny/remove_regexp_global_from_url_forAaron Patterson2013-02-141-2/+6
|\ | | | | replace regexp global in #url_for
| * replace regexp global in #url_forYves Senn2013-01-161-2/+6
| |
* | Avoid to_sym callsSantiago Pastorino2013-02-131-1/+1
| |
* | Use Encoding::UTF_8 constant :do_not_litter:Akira Matsuda2013-01-282-2/+2
| |
* | Merge remote-tracking branch 'docrails/master'Xavier Noria2013-01-261-2/+14
|\ \ | | | | | | | | | | | | | | | Conflicts: actionpack/lib/action_view/helpers/form_options_helper.rb guides/code/getting_started/app/controllers/comments_controller.rb
| * | generic pass before merging docrailsXavier Noria2013-01-261-5/+7
| | |
| * | Add documentation to ActionDispatch::ResponseMatthew Stopa2013-01-201-0/+7
| | |
| * | Fix typo introduced in 0004ca3aCarlos Antonio da Silva2013-01-161-1/+1
| | | | | | | | | | | | [ci skip]
| * | More documentation for ActionDispatch::ResponseMatthew Stopa2013-01-161-1/+3
| | | | | | | | | | | | [ci skip]
| * | Document ActionDispatch::Response#body methodMatthew Stopa2013-01-161-0/+1
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-05 03:44:25 +0000