Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | only extract :params from the options hash once | Aaron Patterson | 2014-07-16 | 1 | -3/+2 | |
| | ||||||
* | always transcode the file to utf-8 | Aaron Patterson | 2014-07-16 | 1 | -0/+1 | |
| | | | | | | people may be passing filenames to the constructor that are not utf-8, but they will assome that calling `original_filename` returns utf-8 (because that's what it used to do). | |||||
* | rack 1.6 encodes the filenames in posts correctly now | Aaron Patterson | 2014-07-15 | 1 | -8/+1 | |
| | ||||||
* | Merge pull request #13999 from jamox/update_rack | Aaron Patterson | 2014-07-08 | 2 | -12/+11 | |
|\ | | | | | This updates rails to use edge rack | |||||
| * | Since upgrading rack we can remove unnecessary string encodings | Jarmo Isotalo | 2014-05-19 | 1 | -9/+2 | |
| | | | | | | | | https://github.com/rack/rack/commit/5a5aee36 | |||||
| * | Upgraded rack | Jarmo Isotalo | 2014-05-19 | 1 | -3/+9 | |
| | | | | | | | | | | | | | | | | As Rack has some non backwards compatible changes added required modifications to keep behaviour in rails close to same as before. Also modified generators to include rack/rack for not yet released version of rack | |||||
* | | Remove symbolized_path_parameters. | Guo Xiang Tan | 2014-07-02 | 1 | -3/+4 | |
| | | | | | | | | This pull request is a continuation of https://github.com/rails/rails/commit/925bd975 and https://github.com/rails/rails/commit/8d8ebe3d. | |||||
* | | makes it sound less misleading | ShunsukeAida | 2014-07-02 | 1 | -2/+2 | |
| | | ||||||
* | | push host / port / protocol extraction up | Aaron Patterson | 2014-06-30 | 1 | -6/+6 | |
| | | | | | | | | Then we only need to extract host once. | |||||
* | | add both branches to the only_path conditional | Aaron Patterson | 2014-06-19 | 1 | -6/+6 | |
| | | ||||||
* | | Change Http::Cache::SPECIAL_KEYS from Array to Set | Mindaugas Mozūras | 2014-06-15 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Slightly improves performance, for example, a simple benchmark: ```ruby require 'benchmark/ips' require 'set' SPECIAL_KEYS = %w[extras no-cache max-age public must-revalidate] SPECIAL_KEYS_SET = Set.new(SPECIAL_KEYS) directive = 'must-revalidate' Benchmark.ips do |x| x.report('array') { SPECIAL_KEYS.include?(directive) } x.report('set') { SPECIAL_KEYS_SET.include?(directive) } end ``` Output: ``` ------------------------------------- array 67926 i/100ms set 74054 i/100ms ------------------------------------- array 2318423.4 (±2.8%) i/s - 11615346 in 5.014899s set 3387981.8 (±4.7%) i/s - 16958366 in 5.019355s ``` | |||||
* | | only check named_host? once in normalize_host | Aaron Patterson | 2014-06-12 | 1 | -3/+7 | |
| | | ||||||
* | | lookup subdomain from the options hash once, defaulting to true | Aaron Patterson | 2014-06-12 | 1 | -2/+2 | |
| | | | | | | | | | | if the subdomain wasn't specified, it's the same as if specifying :subdomain as `true`, so we can default the value to `true` safely. | |||||
* | | only extract domain from the options hash once | Aaron Patterson | 2014-06-12 | 1 | -3/+4 | |
| | | ||||||
* | | reduce calls to `named_host?` | Aaron Patterson | 2014-06-12 | 1 | -2/+6 | |
| | | | | | | | | | | `normalize_host` already calls `named_host?`, so there is no reason to test `named_host?` again in the `extract_domain` method. | |||||
* | | Removed warning actionpack url.rb | Juanito Fatas | 2014-06-12 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | Before: /Users/Juan/dev/rails/actionpack/lib/action_dispatch/http/url.rb:95: warning: shadowing outer local variable - port After: No warning | |||||
* | | remove useless to_param call | Aaron Patterson | 2014-06-11 | 1 | -1/+1 | |
| | | | | | | | | | | extract_subdomain always returns a string, and to_param calls to_s on a string | |||||
* | | only look up the subdomain once | Aaron Patterson | 2014-06-11 | 1 | -3/+4 | |
| | | ||||||
* | | scheme should contain one or more characters | Aaron Patterson | 2014-06-11 | 1 | -1/+1 | |
| | | ||||||
* | | pull the port out of the options hash once | Aaron Patterson | 2014-06-11 | 1 | -2/+3 | |
| | | ||||||
* | | remove useless nil check | Aaron Patterson | 2014-06-11 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | irb(main):004:0> /foo/ !~ nil => true irb(main):005:0> /foo/ !~ 'bar' => true irb(main):006:0> /foo/ !~ 'foo' => false | |||||
* | | these methods are always called with a tld_parameter | Aaron Patterson | 2014-06-11 | 1 | -3/+3 | |
| | | | | | | | | | | remove the default parameter since the methods are always called with a parameter | |||||
* | | rm `same_host?`. The same conditional is two lines down. | Aaron Patterson | 2014-06-11 | 1 | -5/+3 | |
| | | ||||||
* | | Revert "rm `same_host?`. The same conditional is two lines down." | Aaron Patterson | 2014-06-11 | 1 | -5/+8 | |
| | | | | | | | | This reverts commit 79469b4b0c05a50e19699bc9b568042add2d4987. | |||||
* | | rm `same_host?`. The same conditional is two lines down. | Aaron Patterson | 2014-06-11 | 1 | -8/+5 | |
| | | ||||||
* | | cache host on the stack so we only look it up once | Aaron Patterson | 2014-06-11 | 1 | -8/+9 | |
| | | ||||||
* | | only pull :protocol from the options hash once | Aaron Patterson | 2014-06-11 | 1 | -2/+3 | |
| | | ||||||
* | | cache protocol on the stack to reduce options hash lookups | Aaron Patterson | 2014-06-11 | 1 | -7/+7 | |
| | | ||||||
* | | eliminate nil checks in normalize_port | Aaron Patterson | 2014-06-11 | 1 | -7/+7 | |
| | | ||||||
* | | reduce hash lookups and disconnect normalize_port from the options hash | Aaron Patterson | 2014-06-11 | 1 | -9/+9 | |
| | | ||||||
* | | Handle client disconnect during live streaming | Matthew Draper | 2014-06-08 | 1 | -13/+47 | |
| | | | | | | | | .. even when the producer is blocked for a write. | |||||
* | | Use a frozen Set instance for CGI_VARIABLES. | Nathaniel Bibler | 2014-06-05 | 1 | -8/+21 | |
| | | | | | | Also expand the CGI_VARIABLE name listing to multiple lines for cleaner diffs and legibility. | |||||
* | | Merge pull request #15349 from tgxworld/remove_duplicated_method_call | Rafael Mendonça França | 2014-06-03 | 2 | -3/+2 | |
|\ \ | | | | | | | Remove duplicated HashWithIndifferentAccess#with_indifferent_access. | |||||
| * | | Remove duplicated HashWithIndifferentAccess#with_indifferent_access. | Guo Xiang Tan | 2014-05-26 | 2 | -3/+2 | |
| | | | ||||||
* | | | rm dead code | Aaron Patterson | 2014-05-27 | 1 | -5/+0 | |
| | | | ||||||
* | | | PARAMETERS_KEY is only used in the request, so move the constant there | Aaron Patterson | 2014-05-27 | 1 | -2/+4 | |
| | | | ||||||
* | | | rm reset_parameters because we automatically do it from 9ca4839a | Aaron Patterson | 2014-05-27 | 1 | -4/+0 | |
| | | | ||||||
* | | | move path_parameter encoding check to the request object | Aaron Patterson | 2014-05-27 | 1 | -0/+11 | |
|/ / | ||||||
* | | Merge pull request #14986 from dlangevin/trailing-slash-url-generation | Rafael Mendonça França | 2014-05-24 | 1 | -7/+13 | |
|\ \ | | | | | | | | | | | | | | | | | | | Fixes URL generation with trailing_slash: true Conflicts: actionpack/lib/action_dispatch/http/url.rb | |||||
| * | | Fixes URL generation with trailing_slash: true | Dan Langevin | 2014-05-22 | 1 | -9/+17 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | URL generation with trailing_slash: true was adding a trailing slash after .:format Routes.draw do resources :bars end bars_url(trailing_slash: true, format: 'json') # => /bars.json/ This commit removes that extra trailing slash | |||||
* | | | just return path parameters | Aaron Patterson | 2014-05-22 | 1 | -2/+1 | |
| | | | ||||||
* | | | Fix the hash key being delete from env | Rafael Mendonça França | 2014-05-22 | 1 | -1/+1 | |
| | | | | | | | | | | | | It was changed by mistake at c5d64b2b86aa42f57881091491ee289b3c489c7e. | |||||
* | | | use the existing constant rather than the hardcoded string | Aaron Patterson | 2014-05-21 | 1 | -3/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | so tht I don't go totally insane with THsi crazy hash driven development. why is Everything a hash? Why do people think hashes in hashes with random keys is a Good API? You can't find things or deprecate them or control access whatsoever, you just have to hope that everyone is like "oh, you want to change that? that's cool! we all know it's hashes so go for it!" The End. | |||||
* | | | fewer string allocations per url_for | Aaron Patterson | 2014-05-20 | 1 | -7/+5 | |
| | | | ||||||
* | | | mutate the path string to avoid object allocations | Aaron Patterson | 2014-05-20 | 1 | -4/+4 | |
| | | | ||||||
* | | | push only_path conditional up | Aaron Patterson | 2014-05-20 | 1 | -18/+19 | |
| | | | ||||||
* | | | push arg checking up | Aaron Patterson | 2014-05-20 | 1 | -4/+4 | |
| | | | ||||||
* | | | fewer method calls and string garbage when there is no user/password | Aaron Patterson | 2014-05-20 | 1 | -9/+5 | |
| |/ |/| | ||||||
* | | fixes stack level too deep exception on action named 'status' returning ↵ | Christiaan Van den Poel | 2014-05-15 | 1 | -0/+3 | |
| | | | | | | | | 'head :ok' | |||||
* | | Add RFC4791 MKCALENDAR method | kasper | 2014-05-15 | 1 | -1/+3 | |
| | |