Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | give access to the original exception raised in case of a parse error | Aaron Patterson | 2012-10-25 | 1 | -2/+2 | |
| | | ||||||
* | | do not lose backtrace information from the raised exception | Aaron Patterson | 2012-10-25 | 1 | -10/+6 | |
|/ | ||||||
* | synchronize on param filter cache. | Aaron Patterson | 2012-10-18 | 1 | -2/+7 | |
| | | | | Do we actually need this cache? | |||||
* | add another singleton for environment filtering | Aaron Patterson | 2012-10-18 | 1 | -3/+8 | |
| | ||||||
* | oops, forgot the default parameter | Aaron Patterson | 2012-10-18 | 1 | -1/+1 | |
| | ||||||
* | keep a singleton filter around that we can use when no filter is set | Aaron Patterson | 2012-10-18 | 1 | -2/+6 | |
| | ||||||
* | move compiled filters to their own class so that recursive calls don't | Aaron Patterson | 2012-10-18 | 1 | -41/+45 | |
| | | | | need to check for the length of @filters | |||||
* | nil isn't a valid filter | Aaron Patterson | 2012-10-18 | 1 | -1/+0 | |
| | ||||||
* | prevent people from accidentally modifying the filter word | Aaron Patterson | 2012-10-18 | 1 | -1/+1 | |
| | ||||||
* | simplify filter enabled checking | Aaron Patterson | 2012-10-18 | 1 | -9/+4 | |
| | ||||||
* | if no filters are supplied, default to an empty list | Aaron Patterson | 2012-10-18 | 1 | -1/+1 | |
| | ||||||
* | initialize required instance variables for this mixin | Aaron Patterson | 2012-10-18 | 1 | -2/+7 | |
| | ||||||
* | eagerly populate the http method loookup cache so we don't need locks | Aaron Patterson | 2012-10-18 | 1 | -1/+7 | |
| | ||||||
* | move cache inside the instance so we do not need locking | Aaron Patterson | 2012-10-18 | 1 | -9/+12 | |
| | ||||||
* | add test for fetch with a block | Aaron Patterson | 2012-10-18 | 1 | -2/+2 | |
| | ||||||
* | prefer composition over inheritence | Aaron Patterson | 2012-10-18 | 1 | -11/+15 | |
| | ||||||
* | depreacte unused Mime::Type#verify_request? and ↵ | grosser | 2012-09-24 | 1 | -1/+6 | |
| | | | | Mime::Type.browser_generated_types | |||||
* | documents ActionDispatch::Http::UploadedFile | Xavier Noria | 2012-09-22 | 1 | -6/+55 | |
| | ||||||
* | Accept parameters in methods delegated to tempfile | Sergio Gil Pérez de la Manga | 2012-09-22 | 1 | -6/+2 | |
| | ||||||
* | Delegate ActionDispatch::Http::UploadedFile#close to tempfile | Sergio Gil Pérez de la Manga | 2012-09-20 | 1 | -1/+1 | |
| | ||||||
* | Check if etag exists before to do the gsub | Rafael Mendonça França | 2012-09-15 | 1 | -2/+4 | |
| | | | | This fix the build http://travis-ci.org/#!/rails/rails/builds/2459981 | |||||
* | fix the build | Steve Klabnik | 2012-09-15 | 1 | -0/+1 | |
| | ||||||
* | Support for multiple etags in an If-None-Match header | Travis Warlick | 2012-09-15 | 1 | -1/+7 | |
| | | | | | | | | This is a rebased version of #2520. Conflicts: actionpack/test/dispatch/request_test.rb | |||||
* | Fixed missing require | Ilya Vorontsov | 2012-09-08 | 1 | -0/+1 | |
| | | | | | | | Missing require caused fail of guide generation (in action_dispatch/http/mime_type, line 295, undefined method `ends_with` for "to_ary":String) With this fix guides were normally generated | |||||
* | Refactor `Mime::Type` | Aleksey Magusev | 2012-09-05 | 1 | -84/+93 | |
| | | | | | | | | | | | `parse` method performance improvements - ~27-33%: accept = "image/gif, image/x-xbitmap, image/jpeg, image/pjpeg, application/x-shockwave-flash, application/vnd.ms-excel, application/vnd.ms-powerpoint, application/msword, , pronto/1.00.00, sslvpn/1.00.00.00, */*" Benchmark.measure{ 1_000_0.times { Mime::Type.parse(accept) }} old: 1.430000 0.000000 1.430000 ( 1.440977) new: 0.920000 0.000000 0.920000 ( 0.921813) | |||||
* | Properly reset the session on reset_session | Steve Klabnik | 2012-08-31 | 1 | -2/+5 | |
| | | | | Fixes #7478 | |||||
* | Add Request#formats=(extensions) that lets you set multiple formats directly ↵ | David Heinemeier Hansson | 2012-08-14 | 1 | -0/+21 | |
| | | | | in a prioritized order | |||||
* | push header merge down to a private method so that live responses can have ↵ | Aaron Patterson | 2012-08-13 | 1 | -3/+7 | |
| | | | | their own header object | |||||
* | Merge pull request #7302 from homakov/default_headers | Aaron Patterson | 2012-08-09 | 1 | -0/+5 | |
|\ | | | | | Introduce default_headers. closes #6311 #6515 | |||||
| * | introduce default_headers config | Egor Homakov | 2012-08-09 | 1 | -0/+5 | |
| | | ||||||
* | | initialize instance variables | Aaron Patterson | 2012-08-09 | 3 | -0/+22 | |
|/ | ||||||
* | load active_support/core_ext/module/delegation in active_support/rails | Xavier Noria | 2012-08-02 | 1 | -1/+0 | |
| | ||||||
* | load active_support/core_ext/object/blank in active_support/rails | Xavier Noria | 2012-08-02 | 4 | -4/+0 | |
| | ||||||
* | Merge pull request #7198 from cfcosta/refactor-cache_control_headers | Rafael Mendonça França | 2012-07-29 | 1 | -11/+19 | |
|\ | | | | | Refactor ActionDispatch::Http::Cache::Response#cache_control_headers | |||||
| * | Refactor ActionDispatch::Http::Cache::Response#cache_control_headers. | Cainã Costa | 2012-07-30 | 1 | -11/+19 | |
| | | ||||||
* | | header hash is duped before being sent up the rack stack | Aaron Patterson | 2012-07-29 | 1 | -12/+16 | |
| | | ||||||
* | | ActionController::DataStreaming::FileBody doesn't respond to #close. | Rafael Mendonça França | 2012-07-29 | 1 | -1/+1 | |
| | | ||||||
* | | flushing output should write to the stream rather than mutating the response ↵ | Aaron Patterson | 2012-07-29 | 1 | -8/+12 | |
|/ | | | | object | |||||
* | adding a buffered stream to the response object | Aaron Patterson | 2012-07-29 | 1 | -2/+42 | |
| | ||||||
* | initialize ivars, refactor recycle! to call initialize | Aaron Patterson | 2012-07-29 | 1 | -0/+2 | |
| | ||||||
* | threads can wait on responses to be committed | Aaron Patterson | 2012-07-27 | 1 | -1/+24 | |
| | ||||||
* | Remove ActionDispatch::Head middleware in favor of Rack::Head | Santiago Pastorino | 2012-07-23 | 1 | -2/+2 | |
| | | | | Closes #7110 there's more work to do on rack-cache issue 69 | |||||
* | Prevent conflict between mime types and Object methods | Mircea Pricop | 2012-07-06 | 1 | -1/+12 | |
| | | | | | | | | | | | | | | | | | | | | | | | Assuming the type ":touch", Collector.new was calling send(:touch), which instead of triggering method_missing and generating a new collector method, actually invoked the private method `touch` inherited from Object. By generating the method for each mime type as it is registered, the private methods on Object can never be reached by `send`, because the `Collector` will have them before `send` is called on it. To do this, a callback mechanism was added to Mime::Type This allows someone to add a callback for whenever a new mime type is registered. The callback then gets called with the new mime as a parameter. This is then used in AbstractController::Collector to generate new collector methods after each mime is registered. | |||||
* | add Mime.fetch so we can have default mime types | Aaron Patterson | 2012-07-03 | 1 | -0/+5 | |
| | ||||||
* | Ensure that cache-control headers are merged | James Tucker | 2012-06-18 | 1 | -10/+32 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | There are several aspects to this commit, that don't well fit into broken down commits, so they are detailed here: * When a user uses response.headers['Cache-Control'] = some_value, then the documented convention in ConditionalGet is not adhered to, in this case, response.cache_control is ignored due to `return if self[CACHE_CONTROL].present?` * When a middleware sets cache-control headers that would clobber, they're converted to symbols directly, without underscores. This would lead to bugs. * Items that would live in :extras if set through expires_in, are placed directly in the @cache_control hash, and not respected in many cases (somewhat adhering to the aforementioned documentation). * Although quite useless, any directive named 'extras' would be ignored. The general convention applied is that expires_* take precedence, but no longer overwrite everything and expires_* are ALWAYS applied, even if the header is set. I am still unhappy about the contents of this commit, and the code in general. Ideally it should be refactored to no longer use :extras. I'd likely recommend expanding @cache_control into a class, and giving it the power to handle the merge in a more efficient fashion. Such a commit would be a larger change that could have additional semantic changes for other libraries unless they utilize expires_in in very standard ways. | |||||
* | These lines don't help to mitigate CVE. They only turn [nil] into nil, w/o ↵ | Egor Homakov | 2012-06-13 | 1 | -3/+0 | |
| | | | | | | them [nil] turns into [] and that is quite innocent. generated SQL - `IN (NULL)` compact! did all the job. | |||||
* | Array parameters should not contain nil values. | Aaron Patterson | 2012-06-12 | 1 | -2/+4 | |
| | ||||||
* | both string and sumbol will be interpolated as string no need to convert to_s | ganesh | 2012-06-11 | 1 | -3/+3 | |
| | ||||||
* | Strip [nil] from parameters hash. | Aaron Patterson | 2012-05-30 | 1 | -0/+22 | |
| | | | | | | Thanks to Ben Murphy for reporting this! CVE-2012-2660 | |||||
* | Raise ActionController::BadRequest for malformed parameter hashes. | Andrew White | 2012-05-20 | 1 | -3/+10 | |
| | | | | | | | | | | | | | | Currently Rack raises a TypeError when it encounters a malformed or ambiguous hash like `foo[]=bar&foo[4]=bar`. Rather than pass this through to the application this commit captures the exception and re-raises it using a new ActionController::BadRequest exception. The new ActionController::BadRequest exception returns a 400 error instead of the 500 error that would've been returned by the original TypeError. This allows exception notification libraries to ignore these errors if so desired. Closes #3051 |