Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | remove check for string from request body setter | lest | 2011-12-21 | 1 | -8/+1 |
| | | | | it was required on ruby 1.8 | ||||
* | use Array#join so that file encoding doesn't impact returned string. | Aaron Patterson | 2011-12-12 | 1 | -3/+3 |
| | | | | Fixes #3957 | ||||
* | Use freezed string constant. Some string literals is used repeatedly. | kennyj | 2011-12-08 | 1 | -8/+10 |
| | |||||
* | Use default charset when we read content type without charset. | kennyj | 2011-12-07 | 1 | -1/+1 |
| | |||||
* | removed deprecated methods, and related tests, from ActionPack | Josh Kalderimis | 2011-05-24 | 1 | -23/+0 |
| | |||||
* | Make :status an attr_reader to avoid unnecessary warning when replacing status= | wycats | 2011-05-22 | 1 | -1/+2 |
| | |||||
* | Fix previous commit by allowing a proc to be given as response_body. This is ↵ | José Valim | 2011-05-10 | 1 | -15/+41 |
| | | | | deprecated and is going to be removed in future releases. | ||||
* | Fix tests on 1.8 by explicitly checking for strings (which also improves ↵ | José Valim | 2011-04-20 | 1 | -1/+9 |
| | | | | performance). | ||||
* | Do not inherit from Rack::Response, remove a shit-ton of unused code. | José Valim | 2011-04-19 | 1 | -53/+48 |
| | |||||
* | Fix status initialization when custom status provided | Krekoten' Marjan | 2010-10-18 | 1 | -2/+2 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Move ETag and ConditionalGet logic from AD::Response to the middleware stack. | José Valim | 2010-10-03 | 1 | -1/+1 |
| | |||||
* | @_etag is not used anywhere. | José Valim | 2010-09-29 | 1 | -2/+0 |
| | |||||
* | Initialize @_etag. | Emilio Tagua | 2010-09-27 | 1 | -0/+1 |
| | |||||
* | Expanded routing documentation with current best practices | Joost Baaij | 2010-08-29 | 1 | -10/+9 |
| | |||||
* | Rely on set and delete cookie logic from rack. | José Valim | 2010-05-18 | 1 | -33/+2 |
| | |||||
* | Missing requires | wycats | 2010-04-16 | 1 | -0/+1 |
| | |||||
* | adds missing requires for Object#blank? and Object#present? | Xavier Noria | 2010-03-28 | 1 | -0/+1 |
| | |||||
* | Set the body using the accessor for AD::Response introspection mode so it ↵ | Carlhuda | 2010-02-26 | 1 | -1/+2 |
| | | | | gets wrapped in a [] | ||||
* | Make AD::Response correctly handle bodies that respond_to?(:to_path) as per ↵ | Carlhuda | 2010-02-23 | 1 | -0/+12 |
| | | | | the Rack spec | ||||
* | Fix a bunch of pending tests by providing an introspection mode for the ↵ | Carlhuda | 2010-02-19 | 1 | -15/+21 |
| | | | | Response object that does up-front parsing of the headers to populate things like @etag | ||||
* | Cookies middleware | Joshua Peek | 2010-01-16 | 1 | -1/+1 |
| | |||||
* | Split ActionDispatch http in smaller chunks. | José Valim | 2010-01-16 | 1 | -78/+2 |
| | |||||
* | AD::StatusCodes support is now part of rack | Joshua Peek | 2009-12-22 | 1 | -2/+2 |
| | |||||
* | AC::Head now doesn't have an unfulfilled Rendering dependency, and instead ↵ | Yehuda Katz | 2009-12-20 | 1 | -1/+1 |
| | | | | works just fine standalone (which means that ConditionalGet also doesn't have a Rendering dependency) | ||||
* | Pending tests for AD Response | Joshua Peek | 2009-12-17 | 1 | -13/+12 |
| | |||||
* | Fix warnings in AD::Response | Joshua Peek | 2009-12-14 | 1 | -0/+3 |
| | |||||
* | Ensure Cache-Control max-age is an integer | Jeremy Kemper | 2009-12-02 | 1 | -1/+1 |
| | |||||
* | Response#write is defined twice (this is why -w is good) | Joshua Peek | 2009-12-01 | 1 | -6/+0 |
| | |||||
* | Response#cache_control is defined later | Joshua Peek | 2009-12-01 | 1 | -1/+0 |
| | |||||
* | Fixes expires_now and cleans things up a bit | Yehuda Katz | 2009-10-26 | 1 | -0/+2 |
| | |||||
* | SessionRestoreError belongs in AD | Joshua Peek | 2009-09-23 | 1 | -4/+4 |
| | |||||
* | ActionController::Metal can be a middleware | Yehuda Katz + Carl Lerche | 2009-08-25 | 1 | -1/+4 |
| | |||||
* | More perf work: | Yehuda Katz | 2009-08-11 | 1 | -31/+53 |
| | | | | | | | | | | | | | | * Move #set_cookie and #delete_cookie inline to optimize. These optimizations should almost certainly be sent back upstream to Rack. The optimization involves using an ivar for cookies instead of indexing into the headers each time. * Was able to use a bare Hash for headers now that cookies have their own joining semantics (some code assumed that the raw cookies were an Array). * Cache blankness of body on body= * Improve expand_cache_key for Arrays of a single element (common in our case) * Use a simple layout condition check unless conditions are used * Cache visible actions * Lazily load the UrlRewriter * Make etag an ivar that is set on prepare! | ||||
* | Got overhead down from 127 to 85. All tests pass: | Yehuda Katz | 2009-08-11 | 1 | -36/+56 |
| | | | | | | | | | | | | | | | | | | | | | | | | | * Tentatively replaced HeaderHash with SimpleHeaderHash, which does not preserve case but does handle converting Arrays to Strings in to_hash. This requires further discussion. * Moved default_charset to ActionDispatch::Response to avoid having to hop over to ActionController. Ideally, this would be a constant on AD::Response, but some tests expect to be able to change it dynamically and I didn't want to change them yet. * Completely override #initialize from Rack::Response. Previously, it was creating a HeaderHash, and then we were creating an entirely new one. There is no way to call super without incurring the overhead of creating a HeaderHash. * Override #write from Rack::Response. Its implementation tracks Content-Length, and doing so adds additional overhead that could be mooted if other middleware changes the body. It is more efficiently done at the top-level server. * Change sending_file to an instance_variable instead of header inspection. In general, if a state is important, it should be set as a property of the response not reconstructed later. * Set the Etag to @body instead of .body. AS::Cache.expand_cache_key handles Arrays fine, and it's more efficient to let it handle the body parts, since it is not forced to create a joined String. * If we detect the default cache control case, just set it, rather than setting the constituent parts and then running the normal (expensive) code to generate the string. | ||||
* | Remove legacy processing and content_length | Yehuda Katz | 2009-08-02 | 1 | -40/+10 |
| | | | | | | | | | | | * convert_content_type! is handled by assign_default_content_type_and_charset! * set_content_length! should be handled by the endpoint server. Otherwise each middleware that modifies the body has to do the expensive work of recalculating content_length. * convert_language! appears to be legacy. There are no tests for this * convert_cookies! should be handled by the new HeaderHash in Rack * Use an integer for .status's internal representation to avoid needing to do String manipulation just to find out the status | ||||
* | Update cache_control to be a Hash of options that is used to build the header. | Yehuda Katz | 2009-08-02 | 1 | -5/+19 |
| | | | | * Significantly simplifies setting and modifying cache control in other areas | ||||
* | Finish making things pass with updated internal content_type semantics | Yehuda Katz + Carl Lerche | 2009-06-15 | 1 | -45/+11 |
| | |||||
* | Don't want Rack's Content-Type default header though | Jeremy Kemper | 2009-05-24 | 1 | -2/+3 |
| | |||||
* | Construct a single HeaderHash. Speed up assign_default_content_type_and_charset | Jeremy Kemper | 2009-05-24 | 1 | -4/+10 |
| | |||||
* | Cherry-pick core extensions | Jeremy Kemper | 2009-05-13 | 1 | -0/+1 |
| | |||||
* | Implemented redirects and partial rendering in new base. | Yehuda Katz + Carl Lerche | 2009-05-12 | 1 | -6/+0 |
| | |||||
* | Functional test runner finalizes response just like the integration test ↵ | Joshua Peek | 2009-05-02 | 1 | -1/+1 |
| | | | | | runner. In both runners, the @response object will now behave the same. Some functional tests will need to be updated if they are relying on preprocessed data on the response. | ||||
* | Deprecate assert_redirect_to's partial hash matching | Joshua Peek | 2009-05-02 | 1 | -2/+0 |
| | |||||
* | Start moving TestRequest and TestResponse into ActionDispatch | Joshua Peek | 2009-04-30 | 1 | -56/+0 |
| | |||||
* | Group integration test helpers and delegate other helpers to request and ↵ | Joshua Peek | 2009-04-30 | 1 | -0/+9 |
| | | | | response objects | ||||
* | Deprecate template, session, assigns, and layout accessors on response ↵ | Joshua Peek | 2009-04-28 | 1 | -3/+13 |
| | | | | object. Instead access them through the controller instance. This mainly affects functional test assertions. | ||||
* | Deprecate response.assigns | Joshua Peek | 2009-04-28 | 1 | -2/+6 |
| | |||||
* | Delegate controller.session to request.session and deprecate response session | Joshua Peek | 2009-04-27 | 1 | -1/+5 |
| | |||||
* | Array splitting strings on newlines is deprecated | Jeremy Kemper | 2009-04-26 | 1 | -4/+15 |
| | |||||
* | Check for to_str rather than String | Jeremy Kemper | 2009-04-26 | 1 | -3/+1 |
| |