aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch/http/response.rb
Commit message (Collapse)AuthorAgeFilesLines
...
* Use default charset when we read content type without charset.kennyj2011-12-071-1/+1
|
* removed deprecated methods, and related tests, from ActionPackJosh Kalderimis2011-05-241-23/+0
|
* Make :status an attr_reader to avoid unnecessary warning when replacing status=wycats2011-05-221-1/+2
|
* Fix previous commit by allowing a proc to be given as response_body. This is ↵José Valim2011-05-101-15/+41
| | | | deprecated and is going to be removed in future releases.
* Fix tests on 1.8 by explicitly checking for strings (which also improves ↵José Valim2011-04-201-1/+9
| | | | performance).
* Do not inherit from Rack::Response, remove a shit-ton of unused code.José Valim2011-04-191-53/+48
|
* Fix status initialization when custom status providedKrekoten' Marjan2010-10-181-2/+2
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Move ETag and ConditionalGet logic from AD::Response to the middleware stack.José Valim2010-10-031-1/+1
|
* @_etag is not used anywhere.José Valim2010-09-291-2/+0
|
* Initialize @_etag.Emilio Tagua2010-09-271-0/+1
|
* Expanded routing documentation with current best practicesJoost Baaij2010-08-291-10/+9
|
* Rely on set and delete cookie logic from rack.José Valim2010-05-181-33/+2
|
* Missing requireswycats2010-04-161-0/+1
|
* adds missing requires for Object#blank? and Object#present?Xavier Noria2010-03-281-0/+1
|
* Set the body using the accessor for AD::Response introspection mode so it ↵Carlhuda2010-02-261-1/+2
| | | | gets wrapped in a []
* Make AD::Response correctly handle bodies that respond_to?(:to_path) as per ↵Carlhuda2010-02-231-0/+12
| | | | the Rack spec
* Fix a bunch of pending tests by providing an introspection mode for the ↵Carlhuda2010-02-191-15/+21
| | | | Response object that does up-front parsing of the headers to populate things like @etag
* Cookies middlewareJoshua Peek2010-01-161-1/+1
|
* Split ActionDispatch http in smaller chunks.José Valim2010-01-161-78/+2
|
* AD::StatusCodes support is now part of rackJoshua Peek2009-12-221-2/+2
|
* AC::Head now doesn't have an unfulfilled Rendering dependency, and instead ↵Yehuda Katz2009-12-201-1/+1
| | | | works just fine standalone (which means that ConditionalGet also doesn't have a Rendering dependency)
* Pending tests for AD ResponseJoshua Peek2009-12-171-13/+12
|
* Fix warnings in AD::ResponseJoshua Peek2009-12-141-0/+3
|
* Ensure Cache-Control max-age is an integerJeremy Kemper2009-12-021-1/+1
|
* Response#write is defined twice (this is why -w is good)Joshua Peek2009-12-011-6/+0
|
* Response#cache_control is defined laterJoshua Peek2009-12-011-1/+0
|
* Fixes expires_now and cleans things up a bitYehuda Katz2009-10-261-0/+2
|
* SessionRestoreError belongs in ADJoshua Peek2009-09-231-4/+4
|
* ActionController::Metal can be a middlewareYehuda Katz + Carl Lerche2009-08-251-1/+4
|
* More perf work:Yehuda Katz2009-08-111-31/+53
| | | | | | | | | | | | | | * Move #set_cookie and #delete_cookie inline to optimize. These optimizations should almost certainly be sent back upstream to Rack. The optimization involves using an ivar for cookies instead of indexing into the headers each time. * Was able to use a bare Hash for headers now that cookies have their own joining semantics (some code assumed that the raw cookies were an Array). * Cache blankness of body on body= * Improve expand_cache_key for Arrays of a single element (common in our case) * Use a simple layout condition check unless conditions are used * Cache visible actions * Lazily load the UrlRewriter * Make etag an ivar that is set on prepare!
* Got overhead down from 127 to 85. All tests pass:Yehuda Katz2009-08-111-36/+56
| | | | | | | | | | | | | | | | | | | | | | | | | * Tentatively replaced HeaderHash with SimpleHeaderHash, which does not preserve case but does handle converting Arrays to Strings in to_hash. This requires further discussion. * Moved default_charset to ActionDispatch::Response to avoid having to hop over to ActionController. Ideally, this would be a constant on AD::Response, but some tests expect to be able to change it dynamically and I didn't want to change them yet. * Completely override #initialize from Rack::Response. Previously, it was creating a HeaderHash, and then we were creating an entirely new one. There is no way to call super without incurring the overhead of creating a HeaderHash. * Override #write from Rack::Response. Its implementation tracks Content-Length, and doing so adds additional overhead that could be mooted if other middleware changes the body. It is more efficiently done at the top-level server. * Change sending_file to an instance_variable instead of header inspection. In general, if a state is important, it should be set as a property of the response not reconstructed later. * Set the Etag to @body instead of .body. AS::Cache.expand_cache_key handles Arrays fine, and it's more efficient to let it handle the body parts, since it is not forced to create a joined String. * If we detect the default cache control case, just set it, rather than setting the constituent parts and then running the normal (expensive) code to generate the string.
* Remove legacy processing and content_lengthYehuda Katz2009-08-021-40/+10
| | | | | | | | | | | * convert_content_type! is handled by assign_default_content_type_and_charset! * set_content_length! should be handled by the endpoint server. Otherwise each middleware that modifies the body has to do the expensive work of recalculating content_length. * convert_language! appears to be legacy. There are no tests for this * convert_cookies! should be handled by the new HeaderHash in Rack * Use an integer for .status's internal representation to avoid needing to do String manipulation just to find out the status
* Update cache_control to be a Hash of options that is used to build the header.Yehuda Katz2009-08-021-5/+19
| | | | * Significantly simplifies setting and modifying cache control in other areas
* Finish making things pass with updated internal content_type semanticsYehuda Katz + Carl Lerche2009-06-151-45/+11
|
* Don't want Rack's Content-Type default header thoughJeremy Kemper2009-05-241-2/+3
|
* Construct a single HeaderHash. Speed up assign_default_content_type_and_charsetJeremy Kemper2009-05-241-4/+10
|
* Cherry-pick core extensionsJeremy Kemper2009-05-131-0/+1
|
* Implemented redirects and partial rendering in new base.Yehuda Katz + Carl Lerche2009-05-121-6/+0
|
* Functional test runner finalizes response just like the integration test ↵Joshua Peek2009-05-021-1/+1
| | | | | runner. In both runners, the @response object will now behave the same. Some functional tests will need to be updated if they are relying on preprocessed data on the response.
* Deprecate assert_redirect_to's partial hash matchingJoshua Peek2009-05-021-2/+0
|
* Start moving TestRequest and TestResponse into ActionDispatchJoshua Peek2009-04-301-56/+0
|
* Group integration test helpers and delegate other helpers to request and ↵Joshua Peek2009-04-301-0/+9
| | | | response objects
* Deprecate template, session, assigns, and layout accessors on response ↵Joshua Peek2009-04-281-3/+13
| | | | object. Instead access them through the controller instance. This mainly affects functional test assertions.
* Deprecate response.assignsJoshua Peek2009-04-281-2/+6
|
* Delegate controller.session to request.session and deprecate response session Joshua Peek2009-04-271-1/+5
|
* Array splitting strings on newlines is deprecatedJeremy Kemper2009-04-261-4/+15
|
* Check for to_str rather than StringJeremy Kemper2009-04-261-3/+1
|
* Inherit TestSession from Session::AbstractStore and add indifferent access ↵Joshua Peek2009-04-261-1/+2
| | | | to Session::AbstractStore.
* Move useful response test helpers into requestJoshua Peek2009-04-261-2/+63
|
* Bring abstract_controller up to date with rails/masterCarl Lerche & Yehuda Katz2009-04-131-42/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolved all the conflicts since 2.3.0 -> HEAD. Following is a list of commits that could not be applied cleanly or are obviated with the abstract_controller refactor. They all need to be revisited to ensure that fixes made in 2.3 do not reappear in 3.0: 2259ecf368e6a6715966f69216e3ee86bf1a82a7 AR not available * This will be reimplemented with ActionORM or equivalent 06182ea02e92afad579998aa80144588e8865ac3 implicitly rendering a js response should not use the default layout [#1844 state:resolved] * This will be handled generically 893e9eb99504705419ad6edac14d00e71cef5f12 Improve view rendering performance in development mode and reinstate template recompiling in production [#1909 state:resolved] * We will need to reimplement rails-dev-boost on top of the refactor; the changes here are very implementation specific and cannot be cleanly applied. The following commits are implicated: 199e750d46c04970b5e7684998d09405648ecbd4 3942cb406e1d5db0ac00e03153809cc8dc4cc4db f8ea9f85d4f1e3e6f3b5d895bef6b013aa4b0690 e3b166aab37ddc2fbab030b146eb61713b91bf55 ae9f258e03c9fd5088da12c1c6cd216cc89a01f7 44423126c6f6133a1d9cf1d0832b527e8711d40f 0cb020b4d6d838025859bd60fb8151c8e21b8e84 workaround for picking layouts based on wrong view_paths [#1974 state:resolved] * The specifics of this commit no longer apply. Since it is a two-line commit, we will reimplement this change. 8c5cc66a831aadb159f3daaffa4208064c30af0e make action_controller/layouts pick templates from the current instance's view_paths instead of the class view_paths [#1974 state:resolved] * This does not apply at all. It should be trivial to apply the feature to the reimplemented ActionController::Base. 87e8b162463f13bd50d27398f020769460a770e3 fix HTML fallback for explicit templates [#2052 state:resolved] * There were a number of patches related to this that simply compounded each other. Basically none of them apply cleanly, and the underlying issue needs to be revisited. After discussing the underlying problem with Koz, we will defer these fixes for further discussion.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-02 10:41:11 +0000