| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
| | |
| | |
| | | |
without this module, the content type is not set correctly
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
Now that `Controller#status=` just delegates to the response object,
we don't need to set the response on the controller and the response.
We can just set it in one place.
|
| | |
| | |
| | |
| | | |
we always have a response object, so there is no reason to test it
|
| | |
| | |
| | |
| | | |
these ivars don't exist anymore, so we can remove them from the list
|
| | |
| | |
| | |
| | |
| | | |
since the controller always has a request on it, we can just ask the
request for the content type.
|
| | |
| | |
| | |
| | |
| | |
| | | |
The controller instance always has an instance of a response object. We
should store the status code on the response object so that it's only
store in one place.
|
| | |
| | |
| | |
| | |
| | | |
We always have a response object in controller instances, so we can
remove this conditional
|
|/ /
| |
| |
| |
| | |
controller instances always have a response object, so we don't need to
test to see if there is one, just always call to_a on the response.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Controllers should always have a request and response when responding.
Since we make this The Rule(tm), then controllers don't need to be
somewhere in limbo between "asking a response object for a rack
response" or "I, myself contain a rack response". This duality leads to
conditionals spread through the codebase that we can delete:
* https://github.com/rails/rails/blob/85a78d9358aa728298cd020cdc842b55c16f9549/actionpack/lib/action_controller/metal.rb#L221-L223
|
| | |
|
| |
| |
| |
| |
| |
| | |
we don't need an instance to figure out what type of response to
allocate. Later we'll pull this up the stack and pass the response
object down
|
| |
| |
| |
| | |
This saves a lambda and request allocation on each request.
|
| |
| |
| |
| |
| | |
controllers should always go through the `action` class method so that
their middleware is respected.
|
| | |
|
| | |
|
| |
| |
| |
| | |
superclass already has this method, so remove this one
|
|\ \
| | |
| | | |
Remove unused block arguments
|
| |/ |
|
| | |
|
| | |
|
| | |
|
| | |
|
|/
|
|
| |
May be missed in 5fe141638f1243ac6ae187ae14aa398b4c1875a2 commit
Also fixes the broken build
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is part of a larger refactoring on controller tests. We needed to
move these methods here so that we could get rid of the `|| key ==
:action || key == :controller` in `assign_parameters`. We know this is
ugly and intend to fix it but for now `generate_extras` needs to be used
in the two methods to access the path and the query_string_keys.
We're adding `:controller` and `:action` to the `query_string_keys`
because we always need a controller and action. If someone passed
`action` or `controller` in in there test they are unambigious - we
know they have to go into the query params.
|
|\
| |
| | |
Authorization scheme should be case insensitive. Fixes #21199
|
| | |
|
| |
| |
| |
| |
| |
| | |
`extra_keys` is a confusing variable name because it's not clear what is
"extra". This renames it to `query_string_keys` so it's clear that the
"extra" is just the query string.
|
| |
| |
| |
| |
| |
| | |
people should be accessing request information through the request
object, not via the env hash. If they really really want at the env
hash, then they can get it off the request.
|
| |
| |
| |
| |
| | |
remove the setter. The request object manages the env hash, so any
mutations need to go through it
|
| |
| |
| |
| |
| | |
Looks like this was left over from converting Rails to Rack. I think
it's safe to remove now.
|
| |
| |
| |
| |
| |
| |
| | |
Actions are processed through `dispatch`, so they should have the
request set on them before any user land code can be executed. Lets
stop setting _env on the controller, and give access to it through the
`env` method.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Convert things like this:
middleware.use "Foo::Bar"
to this:
middleware.use Foo::Bar
|
| |
| |
| |
| |
| | |
use a strategy pattern to calculate the conditional in `valid?` in
advance.
|
| |
| |
| |
| |
| |
| | |
We should do the hard work outside the constructor. Also fix the tests
to not directly construct middleware objects, but to go through the
stack object.
|
| | |
|
| |
| |
| |
| | |
allow testing controllers that use session#fetch with a default value.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
The cookie jar can just ask the request object for the information it
needs. This allows us to stop allocating hashes for options, and also
allows us to delay calculating values in advance. Generating the
options hash forced us to calculate values that we may never have needed
at runtime
|
|/
|
|
|
|
| |
Accessing a request object has nice advantages over accessing a hash.
If you use a missing method name, you'll get an exception rather than a
`nil` (is one nice feature)
|
|
|
|
| |
This is a follow up to #21008.
|
|\
| |
| |
| | |
Add documentation to get a running custom base controller [ci skip]
|
| | |
|
| |
| |
| |
| |
| |
| | |
The request.script_name is dup-d which allocates an extra string. It is most commonly an empty string "". We can save a ton of string allocations by checking first if the string is empty, if so we can use a frozen empty string instead of duplicating an empty string.
This change buys us 35,714 bytes of memory and 893 fewer objects per request.
|
|\ \
| | |
| | | |
Fix params_wrapper doc [ci skip]
|