aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_controller
Commit message (Collapse)AuthorAgeFilesLines
...
* Exceptions from views should be rescued based on the original exception. If ↵Neeraj Singh2010-07-192-2/+18
| | | | | | | | a handler for original exception is missing then apply ActiveView::TemplateError [#2034 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Fixed many references to the old config/environment.rb and Rails::InitializerBenjamin Quorning2010-07-131-1/+1
|
* Fix setting helpers_path to a string or pathnameJeremy Kemper2010-07-071-2/+3
|
* Define a convention for descendants and subclasses.José Valim2010-07-052-7/+0
| | | | | | The former should be symmetric with ancestors and include all children. However, it should not include self since ancestors + descendants should not have duplicated. The latter is symmetric to superclass in the sense it only includes direct children. By adopting a convention, we expect to have less conflict with other frameworks, as Datamapper. For this moment, to ensure ActiveModel::Validations can be used with Datamapper, we should always call ActiveSupport::DescendantsTracker.descendants(self) internally instead of self.descendants avoiding conflicts.
* Fixes for "router" and "routes" terminologyWincent Colaiuta2010-07-033-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit f7ba614c2db improved the internal consistency of the different means of accessing routes, but it introduced some problems at the level of code comments and user-visible strings. This commit applies fixes on three levels: Firstly, we remove or replace grammatically invalid constructs such as "a routes" or "a particular routes". Secondly, we make sure that we always use "the router DSL" or "the router syntax", because this has always been the official terminology. Finally, we make sure that we only use "routes" when referring to the application-specific set of routes that are defined in the "config/routes.rb" file, we use "router" when referring on a more abstract level to "the code in Rails used to handle routing", and we use "routing" when we need an adjective to apply to nouns such as "url_helpers. Again this is consistent with historical practice and other places in the documentation. Note that this is not a sweep over the entire codebase to ensure consistent usage of language; it is just a revision of the changes introduced in commit f7ba614c2db. Signed-off-by: Wincent Colaiuta <win@wincent.com> Signed-off-by: José Valim <jose.valim@gmail.com>
* Unify routes naming by renaming router to routesPiotr Sarnacki2010-07-023-6/+6
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Use caller for helpers_dir deprecation warningsJeremy Kemper2010-06-281-2/+2
|
* Strip_tags never ending attribute should not raise a TypeError [#4870 ↵Bruno Michel2010-06-282-0/+2
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Small changes to responder:José Valim2010-06-261-5/+13
| | | | | | * resources is always an array; * Lazy retrieve request and formats; * Alias api_location and navigation_location to resource_location, making easier to change its behavior without affecting each other and without a need to reimplement any of the behavior methods.
* Move Rails::LogSubscriber to ActiveSupport::LogSubscriber, allowing ↵José Valim2010-06-244-59/+58
| | | | frameworks like ActiveRecord and ActiveResource to log outsude Rails::Application [#4816 state:resolved]
* Sessions should not be created until written to and session data should be ↵Michael Lovitt2010-06-231-0/+2
| | | | | | | | destroyed on reset. [#4938] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Fix controller_name for non default controller paths [#4901 state:resolved]knapo2010-06-231-1/+1
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Add support for specifying locals in view tests with assert template [#4927 ↵David Chelimsky2010-06-221-3/+13
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Merge remote branch 'rails/master'Xavier Noria2010-06-204-10/+22
|\ | | | | | | | | Conflicts: actionpack/lib/abstract_controller/base.rb
| * Make polymorphic_url and scaffolding work with uncountable resources [#3930 ↵Andrew White2010-06-202-4/+13
| | | | | | | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
| * Remove a relic of #request being in RackDelegationwycats2010-06-192-6/+9
| |
* | Fix a bunch of minor spelling mistakesEvgeniy Dolzhenko2010-06-152-3/+3
|\ \ | |/ |/|
| * Fix a bunch of minor spelling mistakesEvgeniy Dolzhenko2010-06-112-3/+3
| |
* | edit pass: the names of Rails components have a space, ie, "Active Record", ↵Xavier Noria2010-06-141-1/+1
|/ | | | not "ActiveRecord"
* class_attribute is not a direct replacement of class_inheritable_*.José Valim2010-06-101-3/+3
| | | | | | If you are setting a hash or an array in class_attribute or you need to freeze it, to ensure people won't modify it in place or you need to dup it on inheritance.
* cache_sweeper yields blank outputNeeraj Singh2010-06-081-0/+1
| | | | | | [#3914 state:open] Signed-off-by: José Valim <jose.valim@gmail.com>
* regular expressions are usually ASCII-encoded, so force_encoding the content ↵wycats2010-06-071-0/+1
| | | | of a Node to the encoding of the regular expression is wrong.
* Make named helpers unprotected without becoming actions [#4696 state:resolved]wycats2010-06-071-0/+8
|
* Reset request.parameters after assigning params for functional testsJeremy Kemper2010-06-061-2/+4
|
* Memoizing methods on request means we need to clear them out on recycle!wycats2010-06-041-3/+3
|
* Add an asset_host accessor for consistency.José Valim2010-06-021-2/+1
|
* Extract assets paths and make them available to Action Mailer as wellDavid Heinemeier Hansson2010-06-021-1/+2
|
* Changes made while working on upgrading cells to Rails 3wycats2010-06-022-4/+5
|
* Add :only and :except to controllers MiddlewareStack. This allowsJosé Valim2010-05-301-3/+45
| | | | | | | | you to do the following: class PostsController < ApplicationController use AutheMiddleware, :except => [:index, :show] end
* Fix a bug where responders were not working properly on method override.José Valim2010-05-241-1/+1
|
* Ruby 1.9: helper path may be a pathname, so convert to a string before ↵Jeremy Kemper2010-05-161-1/+1
| | | | quoting for regexp
* Eliminate false positives when passing symbols to assert_templateDavid Chelimsky2010-05-031-1/+2
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Change event namespace ordering to most-significant first [#4504 state:resolved]Justin George2010-05-024-11/+11
| | | | | | | | | More work still needs to be done on some of these names (render_template.action_view and render_template!.action_view particularly) but this allows (for example) /^sql/ to subscribe to all the various ORMs without further modification Signed-off-by: José Valim <jose.valim@gmail.com>
* add HTTP Token Authorization support to complement Basic and Digest ↵rick2010-04-302-0/+159
| | | | Authorization.
* ActionCachingTestController rescues from all exceptions. Making sure that ↵Neeraj Singh2010-04-291-1/+1
| | | | | | all the tests check for valid response. [#4468 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* extract ActionController::TestCase::BehaviorDavid Chelimsky2010-04-261-126/+133
| | | | | | | | | | - this makes it possible for other test frameworks to hook into testing facilities provided by Rails without having to subclass AC::TestCase. [#4474 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* allow unsubscribe by name or subscription [#4433 state:resolved]David Chelimsky2010-04-241-0/+1
| | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Always downstream given options in :json, :xml and :js renderers and add ↵José Valim2010-04-221-2/+2
| | | | tests for it.
* Clean up the config object in ActionPack. Create config_accessor which just ↵José Valim2010-04-228-165/+93
| | | | delegates to the config object, reducing the number of deprecations and add specific tests.
* It should be possible to render :json with optionswycats2010-04-201-1/+1
|
* perform_caching is now delegated to config on instance and class levelSantiago Pastorino2010-04-171-2/+3
|
* Revert "Avoid deprecation warnings and potential TypeErrors [#4404 ↵Carl Lerche2010-04-161-1/+0
| | | | | | | state:resolved]" Revert "protected instance variables added to the deprecated config accessor This reverts commit 4bce5ba600596b5e7afec9b097866ac259c5940a and 0ee2d3c89a893f0c53924cbb756c7e9be616eb8f.
* page_cache_extension is delegating to config so no need to deprecateSantiago Pastorino2010-04-161-1/+0
|
* Make perform_caching work again, with the tests passing and backward compatibleSantiago Pastorino and Carl Lerche2010-04-153-11/+10
|
* Revert "logger added to the deprecated config accessor" we need a major ↵Santiago Pastorino and Carl Lerche2010-04-151-1/+0
| | | | | | refactor to get this working This reverts commit 68f4e046a7f5db3f7c48a3721bead73a625b6f6e.
* logger added to the deprecated config accessorSantiago Pastorino2010-04-141-0/+1
|
* protected instance variables added to the deprecated config accessorSantiago Pastorino2010-04-141-0/+1
|
* asset and helper path added to the deprecated config accessorSantiago Pastorino2010-04-141-0/+2
|
* page_cache added to the deprecated config accessorSantiago Pastorino2010-04-141-3/+6
|
* Make use of config.perform_cachingSantiago Pastorino2010-04-142-6/+6
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-08 18:13:47 +0000