Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | Whitespaces :scissors: [ci skip] | Rafael Mendonça França | 2012-09-30 | 1 | -1/+1 | |
| | | ||||||
* | | `assert_template` no more passing with what ever string that matches. | Hugo Roque | 2012-09-29 | 1 | -5/+12 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Given Im rendering an template `/layout/hello.html.erb`, assert_template was passing with any string that matches. This behavior allowed false passing like: assert_template "layout" assert_template "out/hello" Now the passing possibilities are: assert_template "layout/hello" assert_template "hello" fixing assert_template bug when template matches expected, but not ends with Cherry Pick Merge: Fixes issue #3849 assert_template false positive taking redundant test off prevening incorrect assert_template when rendering with repeated names in path updating CHANGELOG with bugfix: assert_template false passing | |||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-09-28 | 7 | -117/+137 | |
|\ \ | | | | | | | | | | | | | Conflicts: actionpack/lib/action_view/helpers/asset_tag_helper.rb | |||||
| * | | update AC::ConditionalGet documentation [ci skip] | Francesco Rodriguez | 2012-09-22 | 1 | -27/+31 | |
| | | | ||||||
| * | | update AC::Caching documentation [ci skip] | Francesco Rodriguez | 2012-09-22 | 5 | -87/+103 | |
| | | | ||||||
| * | | remove AC::Parameters reference [ci skip] | Francesco Rodriguez | 2012-09-21 | 1 | -1/+1 | |
| | | | ||||||
| * | | fix typos in AC::StrongParameters documentation [ci skip] | Francesco Rodriguez | 2012-09-21 | 1 | -2/+2 | |
| | | | ||||||
* | | | Is not needed to wrap name inside an array here | Santiago Pastorino | 2012-09-27 | 1 | -1/+1 | |
| | | | ||||||
* | | | Change key not found to param not found | Santiago Pastorino | 2012-09-27 | 1 | -6/+6 | |
| | | | ||||||
* | | | Also includes ConstantLookup dependency for controller and mailer tests | Andy Lindeman | 2012-09-26 | 1 | -0/+1 | |
| | | | ||||||
* | | | Allow strings in the controller test describe blocks | Mike Moore | 2012-09-24 | 1 | -0/+1 | |
| | | | | | | | | | | | | | | | Allow controller tests using the spec DSL to match strings. Add test coverage for the register_spec_type calls. | |||||
* | | | Support controller tests using spec DSL - fixes #7743 | Mike Moore | 2012-09-24 | 1 | -3/+5 | |
|/ / | | | | | | | Add tests for controller tests using the minitest spec DSL. | |||||
* | | fix typos and improve AC::StrongParameters documentation [ci skip] | Francesco Rodriguez | 2012-09-20 | 1 | -6/+8 | |
| | | ||||||
* | | update AC::StrongParameters documentation | Francesco Rodriguez | 2012-09-19 | 1 | -8/+53 | |
| | | ||||||
* | | define permitted? method instead of use an alias to fix rdoc | Francesco Rodriguez | 2012-09-19 | 1 | -2/+12 | |
| | | ||||||
* | | update AC::Parameters documentation [ci skip] | Francesco Rodriguez | 2012-09-19 | 1 | -1/+149 | |
| | | ||||||
* | | update AC::ParameterMissing documentation [ci skip] | Francesco Rodriguez | 2012-09-19 | 1 | -2/+9 | |
| | | ||||||
* | | update AC::ParamsWrapper documentation [ci skip] | Francesco Rodriguez | 2012-09-19 | 1 | -3/+4 | |
|/ | ||||||
* | Set AC::Parameters.permit_all_parameters explicitly to false when ↵ | Guillermo Iguaran | 2012-09-19 | 1 | -1/+1 | |
| | | | | config.action_controller.permit_all_parameters is not present | |||||
* | fix shadowing outer local variable warning | Sergey Nartimov | 2012-09-19 | 1 | -3/+3 | |
| | ||||||
* | Merge pull request #7251 from rails/integrate-strong_parameters | David Heinemeier Hansson | 2012-09-18 | 4 | -7/+132 | |
|\ | | | | | Integrate strong_parameters in Rails 4 | |||||
| * | AC::ParameterMissing inherits from KeyError since it's more appropiated than ↵ | Guillermo Iguaran | 2012-09-16 | 1 | -1/+1 | |
| | | | | | | | | IndexError | |||||
| * | Support fields_for attributes, which may have numeric symbols as hash keys | Guillermo Iguaran | 2012-09-16 | 1 | -0/+4 | |
| | | ||||||
| * | Add config.action_controller.permit_all_attributes to bypass ↵ | Guillermo Iguaran | 2012-09-16 | 2 | -1/+6 | |
| | | | | | | | | StrongParameters protection | |||||
| * | Remove integration between attr_accessible/protected and ↵ | Guillermo Iguaran | 2012-09-16 | 1 | -7/+2 | |
| | | | | | | | | AC::Metal::ParamsWrapper | |||||
| * | Integrate ActionController::Parameters from StrongParameters gem | Guillermo Iguaran | 2012-09-16 | 2 | -0/+121 | |
| | | ||||||
* | | log 404 status when ActiveRecord::RecordNotFound was raised (#7646) | Yves Senn | 2012-09-17 | 1 | -1/+2 | |
| | | ||||||
* | | removes unnecessary self | Xavier Noria | 2012-09-17 | 1 | -1/+1 | |
| | | ||||||
* | | revises the RDoc of AC::Base.without_modules | Xavier Noria | 2012-09-17 | 1 | -2/+2 | |
| | | ||||||
* | | documents the request and response methods in AC::Base | Xavier Noria | 2012-09-17 | 1 | -3/+21 | |
| | | ||||||
* | | revises RDoc in AC::Metal [ci skip] | Xavier Noria | 2012-09-17 | 1 | -14/+7 | |
| | | ||||||
* | | removes unnecessary self | Xavier Noria | 2012-09-17 | 1 | -1/+1 | |
|/ | ||||||
* | Build fix for ActionMailer | Arun Agrawal | 2012-09-14 | 1 | -0/+1 | |
| | | | | | | See http://travis-ci.org/#!/rails/rails/jobs/2444632 | |||||
* | Implement :null_session CSRF protection method | Sergey Nartimov | 2012-09-13 | 1 | -22/+70 | |
| | | | | | | | | It's further work on CSRF after 245941101b1ea00a9b1af613c20b0ee994a43946. The :null_session CSRF protection method provide an empty session during request processing but doesn't reset it completely (as :reset_session does). | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-09-09 | 1 | -1/+1 | |
|\ | | | | | | | | | Conflicts: activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb | |||||
| * | Doc: sweepers only work on Active Record Models | schneems | 2012-09-05 | 1 | -1/+1 | |
| | | | | | | In response to this rails issue: https://github.com/rails/rails/issues/3729 | |||||
* | | Use merge! to merge additional options onto default options | Carlos Antonio da Silva | 2012-09-07 | 1 | -4/+3 | |
| | | ||||||
* | | AS::Callbacks: deprecate monkey patch of object callbacks | Bogdan Gusiev | 2012-09-07 | 1 | -1/+1 | |
| | | ||||||
* | | Fix example code: use tasks instead of comments | Erik Behrends | 2012-09-02 | 1 | -1/+1 | |
|/ | ||||||
* | Sprockets-rails tests fail | Dmitry Vorotilin | 2012-09-01 | 2 | -14/+1 | |
| | | | | | | | Method invalid_asset_host! was delegated to controller but sprockets compile assets in their own scope without controller. And if we set asset_host with second parameter it should raise error through invalid_asset_host!. But since controller is nil it cannot be reached. | |||||
* | Instrumentation requires RackDelegation | José Valim | 2012-08-30 | 1 | -0/+1 | |
| | | | Since it uses request and response methods | |||||
* | Fixes warning: & interpreted as argument prefix | kennyj | 2012-08-30 | 1 | -1/+1 | |
| | ||||||
* | Use class_attribute so we dont bleed | David Heinemeier Hansson | 2012-08-29 | 1 | -1/+6 | |
| | ||||||
* | Added controller-level etag additions that will be part of the action etag ↵ | David Heinemeier Hansson | 2012-08-29 | 1 | -4/+34 | |
| | | | | computation *Jeremy Kemper/DHH* | |||||
* | Fix spacing | David Heinemeier Hansson | 2012-08-29 | 1 | -8/+8 | |
| | ||||||
* | Fix spacing | David Heinemeier Hansson | 2012-08-29 | 1 | -5/+4 | |
| | ||||||
* | Add Missing Keys from Journey on failed URL format | schneems | 2012-08-28 | 1 | -0/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | Many named routes have keys that are required to successfully resolve. If a key is left off like this: <%= link_to 'user', user_path %> This will produce an error like this: No route matches {:action=>"show", :controller=>"users"} Since we know that the :id is missing, we can add extra debugging information to the error message. No route matches {:action=>"show", :controller=>"users"} missing required keys: [:id] This will help new and seasoned developers look closer at their parameters. I've also subclassed the routing error to be clear that this error is a result of attempting to generate a url and not because the user is trying to visit a bad url. While this may sound trivial this error message is misleading and confuses most developers. The important part isn't what's in the options its's what's missing. Adding this information to the error message will make debugging much more obvious. This is the sister pull request of https://github.com/rails/journey/pull/44 which will be required to get they missing keys into the correct error message. Example Development Error in Rails: http://cl.ly/image/3S0T0n1T3421 | |||||
* | Deprecate AV::RecordIdentifier in controllers | Piotr Sarnacki | 2012-08-28 | 2 | -4/+16 | |
| | | | | | | | | Methods provided by RecordIdentifier are not widely used in controllers nowadays as they're view specific (this is probably a legacy left after RJS rendering directly in controllers). However if people still need to use it, it's trivial to include ActionView::RecordIdentifier by themselves. | |||||
* | No need to use included hook for include | Piotr Sarnacki | 2012-08-28 | 1 | -3/+1 | |
| | | | | | When module is extended ActiveSupport::Concern, include calls are lazily loaded, so there is no need to wrap it with included hook. | |||||
* | Add deprecation horizon to html-scanner | Piotr Sarnacki | 2012-08-28 | 1 | -1/+2 | |
| |