aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_controller
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #15537 from tgxworld/fix_state_leakMatthew Draper2014-06-201-1/+0
|\ | | | | Fix state leak.
| * Prevent state leak.Guo Xiang Tan2014-06-051-1/+0
| |
* | [ci skip] /javascript/ ~> JavaScriptAditya Kapoor2014-06-171-3/+3
| |
* | Merge pull request #15692 from sromano/falseClassMatthew Draper2014-06-141-1/+6
|\ \ | | | | | | | | | ActionController::Parameters#require now accepts FalseClass values
| * | ActionController::Parameters#require now accepts FalseClass valuesSergio Romano2014-06-131-0/+1
|/ / | | | | | | Fixes #15685.
* | Merge pull request #15682 from tgxworld/controller_test_processRafael Mendonça França2014-06-131-2/+5
|\ \ | | | | | | Set flash in test session when necessary.
| * | Set flash in test session when necessary.Guo Xiang Tan2014-06-121-2/+5
| | | | | | | | | | | | `to_session_value` returns nil when empty.
* | | Fix parsed token value with header `Authorization token=`.Larry Lv2014-06-131-2/+2
| | |
* | | Set the status before of setting the response bodyGuillermo Iguaran2014-06-131-2/+2
|/ / | | | | | | | | | | | | The 401 status should be set first because setting the response body in a live controller also closes the response to further changes. Fixes #14229.
* | Handle client disconnect during live streamingMatthew Draper2014-06-081-0/+48
| | | | | | | | .. even when the producer is blocked for a write.
* | adds some details to the rationale of converted_arrays [ci skip]Xavier Noria2014-06-071-0/+4
| |
* | Revert "Convert StrongParameters cache to a hash. This fixes an unbounded"Xavier Noria2014-06-071-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We cannot cache keys because arrays are mutable. We rather want to cache the arrays. This behaviour is tailor-made for the usage pattern strongs params is designed for. In a forthcoming commit I am going to add a test that covers why we need to cache by value. Every strong params instance has a live span of a request, the cache goes away with the object. Since strong params have such a concrete intention, it would be interesting to see if there are actually any real-world use cases that are an actual leak, one that practically may matter. I am not convinced that the theoretical leak has any practical consequences, but if it can be shown there are, then I believe we should either get rid of the cache (which is an optimization), or else wipe it in the mutating API. This reverts commit e63be2769c039e4e9ada523a8497ce3206cc8a9b.
* | [ci skip] Fix capitalizationAkshay Vishnoi2014-06-071-1/+1
| |
* | eliminate wasteful AS::SafeBuffer allocationAaron Patterson2014-06-061-1/+1
|/
* Avoid misuse of underscore argumentCorey Ward2014-06-051-2/+2
| | | Per convention, underscore-only argument names should be used for unused parameters.
* Convert StrongParameters cache to a hash. This fixes an unboundedRyan Davis2014-06-031-6/+6
| | | | | | memory leak demonstrated on @tenderlove's latest blog post: http://tenderlovemaking.com/2014/06/02/yagni-methods-are-killing-me.html
* Merge branch 'constraints'Aaron Patterson2014-05-271-3/+8
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * constraints: rm reset_parameters because we automatically do it from 9ca4839a move path_parameter encoding check to the request object dispatcher doesn't need `call` anymore call `serve` with the request on dispatchers constraints class does not need the request class anymore give all endpoints a superclass skip the build business if the stack is empty stop hardcoding path_parameters and get it from the request we do not need to cache rack_app a redirect is not a dispatcher by definition, so eliminate test push is_a check up to where the Constraints object is allocated pass the request object to the application pass a request to `matches?` so we can avoid creating excess requests nothing is passed to `rack_app` anymore, so rm the params one fewer is_a check Constraints#app should never return another Constraints object, so switch to if statement eliminate dispatcher is_a checks push is_a?(Dispatcher) check in to one place Always construct route objects with Constraint objects Conflicts: actionpack/lib/action_controller/metal.rb
| * skip the build business if the stack is emptyAaron Patterson2014-05-261-2/+6
| |
| * stop hardcoding path_parameters and get it from the requestAaron Patterson2014-05-261-1/+2
| |
* | Merge pull request #15325 from tgxworld/no_need_to_call_to_sYves Senn2014-05-261-1/+1
|\ \ | | | | | | Remove duplicated to_s method call.
| * | Remove duplicated to_s method call.Guo Xiang Tan2014-05-251-1/+1
| |/
* / Fix docs for ActionController::Renderers.addGuillermo Iguaran2014-05-261-1/+1
|/
* use Proc.new to automatically do parameter checking for usAaron Patterson2014-05-231-3/+1
|
* use symbol keys for path_parametersAaron Patterson2014-05-222-6/+6
|
* we can just use Ruby hereAaron Patterson2014-05-211-2/+2
|
* fix formatting and text for ActionController::Redirecting docLaurel Fan2014-05-211-4/+8
|
* Merge pull request #11346 from tomykaira/fix_10257Rafael Mendonça França2014-05-201-2/+14
|\ | | | | Check authentication scheme in Basic auth
| * Run login_procedure only when the auth_scheme is validtomykaira2013-07-081-7/+14
| |
| * Check authentication scheme in Basic authtomykaira2013-07-071-1/+6
| | | | | | | | | | | | | | | | | | | | `authenticate_with_http_basic` and its families should check the authentication schema is "Basic". Different schema, such as OAuth2 Bearer should be rejected by basic auth, but it was passing as the test shows. This fixes #10257.
* | Add ActionController::Renderers.remove.Zuhao Wan2014-05-201-0/+16
| |
* | fixes stack level too deep exception on action named 'status' returning ↵Christiaan Van den Poel2014-05-153-2/+6
| | | | | | | | 'head :ok'
* | Merge pull request #14137 from dasch/better-fragment-cache-instrumentationRafael Mendonça França2014-05-141-1/+7
|\ \ | | | | | | | | | | | | | | | | | | Add controller and action name to the fragment caching instrumentation payload Conflicts: actionpack/CHANGELOG.md
| * | Add controller and action name to the instrumentation payloadDaniel Schierbeck2014-05-101-1/+7
| | |
* | | Add multiple lines message support for SSE moduleayaya2014-05-121-1/+2
| | |
* | | Moved 'params[request_forgery_protection_token]' into its own method and ↵Tom Kadwill2014-05-061-1/+1
| | | | | | | | | | | | improved tests.
* | | Fix examples indent and improve #process docs a bit [ci skip]Carlos Antonio da Silva2014-05-041-16/+14
| | |
* | | Document ActionController::TestCase::Behavior#processGaurish Sharma2014-05-041-0/+27
|/ / | | | | | | [ci skip]
* | do not allocate strings while creating urlsAaron Patterson2014-04-301-1/+1
| |
* | don't allocate string on hash accessAaron Patterson2014-04-301-1/+1
| |
* | ActionController::Renderers documentation fixStevie Graham2014-04-201-2/+2
| | | | | | | | | | ActionController::Renderers::RENDERERS is an instance of Set. Docs incorrectly state that it's a Hash.
* | [ci skip] builtin -> built-inAkshay Vishnoi2014-04-201-1/+1
| |
* | Update AC::Metal documentation example [ci skip]Yury Velikanau2014-04-151-1/+2
| | | | | | | | Include proper module since AV was extracted form AP as mentioned in #14659.
* | Fix subscriptions not being unsubscribed.Guo Xiang Tan2014-04-141-5/+7
| |
* | Tiny doc fix for Strong ParametersIan C. Anderson2014-03-301-1/+1
| | | | | | - accepts_nested_attribute_for -> accepts_nested_attributes_for
* | Replace trivial regexp with string or index, twice as fastKelley Reynolds2014-03-281-1/+1
| |
* | update comments to reflect that options support is not availableFrederick Cheung2014-03-251-2/+2
| |
* | re-raise error if error occurs before committing in streamingKevin Casey2014-03-141-10/+11
| | | | | | | | update the tests, using an if-else
* | use the body proxy to freeze headersAaron Patterson2014-03-122-3/+9
| | | | | | | | | | | | avoid freezing the headers until the web server has actually read data from the body proxy. Once the webserver has read data, then we should throw an error if someone tries to set a header
* | just ask the response for the commit status, we do not need to ask the jarAaron Patterson2014-03-121-1/+1
| |
* | only write the jar if the response isn't committedAaron Patterson2014-03-122-5/+23
| | | | | | | | | | | | | | | | | | | | | | when streaming responses, we need to make sure the cookie jar is written to the headers before returning up the stack. This commit introduces a new method on the response object that writes the cookie jar to the headers as the response is committed. The middleware and test framework will not write the cookie headers if the response has already been committed. fixes #14352
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 15:50:27 +0000