aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_controller
Commit message (Collapse)AuthorAgeFilesLines
* Change docs to use update instead of update_attributesAmparo Luna + Guillermo Iguaran2013-01-031-2/+2
|
* Inherit from MiniTest::Unit::TestCase instead of MiniTest::SpecRafael Mendonça França2012-12-311-7/+0
|
* charset should not be appended for `head` responsesYves Senn2012-12-311-0/+1
| | | | | | | 1) Failure: test_head_created_with_image_png_content_type(RenderTest) [test/controller/render_test.rb:1238]: Expected: "image/png" Actual: "image/png; charset=utf-8"
* "warning: ambiguous first argument; put parentheses or even spaces"Akira Matsuda2012-12-241-1/+1
|
* Refactoring the token_and_options method to fix bugsKurtis Rainbolt-Greene2012-12-151-11/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Adding a test for the equal trun bug Adding a test for the after equal trunc bug Adding a test for the slash bug Adding a test for the slash quote bug Adding a helper method for creating a sample request object with token Writing a method to create params array from raw params Writing a method to rewrite param values in the params Writing a method to get the token params from an authorization value Refactoring the token_and_options method to fix bugs Removing unnessecary test A constant for this shared regex seemed appropriate Wanting to split up this logic Adding small documentation pieces
* Add missing require.Rafael Mendonça França2012-12-131-0/+1
| | | | | I was trying to use those files without Rails and that require was missing.
* Bring back helpers_path attr accessorCarlos Antonio da Silva2012-12-131-1/+1
| | | | | This is apparently used by the railtie to setup the app helpers paths correctly between initializers. I'll need to check it further.
* Refactor helpers code in Action Pack a bitCarlos Antonio da Silva2012-12-132-7/+5
| | | | | | | | * Avoid calling class_eval when not needed * Remove helpers_path attr accessor, it's defined as a class attribute a few lines later * Avoid creating extra arrays when finding helpers, use flat_map and sort! * Remove not required refer variable when redirecting :back
* Remove not used variable warnings from AM and ACCarlos Antonio da Silva2012-12-111-1/+1
|
* use `_action` instead of `_filter` callbacksFrancesco Rodriguez2012-12-071-6/+6
|
* update documentation and code to use _action callbacksFrancesco Rodriguez2012-12-072-7/+7
|
* Merge pull request #8404 from freegenie/filter_redirectsAndrew White2012-12-051-1/+1
|\
| * Adding filter capability to ActionController logsFabrizio Regini2012-12-051-1/+1
| |
* | Replace comments' non-breaking spaces with spacesclaudiob2012-12-042-3/+3
|/ | | | | | | | | | Sometimes, on Mac OS X, programmers accidentally press Option+Space rather than just Space and don’t see the difference. The problem is that Option+Space writes a non-breaking space (0XA0) rather than a normal space (0x20). This commit removes all the non-breaking spaces inadvertently introduced in the comments of the code.
* Fix a typo in ActionController::CachingJean Boussier2012-12-031-2/+1
|
* Cleans and removes useless 'Examples' tag [ci skip]Alvaro Pereyra2012-12-011-2/+0
|
* Revert "Remove trailing whitespaces"Florent Guilleux2012-12-011-1/+1
| | | | This reverts commit 90c887fa7d0c454b7533e208daefc342dea4d5f3.
* Remove trailing whitespacesFlorent Guilleux2012-12-011-1/+1
|
* hash filters should be accessed with symbols or stringsFrancesco Rodriguez2012-11-301-3/+5
|
* Remove observers and sweepersRafael Mendonça França2012-11-282-121/+2
| | | | | | | | They was extracted from a plugin. See https://github.com/rails/rails-observers [Rafael Mendonça França + Steve Klabnik]
* Fix Strong Parameters docs.Uģis Ozols2012-11-271-2/+1
| | | | | It's only possible to inherit from ActiveRecord::Base and not include it.
* Remove warning of circular requireRafael Mendonça França2012-11-271-1/+1
| | | | | | | | | This file was using mime_types before load the Mime::Type class. When trying to register first Mime::Type it load mime_type that loads mime_types in the end. Requiring mime_type ensure that we have the class definition and the mime types
* Accept symbols as #send_data :disposition valueElia Schito2012-11-271-0/+1
|
* assert_template: validating option keysRoberto Soares2012-11-251-0/+2
|
* `assert_template` fails with empty string.Roberto Soares2012-11-231-8/+4
|
* `assert_template` fails with empty string when a template has been renderedRoberto Soares2012-11-231-4/+8
| | | | | | | | For instance, it prevents false positive in this case: file = nil get :index assert_template("#{file}")
* Merge pull request #8183 from jcoglan/objectless_sessionsJon Leighton2012-11-211-1/+2
|\ | | | | Store FlashHashes in the session as plain hashes
| * Store FlashHashes in the session as plain hashes rather than custom objects ↵James Coglan2012-11-091-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | with unstable class names and instance variables. Refactor FlashHash to take values for its ivars in the constructor, to pretty up FlashHash.from_session_value. Remove stale comment on FlashHash: it is no longer Marshaled in the session so we can change its implementation. Remove blank lines I introduced in controller/test_case.rb. Unit tests for FlashHash#to_session_value. Put in a compatibility layer to accept FlashHash serializations from Rails 3.0+. Test that Rails 3.2 session flashes are correctly converted to the new format. Remove code path for processing Rails 3.0 FlashHashes since they can no longer deserialize. Fix session['flash'] deletion condition: it will never be empty?, it will either be nil or a hash with 'discard' and 'flashes' keys.
* | Merge pull request #8112 from rails/encrypted_cookiesSantiago Pastorino2012-11-152-7/+7
|\ \ | | | | | | Encrypted cookies
| * | Allow users to change the default salt if they want, shouldn't be necessarySantiago Pastorino2012-11-031-2/+3
| | |
| * | Use derived keys everywhere, http_authentication was missing itSantiago Pastorino2012-11-031-3/+2
| | |
| * | Sign cookies using key deriverSantiago Pastorino2012-11-031-4/+4
| |/
* | lazily calculate name in the options objectAaron Patterson2012-11-131-14/+18
| |
* | move include calculation to include method on the options objectAaron Patterson2012-11-131-9/+24
| |
* | model name is lazily evaluated in the options objectAaron Patterson2012-11-131-27/+37
| |
* | move the controller class to the options objectAaron Patterson2012-11-131-9/+12
| |
* | attribute_names will always return a list, so just use any?Aaron Patterson2012-11-131-1/+1
| |
* | wrap up hash conversion in the constructorAaron Patterson2012-11-131-5/+5
| |
* | use the options object in the wrapper defaultsAaron Patterson2012-11-131-13/+12
| |
* | start using options objectAaron Patterson2012-11-131-9/+20
| |
* | only do hash lookups on options onceAaron Patterson2012-11-131-13/+15
| |
* | replace present? with any? to reduce dependency on ASAaron Patterson2012-11-132-1/+2
| |
* | Revert "Merge pull request #8017 from jcoglan/objectless_sessions"Jon Leighton2012-11-091-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 36376560fdd02f955ae3bf6b7792b784443660ad, reversing changes made to 3148ed9a4bb7efef30b846dc945d73ceebcc3f0f. Conflicts: actionpack/lib/action_dispatch/middleware/flash.rb Reason: it broke Sam's CI https://github.com/rails/rails/pull/8017#issuecomment-10210655
* | Merge pull request #8017 from jcoglan/objectless_sessionsJon Leighton2012-11-081-1/+2
|\ \ | | | | | | Store FlashHashes in the session as plain hashes
| * | Store FlashHashes in the session as plain hashes rather than custom objects ↵James Coglan2012-11-031-1/+2
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | with unstable class names and instance variables. Refactor FlashHash to take values for its ivars in the constructor, to pretty up FlashHash.from_session_value. Remove stale comment on FlashHash: it is no longer Marshaled in the session so we can change its implementation. Remove blank lines I introduced in controller/test_case.rb. Unit tests for FlashHash#to_session_value. Put in a compatibility layer to accept FlashHash serializations from Rails 3.0+. Test that Rails 3.2 session flashes are correctly converted to the new format. Remove code path for processing Rails 3.0 FlashHashes since they can no longer deserialize.
* | Set @permitted on new instance when slicing parameters hashBenjamin Quorning2012-11-061-1/+3
| |
* | Remove #permitted attr accessor from ParametersCarlos Antonio da Silva2012-11-031-1/+0
|/ | | | | There is no need to expose this accessor since we already have the query method #permitted? that should handle this purpose.
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-11-0316-79/+79
|\ | | | | | | | | | | | | Conflicts: actionpack/lib/action_controller/metal/mime_responds.rb activerecord/lib/active_record/attribute_methods.rb guides/source/working_with_javascript_in_rails.md
| * Revert "dont encourage AC::Parameters#permit_all_parameters usage [ci skip]"Vijay Dev2012-11-031-1/+21
| | | | | | | | | | | | | | | | This reverts commit cd17ee5598411728747011566abf6779166be9d3. Reason: Let's note that this is discouraged, not remove the docs [ci skip]
| * dont encourage AC::Parameters#permit_all_parameters usage [ci skip]Francesco Rodriguez2012-10-281-21/+1
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-31 16:46:17 +0000