Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Strong parameters should permit nested number as key. Closes #12293 | kennyj | 2013-09-27 | 1 | -1/+5 |
| | |||||
* | [ci skip] escape unintended url in docs | Chris Ciollaro | 2013-09-26 | 1 | -1/+1 |
| | |||||
* | Fix regex used to find URI schemes in redirect_to | Derek Prior | 2013-09-19 | 1 | -1/+1 |
| | | | | | The previous regex was allowing `_` in the URI scheme, which is not allowed by RFC 3986. This change brings the regex in line with the RFC. | ||||
* | Fix incorrect assert_redirected_to failure message | Derek Prior | 2013-09-19 | 1 | -19/+20 |
| | | | | | | | | | | | | | | | In some instances, `assert_redirected_to` assertion was returning an incorrect and misleading failure message when the assertion failed. This was due to a disconnect in how the assertion computes the redirect string for the failure message and how `redirect_to` computes the string that is actually used for redirection. I made the `_compute_redirect_to_loaction` method used by `redirect_to` public and call that from the method `assert_redirect_to` uses to calculate the URL. The reveals a new test failure due to the regex used by `_compute_redirect_to_location` allow `_` in the URL scheme. | ||||
* | NullSessionHash#destroy should be a no-op | Jonathan Baudanza | 2013-09-18 | 1 | -0/+3 |
| | | | | Previously it was raising a NilException | ||||
* | Removing ActiveSupport::Concern, it's not needed | Attila Domokos | 2013-09-13 | 1 | -2/+0 |
| | |||||
* | Fixing comment typo in ActionController::Base | Attila Domokos | 2013-09-13 | 1 | -1/+1 |
| | |||||
* | Custom flash should be defined only for the class that defines it and it's ↵ | Ricardo de Cillo | 2013-09-13 | 1 | -1/+1 |
| | | | | subclasses. | ||||
* | Merge pull request #12159 from nashby/issue-12149 | Rafael Mendonça França | 2013-09-12 | 1 | -1/+1 |
|\ | | | | | do not break params filtering on nil values | ||||
| * | do not break params filtering on nil values | Vasiliy Ermolovich | 2013-09-07 | 1 | -1/+1 |
| | | | | | | | | closes #12149 | ||||
* | | Remove remaining coupling with AV in MimeResponds | José Valim | 2013-09-09 | 2 | -5/+6 |
| | | |||||
* | | Remove BasicRendering and remove template functionality from AbsC::Rendering | José Valim | 2013-09-09 | 2 | -4/+7 |
|/ | |||||
* | Do not use instance variables if they are not reused elsewhere | Carlos Antonio da Silva | 2013-09-06 | 1 | -2/+1 |
| | |||||
* | render_to_string shouldn't play with response_body | Santiago Pastorino | 2013-09-04 | 1 | -4/+5 |
| | |||||
* | Fix a few typos. [ci skip] | namusyaka | 2013-09-04 | 1 | -1/+1 |
| | |||||
* | Move BasicRendering to AbstractController | Łukasz Strzałkowski | 2013-09-03 | 2 | -29/+1 |
| | |||||
* | Make Mime::TEXT default format in AbstractController | Łukasz Strzałkowski | 2013-09-03 | 1 | -4/+0 |
| | |||||
* | Revert "Port all remaining self.protected_instance_variables to class methods" | Łukasz Strzałkowski | 2013-09-02 | 1 | -6/+5 |
| | | | | This reverts commit 7de994fa215e9f4c2856d85034bc4dd7b65d0c01. | ||||
* | Stop messing up with instance variables, use protected as it was meant for | Carlos Antonio da Silva | 2013-08-30 | 1 | -2/+7 |
| | |||||
* | Port all remaining self.protected_instance_variables to class methods | Łukasz Strzałkowski | 2013-08-29 | 1 | -5/+6 |
| | |||||
* | Fix formatting of error message | Łukasz Strzałkowski | 2013-08-25 | 1 | -2/+1 |
| | | | | Make it oneliner | ||||
* | Change description of BasicRendering#render | Łukasz Strzałkowski | 2013-08-25 | 1 | -1/+1 |
| | | | | | | We're not dealing with templates here [ci skip] | ||||
* | Simplify if statements | Łukasz Strzałkowski | 2013-08-25 | 1 | -6/+4 |
| | |||||
* | Describe BasicRendering shortly | Łukasz Strzałkowski | 2013-08-25 | 1 | -0/+4 |
| | | | | [ci skip] | ||||
* | Extend basic rendering, test it in railties | Łukasz Strzałkowski | 2013-08-25 | 1 | -3/+16 |
| | |||||
* | Fist stab on basic rendering | Łukasz Strzałkowski | 2013-08-25 | 2 | -0/+19 |
| | |||||
* | Do not include action_view/layouts | Łukasz Strzałkowski | 2013-08-25 | 1 | -1/+0 |
| | | | | We don't need them. They'll be loaded automaticly if AV will be included | ||||
* | Add #rendered_format method to controllers | Łukasz Strzałkowski | 2013-08-25 | 1 | -4/+4 |
| | |||||
* | Do not load AV inside AP | Łukasz Strzałkowski | 2013-08-25 | 1 | -1/+0 |
| | | | | Move that part to AV railtie | ||||
* | Revert "Move setting content_type to AV" | Łukasz Strzałkowski | 2013-08-25 | 1 | -0/+1 |
| | | | | This reverts commit f4d602aff6cec80304b131ecfcc2676d0304f0cc. | ||||
* | Change documentation of metal anonymous class | Łukasz Strzałkowski | 2013-08-25 | 1 | -5/+10 |
| | | | | | | Make it clearer [ci skip] | ||||
* | Move setting content_type to AV | Łukasz Strzałkowski | 2013-08-25 | 1 | -1/+0 |
| | |||||
* | Indent protected methods | Łukasz Strzałkowski | 2013-08-25 | 1 | -18/+18 |
| | | | | [ci skip] | ||||
* | Load AV::Layouts dynamicly via railties | Łukasz Strzałkowski | 2013-08-25 | 2 | -3/+0 |
| | |||||
* | Code formatting & typo fixes | Łukasz Strzałkowski | 2013-08-25 | 1 | -1/+1 |
| | |||||
* | Move anonymous class to the top, add documentation | Łukasz Strzałkowski | 2013-08-25 | 1 | -4/+9 |
| | |||||
* | Create AbstractController::Rendering interface | Łukasz Strzałkowski | 2013-08-25 | 1 | -1/+5 |
| | | | | This interface should be use when implementing renderers. | ||||
* | Fix AP test suite after moving stuff to AV | Łukasz Strzałkowski | 2013-08-25 | 1 | -0/+1 |
| | |||||
* | Hook up AV::Rendering on AV intialization | Łukasz Strzałkowski | 2013-08-25 | 1 | -2/+0 |
| | |||||
* | Move layouts to AV | Łukasz Strzałkowski | 2013-08-25 | 1 | -1/+1 |
| | |||||
* | Move rendering from AP to AV | Łukasz Strzałkowski | 2013-08-25 | 2 | -2/+2 |
| | |||||
* | Merge pull request #11443 from wangjohn/sse_reloader_class | Santiago Pastorino | 2013-08-19 | 1 | -0/+74 |
|\ | | | | | SSE class for ActionController::Live | ||||
| * | Creating an SSE class to be used with ActionController::Live. | wangjohn | 2013-07-30 | 1 | -0/+74 |
| | | |||||
* | | Fail informatively in #respond_with when no appropriate #api_behavior ↵ | Ben Woosley | 2013-08-17 | 2 | -0/+13 |
| | | | | | | | | | | | | | | | | | | | | | | | | renderer is available. Currently if a user calls #respond_with(csvable), but has not csv renderer available, Responder will just run through the default render behavior twice, raising ActionView::MissingTemplate both times. This changes ActionController::Metal::Responder#api_behavior to check in advance whether there is a renderer available, and raise ActionController::MissingRenderer if not. | ||||
* | | Merge branch 'master' of github.com:rails/docrails | Vijay Dev | 2013-08-17 | 1 | -1/+1 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | Conflicts: actionview/README.rdoc activerecord/lib/active_record/migration.rb guides/source/development_dependencies_install.md guides/source/getting_started.md | ||||
| * | | Revert "Merge branch 'master' of github.com:rails/docrails" | Vijay Dev | 2013-08-17 | 1 | -1/+1 |
| |/ | | | | | | | | | | | | | This reverts commit 70d6e16fbad75b89dd1798ed697e7732b8606fa3, reversing changes made to ea4db3bc078fb3093ecdddffdf4f2f4ff3e1e8f9. Seems to be a code merge done by mistake. | ||||
* | | Added data for permit array into scalar value | Rahul P. Chaudhari | 2013-08-05 | 1 | -0/+1 |
| | | |||||
* | | fix a gramatical mistake | Rajeev N Bharshetty | 2013-08-02 | 1 | -1/+1 |
| | | |||||
* | | Improve documentation for controller how to get included helpers [ci skip] | Paul Nikitochkin | 2013-07-30 | 1 | -1/+1 |
|/ | | | | Closes #11671 | ||||
* | Typo fix | Ankit Gupta | 2013-07-25 | 1 | -1/+1 |
| | | | | | [skip ci] Fixing the typo which is formed a not required link. Check here http://api.rubyonrails.org/classes/ActionController/Base.html under paramters section keeping it under tt tag |