|  | Commit message (Collapse) | Author | Age | Files | Lines | 
|---|
| ... |  | 
| | | | 
| | | 
| | | 
| | | 
| | | | We should call the setter on `path_parameters` so that we know the hash
will only contain the values that we've set. | 
| | | | 
| | | 
| | | 
| | | 
| | | | I'd like to put all env mutations together so we can understand how to
change this code to call `call` on the controller | 
| | | | 
| | | 
| | | 
| | | 
| | | | Since parameters are converted to a query string, they will
automatically be turned in to strings by the query parser | 
| | | | 
| | | 
| | | 
| | | 
| | | | non_path_parameters is used internally (it never escapes this method) so
we should be able to safely use a regular hash. | 
| | | | 
| | | 
| | | 
| | | 
| | | | since we are serializing parameters, we don't need to do all the dup
checks on each object. | 
| |/ /  
| |   
| |   
| |   
| |   
| | | We should roundtrip the parameters through their respective encoders /
decoders so that the controller will get parameters similar to what they
actually get in a real world situation | 
| | | 
| | 
| | 
| | 
| | 
| | | We should convert request parameters to a query string, then let the
request object parse that query string.  This should give us results
that are more similar to the real-world | 
| | | 
| | 
| | 
| | 
| | | We should assign parameters to the request object rather than mutate the
hash that is returned by `query_parameters` or `request_parameters` | 
| | | 
| | 
| | 
| | | this prevents mutations from being available globally | 
| | | 
| | 
| | 
| | 
| | 
| | | Instead of trying to manually clear out a request object, lets just
allocate a new one.  The rack ENV is reused and cleaned (still), but the
request object is not. | 
| | | |  | 
| | | |  | 
| | | |  | 
| | | 
| | 
| | 
| | 
| | | There is no reason to "recycle" response objects when we can just
allocate a new one. | 
| | | 
| | 
| | 
| | 
| | | we should be pushing the cookies in via headers rather than maintaining
some object and "recycling" it. | 
| |/ |  | 
| |\  
| | 
| | | Allow default_render to take a block to customize behavior when there's no template | 
| | | 
| | 
| | 
| | 
| | 
| | 
| | 
| | 
| | 
| | | In 0de4a23 the behavior when there is a missing template was changed to
not raise an error, but instead head :no_content.  This is a breaking
change and some gems rely on this happening.
To allow gems and other code to work around this, allow
`default_render` to take a block which, if provided, will
execute the contents of that block instead of doing the `head :no_content`. | 
| |\ \  
| | | 
| | | 
| | | 
| | | 
| | | | vngrs/strong_parameters_unpermitted_parameters_wrong_doc_fix
Fix the documentation about ActionController::UnpermittedParameters [ci skip] | 
| |/ / |  | 
| |/ |  | 
| | |  | 
| | |  | 
| | 
| 
| 
| | [ci skip] | 
| | |  | 
| |\  
| | 
| | | fixed sring to be string in ActiveRecord::Base params documentation [ci skip] | 
| | | |  | 
| | | |  | 
| | | |  | 
| | | 
| | 
| | 
| | 
| | 
| | 
| | 
| | 
| | | ParamsWrapper was initially removed from API controllers according to
the following discusision:
https://github.com/rails-api/rails-api/issues/33
However, we're including it again so Rails API devs can decide
whether to enable or disable it. | 
| | | |  | 
| | | |  | 
| | | |  | 
| | | |  | 
| |/ |  | 
| | 
| 
| 
| | skip] | 
| |\ |  | 
| | | |  | 
| |\ \  
| | | 
| | | | Have Bearer be valid as well | 
| | | | |  | 
| |\ \ \  
| |/ /  
|/| | | Deprecate `assert_template` and `assigns()`. | 
| | | | |  | 
| |/ /  
| |   
| |   
| |   
| |   
| | | It's better to use Ruby methods when possible over methods defined by
Active Support because then it does not need to rely on any
dependencies. | 
| | | 
| | 
| | 
| | | Code was moved into the `assign` method. | 
| | | 
| | 
| | 
| | | `head` method works similar to `render` method with `:nothing` option | 
| |\ \  
| | | 
| | | | [PoC] Stop shadowing parameters named `action` | 
| | | | |  | 
| | | | 
| | | 
| | | 
| | | 
| | | 
| | | 
| | | 
| | | 
| | | 
| | | | spelling fix [ci skip]
example to be consistent [ci skip]
grammatical fix
typo fixes [ci skip] | 
| | | | 
| | | 
| | | 
| | | 
| | | 
| | | 
| | | 
| | | 
| | | | Stems from https://github.com/rails/rails/pull/20105#issuecomment-100900939
where @senny said:
> From my point of view, all the docs (guides, API) are version bound.
> They should describe that version and continue to be available when newer versions are released.
> The cross referencing can be done by the interested user. | 
| | |/  
|/|   
| |   
| |   
| |   
| |   
| |   
| |   
| |   
| |   
| | | This moves `TemplateAssertions` out of the `test_case.rb` file and into
it's own `template_assertions` file. It still inherits from
`ActionController`.`
This is in preparation for combining the code for Integration tests and
Controller tests. This will need to be it's own file to be added to the
`requires` for Integration tests. This does not currently change ANY
behavior, just moving it for access later on. |