aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_controller
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #7708 from bdurand/optimize_log_subscribersRafael Mendonça França2012-10-011-6/+11
|\ | | | | Optimize log subscribers to check if the log level is sufficient
| * Optimize log subscribers to check if the log level is sufficient before ↵Brian Durand2012-09-301-6/+11
| | | | | | | | performing an operations.
* | prefix TemplateAssertions ivars (#7459)Yves Senn2012-10-011-20/+20
| |
* | Whitespaces :scissors: [ci skip]Rafael Mendonça França2012-09-301-1/+1
| |
* | `assert_template` no more passing with what ever string that matches.Hugo Roque2012-09-291-5/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Given Im rendering an template `/layout/hello.html.erb`, assert_template was passing with any string that matches. This behavior allowed false passing like: assert_template "layout" assert_template "out/hello" Now the passing possibilities are: assert_template "layout/hello" assert_template "hello" fixing assert_template bug when template matches expected, but not ends with Cherry Pick Merge: Fixes issue #3849 assert_template false positive taking redundant test off prevening incorrect assert_template when rendering with repeated names in path updating CHANGELOG with bugfix: assert_template false passing
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-09-287-117/+137
|\ \ | | | | | | | | | | | | Conflicts: actionpack/lib/action_view/helpers/asset_tag_helper.rb
| * | update AC::ConditionalGet documentation [ci skip]Francesco Rodriguez2012-09-221-27/+31
| | |
| * | update AC::Caching documentation [ci skip]Francesco Rodriguez2012-09-225-87/+103
| | |
| * | remove AC::Parameters reference [ci skip]Francesco Rodriguez2012-09-211-1/+1
| | |
| * | fix typos in AC::StrongParameters documentation [ci skip]Francesco Rodriguez2012-09-211-2/+2
| | |
* | | Is not needed to wrap name inside an array hereSantiago Pastorino2012-09-271-1/+1
| | |
* | | Change key not found to param not foundSantiago Pastorino2012-09-271-6/+6
| | |
* | | Also includes ConstantLookup dependency for controller and mailer testsAndy Lindeman2012-09-261-0/+1
| | |
* | | Allow strings in the controller test describe blocksMike Moore2012-09-241-0/+1
| | | | | | | | | | | | | | | Allow controller tests using the spec DSL to match strings. Add test coverage for the register_spec_type calls.
* | | Support controller tests using spec DSL - fixes #7743Mike Moore2012-09-241-3/+5
|/ / | | | | | | Add tests for controller tests using the minitest spec DSL.
* | fix typos and improve AC::StrongParameters documentation [ci skip]Francesco Rodriguez2012-09-201-6/+8
| |
* | update AC::StrongParameters documentationFrancesco Rodriguez2012-09-191-8/+53
| |
* | define permitted? method instead of use an alias to fix rdocFrancesco Rodriguez2012-09-191-2/+12
| |
* | update AC::Parameters documentation [ci skip]Francesco Rodriguez2012-09-191-1/+149
| |
* | update AC::ParameterMissing documentation [ci skip]Francesco Rodriguez2012-09-191-2/+9
| |
* | update AC::ParamsWrapper documentation [ci skip]Francesco Rodriguez2012-09-191-3/+4
|/
* Set AC::Parameters.permit_all_parameters explicitly to false when ↵Guillermo Iguaran2012-09-191-1/+1
| | | | config.action_controller.permit_all_parameters is not present
* fix shadowing outer local variable warningSergey Nartimov2012-09-191-3/+3
|
* Merge pull request #7251 from rails/integrate-strong_parametersDavid Heinemeier Hansson2012-09-184-7/+132
|\ | | | | Integrate strong_parameters in Rails 4
| * AC::ParameterMissing inherits from KeyError since it's more appropiated than ↵Guillermo Iguaran2012-09-161-1/+1
| | | | | | | | IndexError
| * Support fields_for attributes, which may have numeric symbols as hash keysGuillermo Iguaran2012-09-161-0/+4
| |
| * Add config.action_controller.permit_all_attributes to bypass ↵Guillermo Iguaran2012-09-162-1/+6
| | | | | | | | StrongParameters protection
| * Remove integration between attr_accessible/protected and ↵Guillermo Iguaran2012-09-161-7/+2
| | | | | | | | AC::Metal::ParamsWrapper
| * Integrate ActionController::Parameters from StrongParameters gemGuillermo Iguaran2012-09-162-0/+121
| |
* | log 404 status when ActiveRecord::RecordNotFound was raised (#7646)Yves Senn2012-09-171-1/+2
| |
* | removes unnecessary selfXavier Noria2012-09-171-1/+1
| |
* | revises the RDoc of AC::Base.without_modulesXavier Noria2012-09-171-2/+2
| |
* | documents the request and response methods in AC::BaseXavier Noria2012-09-171-3/+21
| |
* | revises RDoc in AC::Metal [ci skip]Xavier Noria2012-09-171-14/+7
| |
* | removes unnecessary selfXavier Noria2012-09-171-1/+1
|/
* Build fix for ActionMailerArun Agrawal2012-09-141-0/+1
| | | | | | See http://travis-ci.org/#!/rails/rails/jobs/2444632
* Implement :null_session CSRF protection methodSergey Nartimov2012-09-131-22/+70
| | | | | | | | It's further work on CSRF after 245941101b1ea00a9b1af613c20b0ee994a43946. The :null_session CSRF protection method provide an empty session during request processing but doesn't reset it completely (as :reset_session does).
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-09-091-1/+1
|\ | | | | | | | | Conflicts: activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb
| * Doc: sweepers only work on Active Record Modelsschneems2012-09-051-1/+1
| | | | | | In response to this rails issue: https://github.com/rails/rails/issues/3729
* | Use merge! to merge additional options onto default optionsCarlos Antonio da Silva2012-09-071-4/+3
| |
* | AS::Callbacks: deprecate monkey patch of object callbacksBogdan Gusiev2012-09-071-1/+1
| |
* | Fix example code: use tasks instead of commentsErik Behrends2012-09-021-1/+1
|/
* Sprockets-rails tests failDmitry Vorotilin2012-09-012-14/+1
| | | | | | | Method invalid_asset_host! was delegated to controller but sprockets compile assets in their own scope without controller. And if we set asset_host with second parameter it should raise error through invalid_asset_host!. But since controller is nil it cannot be reached.
* Instrumentation requires RackDelegationJosé Valim2012-08-301-0/+1
| | | Since it uses request and response methods
* Fixes warning: & interpreted as argument prefixkennyj2012-08-301-1/+1
|
* Use class_attribute so we dont bleedDavid Heinemeier Hansson2012-08-291-1/+6
|
* Added controller-level etag additions that will be part of the action etag ↵David Heinemeier Hansson2012-08-291-4/+34
| | | | computation *Jeremy Kemper/DHH*
* Fix spacingDavid Heinemeier Hansson2012-08-291-8/+8
|
* Fix spacingDavid Heinemeier Hansson2012-08-291-5/+4
|
* Add Missing Keys from Journey on failed URL formatschneems2012-08-281-0/+3
| | | | | | | | | | | | | | | | | | | | | | | Many named routes have keys that are required to successfully resolve. If a key is left off like this: <%= link_to 'user', user_path %> This will produce an error like this: No route matches {:action=>"show", :controller=>"users"} Since we know that the :id is missing, we can add extra debugging information to the error message. No route matches {:action=>"show", :controller=>"users"} missing required keys: [:id] This will help new and seasoned developers look closer at their parameters. I've also subclassed the routing error to be clear that this error is a result of attempting to generate a url and not because the user is trying to visit a bad url. While this may sound trivial this error message is misleading and confuses most developers. The important part isn't what's in the options its's what's missing. Adding this information to the error message will make debugging much more obvious. This is the sister pull request of https://github.com/rails/journey/pull/44 which will be required to get they missing keys into the correct error message. Example Development Error in Rails: http://cl.ly/image/3S0T0n1T3421
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-06 21:23:44 +0000