Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | move include calculation to include method on the options object | Aaron Patterson | 2012-11-13 | 1 | -9/+24 | |
| | | ||||||
* | | model name is lazily evaluated in the options object | Aaron Patterson | 2012-11-13 | 1 | -27/+37 | |
| | | ||||||
* | | move the controller class to the options object | Aaron Patterson | 2012-11-13 | 1 | -9/+12 | |
| | | ||||||
* | | attribute_names will always return a list, so just use any? | Aaron Patterson | 2012-11-13 | 1 | -1/+1 | |
| | | ||||||
* | | wrap up hash conversion in the constructor | Aaron Patterson | 2012-11-13 | 1 | -5/+5 | |
| | | ||||||
* | | use the options object in the wrapper defaults | Aaron Patterson | 2012-11-13 | 1 | -13/+12 | |
| | | ||||||
* | | start using options object | Aaron Patterson | 2012-11-13 | 1 | -9/+20 | |
| | | ||||||
* | | only do hash lookups on options once | Aaron Patterson | 2012-11-13 | 1 | -13/+15 | |
| | | ||||||
* | | replace present? with any? to reduce dependency on AS | Aaron Patterson | 2012-11-13 | 2 | -1/+2 | |
| | | ||||||
* | | Revert "Merge pull request #8017 from jcoglan/objectless_sessions" | Jon Leighton | 2012-11-09 | 1 | -2/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 36376560fdd02f955ae3bf6b7792b784443660ad, reversing changes made to 3148ed9a4bb7efef30b846dc945d73ceebcc3f0f. Conflicts: actionpack/lib/action_dispatch/middleware/flash.rb Reason: it broke Sam's CI https://github.com/rails/rails/pull/8017#issuecomment-10210655 | |||||
* | | Merge pull request #8017 from jcoglan/objectless_sessions | Jon Leighton | 2012-11-08 | 1 | -1/+2 | |
|\ \ | | | | | | | Store FlashHashes in the session as plain hashes | |||||
| * | | Store FlashHashes in the session as plain hashes rather than custom objects ↵ | James Coglan | 2012-11-03 | 1 | -1/+2 | |
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | with unstable class names and instance variables. Refactor FlashHash to take values for its ivars in the constructor, to pretty up FlashHash.from_session_value. Remove stale comment on FlashHash: it is no longer Marshaled in the session so we can change its implementation. Remove blank lines I introduced in controller/test_case.rb. Unit tests for FlashHash#to_session_value. Put in a compatibility layer to accept FlashHash serializations from Rails 3.0+. Test that Rails 3.2 session flashes are correctly converted to the new format. Remove code path for processing Rails 3.0 FlashHashes since they can no longer deserialize. | |||||
* | | Set @permitted on new instance when slicing parameters hash | Benjamin Quorning | 2012-11-06 | 1 | -1/+3 | |
| | | ||||||
* | | Remove #permitted attr accessor from Parameters | Carlos Antonio da Silva | 2012-11-03 | 1 | -1/+0 | |
|/ | | | | | There is no need to expose this accessor since we already have the query method #permitted? that should handle this purpose. | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-11-03 | 16 | -79/+79 | |
|\ | | | | | | | | | | | | | Conflicts: actionpack/lib/action_controller/metal/mime_responds.rb activerecord/lib/active_record/attribute_methods.rb guides/source/working_with_javascript_in_rails.md | |||||
| * | Revert "dont encourage AC::Parameters#permit_all_parameters usage [ci skip]" | Vijay Dev | 2012-11-03 | 1 | -1/+21 | |
| | | | | | | | | | | | | | | | | This reverts commit cd17ee5598411728747011566abf6779166be9d3. Reason: Let's note that this is discouraged, not remove the docs [ci skip] | |||||
| * | dont encourage AC::Parameters#permit_all_parameters usage [ci skip] | Francesco Rodriguez | 2012-10-28 | 1 | -21/+1 | |
| | | ||||||
| * | Multiple changes to 1,9 hash syntax | AvnerCohen | 2012-10-27 | 15 | -77/+77 | |
| | | ||||||
| * | fix StrongParameters example [ci skip] | Francesco Rodriguez | 2012-10-21 | 1 | -1/+1 | |
| | | ||||||
* | | Allow #permit to take its list of permitted parameters as an array | David Heinemeier Hansson | 2012-10-31 | 1 | -1/+1 | |
| | | ||||||
* | | Make caller attribute in deprecation methods optional | Alexey Gaziev | 2012-10-30 | 1 | -2/+2 | |
| | | ||||||
* | | Provide a call stack for deprecation warnings where needed. | Nikita Afanasenko | 2012-10-29 | 2 | -5/+5 | |
| | | | | | | | | It's sometimes hard to quickly find where deprecated call was performed, especially in case of migrating between Rails versions. So this is an attempt to improve the call stack part of the warning message by providing caller explicitly. | |||||
* | | cleanup, remove trailing whitespace within actionpack | Yves Senn | 2012-10-27 | 1 | -1/+1 | |
| | | ||||||
* | | remain backwards compatible, exception can be constructed with no arguments | Aaron Patterson | 2012-10-25 | 1 | -1/+3 | |
| | | ||||||
* | | give access to the original exception raised in case of a parse error | Aaron Patterson | 2012-10-25 | 1 | -0/+7 | |
|/ | ||||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-10-21 | 1 | -17/+42 | |
|\ | | | | | | | | | | | Conflicts: activesupport/lib/active_support/core_ext/hash/slice.rb guides/source/active_support_core_extensions.md | |||||
| * | add a nested attributes example into Strong Parameters documentation [ci skip] | Francesco Rodriguez | 2012-10-18 | 1 | -6/+31 | |
| | | ||||||
| * | remove some non-breaking spaces [ci skip] | Francesco Rodriguez | 2012-10-18 | 1 | -13/+13 | |
| | | ||||||
* | | There is already a Set of non-hidden action_names lying around. | thedarkone | 2012-10-18 | 1 | -8/+2 | |
| | | ||||||
* | | Permit string and float values in the multiparameter attributes | Rafael Mendonça França | 2012-10-18 | 1 | -1/+1 | |
| | | ||||||
* | | :fire: Rails asset id support | Joshua Peek | 2012-10-15 | 1 | -1/+0 | |
| | | ||||||
* | | warning removed: shadowing outer local variable - value | Arun Agrawal | 2012-10-12 | 1 | -2/+2 | |
| | | ||||||
* | | update AC::Parameters#permit documentation [ci skip] | Francesco Rodriguez | 2012-10-11 | 1 | -0/+22 | |
| | | | | | | | | bdd105d changes the behaviour of AC::Parameters#permit. | |||||
* | | When executing permit with just a key that points to a hash, DO NOT allow ↵ | Santiago Pastorino | 2012-10-12 | 1 | -1/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | all the hash params.require(:person).permit(:projects_attributes) was returning => {"projects_attributes"=>{"0"=>{"name"=>"Project 1"}}} When should return => {} You should be doing ... params.require(:person).permit(projects_attributes: :name) to get just the projects attributes you want to allow | |||||
* | | refactor `ActionView::TestCase` internals to track rendered locals | Yves Senn | 2012-10-11 | 1 | -9/+4 | |
| | | | | | | | | | | this refactoring extracts the semi complex data structure of rendered locals per view into into a separate class | |||||
* | | recognizes when a partial was rendered twice. Closes #3675 | Yves Senn | 2012-10-11 | 1 | -4/+10 | |
| | | ||||||
* | | moving to new hash syntax, for discussion before I take the time on full folders | AvnerCohen | 2012-10-09 | 1 | -9/+9 | |
|/ | ||||||
* | can't pass :locals to #assert_template without a view test case. Closes #3415 | Yves Senn | 2012-10-06 | 1 | -3/+7 | |
| | | | | | | | | | | | the documentation on #assert_template states that the :locals option is only available in view test cases: # In a view test case, you can also assert that specific locals are passed # to partials: I added a warning when it's passed in an inapropriate context to prevent a NoMethodError. | |||||
* | We don't need the each call since grep take a block and yield each match | Rafael Mendonça França | 2012-10-06 | 1 | -1/+1 | |
| | | | | | | to the block. Thanks @tenderlove | |||||
* | Allow parameter filters to match multi-parameter attributes | Rafael Mendonça França | 2012-10-05 | 1 | -0/+1 | |
| | | | | | | | This will make easier to permit date/time attributes generated by helpers like date_select. [Sven Schwyn + Rafael Mendonça França] | |||||
* | Merge pull request #7847 from bloudermilk/recursive_permit | David Heinemeier Hansson | 2012-10-04 | 1 | -0/+5 | |
|\ | | | | | ActionController::Parameters#permit! is recursive | |||||
| * | ActionController::Parameters#permit! is recursive | Brendan Loudermilk | 2012-10-04 | 1 | -0/+5 | |
| | | ||||||
* | | Do not set removed option | Rafael Mendonça França | 2012-10-04 | 1 | -1/+0 | |
|/ | | | | | Sine page caching was remove from the core we don't have the page_cache_directory anymore | |||||
* | rename page_cache_extension option to default_static_extension | Francesco Rodriguez | 2012-10-03 | 1 | -10/+12 | |
| | ||||||
* | extract AP Page and Action caching to actionpack-deprecated_caching gem | Francesco Rodriguez | 2012-10-03 | 3 | -399/+14 | |
| | ||||||
* | Merge pull request #7708 from bdurand/optimize_log_subscribers | Rafael Mendonça França | 2012-10-01 | 1 | -6/+11 | |
|\ | | | | | Optimize log subscribers to check if the log level is sufficient | |||||
| * | Optimize log subscribers to check if the log level is sufficient before ↵ | Brian Durand | 2012-09-30 | 1 | -6/+11 | |
| | | | | | | | | performing an operations. | |||||
* | | prefix TemplateAssertions ivars (#7459) | Yves Senn | 2012-10-01 | 1 | -20/+20 | |
| | | ||||||
* | | Whitespaces :scissors: [ci skip] | Rafael Mendonça França | 2012-09-30 | 1 | -1/+1 | |
| | | ||||||
* | | `assert_template` no more passing with what ever string that matches. | Hugo Roque | 2012-09-29 | 1 | -5/+12 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Given Im rendering an template `/layout/hello.html.erb`, assert_template was passing with any string that matches. This behavior allowed false passing like: assert_template "layout" assert_template "out/hello" Now the passing possibilities are: assert_template "layout/hello" assert_template "hello" fixing assert_template bug when template matches expected, but not ends with Cherry Pick Merge: Fixes issue #3849 assert_template false positive taking redundant test off prevening incorrect assert_template when rendering with repeated names in path updating CHANGELOG with bugfix: assert_template false passing |